1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe 'Group', :with_current_organization, feature_category: :groups_and_projects do
let_it_be(:user) { create(:user, organizations: [current_organization]) }
before do
sign_in(user)
end
matcher :have_namespace_error_message do
match do |page|
page.has_content?("Group URL can contain only letters, digits, '_', '-' and '.'. Cannot start with '-' or end in '.', '.git' or '.atom'.")
end
end
describe 'create a group', :js do
before do
visit new_group_path
click_link 'Create group'
end
describe 'as a non-admin' do
it 'creates a group and persists visibility radio selection', :js do
stub_application_setting(default_group_visibility: :private)
fill_in 'Group name', with: 'test-group'
find("input[name='group[visibility_level]'][value='#{Gitlab::VisibilityLevel::PUBLIC}']").click
click_button 'Create group'
group = Group.find_by(name: 'test-group')
expect(group.visibility_level).to eq(Gitlab::VisibilityLevel::PUBLIC)
expect(page).to have_current_path(group_path(group), ignore_query: true)
expect(page).to have_selector '.visibility-icon [data-testid="earth-icon"]'
end
end
describe 'with expected fields' do
it 'renders from as expected', :aggregate_failures do
expect(page).to have_field('name')
expect(page).to have_field('group_path')
expect(page).to have_field('group_visibility_level_0')
expect(page).not_to have_field('description')
end
end
describe 'with space in group path' do
it 'renders new group form with validation errors' do
fill_in 'Group URL', with: 'space group'
click_button 'Create group'
expect(page).to have_current_path(new_group_path, ignore_query: true)
expect(page).to have_text('Choose a group path that does not start with a dash or end with a period. It can also contain alphanumeric characters and underscores.')
end
end
describe 'with .atom at end of group path' do
it 'renders new group form with validation errors' do
fill_in 'Group name', with: 'test-group'
fill_in 'Group URL', with: 'atom_group.atom'
click_button 'Create group'
expect(page).to have_current_path(groups_path, ignore_query: true)
expect(page).to have_namespace_error_message
end
end
describe 'with .git at end of group path' do
it 'renders new group form with validation errors' do
fill_in 'Group name', with: 'test-group'
fill_in 'Group URL', with: 'git_group.git'
click_button 'Create group'
expect(page).to have_current_path(groups_path, ignore_query: true)
expect(page).to have_namespace_error_message
end
end
describe 'real-time group url validation', :js do
it 'shows a message if group url is available' do
fill_in 'group_path', with: 'az'
wait_for_requests
expect(page).to have_content('Group path is available')
end
it 'shows an error if group url is taken' do
fill_in 'group_path', with: user.username
wait_for_requests
expect(page).to have_content("Group path is unavailable. Path has been replaced with a suggested available path.")
end
it 'does not break after an invalid form submit' do
fill_in 'group_name', with: 'MyGroup'
fill_in 'group_path', with: 'z'
click_button 'Create group'
expect(page).to have_content('Group URL is too short')
fill_in 'group_path', with: 'az'
wait_for_requests
expect(page).to have_content('Group path is available')
end
context 'when filling in the `Group name` field' do
let_it_be(:group1) { create(:group, :public, path: 'foo-bar') }
let_it_be(:group2) { create(:group, :public, path: 'bar-baz') }
it 'automatically populates the `Group URL` field' do
fill_in 'Group name', with: 'Foo bar'
# Wait for debounce in app/assets/javascripts/group.js#18
sleep(1)
fill_in 'Group name', with: 'Bar baz'
# Wait for debounce in app/assets/javascripts/group.js#18
sleep(1)
wait_for_requests
expect(page).to have_field('Group URL', with: 'bar-baz1')
end
end
end
describe 'Mattermost team creation' do
before do
stub_mattermost_setting(enabled: mattermost_enabled, host: 'https://mattermost.test')
visit new_group_path
click_link 'Create group'
end
context 'Mattermost enabled' do
let(:mattermost_enabled) { true }
it 'displays a team creation checkbox' do
expect(page).to have_selector('#group_create_chat_team')
end
it 'unchecks the checkbox by default' do
expect(find('#group_create_chat_team')).not_to be_checked
end
it 'updates the team URL on graph path update', :js do
label = find('#group_create_chat_team ~ label[for=group_create_chat_team]')
url = 'https://mattermost.test/test-group'
expect(label.text).not_to match(url)
fill_in('group_path', with: 'test-group')
expect(label.text).to match(url)
end
end
context 'Mattermost disabled' do
let(:mattermost_enabled) { false }
it 'doesnt show a team creation checkbox if Mattermost not enabled' do
expect(page).not_to have_selector('#group_create_chat_team')
end
end
end
describe 'showing recaptcha on group creation when it is enabled' do
before do
stub_application_setting(recaptcha_enabled: true)
allow(Gitlab::Recaptcha).to receive(:load_configurations!)
visit new_group_path
click_link 'Create group'
end
it 'renders recaptcha' do
expect(page).to have_css('.recaptcha')
end
end
describe 'not showing recaptcha on group creation when it is disabled' do
before do
stub_feature_flags(recaptcha_on_top_level_group_creation: false)
stub_application_setting(recaptcha_enabled: true)
visit new_group_path
click_link 'Create group'
end
it 'does not render recaptcha' do
expect(page).not_to have_css('.recaptcha')
end
end
describe 'showing personalization questions on group creation when it is enabled' do
before do
stub_application_setting(hide_third_party_offers: false)
visit new_group_path(anchor: 'create-group-pane')
end
it 'renders personalization questions' do
expect(page).to have_content('Now, personalize your GitLab experience')
end
end
describe 'not showing personalization questions on group creation when it is enabled' do
before do
stub_application_setting(hide_third_party_offers: true)
# If visiting directly via path, personalization setting is not being picked up correctly
visit new_group_path
click_link 'Create group'
end
it 'does not render personalization questions' do
expect(page).not_to have_content('Now, personalize your GitLab experience')
end
end
end
describe 'create a nested group', :js do
let_it_be(:group) { create(:group, path: 'foo', organization: current_organization) }
context 'as admin' do
let(:user) { create(:admin, organizations: [current_organization]) }
before do
visit new_group_path(parent_id: group.id, anchor: 'create-group-pane')
end
context 'when admin mode is enabled', :enable_admin_mode do
it 'creates a nested group' do
fill_in 'Subgroup name', with: 'bar'
click_button 'Create subgroup'
expect(page).to have_current_path(group_path('foo/bar'), ignore_query: true)
expect(page).to have_selector 'h1', text: 'bar'
end
end
context 'when admin mode is disabled' do
it 'is not allowed' do
expect(page).not_to have_button('Create subgroup')
end
end
end
context 'as group owner' do
it 'creates a nested group' do
user = create(:user, organizations: [current_organization])
group.add_owner(user)
sign_out(:user)
sign_in(user)
visit new_group_path(parent_id: group.id, anchor: 'create-group-pane')
fill_in 'Subgroup name', with: 'bar'
click_button 'Create subgroup'
expect(page).to have_current_path(group_path('foo/bar'), ignore_query: true)
expect(page).to have_selector 'h1', text: 'bar'
end
end
context 'when recaptcha is enabled' do
before do
stub_application_setting(recaptcha_enabled: true)
allow(Gitlab::Recaptcha).to receive(:load_configurations!)
end
context 'when creating subgroup' do
let(:path) { new_group_path(parent_id: group.id, anchor: 'create-group-pane') }
it 'does not render recaptcha' do
visit path
expect(page).not_to have_css('.recaptcha')
end
end
end
context 'when many parent groups are available' do
let_it_be(:group2) { create(:group, path: 'foo2', organization: group.organization) }
let_it_be(:group3) { create(:group, path: 'foo3', organization: group.organization) }
before do
group.add_owner(user)
group2.add_maintainer(user)
group3.add_developer(user)
visit new_group_path(parent_id: group.id, anchor: 'create-group-pane')
end
it 'creates private subgroup' do
fill_in 'Subgroup name', with: 'bar'
click_button 'foo'
expect(page).to have_css('[data-testid="select_group_dropdown_item"]', text: 'foo2')
expect(page).not_to have_css('[data-testid="select_group_dropdown_item"]', text: 'foo3')
click_button 'foo2'
click_button 'Create subgroup'
expect(page).to have_current_path(group_path('foo2/bar'), ignore_query: true)
expect(page).to have_selector('h1', text: 'bar')
expect(page).to have_selector('.visibility-icon [data-testid="lock-icon"]')
end
end
describe 'real-time group url validation', :js do
let_it_be(:subgroup) { create(:group, path: 'sub', parent: group) }
before do
group.add_owner(user)
visit new_group_path(parent_id: group.id, anchor: 'create-group-pane')
end
it 'shows a message if group url is available' do
fill_in 'Subgroup slug', with: group.path
wait_for_requests
expect(page).to have_content('Group path is available')
end
it 'shows an error if group url is taken' do
fill_in 'Subgroup slug', with: subgroup.path
wait_for_requests
expect(page).to have_content("Group path is unavailable. Path has been replaced with a suggested available path.")
end
end
end
it 'checks permissions to avoid exposing groups by parent_id', :js do
group = create(:group, :private, path: 'secret-group')
sign_out(:user)
sign_in(create(:user))
visit new_group_path(parent_id: group.id, anchor: 'create-group-pane')
expect(page).to have_title('Not Found')
expect(page).to have_content('Page not found')
end
describe 'group edit', :js do
let_it_be(:group) { create(:group, :public) }
let(:path) { edit_group_path(group) }
let(:new_name) { 'new-name' }
before do
group.add_owner(user)
visit path
end
it 'saves new settings' do
within_testid('general-settings') do
# Have to reset it to '' so it overwrites rather than appends
fill_in('group_name', with: '')
fill_in 'group_name', with: new_name
click_button 'Save changes'
end
expect(page).to have_content 'successfully updated'
expect(find('#group_name').value).to eq(new_name)
within_testid "breadcrumb-links" do
expect(page).to have_content new_name
end
end
it 'focuses confirmation field on remove group' do
click_button('Delete group')
expect(page).to have_selector '#confirm_name_input:focus'
end
it 'removes group', :sidekiq_might_not_need_inline do
expect { remove_with_confirm('Delete group', group.path) }.to change { Group.count }.by(-1)
expect(group.members.all.count).to be_zero
expect(page).to have_content "is being deleted"
end
end
describe 'group page with markdown description' do
let_it_be(:group) { create(:group) }
let(:path) { group_path(group) }
before do
group.add_owner(user)
end
it 'parses Markdown' do
group.update_attribute(:description, 'This is **my** group')
visit path
expect(page).to have_css('.home-panel-description-markdown > p > strong')
end
it 'passes through html-pipeline' do
group.update_attribute(:description, 'This group is the :poop:')
visit path
expect(page).to have_css('.home-panel-description-markdown > p > gl-emoji')
end
it 'sanitizes unwanted tags' do
group.update_attribute(:description, '# Group Description')
visit path
expect(page).not_to have_css('.home-panel-description-markdown h1')
end
it 'permits `rel` attribute on links' do
group.update_attribute(:description, 'https://google.com/')
visit path
expect(page).to have_css('.home-panel-description-markdown a[rel]')
end
end
describe 'group page with nested groups', :js do
let_it_be(:group) { create(:group) }
let_it_be(:nested_group) { create(:group, parent: group) }
let_it_be(:project) { create(:project, namespace: group) }
before do
group.add_owner(user)
end
it 'renders projects and groups on the page' do
visit group_path(group)
wait_for_requests
expect(page).to have_content(nested_group.name)
expect(page).to have_content(project.name)
end
it 'renders group page with the text "Group" in the sidebar header' do
visit group_path(group)
within('#super-sidebar-context-header') do
expect(page).to have_text('Group')
end
end
it 'renders subgroup page with the text "Group" in the sidebar header' do
visit group_path(nested_group)
within('#super-sidebar-context-header') do
expect(page).to have_text('Group')
end
end
it 'renders project page with the text "Project" in the sidebar header' do
visit project_path(project)
within('#super-sidebar-context-header') do
expect(page).to have_text('Project')
end
end
end
describe 'new subgroup / project button' do
let_it_be(:group, reload: true) do
create(
:group,
project_creation_level: Gitlab::Access::NO_ONE_PROJECT_ACCESS,
subgroup_creation_level: Gitlab::Access::OWNER_SUBGROUP_ACCESS
)
end
before do
group.add_owner(user)
end
context 'when user has subgroup creation permissions but not project creation permissions' do
it 'only displays "New subgroup" button' do
visit group_path(group)
within_testid 'group-buttons' do
expect(page).to have_link('New subgroup')
expect(page).not_to have_link('New project')
end
end
end
context 'when user has project creation permissions but not subgroup creation permissions' do
it 'only displays "New project" button' do
group.update!(project_creation_level: Gitlab::Access::MAINTAINER_PROJECT_ACCESS)
user = create(:user)
group.add_maintainer(user)
sign_out(:user)
sign_in(user)
visit group_path(group)
within_testid 'group-buttons' do
expect(page).to have_link('New project')
expect(page).not_to have_link('New subgroup')
end
end
end
context 'when user has project and subgroup creation permissions' do
it 'displays "New subgroup" and "New project" buttons' do
group.update!(project_creation_level: Gitlab::Access::MAINTAINER_PROJECT_ACCESS)
visit group_path(group)
within_testid 'group-buttons' do
expect(page).to have_link('New subgroup')
expect(page).to have_link('New project')
end
end
end
context 'when in a private group' do
before do
group.update!(
visibility_level: Gitlab::VisibilityLevel::PRIVATE,
project_creation_level: Gitlab::Access::MAINTAINER_PROJECT_ACCESS
)
end
context 'when visibility levels have been restricted to private only by an administrator' do
before do
stub_application_setting(
restricted_visibility_levels: [
Gitlab::VisibilityLevel::PRIVATE
]
)
end
it 'does not display the "New project" button' do
visit group_path(group)
within_testid 'group-buttons' do
expect(page).not_to have_link('New project')
end
end
it 'does not display the "New subgroup" button' do
visit group_path(group)
within_testid 'group-buttons' do
expect(page).not_to have_link('New subgroup')
end
end
end
end
end
describe 'group README', :js do
context 'with gitlab-profile project and README.md' do
let_it_be(:group) { create(:group) }
let_it_be(:project) { create(:project, :public, :readme, namespace: group) }
it 'renders README block on group page' do
visit group_path(group)
wait_for_requests
expect(page).to have_text('README.md')
end
end
end
def remove_with_confirm(button_text, confirm_with)
click_button button_text
fill_in 'confirm_name_input', with: confirm_with
click_button 'Confirm'
end
end
|