1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe 'New/edit issue', :js, feature_category: :team_planning do
include ActionView::Helpers::JavaScriptHelper
include ListboxHelpers
let_it_be(:project) { create(:project, :repository) }
let_it_be(:user) { create(:user, maintainer_of: project) }
let_it_be(:user2) { create(:user, maintainer_of: project) }
let_it_be(:guest) { create(:user, guest_of: project) }
let_it_be(:milestone) { create(:milestone, project: project) }
let_it_be(:label) { create(:label, project: project) }
let_it_be(:label2) { create(:label, project: project) }
let_it_be(:issue) { create(:issue, project: project, assignees: [user], milestone: milestone) }
let_it_be(:confidential_issue) { create(:issue, project: project, assignees: [user], milestone: milestone, confidential: true) }
let(:current_user) { user }
before do
stub_licensed_features(multiple_issue_assignees: false, issue_weights: false)
sign_in(current_user)
end
describe 'new issue' do
before do
visit new_project_issue_path(project)
end
describe 'shorten users API pagination limit' do
before do
# Using `allow_any_instance_of`/`and_wrap_original`, `original` would
# somehow refer to the very block we defined to _wrap_ that method, instead of
# the original method, resulting in infinite recursion when called.
# This is likely a bug with helper modules included into dynamically generated view classes.
# To work around this, we have to hold on to and call to the original implementation manually.
original_issue_dropdown_options = FormHelper.instance_method(:assignees_dropdown_options)
allow_any_instance_of(FormHelper).to receive(:assignees_dropdown_options).and_wrap_original do |original, *args|
options = original_issue_dropdown_options.bind_call(original.receiver, *args)
options[:data][:per_page] = 2
options
end
visit new_project_issue_path(project)
click_button 'Unassigned'
wait_for_requests
end
it 'displays selected users even if they are not part of the original API call' do
find('.dropdown-input-field').native.send_keys user2.name
page.within '.dropdown-menu-user' do
expect(page).to have_content user2.name
click_link user2.name
end
click_button user2.name
page.within '.dropdown-menu-user' do
expect(page).to have_content user.name
expect(find('.dropdown-menu-user a.is-active').first(:xpath, '..')['data-user-id']).to eq(user2.id.to_s)
end
end
end
describe 'single assignee' do
before do
click_button 'Unassigned'
wait_for_requests
end
it 'unselects other assignees when unassigned is selected' do
page.within '.dropdown-menu-user' do
click_link user2.name
end
click_button user2.name
page.within '.dropdown-menu-user' do
click_link 'Unassigned'
end
expect(find('input[name="issue[assignee_ids][]"]', visible: false).value).to match('0')
end
it 'toggles assign to me when current user is selected and unselected' do
page.within '.dropdown-menu-user' do
click_link user.name
end
expect(find('a', text: 'Assign to me', visible: false)).not_to be_visible
click_button user.name
page.within('.dropdown-menu-user') do
click_link user.name
end
expect(page.find('.dropdown-menu-user', visible: false)).not_to be_visible
end
end
it 'allows user to create new issue' do
fill_in 'issue_title', with: 'title'
fill_in 'issue_description', with: 'title'
expect(find('a', text: 'Assign to me')).to be_visible
click_button 'Unassigned'
wait_for_requests
page.within '.dropdown-menu-user' do
click_link user2.name
end
expect(find('input[name="issue[assignee_ids][]"]', visible: false).value).to match(user2.id.to_s)
page.within '.js-assignee-search' do
expect(page).to have_content user2.name
end
expect(find('a', text: 'Assign to me')).to be_visible
click_link 'Assign to me'
assignee_ids = page.all('input[name="issue[assignee_ids][]"]', visible: false)
expect(assignee_ids[0].value).to match(user.id.to_s)
page.within '.js-assignee-search' do
expect(page).to have_content user.name
end
expect(find('a', text: 'Assign to me', visible: false)).not_to be_visible
click_button 'Select milestone'
click_button milestone.title
expect(find('input[name="issue[milestone_id]"]', visible: false).value).to match(milestone.id.to_s)
expect(page).to have_button milestone.title
click_button _('Select label')
wait_for_all_requests
within_testid('sidebar-labels') do
click_button label.title
click_button label2.title
click_button _('Close')
wait_for_requests
within_testid('embedded-labels-list') do
expect(page).to have_content(label.title)
expect(page).to have_content(label2.title)
end
end
click_button 'Create issue'
page.within '.issuable-sidebar' do
page.within '.assignee' do
expect(page).to have_content "Assignee"
end
page.within '.milestone' do
expect(page).to have_content milestone.title
end
page.within '.labels' do
expect(page).to have_content label.title
expect(page).to have_content label2.title
end
end
within_testid 'breadcrumb-links' do
issue = Issue.find_by(title: 'title')
expect(page).to have_text("Issues #{issue.to_reference}")
end
end
it 'correctly updates the dropdown toggle when removing a label' do
click_button _('Select label')
wait_for_all_requests
within_testid 'sidebar-labels' do
click_button label.title
click_button _('Close')
wait_for_requests
within_testid('embedded-labels-list') do
expect(page).to have_content(label.title)
end
expect(page.find('.gl-dropdown-button-text')).to have_content(label.title)
end
click_button label.title, class: 'gl-dropdown-toggle'
wait_for_all_requests
within_testid 'sidebar-labels' do
click_button label.title, class: 'dropdown-item'
click_button _('Close')
wait_for_requests
expect(page).not_to have_selector('[data-testid="embedded-labels-list"]')
expect(page.find('.gl-dropdown-button-text')).to have_content(_('Select label'))
end
end
it 'clears label search input field when a label is selected', :js do
click_button _('Select label')
wait_for_all_requests
within_testid 'sidebar-labels' do
search_field = find('input[type="search"]')
search_field.native.send_keys(label.title)
expect(page).to have_css('.gl-search-box-by-type-clear')
click_button label.title, class: 'dropdown-item'
expect(page).not_to have_css('.gl-search-box-by-type-clear')
expect(search_field.value).to eq ''
end
end
it 'displays an error message when submitting an invalid form' do
click_button 'Create issue'
within_testid('issue-title-input-field') do
expect(page).to have_text(_('This field is required.'))
end
end
it 'correctly updates the selected user when changing assignee' do
click_button 'Unassigned'
wait_for_requests
page.within '.dropdown-menu-user' do
click_link user.name
end
expect(find('.js-assignee-search')).to have_content(user.name)
click_button user.name
page.within '.dropdown-menu-user' do
click_link user2.name
end
expect(find('.js-assignee-search')).to have_content(user2.name)
end
it 'description has autocomplete' do
find('#issue_description').native.send_keys('')
fill_in 'issue_description', with: '@'
expect(page).to have_selector('.atwho-view')
end
describe 'displays issue type options in the dropdown' do
shared_examples 'type option is visible' do |label:, identifier:|
it "shows #{identifier} option", :aggregate_failures do
wait_for_requests
expect_listbox_item(label)
end
end
shared_examples 'type option is missing' do |label:, identifier:|
it "does not show #{identifier} option", :aggregate_failures do
wait_for_requests
expect_no_listbox_item(label)
end
end
before do
page.within('.issue-form') do
click_button 'Issue'
end
end
context 'when user is guest' do
let_it_be(:guest) { create(:user) }
let(:current_user) { guest }
before_all do
project.add_guest(guest)
end
it_behaves_like 'type option is visible', label: 'Issue', identifier: :issue
it_behaves_like 'type option is missing', label: 'Incident', identifier: :incident
end
context 'when user is reporter' do
let_it_be(:reporter) { create(:user) }
let(:current_user) { reporter }
before_all do
project.add_reporter(reporter)
end
it_behaves_like 'type option is visible', label: 'Issue', identifier: :issue
it_behaves_like 'type option is visible', label: 'Incident', identifier: :incident
end
end
describe 'milestone' do
let!(:milestone) do
create(:milestone, title: '"><img src=x onerror=alert(document.domain)>', project: project)
end
it 'escapes milestone' do
click_button 'Select milestone'
click_button milestone.title
page.within '.issue-milestone' do
expect(page).to have_button milestone.title
expect(page).not_to have_selector 'img'
end
end
end
describe 'when repository contains CONTRIBUTING.md' do
it 'has contribution guidelines prompt' do
text = _('Please review the %{linkStart}contribution guidelines%{linkEnd} for this project.') % { linkStart: nil, linkEnd: nil }
expect(find('#new_issue')).to have_text(text)
end
end
end
describe 'new issue with query parameters' do
before do
project.repository.create_file(
current_user,
'.gitlab/issue_templates/test_template.md',
'description from template',
message: 'Add test_template.md',
branch_name: project.default_branch_or_main
)
end
after do
project.repository.delete_file(
current_user,
'.gitlab/issue_templates/test_template.md',
message: 'Remove test_template.md',
branch_name: project.default_branch_or_main
)
end
it 'leaves the description blank if no query parameters are specified' do
visit new_project_issue_path(project)
expect(find('#issue_description').value).to be_empty
end
it 'fills the description from the issue[description] query parameter' do
visit new_project_issue_path(project, issue: { description: 'description from query parameter' })
expect(find('#issue_description').value).to match('description from query parameter')
end
it 'fills the description from the issuable_template query parameter', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/388728' do
visit new_project_issue_path(project, issuable_template: 'test_template')
wait_for_requests
expect(find('#issue_description').value).to match('description from template')
end
it 'fills the description from the issuable_template and issue[description] query parameters', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/388728' do
visit new_project_issue_path(project, issuable_template: 'test_template', issue: { description: 'description from query parameter' })
wait_for_requests
expect(find('#issue_description').value).to match('description from template\ndescription from query parameter')
end
end
describe 'new issue from related issue' do
it 'does not offer to link the new issue to any other issues if the URL parameter is absent' do
visit new_project_issue_path(project)
expect(page).not_to have_selector '#add_related_issue'
expect(page).not_to have_text "Relate to"
end
context 'guest' do
let(:current_user) { guest }
it 'does not offer to link the new issue to an issue that the user does not have access to' do
visit new_project_issue_path(project, { add_related_issue: confidential_issue.iid })
expect(page).not_to have_selector '#add_related_issue'
expect(page).not_to have_text "Relate to"
end
end
it 'links the new issue and the issue of origin' do
visit new_project_issue_path(project, { add_related_issue: issue.iid })
expect(page).to have_selector '#add_related_issue'
expect(page).to have_text "Relate to issue \##{issue.iid}"
expect(page).to have_text 'Adds this issue as related to the issue it was created from'
fill_in 'issue_title', with: 'title'
click_button 'Create issue'
page.within '#related-issues' do
expect(page).to have_text "\##{issue.iid}"
end
end
it 'links the new incident and the incident of origin' do
incident = create(:incident, project: project)
visit new_project_issue_path(project, { add_related_issue: incident.iid })
expect(page).to have_selector '#add_related_issue'
expect(page).to have_text "Relate to incident \##{incident.iid}"
expect(page).to have_text 'Adds this incident as related to the incident it was created from'
fill_in 'issue_title', with: 'title'
click_button 'Create issue'
page.within '#related-issues' do
expect(page).to have_text "\##{incident.iid}"
end
end
it 'does not link the new issue to any other issues if the checkbox is not checked' do
visit new_project_issue_path(project, { add_related_issue: issue.iid })
expect(page).to have_selector '#add_related_issue'
expect(page).to have_text "Relate to issue \##{issue.iid}"
uncheck "Relate to issue \##{issue.iid}"
fill_in 'issue_title', with: 'title'
click_button 'Create issue'
page.within '#related-issues' do
expect(page).not_to have_text "\##{issue.iid}"
end
end
end
describe 'edit issue' do
before do
visit edit_project_issue_path(project, issue)
end
it 'allows user to update issue', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/435787' do
expect(find('input[name="issue[assignee_ids][]"]', visible: false).value).to match(user.id.to_s)
expect(find('input[name="issue[milestone_id]"]', visible: false).value).to match(milestone.id.to_s)
expect(find('a', text: 'Assign to me', visible: false)).not_to be_visible
page.within '.js-user-search' do
expect(page).to have_content user.name
end
expect(page).to have_button milestone.title
click_button _('Select label')
wait_for_all_requests
within_testid 'sidebar-labels' do
click_button label.title
click_button label2.title
click_button _('Close')
wait_for_requests
within_testid('embedded-labels-list') do
expect(page).to have_content(label.title)
expect(page).to have_content(label2.title)
end
end
expect(page.all('input[name="issue[label_ids][]"]', visible: false)
.map(&:value))
.to contain_exactly(label.id.to_s, label2.id.to_s)
click_button 'Save changes'
page.within '.issuable-sidebar' do
page.within '.assignee' do
expect(page).to have_content user.name
end
page.within '.milestone' do
expect(page).to have_content milestone.title
end
page.within '.labels' do
expect(page).to have_content label.title
expect(page).to have_content label2.title
end
end
end
it 'description has autocomplete' do
find('#issue_description').native.send_keys('')
fill_in 'issue_description', with: '@'
expect(page).to have_selector('.atwho-view')
end
end
describe 'editing an issue by hotkey' do
let_it_be(:issue2) { create(:issue, project: project) }
before do
visit project_issue_path(project, issue2)
end
it 'opens inline edit form with shortcut' do
find('body').send_keys('e')
expect(page).to have_selector('.detail-page-description form')
end
context 'when user has made no changes' do
it 'let user leave the page without warnings' do
expected_content = 'Issue created'
expect(page).to have_content(expected_content)
find('body').send_keys('e')
click_link 'Homepage'
expect(page).not_to have_content(expected_content)
end
end
context 'when user has made changes' do
it 'shows a warning and can stay on page' do
content = 'new issue content'
find('body').send_keys('e')
fill_in 'issue-description', with: content
click_link 'Homepage' do
page.driver.browser.switch_to.alert.dismiss
end
click_button 'Save changes'
wait_for_requests
expect(page).to have_content(content)
end
it 'shows a warning and can leave page' do
content = 'new issue content'
find('body').send_keys('e')
fill_in 'issue-description', with: content
click_link 'Homepage' do
page.driver.browser.switch_to.alert.dismiss
end
expect(page).not_to have_content(content)
end
end
end
describe 'sub-group project' do
let(:group) { create(:group) }
let(:nested_group_1) { create(:group, parent: group) }
let(:sub_group_project) { create(:project, group: nested_group_1) }
before do
sub_group_project.add_maintainer(user)
visit new_project_issue_path(sub_group_project)
end
context 'labels', :js do
it 'creates project label from dropdown', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/416585' do
find('[data-testid="labels-select-dropdown-contents"] button').click
wait_for_all_requests
within_testid 'sidebar-labels' do
click_button _('Create project label')
fill_in _('Label name'), with: 'test label'
first('.suggest-colors-dropdown a').click
click_button 'Create'
end
page.within '.js-labels-list' do
expect(page).to have_button 'test label'
end
end
end
end
end
|