1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe 'Two factor auths', feature_category: :system_access do
include Spec::Support::Helpers::ModalHelpers
context 'when signed in' do
let(:invalid_current_pwd_msg) { 'You must provide a valid current password' }
before do
sign_in(user)
end
context 'when user has two-factor authentication disabled' do
let_it_be(:user) { create(:user) }
it 'requires the current password to set up two factor authentication', :js do
visit profile_two_factor_auth_path
register_2fa(user.current_otp, '123')
expect(page).to have_selector('.gl-alert-title', text: invalid_current_pwd_msg, count: 1)
register_2fa(user.reload.current_otp, user.password)
expect(page).to have_content('Please copy, download, or print your recovery codes before proceeding.')
click_button 'Copy codes'
click_link 'Proceed'
expect(page).to have_content('Status: Enabled')
end
context 'when user authenticates with an external service' do
let_it_be(:user) { create(:omniauth_user) }
it 'does not require the current password to set up two factor authentication', :js do
visit profile_two_factor_auth_path
fill_in 'pin_code', with: user.current_otp
click_button 'Register with two-factor app'
expect(page).to have_content('Please copy, download, or print your recovery codes before proceeding.')
click_button 'Copy codes'
click_link 'Proceed'
expect(page).to have_content('Status: Enabled')
end
end
context 'when invalid pin is provided' do
let_it_be(:user) { create(:omniauth_user) }
it 'renders a error alert with a link to the troubleshooting section' do
visit profile_two_factor_auth_path
fill_in 'pin_code', with: '123'
click_button 'Register with two-factor app'
expect(page).to have_link('Try the troubleshooting steps here.', href: help_page_path('user/profile/account/two_factor_authentication_troubleshooting.md'))
end
end
context 'when two factor is enforced for administrator users' do
let_it_be(:admin) { create(:admin) }
before do
stub_application_setting(require_admin_two_factor_authentication: require_admin_two_factor_authentication)
sign_in(admin)
end
context 'when visiting root dashboard path' do
let(:require_admin_two_factor_authentication) { true }
it 'renders alert for administrator users' do
visit profile_two_factor_auth_path
expect(page).to have_content('Administrator users are required to enable Two-Factor Authentication for their account. You need to do this before ')
end
end
end
context 'when two factor is disabled for administrator users' do
context 'when visiting root dashboard path' do
let(:require_admin_two_factor_authentication) { false }
it 'does not render an alert for administrator users' do
visit profile_two_factor_auth_path
expect(page).not_to have_content('Administrator users are required to enable Two-Factor Authentication for their account. You need to do this before ')
end
end
end
context 'when two factor is enforced in global settings' do
before do
stub_application_setting(require_two_factor_authentication: true)
end
context 'when a grace period is set' do
before do
stub_application_setting(two_factor_grace_period: 24.hours)
end
it 'allows the user to skip enabling within the grace period' do
visit root_path
expect(page).to have_current_path(profile_two_factor_auth_path, ignore_query: true)
click_link _('Configure it later')
expect(page).to have_current_path(root_path)
end
end
context 'when invalid pin is provided' do
let_it_be(:user) { create(:omniauth_user) }
it 'renders alert for global settings' do
visit profile_two_factor_auth_path
fill_in 'pin_code', with: '123'
click_button 'Register with two-factor app'
expect(page).to have_content('The global settings require you to enable Two-Factor Authentication for your account. You need to do this before ')
end
end
context 'when invalid password is provided' do
let_it_be(:user) { create(:user) }
it 'renders a error alert with a link to the troubleshooting section' do
visit profile_two_factor_auth_path
register_2fa(user.current_otp, 'abc')
click_button 'Register with two-factor app'
expect(page).to have_content(
'The global settings require you to enable Two-Factor Authentication for your account'
)
end
end
end
end
context 'when user has two-factor authentication enabled' do
let_it_be(:user) { create(:user, :two_factor_via_otp, :two_factor_via_webauthn) }
it 'requires the current_password to delete the OTP authenticator', :js do
visit profile_two_factor_auth_path
click_button _('Delete one-time password authenticator')
modal_submit('wrong_password')
expect(page).to have_selector('.gl-alert-title', text: invalid_current_pwd_msg, count: 1)
click_button _('Delete one-time password authenticator')
modal_submit(user.password)
expect(page).to have_content(_('One-time password authenticator has been deleted!'))
end
it 'requires the current_password to disable two-factor authentication', :js do
visit profile_two_factor_auth_path
click_button _('Disable two-factor authentication')
modal_submit('wrong_password')
expect(page).to have_selector('.gl-alert-title', text: invalid_current_pwd_msg, count: 1)
click_button _('Disable two-factor authentication')
modal_submit(user.password)
expect(page).to have_content('Two-factor authentication has been disabled successfully!')
expect(page).to have_content('Enable two-factor authentication')
end
it 'requires the current_password to regenerate recovery codes', :js do
visit profile_two_factor_auth_path
click_button _('Regenerate recovery codes')
modal_submit('wrong_password')
expect(page).to have_selector('.gl-alert-title', text: invalid_current_pwd_msg, count: 1)
click_button _('Regenerate recovery codes')
modal_submit(user.password)
expect(page).to have_content('Please copy, download, or print your recovery codes before proceeding.')
end
context 'when user authenticates with an external service' do
let_it_be(:user) { create(:omniauth_user, :two_factor) }
it 'does not require the current_password to delete the OTP authenticator', :js do
visit profile_two_factor_auth_path
click_button _('Delete one-time password authenticator')
modal_submit_without_password
expect(page).to have_content(_('One-time password authenticator has been deleted!'))
end
it 'does not require the current_password to disable two-factor authentication', :js do
visit profile_two_factor_auth_path
click_button _('Disable two-factor authentication')
modal_submit_without_password
expect(page).to have_content('Two-factor authentication has been disabled successfully!')
expect(page).to have_content('Enable two-factor authentication')
end
it 'does not require the current_password to regenerate recovery codes', :js do
visit profile_two_factor_auth_path
click_button _('Regenerate recovery codes')
modal_submit_without_password
expect(page).to have_content('Please copy, download, or print your recovery codes before proceeding.')
end
end
end
def register_2fa(pin, password)
fill_in 'pin_code', with: pin
fill_in 'current_password', with: password
click_button 'Register with two-factor app'
end
def modal_submit(password)
within_modal do
fill_in 'current_password', with: password
find_by_testid('2fa-action-primary').click
end
end
def modal_submit_without_password
within_modal do
find_by_testid('2fa-action-primary').click
end
end
end
end
|
