File: container_registry_spec.rb

package info (click to toggle)
gitlab 17.6.5-19
  • links: PTS, VCS
  • area: main
  • in suites: sid
  • size: 629,368 kB
  • sloc: ruby: 1,915,304; javascript: 557,307; sql: 60,639; xml: 6,509; sh: 4,567; makefile: 1,239; python: 406
file content (243 lines) | stat: -rw-r--r-- 7,801 bytes parent folder | download
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
# frozen_string_literal: true

require 'spec_helper'

RSpec.describe 'Container Registry', :js, feature_category: :container_registry do
  include_context 'container registry tags'

  let(:user) { create(:user) }
  let(:project) { create(:project) }

  let(:container_repository) do
    create(:container_repository, name: 'my/image')
  end

  let(:nameless_container_repository) do
    create(:container_repository, name: '')
  end

  let(:help_page_href) { help_page_path('administration/packages/container_registry_metadata_database.md') }

  before do
    sign_in(user)
    project.add_developer(user)
    stub_container_registry_config(enabled: true)
    stub_container_registry_info
    stub_container_registry_tags(repository: :any, tags: [])
  end

  shared_examples 'pagination and state preservation' do
    it 'navigates through pages and preserves pagination state', :aggregate_failures do
      expect(page).to have_css '.gl-keyset-pagination'
      visit_next_page

      expect(page).to have_content 'my/image'
      click_link 'my/image'
      page.go_back

      expect(page).to have_content 'my/image'
    end
  end

  context 'with metadatabase enabled' do
    before do
      allow(ContainerRegistry::GitlabApiClient).to receive(:supports_gitlab_api?).and_return(true)
    end

    it 'has a page title set' do
      visit_container_registry

      expect(page).to have_title _('Container Registry')
    end

    it 'has link to next generation container registry docs' do
      allow(ContainerRegistry::GitlabApiClient).to receive(:supports_gitlab_api?).and_return(false)

      visit_container_registry

      expect(page).to have_link('next-generation container registry', href: help_page_href)
    end

    it 'does not have link to settings' do
      visit_container_registry

      expect(page).not_to have_link(_('Configure in settings'), href: project_settings_packages_and_registries_path(project))
    end

    it 'has link to settings when user is maintainer' do
      project.add_maintainer(user)

      visit_container_registry

      expect(page).to have_link(_('Configure in settings'), href: project_settings_packages_and_registries_path(project))
    end

    context 'when there are no image repositories' do
      it 'list page has no container title' do
        visit_container_registry

        expect(page).to have_content _('There are no container images stored for this project')
      end

      it 'list page has cli commands' do
        visit_container_registry

        expect(page).to have_content _('CLI Commands')
      end
    end

    context 'when there are image repositories' do
      before do
        stub_container_registry_tags(repository: %r{my/image}, tags: %w[latest], with_manifest: true)
        project.container_repositories << container_repository
      end

      it 'list page has a list of images' do
        visit_container_registry

        expect(page).to have_content '1 Image repository'
        expect(page).to have_content 'my/image'
      end

      it 'user removes entire container repository' do
        visit_container_registry

        expect_any_instance_of(ContainerRepository).to receive(:delete_scheduled!).and_call_original

        find('[title="Remove repository"]').click
        expect(find('.modal .modal-title')).to have_content _('Delete image repository?')
        find('.modal .modal-body input').set('my/image')
        find('.modal .modal-footer .btn-danger').click
      end

      it 'navigates to repo details' do
        visit_container_registry_details('my/image')

        expect(page).to have_content 'latest'
      end

      describe 'image repo details' do
        before do
          stub_container_registry_tags(repository: %r{my/image}, tags: ('1'..'25').to_a, with_manifest: true)
          visit_container_registry_details 'my/image'
          click_sort_option('Name', true)
        end

        it 'shows the details breadcrumb' do
          expect(find_by_testid('breadcrumb-links')).to have_link 'my/image'
        end

        it 'shows the image title' do
          expect(page).to have_content 'my/image'
        end

        it 'shows the image tags' do
          expect(page).to have_content '25 tags'
          first_tag = first('[data-testid="name"]')
          expect(first_tag).to have_content '1'
        end

        it 'user removes a specific tag from container repository' do
          service = double('service')
          expect(service).to receive(:execute).with(container_repository) { { status: :success } }
          expect(Projects::ContainerRepository::DeleteTagsService).to receive(:new).with(container_repository.project, user, tags: ['1']) { service }

          first('[data-testid="additional-actions"]').click
          first('[data-testid="single-delete-button"]').click
          expect(find('.modal .modal-title')).to have_content _('Remove tag')
          stub_container_registry_tags(repository: %r{my/image}, tags: ('1'..'19').to_a, with_manifest: true)
          find('.modal .modal-footer .btn-danger').click

          expect(page).to have_content '19 tags'
          expect(page).not_to have_content '20 tags'
        end

        it('pagination navigate to the second page') do
          visit_next_page

          expect(page).to have_content '20'
        end
      end

      describe 'with a tag missing digest' do
        before do
          stub_container_registry_tags(repository: %r{my/image}, tags: %w[latest stable])
          stub_next_container_registry_tags_call(:digest, nil)
          visit_container_registry_details 'my/image'
        end

        it 'renders the tags list correctly', :aggregate_failures do
          expect(page).to have_content('latest')
          expect(page).to have_content('stable')
          expect(page).to have_content('Digest: Not applicable.')
        end
      end

      [ContainerRegistry::Path::InvalidRegistryPathError, Faraday::Error].each do |error_class|
        context "when there is a #{error_class}" do
          before do
            expect(::ContainerRegistry::Client).to receive(:registry_info).and_raise(error_class, nil, nil)
          end

          it_behaves_like 'handling feature network errors with the container registry'
        end
      end
    end

    describe 'image repo details when image has no name' do
      before do
        stub_container_registry_tags(tags: %w[latest], with_manifest: true)
        project.container_repositories << nameless_container_repository
        visit_container_registry
      end

      it 'renders correctly' do
        find('a[data-testid="details-link"]').click

        expect(page).to have_content 'latest'
      end
    end

    context 'when there are more than 20 images' do
      before do
        project.container_repositories << container_repository
        create_list(:container_repository, 22, project: project)

        visit_container_registry
      end

      it_behaves_like 'pagination and state preservation'
    end
  end

  describe 'with metadatabase disabled' do
    before do
      allow(ContainerRegistry::GitlabApiClient).to receive(:supports_gitlab_api?).and_return(false)
    end

    context 'when there are more than 10 images' do
      before do
        project.container_repositories << container_repository
        create_list(:container_repository, 12, project: project)

        visit_container_registry
      end

      it_behaves_like 'pagination and state preservation'
    end
  end

  def visit_container_registry
    visit project_container_registry_index_path(project)
  end

  def visit_container_registry_details(name)
    visit_container_registry
    click_link name
  end

  def visit_next_page
    pagination = find '.gl-keyset-pagination'
    pagination.click_button 'Next'
  end
end