File: user_creates_files_spec.rb

package info (click to toggle)
gitlab 17.6.5-19
  • links: PTS, VCS
  • area: main
  • in suites: sid
  • size: 629,368 kB
  • sloc: ruby: 1,915,304; javascript: 557,307; sql: 60,639; xml: 6,509; sh: 4,567; makefile: 1,239; python: 406
file content (227 lines) | stat: -rw-r--r-- 7,575 bytes parent folder | download
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
# frozen_string_literal: true

require 'spec_helper'

RSpec.describe 'Projects > Files > User creates files', :js, feature_category: :source_code_management do
  include Features::SourceEditorSpecHelpers
  include Features::BlobSpecHelpers

  let(:fork_message) do
    "You're not allowed to make changes to this project directly. "\
    "A fork of this project has been created that you can make changes in, so you can submit a merge request."
  end

  let(:project) { create(:project, :repository, name: 'Shop') }
  let(:project2) { create(:project, :repository, name: 'Another Project', path: 'another-project') }
  let(:project_tree_path_root_ref) { project_tree_path(project, project.repository.root_ref) }
  let(:project2_tree_path_root_ref) { project_tree_path(project2, project2.repository.root_ref) }
  let(:user) { create(:user) }

  before do
    project.add_maintainer(user)
    sign_in(user)
  end

  context 'without committing a new file' do
    context 'when an user has write access' do
      before do
        visit(project_tree_path_root_ref)
      end

      it 'opens new file page' do
        find('.add-to-tree').click
        click_link('New file')

        expect(page).to have_content('New file')
        expect(page).to have_content('Commit message')
      end
    end

    context 'when an user does not have write access' do
      before do
        project2.add_reporter(user)
        visit(project2_tree_path_root_ref)
      end

      it 'opens new file page on a forked project', :sidekiq_might_not_need_inline do
        find('.add-to-tree').click
        click_link('New file')

        expect(page).to have_selector('.file-editor')
        expect(page).to have_content(fork_message)
        expect(page).to have_content('New file')
        expect(page).to have_content('Commit message')
      end
    end
  end

  context 'with committing a new file' do
    let(:file_name) { 'a_file.md' }
    let(:file_content) { 'some file content' }
    let(:can_submit_mr_content) { 'You can now submit a merge request to get this change into the original branch.' }

    context 'when an user has write access' do
      let(:branch_name) { 'new_branch_name' }

      before do
        visit(project_tree_path_root_ref)

        find('.add-to-tree').click
        click_link('New file')
        expect(page).to have_selector('.file-editor')
      end

      it 'shows full path instead of ref when creating a file' do
        expect(page).to have_selector('#editor_path')
        expect(page).not_to have_selector('#editor_ref')
      end

      def submit_new_file(options)
        file_name = find('#file_name')
        file_name.set options[:file_name] || 'README.md'

        find('.monaco-editor textarea').send_keys.native.send_keys options[:file_content] || 'Some content'

        click_button 'Commit changes'
      end

      it 'allows Chinese characters in file name' do
        submit_new_file(file_name: '测试.md')
        expect(page).to have_content 'The file has been successfully created.'
      end

      it 'allows Chinese characters in directory name' do
        submit_new_file(file_name: '中文/测试.md')
        expect(page).to have_content 'The file has been successfully created'
      end

      it 'does not allow directory traversal in file name' do
        submit_new_file(file_name: '../README.md')
        expect(page).to have_content 'Path cannot include directory traversal'
      end

      it 'creates and commits a new file' do
        editor_set_value(file_content)
        fill_in(:file_name, with: file_name)
        fill_in(:commit_message, with: 'New commit message', visible: true)

        click_button('Commit changes')

        new_file_path = project_blob_path(project, "master/#{file_name}")

        expect(page).to have_current_path(new_file_path, ignore_query: true)

        wait_for_requests

        expect(page).to have_content(file_content)
      end

      it 'creates and commits a new file with new lines at the end of file' do
        editor_set_value('Sample\n\n\n')
        fill_in(:file_name, with: file_name)
        fill_in(:commit_message, with: 'New commit message', visible: true)

        click_button('Commit changes')

        new_file_path = project_blob_path(project, "master/#{file_name}")

        expect(page).to have_current_path(new_file_path, ignore_query: true)

        edit_in_single_file_editor

        expect(find('.monaco-editor')).to have_content('Sample\n\n\n')
      end

      it 'creates and commits a new file with a directory name' do
        fill_in(:file_name, with: 'foo/bar/baz.txt')

        expect(page).to have_selector('.file-editor')

        editor_set_value(file_content)
        fill_in(:commit_message, with: 'New commit message', visible: true)

        click_button('Commit changes')

        expect(page).to have_current_path(project_blob_path(project, 'master/foo/bar/baz.txt'), ignore_query: true)

        wait_for_requests

        expect(page).to have_content(file_content)
      end

      context 'when not creating a new MR' do
        it 'creates and commits a new file specifying a new branch' do
          expect(page).to have_selector('.file-editor')

          editor_set_value(file_content)
          fill_in(:file_name, with: file_name)
          fill_in(:commit_message, with: 'New commit message', visible: true)
          fill_in(:branch_name, with: branch_name, visible: true)
          find_field('Start a new merge request with these changes').uncheck

          click_button('Commit changes')

          new_file_path = project_blob_path(project, "#{branch_name}/#{file_name}")

          expect(page).to have_current_path(new_file_path)

          wait_for_requests

          expect(page).not_to have_content(can_submit_mr_content)
        end
      end

      context 'when creating a new MR' do
        it 'creates and commits a new file specifying a new branch and creates an MR' do
          expect(page).to have_selector('.file-editor')

          editor_set_value(file_content)
          fill_in(:file_name, with: file_name)
          fill_in(:commit_message, with: 'New commit message', visible: true)
          fill_in(:branch_name, with: branch_name, visible: true)

          click_button('Commit changes')

          expect(page).to have_current_path(project_new_merge_request_path(project), ignore_query: true)

          click_link('Changes')

          wait_for_requests

          expect(page).to have_content(can_submit_mr_content)
        end
      end
    end

    context 'when an user does not have write access', :sidekiq_might_not_need_inline do
      before do
        project2.add_reporter(user)
        visit(project2_tree_path_root_ref)

        find('.add-to-tree').click
        click_link('New file')
      end

      it 'shows a message saying the file will be committed in a fork' do
        message = "GitLab will create a branch in your fork and start a merge request."

        expect(page).to have_content(message)
      end

      it 'creates and commits a new file in forked project' do
        expect(page).to have_selector('.file-editor')

        editor_set_value(file_content)

        fill_in(:file_name, with: file_name)
        fill_in(:commit_message, with: 'New commit message', visible: true)
        click_button('Commit changes')

        fork = user.fork_of(project2.reload)

        expect(page).to have_current_path(project_new_merge_request_path(fork), ignore_query: true)
        expect(page).to have_content('New commit message')
      end
    end
  end
end