1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe 'GPG signed commits', :js, feature_category: :source_code_management do
let_it_be(:project) { create(:project, :public, :repository) }
it 'changes from unverified to verified when the user changes their email to match the gpg key', :sidekiq_might_not_need_inline do
ref = GpgHelpers::SIGNED_AND_AUTHORED_SHA
user = create(:user, email: 'unrelated.user@example.org')
perform_enqueued_jobs do
create :gpg_key, key: GpgHelpers::User1.public_key, user: user
user.reload # necessary to reload the association with gpg_keys
end
visit project_commit_path(project, ref)
expect(page).to have_selector('.gl-badge', text: 'Unverified')
# user changes their email which makes the gpg key verified
perform_enqueued_jobs do
user.skip_reconfirmation!
user.update!(email: GpgHelpers::User1.emails.first)
end
visit project_commit_path(project, ref)
expect(page).to have_selector('.gl-badge', text: 'Verified')
end
it 'changes from unverified to verified when the user adds the missing gpg key', :sidekiq_might_not_need_inline do
ref = GpgHelpers::SIGNED_AND_AUTHORED_SHA
user = create(:user, email: GpgHelpers::User1.emails.first)
visit project_commit_path(project, ref)
expect(page).to have_selector('.gl-badge', text: 'Unverified')
# user adds the gpg key which makes the signature valid
perform_enqueued_jobs do
create :gpg_key, key: GpgHelpers::User1.public_key, user: user
end
visit project_commit_path(project, ref)
expect(page).to have_selector('.gl-badge', text: 'Verified')
end
context 'shows popover badges' do
let(:user_1) do
create :user, email: GpgHelpers::User1.emails.first, username: 'nannie.bernhard', name: 'Nannie Bernhard'
end
let(:user_1_key) do
perform_enqueued_jobs do
create :gpg_key, key: GpgHelpers::User1.public_key, user: user_1
end
end
let(:user_2) do
create(:user, email: GpgHelpers::User2.emails.first, username: 'bette.cartwright', name: 'Bette Cartwright').tap do |user|
# secondary, unverified email
create :email, user: user, email: 'mail@koffeinfrei.org'
end
end
let(:user_2_key) do
perform_enqueued_jobs do
create :gpg_key, key: GpgHelpers::User2.public_key, user: user_2
end
end
it 'unverified signature', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/444982' do
visit project_commit_path(project, GpgHelpers::SIGNED_COMMIT_SHA)
wait_for_all_requests
page.find('.gl-badge', text: 'Unverified').click
within '.popover' do
expect(page).to have_content 'This commit was signed with an unverified signature.'
expect(page).to have_content "GPG Key ID: #{GpgHelpers::User2.primary_keyid}"
end
end
it 'unverified signature: gpg key email does not match the committer_email but is the same user when the committer_email belongs to the user as a confirmed secondary email', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/444984' do
user_2_key
user_2.emails.find_by(email: 'mail@koffeinfrei.org').confirm
visit project_commit_path(project, GpgHelpers::SIGNED_COMMIT_SHA)
wait_for_all_requests
page.find('.gl-badge', text: 'Unverified').click
within '.popover' do
expect(page).to have_content 'This commit was signed with a verified signature, but the committer email is not associated with the GPG Key.'
expect(page).to have_content "GPG Key ID: #{GpgHelpers::User2.primary_keyid}"
end
end
it 'unverified signature: gpg key email does not match the committer_email when the committer_email belongs to the user as a unconfirmed secondary email',
quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/408233' do
user_2_key
visit project_commit_path(project, GpgHelpers::SIGNED_COMMIT_SHA)
wait_for_all_requests
page.find('.gl-badge', text: 'Unverified').click
within '.popover' do
expect(page).to have_content "This commit was signed with a different user's verified signature."
expect(page).to have_content "GPG Key ID: #{GpgHelpers::User2.primary_keyid}"
end
end
it 'unverified signature: commit contains multiple GPG signatures', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/408233' do
user_1_key
visit project_commit_path(project, GpgHelpers::MULTIPLE_SIGNATURES_SHA)
wait_for_all_requests
page.find('.gl-badge', text: 'Unverified').click
within '.popover' do
expect(page).to have_content "This commit was signed with multiple signatures."
end
end
it 'verified and the gpg user has a gitlab profile', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/408233' do
user_1_key
visit project_commit_path(project, GpgHelpers::SIGNED_AND_AUTHORED_SHA)
wait_for_all_requests
page.find('.gl-badge', text: 'Verified').click
within '.popover' do
expect(page).to have_content 'This commit was signed with a verified signature and the committer email was verified to belong to the same user.'
expect(page).to have_content "GPG Key ID: #{GpgHelpers::User1.primary_keyid}"
end
end
it "verified and the gpg user's profile doesn't exist anymore", quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/395802' do
user_1_key
visit project_commit_path(project, GpgHelpers::SIGNED_AND_AUTHORED_SHA)
wait_for_all_requests
# wait for the signature to get generated
expect(page).to have_selector('.gl-badge', text: 'Verified')
user_1.destroy!
refresh
wait_for_all_requests
page.find('.gl-badge', text: 'Verified').click
within '.popover' do
expect(page).to have_content 'This commit was signed with a verified signature and the committer email was verified to belong to the same user.'
expect(page).to have_content "GPG Key ID: #{GpgHelpers::User1.primary_keyid}"
end
end
# The below situation can occur when using the git mailmap feature.
# See https://gitlab.com/gitlab-org/gitlab/-/issues/425042.
describe 'the effect of mailmapping' do
def expect_to_have_mapped_verified_label_content(ref, fingerprint_message)
visit project_commit_path(project, ref)
wait_for_all_requests
page.find('.gl-badge', text: 'Verified').click
within '.popover' do
expect(page).to have_content 'This commit was previously signed with a verified signature and verified committer email address. However the committer email address is no longer verified to the same user.'
expect(page).to have_content fingerprint_message
end
end
def expect_to_have_verified_label_content(ref, fingerprint_message)
visit project_commit_path(project, ref)
wait_for_all_requests
page.find('.gl-badge', text: 'Verified').click
within '.popover' do
expect(page).to have_content 'Verified commit This commit was signed with a verified signature and the committer email was verified to belong to the same user.'
expect(page).to have_content fingerprint_message
end
end
context 'on SSH signed commits' do
let(:commit) { project.commit('7b5160f9bb23a3d58a0accdbe89da13b96b1ece9') }
context 'when user commit email is not verified and the commit is signed and verified' do
let(:commit) { project.commit('7b5160f9bb23a3d58a0accdbe89da13b96b1ece9') }
let(:fingerprint) { commit.signature.key_fingerprint_sha256 }
before do
create(:ssh_signature, user: user_1, commit_sha: commit.sha, project: project, verification_status: :verified)
allow(commit).to receive(:author_email).and_return('unverified@email.org')
end
it 'label is mapped verified' do
expect_to_have_mapped_verified_label_content(commit.sha, "SSH key fingerprint: #{fingerprint}")
end
context 'when the check_for_mailmapped_commit_emails feature flag is disabled' do
before do
stub_feature_flags(check_for_mailmapped_commit_emails: false)
end
it 'label is verified' do
expect_to_have_verified_label_content(commit.sha, "SSH key fingerprint: #{fingerprint}")
end
end
end
end
context 'on GPG on signed commits' do
let(:commit) { project.commit(GpgHelpers::SIGNED_COMMIT_SHA) }
context 'when user commit email is not verified and the commit is signed and verified' do
let(:fingerprint) { GpgHelpers::User1.primary_keyid }
before do
create(
:gpg_signature,
commit_sha: commit.sha,
gpg_key: (create :gpg_key, user: user_1),
project: project,
verification_status: :verified
)
allow(commit).to receive(:author_email).and_return('unverified@email.org')
end
it 'label is mapped verified' do
expect_to_have_mapped_verified_label_content(commit.sha, "GPG Key ID: #{fingerprint}")
end
context 'when the check_for_mailmapped_commit_emails feature flag is disabled' do
before do
stub_feature_flags(check_for_mailmapped_commit_emails: false)
end
it 'label is verified' do
expect_to_have_verified_label_content(commit.sha, "GPG Key ID: #{fingerprint}")
end
end
end
end
end
end
context 'view signed commit on the tree view' do
shared_examples 'a commit with a signature' do
before do
visit project_tree_path(project, 'signed-commits')
wait_for_all_requests
end
it 'displays commit signature' do
expect(page).to have_selector('.gl-badge', text: 'Unverified')
page.find('.gl-badge', text: 'Unverified').click
within '.popover' do
expect(page).to have_content 'This commit was signed with multiple signatures.'
end
end
end
context 'with vue tree view enabled' do
it_behaves_like 'a commit with a signature'
end
end
end
|
