1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
|
# frozen_string_literal: true
# TODO: This spec file can be removed after fully migration to the gitlab-http gem.
# It's already covered in gems/gitlab-http/spec/gitlab/http_v2/net_http_patch_spec.rb
require 'spec_helper'
RSpec.describe 'Net::HTTP patch proxy user and password encoding', feature_category: :shared do
let(:net_http) { Net::HTTP.new('hostname.example') }
before do
# This file can be removed once Ruby 3.0 is no longer supported:
# https://gitlab.com/gitlab-org/gitlab/-/issues/396223
skip if Gem::Version.new(Net::HTTP::VERSION) >= Gem::Version.new('0.2.0')
end
describe '#proxy_user' do
subject { net_http.proxy_user }
it { is_expected.to eq(nil) }
context 'with http_proxy env' do
let(:http_proxy) { 'http://proxy.example:8000' }
before do
allow(ENV).to receive(:[]).and_call_original
stub_env('http_proxy', http_proxy)
end
it { is_expected.to eq(nil) }
context 'and user:password authentication' do
let(:http_proxy) { 'http://Y%5CX:R%25S%5D%20%3FX@proxy.example:8000' }
context 'when on multiuser safe platform' do
# linux, freebsd, darwin are considered multi user safe platforms
# See https://github.com/ruby/net-http/blob/v0.1.1/lib/net/http.rb#L1174-L1178
before do
allow(net_http).to receive(:environment_variable_is_multiuser_safe?).and_return(true)
end
it { is_expected.to eq 'Y\\X' }
end
context 'when not on multiuser safe platform' do
before do
allow(net_http).to receive(:environment_variable_is_multiuser_safe?).and_return(false)
end
it { is_expected.to be_nil }
end
end
end
end
describe '#proxy_pass' do
subject { net_http.proxy_pass }
it { is_expected.to eq(nil) }
context 'with http_proxy env' do
let(:http_proxy) { 'http://proxy.example:8000' }
before do
allow(ENV).to receive(:[]).and_call_original
stub_env('http_proxy', http_proxy)
end
it { is_expected.to eq(nil) }
context 'and user:password authentication' do
let(:http_proxy) { 'http://Y%5CX:R%25S%5D%20%3FX@proxy.example:8000' }
context 'when on multiuser safe platform' do
# linux, freebsd, darwin are considered multi user safe platforms
# See https://github.com/ruby/net-http/blob/v0.1.1/lib/net/http.rb#L1174-L1178
before do
allow(net_http).to receive(:environment_variable_is_multiuser_safe?).and_return(true)
end
it { is_expected.to eq 'R%S] ?X' }
end
context 'when not on multiuser safe platform' do
before do
allow(net_http).to receive(:environment_variable_is_multiuser_safe?).and_return(false)
end
it { is_expected.to be_nil }
end
end
end
end
end
|
