1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
|
# frozen_string_literal: true
require 'spec_helper'
require './keeps/helpers/groups'
RSpec.describe Keeps::Helpers::Groups, feature_category: :tooling do
let(:groups) do
{
'tenant_scale' => {
'name' => 'Tenant Scale',
'section' => 'core_platform',
'stage' => 'data_stores',
'categories' => %w[cell groups_and_projects user_profile organization],
'label' => 'group::tenant scale',
'extra_labels' => [],
'slack_channel' => 'g_tenant_scale',
'backend_engineers' => %w[be1 be2 be3 be4 be5],
'triage_ops_config' => nil
},
'group_b' => {
'name' => 'Group B',
'section' => 'core_platform',
'stage' => 'data_stores',
'categories' => %w[category_b],
'label' => 'group::group b',
'extra_labels' => [],
'slack_channel' => 'g_group_b',
'backend_engineers' => %w[],
'triage_ops_config' => nil
}
}
end
before do
stub_request(:get, "https://about.gitlab.com/groups.json").to_return(status: 200, body: groups.to_json)
end
describe '#group_for_feature_category' do
let(:category) { 'organization' }
subject(:group) { described_class.new.group_for_feature_category(category) }
it { is_expected.to eq(groups['tenant_scale']) }
context 'when the category does not exist' do
let(:category) { 'missing-category' }
it { is_expected.to eq(nil) }
end
context 'when given nil' do
let(:category) { nil }
it { is_expected.to eq(nil) }
end
context 'when the request to fetch groups fails' do
before do
stub_request(:get, "https://about.gitlab.com/groups.json").to_return(status: 404, body: '')
end
it 'raises an error' do
expect { group }.to raise_error(described_class::Error)
end
end
end
describe '#pick_reviewer' do
let(:group) { groups['tenant_scale'] }
let(:identifiers) { %w[example identifier] }
let(:expected_index) { Digest::SHA256.hexdigest(identifiers.join).to_i(16) % group['backend_engineers'].size }
subject { described_class.new.pick_reviewer(group, identifiers) }
it { is_expected.to eq(group['backend_engineers'][expected_index]) }
context 'when given nil' do
let(:group) { nil }
it { is_expected.to eq(nil) }
end
end
describe '#pick_reviewer_for_feature_category' do
let(:group) { groups['tenant_scale'] }
let(:identifiers) { %w[example identifier] }
let(:expected_index) { Digest::SHA256.hexdigest(identifiers.join).to_i(16) % group['backend_engineers'].size }
let(:category) { 'organization' }
let(:fallback_feature_category) { nil }
subject(:reviewer) do
described_class.new.pick_reviewer_for_feature_category(category, identifiers,
fallback_feature_category: fallback_feature_category)
end
it 'finds a matching group and picks a reviewer from the group owning that feature category' do
expect(reviewer).to eq(group['backend_engineers'][expected_index])
end
context 'when the matching group does not have backend_engineers' do
let(:category) { 'category_b' }
it { is_expected.to eq(nil) }
context 'when a fallback_feature_category is passed' do
let(:fallback_feature_category) { 'organization' }
it 'returns a reviewer from that fallback_feature_category' do
expect(reviewer).to eq(group['backend_engineers'][expected_index])
end
end
end
end
describe '#labels_for_feature_category' do
let(:category) { 'organization' }
subject(:labels) { described_class.new.labels_for_feature_category(category) }
it 'returns the group label for the matching group' do
expect(labels).to eq(['group::tenant scale'])
end
context 'when there is no matching group' do
let(:category) { 'not_a_category' }
it { is_expected.to eq([]) }
end
end
end
|
