1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe API::Ci::Helpers::Runner, feature_category: :runner do
let(:helper) do
Class.new do
include API::Ci::Helpers::Runner
include Gitlab::RackLoadBalancingHelpers
end.new
end
let(:env_hash) { {} }
let(:request) { instance_double(Rack::Request, env: env_hash) }
before do
allow(helper).to receive(:request).and_return(request)
end
describe '#current_job', feature_category: :continuous_integration do
let(:build) { create(:ci_build, :running) }
it 'handles sticking of a build when a build ID is specified' do
allow(helper).to receive(:params).and_return(id: build.id)
expect(Ci::Build.sticking)
.to receive(:find_caught_up_replica)
.with(:build, build.id)
helper.current_job
stick_object = env_hash[::Gitlab::Database::LoadBalancing::RackMiddleware::STICK_OBJECT].first
expect(stick_object[0]).to eq(Ci::Build.sticking)
expect(stick_object[1]).to eq(:build)
expect(stick_object[2]).to eq(build.id)
end
it 'does not handle sticking if no build ID was specified' do
allow(helper).to receive(:params).and_return({})
expect(Ci::Build.sticking)
.not_to receive(:find_caught_up_replica)
helper.current_job
end
it 'returns the build if one could be found' do
allow(helper).to receive(:params).and_return(id: build.id)
expect(helper.current_job).to eq(build)
end
end
describe '#current_runner', feature_category: :runner do
let(:runner) { create(:ci_runner, token: 'foo') }
it 'handles sticking of a runner if a token is specified' do
allow(helper).to receive(:params).and_return(token: runner.token)
expect(Ci::Runner.sticking)
.to receive(:find_caught_up_replica)
.with(:runner, runner.token)
helper.current_runner
stick_object = env_hash[::Gitlab::Database::LoadBalancing::RackMiddleware::STICK_OBJECT].first
expect(stick_object[0]).to eq(Ci::Runner.sticking)
expect(stick_object[1]).to eq(:runner)
expect(stick_object[2]).to eq(runner.token)
end
it 'does not handle sticking if no token was specified' do
allow(helper).to receive(:params).and_return({})
expect(Ci::Runner.sticking)
.not_to receive(:find_caught_up_replica)
helper.current_runner
end
it 'returns the runner if one could be found' do
allow(helper).to receive(:params).and_return(token: runner.token)
expect(helper.current_runner).to eq(runner)
end
end
describe '#current_runner_manager', :freeze_time, feature_category: :fleet_visibility do
let_it_be(:group) { create(:group) }
let(:runner) { create(:ci_runner, :group, token: 'foo', groups: [group]) }
subject(:current_runner_manager) { helper.current_runner_manager }
context 'when runner manager already exists' do
let!(:existing_runner_manager) do
create(:ci_runner_machine, runner: runner, system_xid: 'bar', contacted_at: 1.hour.ago)
end
before do
allow(helper).to receive(:params).and_return(token: runner.token, system_id: existing_runner_manager.system_xid)
end
it { is_expected.to eq(existing_runner_manager) }
it 'does not update the contacted_at field' do
expect(current_runner_manager.contacted_at).to eq 1.hour.ago
end
context 'when a runner manager with nil sharding_key_id already exists' do
before do
Ci::ApplicationRecord.connection.execute <<~SQL
ALTER TABLE group_type_ci_runner_machines_687967fa8a
DROP CONSTRAINT IF EXISTS check_sharding_key_id_nullness
SQL
existing_runner_manager.update_columns(sharding_key_id: nil)
end
it 'reuses existing runner manager', :aggregate_failures do
expect { current_runner_manager }.not_to raise_error
expect(current_runner_manager).not_to be_nil
expect(current_runner_manager).to eq existing_runner_manager
expect(current_runner_manager.reload.contacted_at).to eq 1.hour.ago
expect(current_runner_manager.runner_type).to eq runner.runner_type
expect(current_runner_manager.sharding_key_id).to be_nil
end
end
end
context 'when runner manager cannot be found' do
it 'creates a new runner manager', :aggregate_failures do
allow(helper).to receive(:params).and_return(token: runner.token, system_id: 'new_system_id')
expect { current_runner_manager }.to change { Ci::RunnerManager.count }.by(1)
expect(current_runner_manager).not_to be_nil
current_runner_manager.reload
expect(current_runner_manager.system_xid).to eq('new_system_id')
expect(current_runner_manager.contacted_at).to be_nil
expect(current_runner_manager.runner).to eq(runner)
expect(current_runner_manager.runner_type).to eq(runner.runner_type)
expect(current_runner_manager.sharding_key_id).to eq(runner.sharding_key_id)
# Verify that a second call doesn't raise an error
expect { helper.current_runner_manager }.not_to raise_error
expect(Ci::RunnerManager.count).to eq(1)
end
it 'creates a new <legacy> runner manager if system_id is not specified', :aggregate_failures do
allow(helper).to receive(:params).and_return(token: runner.token)
expect { current_runner_manager }.to change { Ci::RunnerManager.count }.by(1)
expect(current_runner_manager).not_to be_nil
expect(current_runner_manager.system_xid).to eq(::API::Ci::Helpers::Runner::LEGACY_SYSTEM_XID)
expect(current_runner_manager.runner).to eq(runner)
expect(current_runner_manager.runner_type).to eq(runner.runner_type)
expect(current_runner_manager.sharding_key_id).to eq(runner.sharding_key_id)
end
end
end
describe '#track_runner_authentication', :prometheus, feature_category: :runner do
subject { helper.track_runner_authentication }
let(:runner) { create(:ci_runner, token: 'foo') }
it 'increments gitlab_ci_runner_authentication_success_total' do
allow(helper).to receive(:params).and_return(token: runner.token)
success_counter = ::Gitlab::Ci::Runner::Metrics.runner_authentication_success_counter
failure_counter = ::Gitlab::Ci::Runner::Metrics.runner_authentication_failure_counter
expect { subject }.to change { success_counter.get(runner_type: 'instance_type') }.by(1)
.and not_change { success_counter.get(runner_type: 'project_type') }
.and not_change { failure_counter.get }
end
it 'increments gitlab_ci_runner_authentication_failure_total' do
allow(helper).to receive(:params).and_return(token: 'invalid')
success_counter = ::Gitlab::Ci::Runner::Metrics.runner_authentication_success_counter
failure_counter = ::Gitlab::Ci::Runner::Metrics.runner_authentication_failure_counter
expect { subject }.to change { failure_counter.get }.by(1)
.and not_change { success_counter.get(runner_type: 'instance_type') }
.and not_change { success_counter.get(runner_type: 'project_type') }
end
end
describe '#check_if_backoff_required!' do
subject { helper.check_if_backoff_required! }
let(:backoff_runner) { false }
before do
allow(Gitlab::Database::Migrations::RunnerBackoff::Communicator)
.to receive(:backoff_runner?)
.and_return(backoff_runner)
end
context 'when migrations are running' do
let(:backoff_runner) { true }
it 'denies requests' do
expect(helper).to receive(:too_many_requests!)
subject
end
end
context 'when migrations are not running' do
let(:backoff_runner) { false }
it 'allows requests' do
expect(helper).not_to receive(:too_many_requests!)
subject
end
end
end
end
|