1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Backup::Manager, feature_category: :backup_restore do
include StubENV
let_it_be(:progress) { StringIO.new }
let(:logger) { subject.logger }
let(:backup_tasks) { nil }
let(:options) { build(:backup_options, :skip_none) }
let(:backup_path) { Pathname(Dir.mktmpdir('backup-manager', TestEnv::TMP_TEST_PATH)) }
let(:fixtures_path) { Rails.root.join('spec/fixtures/backups') }
let(:backup_fixture_filename) { '1714155640_2024_04_26_17.0.0-pre_gitlab_backup.tar' }
let(:backup_fixture_version) { '17.0.0-pre' }
let(:backup_fixture) { fixtures_path.join(backup_fixture_filename) }
subject { described_class.new(progress, backup_tasks: backup_tasks) }
before do
# Rspec fails with `uninitialized constant RSpec::Support::Differ` when it
# is trying to display a diff and `File.exist?` is stubbed. Adding a
# default stub fixes this.
allow(File).to receive(:exist?).and_call_original
allow(FileUtils).to receive(:rm_rf).and_call_original
allow(progress).to receive(:puts).and_call_original
allow(Gitlab.config.backup).to receive(:path).and_return(backup_path)
end
after do
FileUtils.rm_rf(backup_path)
end
describe '#run_create_task' do
describe 'other task' do
let(:terraform_state) do
Backup::Tasks::TerraformState.new(progress: progress, options: options)
.tap { |state| allow(state).to receive(:target).and_return(target) }
end
let(:target) { instance_double(Backup::Targets::Target) }
let(:backup_tasks) do
{ 'terraform_state' => terraform_state }
end
it 'runs the provided task' do
expect(target).to receive(:dump)
expect(logger).to receive(:info).with('Dumping terraform states ... ')
expect(logger).to receive(:info).with('Dumping terraform states ... done')
subject.run_create_task(terraform_state)
end
context 'when disabled' do
it 'does not run the task and informs the user' do
allow(terraform_state).to receive(:enabled).and_return(false)
expect(target).not_to receive(:dump)
expect(logger).to receive(:info).with('Dumping terraform states ... [DISABLED]')
subject.run_create_task(terraform_state)
end
end
context 'when skipped' do
it 'does not run the task and informs the user' do
stub_env('SKIP', 'terraform_state')
expect(target).not_to receive(:dump)
expect(logger).to receive(:info).with('Dumping terraform states ... [SKIPPED]')
subject.run_create_task(terraform_state)
end
end
end
end
describe 'database task' do
let(:backup_state) do
Backup::Tasks::Database.new(progress: progress, options: options)
.tap { |state| allow(state).to receive(:target).and_return(target) }
end
let(:target) { instance_double(Backup::Targets::Target) }
let(:backup_tasks) do
backup_state
end
it 'runs the provided task' do
expect(target).to receive(:dump)
expect(logger).to receive(:info).with('Dumping database ... ')
expect(logger).to receive(:info).with('Dumping database ... done')
subject.run_create_task(backup_tasks)
end
context 'when the task succeeds' do
it 'returns true' do
expect(target).to receive(:dump)
expect(logger).to receive(:info).with('Dumping database ... ')
expect(logger).to receive(:info).with('Dumping database ... done')
expect(subject.run_create_task(backup_tasks)).to be_truthy
end
end
context 'when the task fails with a known error' do
it 'returns false' do
allow(target).to receive(:dump).and_raise(Backup::DatabaseBackupError.new({ host: 'foo', port: 'bar', database: 'baz' }, 'foo'))
expect(logger).to receive(:info).with('Dumping database ... ')
expect(logger).to receive(:error).with(/Dumping database failed: Failed to create compressed file/)
expect(subject.run_create_task(backup_tasks)).to be_falsey
end
end
context 'when the task fails with an unknown error' do
it 'returns false' do
allow(target).to receive(:dump).and_raise(StandardError)
expect(logger).to receive(:info).with('Dumping database ... ')
expect do
subject.run_create_task(backup_tasks)
end.to raise_error(StandardError)
end
end
end
describe '#run_restore_task' do
let(:terraform_state) do
Backup::Tasks::TerraformState.new(progress: progress, options: options)
.tap { |task| allow(task).to receive(:target).and_return(target) }
end
let(:task_name) { 'terraform_state' }
let(:pre_restore_warning) { '' }
let(:post_restore_warning) { '' }
let(:target) { instance_double(::Backup::Targets::Target) }
let(:backup_tasks) do
{ 'terraform_state' => terraform_state }
end
let(:backup_information) { { backup_created_at: Time.zone.parse('2019-01-01'), gitlab_version: '12.3' } }
let(:backup_id) { "1546300800_2019_01_01_#{Gitlab::VERSION}" }
let(:restore_process) do
Backup::Restore::Process.new(
backup_id: backup_id,
backup_path: backup_path,
backup_task: backup_tasks[task_name],
logger: logger
)
end
before do
allow_next_instance_of(Backup::Metadata) do |metadata|
allow(metadata).to receive(:load_from_file).and_return(backup_information)
end
allow(terraform_state).to receive(:pre_restore_warning).and_return(pre_restore_warning)
allow(terraform_state).to receive(:post_restore_warning).and_return(post_restore_warning)
end
it 'runs the provided task' do
expect(target).to receive(:restore)
expect(logger).to receive(:info).with('Restoring terraform states ... ').ordered
expect(logger).to receive(:info).with('Restoring terraform states ... done').ordered
restore_process.execute!
end
describe 'disabled' do
it 'informs the user' do
allow(terraform_state).to receive(:enabled).and_return(false)
expect(target).not_to receive(:restore)
expect(logger).to receive(:info).with('Restoring terraform states ... [DISABLED]').ordered
restore_process.execute!
end
end
describe 'pre_restore_warning' do
let(:pre_restore_warning) { 'Watch out!' }
describe 'skip prompt' do
before do
stub_env('GITLAB_ASSUME_YES', 1)
end
it 'does not ask to continue' do
expect(logger).to receive(:info).with('Restoring terraform states ... ').ordered
expect(logger).to receive(:warn).with('Watch out!').ordered
expect(logger).to receive(:info).with('Restoring terraform states ... done').ordered
expect(Gitlab::TaskHelpers).not_to receive(:prompt)
expect(target).to receive(:restore)
restore_process.execute!
end
end
describe 'with prompt' do
it 'displays and waits for the user' do
expect(logger).to receive(:info).with('Restoring terraform states ... ').ordered
expect(logger).to receive(:warn).with('Watch out!').ordered
expect(logger).to receive(:info).with('Restoring terraform states ... done').ordered
expect(Gitlab::TaskHelpers).to receive(:ask_to_continue)
expect(target).to receive(:restore)
restore_process.execute!
end
it 'does not continue when the user quits' do
expect(logger).to receive(:info).with('Restoring terraform states ... ').ordered
expect(logger).to receive(:warn).with('Watch out!').ordered
expect(logger).to receive(:error).with('Quitting...').ordered
expect(Gitlab::TaskHelpers).to receive(:ask_to_continue).and_raise(Gitlab::TaskAbortedByUserError)
expect do
restore_process.execute!
end.to raise_error(SystemExit)
end
end
end
describe 'post_restore_warning' do
let(:post_restore_warning) { 'Watch out!' }
describe 'skip prompt' do
before do
stub_env('GITLAB_ASSUME_YES', 1)
end
it "does not ask to continue" do
expect(logger).to receive(:info).with('Restoring terraform states ... ').ordered
expect(logger).to receive(:info).with('Restoring terraform states ... done').ordered
expect(logger).to receive(:warn).with('Watch out!').ordered
expect(Gitlab::TaskHelpers).not_to receive(:prompt)
expect(target).to receive(:restore)
restore_process.execute!
end
end
describe "prompt" do
it 'displays and waits for the user' do
expect(logger).to receive(:info).with('Restoring terraform states ... ').ordered
expect(logger).to receive(:info).with('Restoring terraform states ... done').ordered
expect(logger).to receive(:warn).with('Watch out!').ordered
expect(Gitlab::TaskHelpers).to receive(:ask_to_continue)
expect(target).to receive(:restore)
restore_process.execute!
end
it 'does not continue when the user quits' do
expect(logger).to receive(:info).with('Restoring terraform states ... ').ordered
expect(logger).to receive(:info).with('Restoring terraform states ... done').ordered
expect(logger).to receive(:warn).with('Watch out!').ordered
expect(logger).to receive(:error).with('Quitting...').ordered
expect(target).to receive(:restore)
expect(Gitlab::TaskHelpers).to receive(:ask_to_continue).and_raise(Gitlab::TaskAbortedByUserError)
expect do
restore_process.execute!
end.to raise_error(SystemExit)
end
end
end
end
describe '#create' do
let(:incremental_env) { 'false' }
let(:expected_backup_contents) { %w[backup_information.yml lfs.tar.gz pages.tar.gz] }
let(:backup_time) { Time.zone.parse('2019-1-1') }
let(:backup_id) { "1546300800_2019_01_01_#{Gitlab::VERSION}" }
let(:full_backup_id) { backup_id }
let(:pack_tar_file) { "#{backup_id}_gitlab_backup.tar" }
let(:lfs) { Backup::Tasks::Lfs.new(progress: progress, options: options) }
let(:pages) { Backup::Tasks::Pages.new(progress: progress, options: options) }
let(:backup_tasks) do
{ 'lfs' => lfs, 'pages' => pages }
end
before do
stub_env('INCREMENTAL', incremental_env)
allow(ApplicationRecord.connection).to receive(:reconnect!)
end
it 'creates a backup tar' do
travel_to(backup_time) do
subject.create # rubocop:disable Rails/SaveBang
end
expect(File).to exist(backup_path.join(pack_tar_file))
expect(FileUtils).to have_received(:rm_rf).with(backup_path.join('backup_information.yml'))
expect(FileUtils).to have_received(:rm_rf).with(backup_path.join('tmp'))
end
context 'when BACKUP is set' do
let(:backup_id) { 'custom' }
before do
stub_env('BACKUP', '/ignored/path/custom')
end
it 'uses the given value as tar file name' do
subject.create # rubocop:disable Rails/SaveBang
expect(File).to exist(backup_path.join('custom_gitlab_backup.tar'))
end
context 'tar fails' do
it 'logs a failure' do
allow(Open3).to receive(:pipeline).and_return(
[instance_double(Process::Status, success?: false, exitstatus: 1)]
)
expect do
subject.create # rubocop:disable Rails/SaveBang
end.to raise_error(Backup::Error, 'Backup failed')
expect(progress.string).to include("Creating archive #{pack_tar_file} failed")
expect(FileUtils).to have_received(:rm_rf).with(backup_path.join('backup_information.yml'))
expect(FileUtils).to have_received(:rm_rf).with(backup_path.join('tmp'))
end
end
context 'when SKIP env is set' do
let(:expected_backup_contents) { %w[backup_information.yml lfs.tar.gz] }
it 'executes tar' do
stub_env('SKIP', 'pages')
expect(lfs).to receive(:target).and_call_original
expect(pages).not_to receive(:target)
subject.create # rubocop:disable Rails/SaveBang
end
end
context 'when the destination is optional' do
let(:expected_backup_contents) { %w[backup_information.yml lfs.tar.gz] }
let(:pages) do
Backup::Tasks::Pages.new(progress: progress, options: options)
.tap do |task|
allow(task).to receive(:destination_optional).and_return(true)
end
end
it 'executes tar' do
allow(pages).to receive_message_chain(:target, :dump)
expect(File).to receive(:exist?).with(backup_path.join('pages.tar.gz')).and_return(false)
subject.create # rubocop:disable Rails/SaveBang
end
end
context 'many backup files' do
let(:files) do
%w[
1451606400_2016_01_01_1.2.3_gitlab_backup.tar
1451520000_2015_12_31_4.5.6_gitlab_backup.tar
1451520000_2015_12_31_4.5.6-pre_gitlab_backup.tar
1451520000_2015_12_31_4.5.6-rc1_gitlab_backup.tar
1451520000_2015_12_31_4.5.6-pre-ee_gitlab_backup.tar
1451510000_2015_12_30_gitlab_backup.tar
1450742400_2015_12_22_gitlab_backup.tar
1449878400_gitlab_backup.tar
1449014400_gitlab_backup.tar
manual_gitlab_backup.tar
]
end
before do
files.each do |bkp|
FileUtils.touch(backup_path.join(bkp))
end
allow(FileUtils).to receive(:rm).and_call_original
allow(Time).to receive(:now).and_return(Time.zone.parse('2016-1-1'))
end
context 'when keep_time is zero' do
before do
allow(Gitlab.config.backup).to receive(:keep_time).and_return(0)
subject.create # rubocop:disable Rails/SaveBang
end
it 'removes no files' do
files.each do |bkp|
expect(File).to exist(backup_path.join(bkp))
end
end
it 'prints a skipped message' do
expect(progress.string).to include('Deleting old backups ... [SKIPPED]')
end
end
context 'when no valid file is found' do
let(:files) do
%w[
14516064000_2016_01_01_1.2.3_gitlab_backup.tar
foo_1451520000_2015_12_31_4.5.6_gitlab_backup.tar
1451520000_2015_12_31_4.5.6-foo_gitlab_backup.tar
]
end
before do
allow(Gitlab.config.backup).to receive(:keep_time).and_return(1)
subject.create # rubocop:disable Rails/SaveBang
end
it 'removes no files' do
files.each do |bkp|
expect(File).to exist(backup_path.join(bkp))
end
end
it 'prints a done message' do
expect(progress.string).to include('Deleting old backups ... done. (0 removed)')
end
end
context 'when there are no files older than keep_time' do
before do
# Set to 30 days
allow(Gitlab.config.backup).to receive(:keep_time).and_return(2592000)
subject.create # rubocop:disable Rails/SaveBang
end
it 'removes no files' do
files.each do |bkp|
expect(File).to exist(backup_path.join(bkp))
end
end
it 'prints a done message' do
expect(progress.string).to include('Deleting old backups ... done. (0 removed)')
end
end
context 'when keep_time is set to remove files' do
before do
# Set to 1 second
allow(Gitlab.config.backup).to receive(:keep_time).and_return(1)
subject.create # rubocop:disable Rails/SaveBang
end
it 'removes matching files with a human-readable versioned timestamp' do
expect(FileUtils).to have_received(:rm).with(files[1])
expect(FileUtils).to have_received(:rm).with(files[2])
expect(FileUtils).to have_received(:rm).with(files[3])
end
it 'removes matching files with a human-readable versioned timestamp with tagged EE' do
expect(FileUtils).to have_received(:rm).with(files[4])
end
it 'removes matching files with a human-readable non-versioned timestamp' do
expect(FileUtils).to have_received(:rm).with(files[5])
expect(FileUtils).to have_received(:rm).with(files[6])
end
it 'removes matching files without a human-readable timestamp' do
expect(FileUtils).to have_received(:rm).with(files[7])
expect(FileUtils).to have_received(:rm).with(files[8])
end
it 'does not remove files that are not old enough' do
expect(FileUtils).not_to have_received(:rm).with(files[0])
end
it 'does not remove non-matching files' do
expect(FileUtils).not_to have_received(:rm).with(files[9])
end
it 'prints a done message' do
expect(progress.string).to include('Deleting old backups ... done. (8 removed)')
end
end
context 'when removing a file fails' do
let(:file) { files[1] }
let(:message) { "Permission denied @ unlink_internal - #{file}" }
before do
allow(Gitlab.config.backup).to receive(:keep_time).and_return(1)
allow(FileUtils).to receive(:rm).with(file).and_raise(Errno::EACCES, message)
subject.create # rubocop:disable Rails/SaveBang
end
it 'removes the remaining expected files' do
expect(FileUtils).to have_received(:rm).with(files[4])
expect(FileUtils).to have_received(:rm).with(files[5])
expect(FileUtils).to have_received(:rm).with(files[6])
expect(FileUtils).to have_received(:rm).with(files[7])
expect(FileUtils).to have_received(:rm).with(files[8])
end
it 'sets the correct removed count' do
expect(progress.string).to include('Deleting old backups ... done. (7 removed)')
end
it 'prints the error from file that could not be removed' do
expect(progress.string).to include(message)
end
end
end
describe 'cloud storage' do
let(:backup_file) { Tempfile.new('backup', backup_path) }
let(:backup_filename) { File.basename(backup_file.path) }
before do
allow_next_instance_of(described_class) do |manager|
allow(manager).to receive(:tar_file).and_return(backup_filename)
allow(manager.remote_storage).to receive(:tar_file).and_return(backup_filename)
end
stub_backup_setting(
upload: {
connection: {
provider: 'AWS',
aws_access_key_id: 'id',
aws_secret_access_key: 'secret'
},
remote_directory: 'directory',
multipart_chunk_size: 104857600,
encryption: nil,
encryption_key: nil,
storage_class: nil
}
)
Fog.mock!
# the Fog mock only knows about directories we create explicitly
connection = ::Fog::Storage.new(Gitlab.config.backup.upload.connection.symbolize_keys)
connection.directories.create(key: Gitlab.config.backup.upload.remote_directory) # rubocop:disable Rails/SaveBang
end
context 'skipped upload' do
let(:backup_information) do
{
backup_created_at: Time.zone.parse('2019-01-01'),
gitlab_version: '12.3',
skipped: ['remote']
}
end
it 'informs the user' do
stub_env('SKIP', 'remote')
subject.create # rubocop:disable Rails/SaveBang
expect(progress.string).to include('Uploading backup archive to remote storage directory ... [SKIPPED]')
end
end
context 'target path' do
it 'uses the tar filename by default' do
expect_any_instance_of(Fog::Collection).to receive(:create)
.with(hash_including(key: backup_filename, public: false))
.and_call_original
subject.create # rubocop:disable Rails/SaveBang
end
it 'adds the DIRECTORY environment variable if present' do
stub_env('DIRECTORY', 'daily')
expect_any_instance_of(Fog::Collection).to receive(:create)
.with(hash_including(key: "daily/#{backup_filename}", public: false))
.and_call_original
subject.create # rubocop:disable Rails/SaveBang
end
end
context 'with AWS with server side encryption' do
let(:connection) { ::Fog::Storage.new(Gitlab.config.backup.upload.connection.symbolize_keys) }
let(:encryption_key) { nil }
let(:encryption) { nil }
let(:storage_options) { nil }
before do
stub_backup_setting(
upload: {
connection: {
provider: 'AWS',
aws_access_key_id: 'AWS_ACCESS_KEY_ID',
aws_secret_access_key: 'AWS_SECRET_ACCESS_KEY'
},
remote_directory: 'directory',
multipart_chunk_size: Gitlab.config.backup.upload.multipart_chunk_size,
encryption: encryption,
encryption_key: encryption_key,
storage_options: storage_options,
storage_class: nil
}
)
connection.directories.create(key: Gitlab.config.backup.upload.remote_directory) # rubocop:disable Rails/SaveBang
end
context 'with SSE-S3 without using storage_options' do
let(:encryption) { 'AES256' }
it 'sets encryption attributes' do
subject.create # rubocop:disable Rails/SaveBang
expect(progress.string).to include('Uploading backup archive to remote storage directory ... done (encrypted with AES256)')
end
end
context 'with SSE-C (customer-provided keys) options' do
let(:encryption) { 'AES256' }
let(:encryption_key) { SecureRandom.hex }
it 'sets encryption attributes' do
subject.create # rubocop:disable Rails/SaveBang
expect(progress.string).to include('Uploading backup archive to remote storage directory ... done (encrypted with AES256)')
end
end
context 'with SSE-KMS options' do
let(:storage_options) do
{
server_side_encryption: 'aws:kms',
server_side_encryption_kms_key_id: 'arn:aws:kms:12345'
}
end
it 'sets encryption attributes' do
subject.create # rubocop:disable Rails/SaveBang
expect(progress.string).to include('Uploading backup archive to remote storage directory ... done (encrypted with aws:kms)')
end
end
end
context 'with Google provider' do
before do
stub_backup_setting(
upload: {
connection: {
provider: 'Google',
google_storage_access_key_id: 'test-access-id',
google_storage_secret_access_key: 'secret'
},
remote_directory: 'directory',
multipart_chunk_size: Gitlab.config.backup.upload.multipart_chunk_size,
encryption: nil,
encryption_key: nil,
storage_class: nil
}
)
connection = ::Fog::Storage.new(Gitlab.config.backup.upload.connection.symbolize_keys)
connection.directories.create(key: Gitlab.config.backup.upload.remote_directory) # rubocop:disable Rails/SaveBang
end
it 'does not attempt to set ACL' do
expect_any_instance_of(Fog::Collection).to receive(:create)
.with(hash_excluding(public: false))
.and_call_original
subject.create # rubocop:disable Rails/SaveBang
end
end
context 'with AzureRM provider' do
before do
stub_backup_setting(
upload: {
connection: {
provider: 'AzureRM',
azure_storage_account_name: 'test-access-id',
azure_storage_access_key: 'secret'
},
remote_directory: 'directory',
multipart_chunk_size: nil,
encryption: nil,
encryption_key: nil,
storage_class: nil
}
)
end
it 'loads the provider' do
expect { subject.create }.not_to raise_error # rubocop:disable Rails/SaveBang
end
end
end
end
context 'tar skipped' do
before do
stub_env('SKIP', 'tar')
end
after do
FileUtils.rm_rf(Dir.glob(backup_path.join('*')), secure: true)
end
it 'creates a non-tarred backup' do
expect(subject).not_to receive(:pack)
travel_to(backup_time) do
subject.create # rubocop:disable Rails/SaveBang
end
expect(subject.send(:backup_information).to_h).to include(
backup_id: backup_id,
backup_created_at: backup_time.localtime,
db_version: be_a(String),
gitlab_version: Gitlab::VERSION,
installation_type: Gitlab::INSTALLATION_TYPE,
skipped: 'tar',
tar_version: be_a(String)
)
expect(FileUtils).to have_received(:rm_rf).with(backup_path.join('tmp'))
end
end
context 'incremental' do
let(:incremental_env) { 'true' }
let(:gitlab_version) { Gitlab::VERSION }
let(:backup_id) { "1546300800_2019_01_01_#{gitlab_version}" }
let(:unpack_tar_file) { "#{full_backup_id}_gitlab_backup.tar" }
let(:unpack_tar_cmdline) { ['tar', '-xf', unpack_tar_file] }
let(:backup_information) do
{
backup_created_at: Time.zone.parse('2018-01-01'),
gitlab_version: gitlab_version
}
end
before do
allow_next_instance_of(Backup::Metadata) do |metadata|
allow(metadata).to receive(:load_from_file).and_return(backup_information)
end
end
context 'when there are no backup files in the directory' do
before do
allow(Dir).to receive(:glob).and_return([])
end
it 'fails the operation and prints an error' do
expect { subject.create }.to raise_error SystemExit # rubocop:disable Rails/SaveBang
expect(progress.string).to include('No backups found')
end
end
context 'when there are two backup files in the directory and BACKUP variable is not set' do
before do
allow(Dir).to receive(:glob).and_return(
%w[
1451606400_2016_01_01_1.2.3_gitlab_backup.tar
1451520000_2015_12_31_gitlab_backup.tar
]
)
end
it 'prints the list of available backups' do
expect { subject.create }.to raise_error SystemExit # rubocop:disable Rails/SaveBang
expect(progress.string).to include('1451606400_2016_01_01_1.2.3')
expect(progress.string).to include('1451520000_2015_12_31')
end
it 'fails the operation and prints an error' do
expect { subject.create }.to raise_error SystemExit # rubocop:disable Rails/SaveBang
expect(progress.string).to include('Found more than one backup')
end
end
context 'when BACKUP variable is set to a non-existing file' do
before do
allow(Dir).to receive(:glob).and_return(
[
'1451606400_2016_01_01_gitlab_backup.tar'
]
)
allow(File).to receive(:exist?).and_return(false)
stub_env('BACKUP', 'wrong')
end
it 'fails the operation and prints an error' do
expect { subject.create }.to raise_error SystemExit # rubocop:disable Rails/SaveBang
expect(File).to have_received(:exist?).with('wrong_gitlab_backup.tar')
expect(progress.string).to include('The backup file wrong_gitlab_backup.tar does not exist')
end
end
context 'when BACKUP variable is set to a correct file' do
let(:backup_id) { '1451606400_2016_01_01_1.2.3' }
before do
allow(Dir).to receive(:glob).and_return(
[
'1451606400_2016_01_01_1.2.3_gitlab_backup.tar'
]
)
allow(File).to receive(:exist?).and_return(true)
allow(Kernel).to receive(:system).and_return(true)
stub_env('BACKUP', '/ignored/path/1451606400_2016_01_01_1.2.3')
end
it 'unpacks and packs the backup' do
expect(subject).to receive(:run_unpack).and_call_original
expect(subject).to receive(:pack).and_call_original
travel_to(backup_time) do
subject.create # rubocop:disable Rails/SaveBang
end
expect(Kernel).to have_received(:system).with(*unpack_tar_cmdline)
expect(FileUtils).to have_received(:rm_rf).with(backup_path.join('backup_information.yml'))
expect(FileUtils).to have_received(:rm_rf).with(backup_path.join('tmp'))
end
context 'untar fails' do
before do
expect(Kernel).to receive(:system).with(*unpack_tar_cmdline).and_return(false)
end
it 'logs a failure' do
expect do
subject.create # rubocop:disable Rails/SaveBang
end.to raise_error(SystemExit)
expect(progress.string).to include('Unpacking backup failed')
end
end
context 'tar fails' do
it 'logs a failure' do
allow(Open3).to receive(:pipeline).and_return(
[instance_double(Process::Status, success?: false, exitstatus: 1)]
)
expect do
subject.create # rubocop:disable Rails/SaveBang
end.to raise_error(Backup::Error, 'Backup failed')
expect(progress.string).to include("Creating archive #{pack_tar_file} failed")
expect(FileUtils).to have_received(:rm_rf).with(backup_path.join('backup_information.yml'))
expect(FileUtils).to have_received(:rm_rf).with(backup_path.join('tmp'))
end
end
context 'on version mismatch' do
let(:backup_information) do
{
backup_created_at: Time.zone.parse('2019-01-01'),
gitlab_version: "not #{gitlab_version}"
}
end
it 'stops the process' do
expect { subject.create }.to raise_error SystemExit # rubocop:disable Rails/SaveBang
expect(progress.string).to include('GitLab version mismatch')
end
end
end
context 'when PREVIOUS_BACKUP variable is set to a non-existing file' do
before do
allow(Dir).to receive(:glob).and_return(
[
'1451606400_2016_01_01_gitlab_backup.tar'
]
)
allow(File).to receive(:exist?).and_return(false)
stub_env('PREVIOUS_BACKUP', 'wrong')
end
it 'fails the operation and prints an error' do
expect { subject.create }.to raise_error SystemExit # rubocop:disable Rails/SaveBang
expect(File).to have_received(:exist?).with('wrong_gitlab_backup.tar')
expect(progress.string).to include('The backup file wrong_gitlab_backup.tar does not exist')
end
end
context 'when PREVIOUS_BACKUP variable is set to a correct file' do
let(:full_backup_id) { 'some_previous_backup' }
before do
allow(Dir).to receive(:glob).and_return(
[
'some_previous_backup_gitlab_backup.tar'
]
)
allow(File).to receive(:exist?).with('some_previous_backup_gitlab_backup.tar').and_return(true)
allow(Kernel).to receive(:system).and_return(true)
stub_env('PREVIOUS_BACKUP', '/ignored/path/some_previous_backup')
end
it 'unpacks and packs the backup' do
expect(subject).to receive(:run_unpack).and_call_original
expect(subject).to receive(:pack).and_call_original
travel_to(backup_time) do
subject.create # rubocop:disable Rails/SaveBang
end
expect(Kernel).to have_received(:system).with(*unpack_tar_cmdline)
expect(FileUtils).to have_received(:rm_rf).with(backup_path.join('backup_information.yml'))
expect(FileUtils).to have_received(:rm_rf).with(backup_path.join('tmp'))
end
context 'untar fails' do
before do
expect(Kernel).to receive(:system).with(*unpack_tar_cmdline).and_return(false)
end
it 'logs a failure' do
expect do
travel_to(backup_time) do
subject.create # rubocop:disable Rails/SaveBang
end
end.to raise_error(SystemExit)
expect(progress.string).to include('Unpacking backup failed')
end
end
context 'tar fails' do
before do
allow(Open3).to receive(:pipeline).and_return(
[instance_double(Process::Status, success?: false, exitstatus: 1)]
)
end
it 'logs a failure' do
expect do
travel_to(backup_time) do
subject.create # rubocop:disable Rails/SaveBang
end
end.to raise_error(Backup::Error, 'Backup failed')
expect(progress.string).to include("Creating archive #{pack_tar_file} failed")
expect(FileUtils).to have_received(:rm_rf).with(backup_path.join('backup_information.yml'))
expect(FileUtils).to have_received(:rm_rf).with(backup_path.join('tmp'))
end
end
context 'on version mismatch' do
let(:backup_information) do
{
backup_created_at: Time.zone.parse('2018-01-01'),
gitlab_version: "not #{gitlab_version}"
}
end
it 'stops the process' do
expect { subject.create }.to raise_error SystemExit # rubocop:disable Rails/SaveBang
expect(progress.string).to include('GitLab version mismatch')
end
end
end
context 'when there is a non-tarred backup in the directory' do
let(:full_backup_id) { "1514764800_2018_01_01_#{Gitlab::VERSION}" }
let(:backup_information) do
{
backup_created_at: Time.zone.parse('2018-01-01'),
gitlab_version: gitlab_version,
skipped: 'tar'
}
end
before do
allow(Dir).to receive(:glob).and_return(
[
'backup_information.yml'
]
)
allow(File).to receive(:exist?).with(backup_path.join('backup_information.yml')).and_return(true)
stub_env('SKIP', 'pages')
end
after do
FileUtils.rm(backup_path.join('backup_information.yml'), force: true)
end
it 'updates the non-tarred backup' do
travel_to(backup_time) do
subject.create # rubocop:disable Rails/SaveBang
end
expect(progress.string).to include('Non tarred backup found ')
expect(progress.string).to include("Backup #{backup_id} is done")
expect(subject.send(:backup_information).to_h).to include(
backup_created_at: backup_time,
full_backup_id: full_backup_id,
gitlab_version: Gitlab::VERSION,
skipped: 'tar,pages')
end
context 'on version mismatch' do
let(:backup_information) do
{
backup_created_at: Time.zone.parse('2019-01-01'),
gitlab_version: "not #{gitlab_version}"
}
end
it 'stops the process' do
expect { subject.create }.to raise_error SystemExit # rubocop:disable Rails/SaveBang
expect(progress.string).to include('GitLab version mismatch')
end
end
end
end
context 'when a single task fails' do
before do
stub_env('SKIP', 'tar') # avoiding an error during #pack
end
after do
FileUtils.rm_rf(Dir.glob(backup_path.join('*')), secure: true)
end
it 'returns false' do
allow(lfs).to receive(:backup!).and_raise(Backup::FileBackupError.new('foo', 'bar'))
expect(subject.create).to be_falsey
end
end
end
describe '#restore' do
let(:lfs) do
Backup::Tasks::Lfs.new(progress: progress, options: options)
.tap { |task| allow(task).to receive(:target).and_return(target1) }
end
let(:pages) do
Backup::Tasks::Pages.new(progress: progress, options: options)
.tap { |task| allow(task).to receive(:target).and_return(target2) }
end
let(:target1) { instance_double(Backup::Targets::Target) }
let(:target2) { instance_double(Backup::Targets::Target) }
let(:backup_tasks) do
{ 'lfs' => lfs, 'pages' => pages }
end
let(:gitlab_version) { Gitlab::VERSION }
let(:backup_id) { "1546300800_2019_01_01_#{gitlab_version}" }
let(:backup_information) do
{
backup_created_at: Time.zone.parse('2019-01-01'),
gitlab_version: gitlab_version
}
end
before do
Rake.application.rake_require 'tasks/gitlab/shell'
Rake.application.rake_require 'tasks/cache'
allow(target1).to receive(:restore).with(backup_path.join('lfs.tar.gz'), backup_id)
allow(target2).to receive(:restore).with(backup_path.join('pages.tar.gz'), backup_id)
allow_next_instance_of(Backup::Metadata) do |metadata|
allow(metadata).to receive(:load_from_file).and_return(backup_information)
end
allow(Rake::Task['gitlab:shell:setup']).to receive(:invoke)
allow(Rake::Task['cache:clear']).to receive(:invoke)
end
context 'when there are no backup files in the directory' do
before do
allow(Dir).to receive(:glob).and_return([])
end
it 'fails the operation and prints an error' do
expect { subject.restore }.to raise_error SystemExit
expect(progress.string).to include('No backups found')
end
end
context 'when there are two backup files in the directory and BACKUP variable is not set' do
before do
allow(Dir).to receive(:glob).and_return(
%w[
1451606400_2016_01_01_1.2.3_gitlab_backup.tar
1451520000_2015_12_31_gitlab_backup.tar
]
)
end
it 'prints the list of available backups' do
expect { subject.restore }.to raise_error SystemExit
expect(progress.string).to include('1451606400_2016_01_01_1.2.3')
expect(progress.string).to include('1451520000_2015_12_31')
end
it 'fails the operation and prints an error' do
expect { subject.restore }.to raise_error SystemExit
expect(progress.string).to include('Found more than one backup')
end
end
context 'when BACKUP variable is set to a non-existing file' do
before do
allow(Dir).to receive(:glob).and_return(
[
'1451606400_2016_01_01_gitlab_backup.tar'
]
)
allow(File).to receive(:exist?).and_return(false)
stub_env('BACKUP', 'wrong')
end
it 'fails the operation and prints an error' do
expect { subject.restore }.to raise_error SystemExit
expect(File).to have_received(:exist?).with('wrong_gitlab_backup.tar')
expect(progress.string).to include('The backup file wrong_gitlab_backup.tar does not exist')
end
end
context 'when BACKUP variable is set to a correct file' do
let(:tar_cmdline) { %w[tar -xf 1451606400_2016_01_01_1.2.3_gitlab_backup.tar] }
let(:backup_id) { "1451606400_2016_01_01_1.2.3" }
before do
allow(Dir).to receive(:glob).and_return(
[
'1451606400_2016_01_01_1.2.3_gitlab_backup.tar'
]
)
allow(File).to receive(:exist?).and_return(true)
allow(Kernel).to receive(:system).and_return(true)
stub_env('BACKUP', '/ignored/path/1451606400_2016_01_01_1.2.3')
end
it 'unpacks the file' do
subject.restore
expect(Kernel).to have_received(:system).with(*tar_cmdline)
expect(FileUtils).to have_received(:rm_rf).with(backup_path.join('backup_information.yml'))
expect(FileUtils).to have_received(:rm_rf).with(backup_path.join('tmp'))
end
context 'backup information mismatches' do
let(:backup_id) { 'pineapple' }
let(:backup_information) do
{
backup_id: backup_id,
backup_created_at: Time.zone.parse('2019-01-01'),
gitlab_version: gitlab_version
}
end
it 'unpacks the BACKUP specified file but uses the backup information backup ID' do
expect(target1).to receive(:restore).with(backup_path.join('lfs.tar.gz'), backup_id)
expect(target2).to receive(:restore).with(backup_path.join('pages.tar.gz'), backup_id)
subject.restore
expect(Kernel).to have_received(:system).with(*tar_cmdline)
expect(FileUtils).to have_received(:rm_rf).with(backup_path.join('backup_information.yml'))
expect(FileUtils).to have_received(:rm_rf).with(backup_path.join('tmp'))
end
end
context 'tar fails' do
before do
expect(Kernel).to receive(:system).with(*tar_cmdline).and_return(false)
end
it 'logs a failure' do
expect do
subject.restore
end.to raise_error(SystemExit)
expect(progress.string).to include('Unpacking backup failed')
end
end
context 'on version mismatch' do
let(:backup_information) do
{
backup_created_at: Time.zone.parse('2019-01-01'),
gitlab_version: "not #{gitlab_version}"
}
end
it 'stops the process' do
expect { subject.restore }.to raise_error SystemExit
expect(progress.string).to include('GitLab version mismatch')
end
end
end
context 'when there is a non-tarred backup in the directory' do
before do
allow(Dir).to receive(:glob).and_return(
[
'backup_information.yml'
]
)
allow(File).to receive(:exist?).and_return(true)
end
it 'selects the non-tarred backup to restore from' do
expect(Kernel).not_to receive(:system)
subject.restore
expect(progress.string).to include('Non tarred backup found ')
expect(FileUtils).to have_received(:rm_rf).with(backup_path.join('tmp'))
end
context 'on version mismatch' do
let(:backup_information) do
{
backup_created_at: Time.zone.parse('2019-01-01'),
gitlab_version: "not #{gitlab_version}"
}
end
it 'stops the process' do
expect { subject.restore }.to raise_error SystemExit
expect(progress.string).to include('GitLab version mismatch')
end
end
end
end
describe '#tar_version' do
it 'returns a version matching expected format' do
tar_version = subject.send(:tar_version)
expect(tar_version).to be_a(String)
expect(tar_version).to match(/tar \(GNU tar\) [0-9]\.[0-9]+/)
end
end
describe '#verify!' do
let(:backup_id) { '1714155640_2024_04_26_17.0.0-pre' }
before do
FileUtils.cp(backup_fixture, backup_path)
end
it 'unpacks the backup and reads information from disk' do
expect(subject).to receive(:run_unpack).and_call_original
expect(subject).to receive(:read_backup_information).and_call_original
allow_next_instance_of(Backup::Restore::Preconditions) do |preconditions|
allow(preconditions).to receive(:validate_backup_version!)
end
metadata = subject.instance_variable_get(:@metadata)
expect { subject.verify! }.to change { metadata.backup_information.try(:backup_id) }.from(nil).to(backup_id)
end
context 'when backup version matches with running gitlab version' do
it 'runs precondition verification and exit 0' do
stub_const('Gitlab::VERSION', backup_fixture_version)
allow_next_instance_of(Backup::Restore::Preconditions) do |preconditions|
allow(preconditions).to receive(:validate_backup_version!).and_call_original
end
expect { subject.verify! }.to raise_error(SystemExit) do |error|
expect(error.status).to eq(0)
end
end
end
context 'when backup version doesnt match with running gitlab version' do
it 'runs precondition verification and exit 0' do
stub_const('Gitlab::VERSION', '13.5.0')
allow_next_instance_of(Backup::Restore::Preconditions) do |preconditions|
allow(preconditions).to receive(:validate_backup_version!).and_call_original
end
expect { subject.verify! }.to raise_error(SystemExit) do |error|
expect(error.status).to eq(1)
end
end
end
it 'cleans up the backup temporary folder after verification' do
allow_next_instance_of(Backup::Restore::Preconditions) do |preconditions|
allow(preconditions).to receive(:validate_backup_version!)
end
subject.verify!
expect(backup_path.children.size).to eq(1)
expect(backup_path.children[0]).to eq(backup_path.join(backup_fixture_filename))
end
end
end
|