1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Ci::JobToken::Scope, feature_category: :continuous_integration, factory_default: :keep do
include Ci::JobTokenScopeHelpers
using RSpec::Parameterized::TableSyntax
let_it_be(:project) { create_default(:project) }
let_it_be(:user) { create_default(:user) }
let_it_be(:namespace) { create_default(:namespace) }
let_it_be(:source_project) do
create(:project,
ci_outbound_job_token_scope_enabled: true,
ci_inbound_job_token_scope_enabled: true
)
end
let(:current_project) { source_project }
let(:scope) { described_class.new(current_project) }
describe '#outbound_projects' do
subject { scope.outbound_projects }
context 'when no projects are added to the scope' do
it 'returns the project defining the scope' do
expect(subject).to contain_exactly(current_project)
end
end
context 'when projects are added to the scope' do
include_context 'with accessible and inaccessible projects'
it 'returns all projects that can be accessed from a given scope' do
expect(subject).to contain_exactly(current_project, outbound_allowlist_project, fully_accessible_project)
end
end
end
describe '#inbound_projects' do
subject { scope.inbound_projects }
context 'when no projects are added to the scope' do
it 'returns the project defining the scope' do
expect(subject).to contain_exactly(current_project)
end
end
context 'when projects are added to the scope' do
include_context 'with accessible and inaccessible projects'
it 'returns all projects that can be accessed from a given scope' do
expect(subject).to contain_exactly(current_project, inbound_allowlist_project)
end
end
end
describe '#groups' do
subject { scope.groups }
context 'when no groups are added to the scope' do
it 'returns an empty list' do
expect(subject).to be_empty
end
end
context 'when groups are added to the scope' do
let_it_be(:target_group) { create(:group) }
include_context 'with projects that are with and without groups added in allowlist'
with_them do
it 'returns all groups that are allowed access in the job token scope' do
expect(subject).to contain_exactly(target_group)
end
end
end
end
describe 'accessible?' do
subject { scope.accessible?(accessed_project) }
context 'with groups in allowlist' do
let_it_be(:target_group) { create(:group) }
let_it_be(:target_project) do
create(:project,
ci_inbound_job_token_scope_enabled: true,
group: target_group
)
end
let(:scope) { described_class.new(target_project) }
include_context 'with projects that are with and without groups added in allowlist'
where(:accessed_project, :result) do
ref(:project_with_target_project_group_in_allowlist) | true
ref(:project_wo_target_project_group_in_allowlist) | false
end
with_them do
it { is_expected.to eq(result) }
end
end
context 'with inbound and outbound scopes enabled' do
context 'when inbound and outbound access setup' do
include_context 'with accessible and inaccessible projects'
where(:accessed_project, :result) do
ref(:current_project) | true
ref(:inbound_allowlist_project) | false
ref(:unscoped_project1) | false
ref(:unscoped_project2) | false
ref(:outbound_allowlist_project) | false
ref(:inbound_accessible_project) | false
ref(:fully_accessible_project) | true
ref(:unscoped_public_project) | false
end
with_them do
it 'allows self and projects allowed from both directions' do
is_expected.to eq(result)
end
end
end
end
context 'with inbound scope enabled and outbound scope disabled' do
before do
accessed_project.update!(ci_inbound_job_token_scope_enabled: true)
current_project.update!(ci_outbound_job_token_scope_enabled: false)
end
include_context 'with accessible and inaccessible projects'
where(:accessed_project, :result) do
ref(:current_project) | true
ref(:inbound_allowlist_project) | false
ref(:unscoped_project1) | false
ref(:unscoped_project2) | false
ref(:outbound_allowlist_project) | false
ref(:inbound_accessible_project) | true
ref(:fully_accessible_project) | true
ref(:unscoped_public_project) | false
end
with_them do
it { is_expected.to eq(result) }
end
end
context 'with inbound scope disabled and outbound scope enabled' do
before do
accessed_project.update!(ci_inbound_job_token_scope_enabled: false)
current_project.update!(ci_outbound_job_token_scope_enabled: true)
end
include_context 'with accessible and inaccessible projects'
where(:accessed_project, :result) do
ref(:current_project) | true
ref(:inbound_allowlist_project) | false
ref(:unscoped_project1) | false
ref(:unscoped_project2) | false
ref(:outbound_allowlist_project) | true
ref(:inbound_accessible_project) | false
ref(:fully_accessible_project) | true
ref(:unscoped_public_project) | true
end
with_them do
it { is_expected.to eq(result) }
end
end
describe 'metrics' do
include_context 'with accessible and inaccessible projects'
context 'when the accessed project has ci_inbound_job_token_scope_enabled' do
before do
fully_accessible_project.update!(ci_inbound_job_token_scope_enabled: true)
end
it 'increments the counter metric with legacy: false' do
expect(Gitlab::Ci::Pipeline::Metrics.job_token_inbound_access_counter)
.to receive(:increment)
.with(legacy: false)
scope.accessible?(fully_accessible_project)
end
it 'does not log authorizations' do
expect(Ci::JobToken::Authorization).not_to receive(:log)
scope.accessible?(fully_accessible_project)
end
end
context 'when the accessed project has ci_inbound_job_token_scope_enabled false' do
before do
fully_accessible_project.update!(ci_inbound_job_token_scope_enabled: false)
end
it 'increments the counter metric with legacy: false' do
expect(Gitlab::Ci::Pipeline::Metrics.job_token_inbound_access_counter)
.to receive(:increment)
.with(legacy: true)
scope.accessible?(fully_accessible_project)
end
it 'captures authorizations', :request_store do
expect(Ci::JobToken::Authorization)
.to receive(:capture)
.with(origin_project: current_project, accessed_project: fully_accessible_project)
.once
.and_call_original
scope.accessible?(fully_accessible_project)
expect(Ci::JobToken::Authorization.captured_authorizations).to eq(
accessed_project_id: fully_accessible_project.id,
origin_project_id: current_project.id)
end
end
end
end
describe '#self_referential?' do
subject { scope.self_referential?(access_project) }
context 'when a current project requested' do
let(:access_project) { current_project }
it { is_expected.to be_truthy }
end
context 'when a different project requested' do
let_it_be(:access_project) { create(:project) }
it { is_expected.to be_falsey }
end
end
end
|
