File: resource_group_spec.rb

package info (click to toggle)
gitlab 17.6.5-19
  • links: PTS, VCS
  • area: main
  • in suites: sid
  • size: 629,368 kB
  • sloc: ruby: 1,915,304; javascript: 557,307; sql: 60,639; xml: 6,509; sh: 4,567; makefile: 1,239; python: 406
file content (203 lines) | stat: -rw-r--r-- 6,515 bytes parent folder | download
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
# frozen_string_literal: true

require 'spec_helper'

RSpec.describe Ci::ResourceGroup, feature_category: :continuous_delivery do
  let_it_be(:group) { create(:group) }

  it_behaves_like 'cleanup by a loose foreign key' do
    let!(:parent) { create(:project, group: group) }
    let!(:model) { create(:ci_resource_group, project: parent) }
  end

  describe 'validation' do
    it 'valids when key includes allowed character' do
      resource_group = build(:ci_resource_group, key: 'test')

      expect(resource_group).to be_valid
    end

    it 'invalids when key includes invalid character' do
      resource_group = build(:ci_resource_group, key: ':::')

      expect(resource_group).not_to be_valid
    end
  end

  describe '#ensure_resource' do
    it 'creates one resource when resource group is created' do
      resource_group = create(:ci_resource_group)

      expect(resource_group.resources.count).to eq(1)
      expect(resource_group.resources.all?(&:persisted?)).to eq(true)
    end
  end

  describe '#assign_resource_to' do
    include Ci::PartitioningHelpers

    before do
      stub_current_partition_id(ci_testing_partition_id)
    end

    subject { resource_group.assign_resource_to(build) }

    let(:build) { create(:ci_build) }
    let(:resource_group) { create(:ci_resource_group) }

    it 'retains resource for the processable' do
      expect(resource_group.resources.first.processable).to be_nil
      expect(resource_group.resources.first.partition_id).to be_nil

      is_expected.to eq(true)

      expect(resource_group.resources.first.processable).to eq(build)
      expect(resource_group.resources.first.partition_id).to eq(build.partition_id)
    end

    context 'when there are no free resources' do
      before do
        resource_group.assign_resource_to(create(:ci_build))
      end

      it 'fails to retain resource' do
        is_expected.to eq(false)
      end
    end

    context 'when the build has already retained a resource' do
      let!(:another_resource) { create(:ci_resource, resource_group: resource_group, processable: build) }

      it 'fails to retain resource' do
        expect { subject }.to raise_error(ActiveRecord::RecordNotUnique)
      end
    end
  end

  describe '#release_resource_from' do
    include Ci::PartitioningHelpers

    before do
      stub_current_partition_id(ci_testing_partition_id)
    end

    subject { resource_group.release_resource_from(build) }

    let(:build) { create(:ci_build) }
    let(:resource_group) { create(:ci_resource_group) }

    context 'when the build has already retained a resource' do
      before do
        resource_group.assign_resource_to(build)
      end

      it 'releases resource from the build' do
        expect(resource_group.resources.first.processable).to eq(build)
        expect(resource_group.resources.first.partition_id).to eq(build.partition_id)

        is_expected.to eq(true)

        expect(resource_group.resources.first.processable).to be_nil
        expect(resource_group.resources.first.partition_id).to be_nil
      end
    end

    context 'when the build has already released a resource' do
      it 'fails to release resource' do
        is_expected.to eq(false)
      end
    end
  end

  describe 'processables scope' do
    let_it_be(:project) { create(:project, :repository, group: group) }
    let_it_be(:pipeline_1) { create(:ci_pipeline, project: project) }
    let_it_be(:pipeline_2) { create(:ci_pipeline, project: project) }

    let!(:resource_group) { create(:ci_resource_group, process_mode: process_mode, project: project) }

    Ci::HasStatus::STATUSES_ENUM.each_key do |status| # rubocop:disable RSpec/UselessDynamicDefinition -- `status` used in `let`
      let!("build_1_#{status}") { create(:ci_build, pipeline: pipeline_1, status: status, resource_group: resource_group) }
      let!("build_2_#{status}") { create(:ci_build, pipeline: pipeline_2, status: status, resource_group: resource_group) }
    end

    describe '#upcoming_processables' do
      subject { resource_group.upcoming_processables }

      context 'when process mode is unordered' do
        let(:process_mode) { :unordered }

        it 'returns correct jobs in an indeterministic order' do
          expect(subject).to contain_exactly(build_1_waiting_for_resource, build_2_waiting_for_resource)
        end
      end

      context 'when process mode is oldest_first' do
        let(:process_mode) { :oldest_first }

        it 'returns correct jobs in a specific order' do
          expect(subject[0]).to eq(build_1_waiting_for_resource)
          expect(subject[1..2]).to contain_exactly(build_1_created, build_1_scheduled)
          expect(subject[3]).to eq(build_2_waiting_for_resource)
          expect(subject[4..5]).to contain_exactly(build_2_created, build_2_scheduled)
        end
      end

      context 'when process mode is newest_first' do
        let(:process_mode) { :newest_first }

        it 'returns correct jobs in a specific order' do
          expect(subject[0]).to eq(build_2_waiting_for_resource)
          expect(subject[1..2]).to contain_exactly(build_2_created, build_2_scheduled)
          expect(subject[3]).to eq(build_1_waiting_for_resource)
          expect(subject[4..5]).to contain_exactly(build_1_created, build_1_scheduled)
        end
      end

      context 'when process mode is unknown' do
        let(:process_mode) { :unordered }

        before do
          resource_group.update_column(:process_mode, 3)
        end

        it 'returns empty' do
          is_expected.to be_empty
        end
      end
    end

    describe '#waiting_processables' do
      subject { resource_group.waiting_processables }

      where(:mode) { [:unordered, :oldest_first, :newest_first] }

      with_them do
        let(:process_mode) { mode }

        it 'returns waiting_for_resource jobs in an indeterministic order' do
          expect(subject).to contain_exactly(build_1_waiting_for_resource, build_2_waiting_for_resource)
        end
      end
    end
  end

  describe '#current_processable' do
    subject { resource_group.current_processable }

    let(:build) { create(:ci_build) }
    let(:resource_group) { create(:ci_resource_group) }

    context 'when resource is retained by a build' do
      before do
        resource_group.assign_resource_to(build)
      end

      it { is_expected.to eq(build) }
    end

    context 'when resource is not retained by a build' do
      it { is_expected.to be_nil }
    end
  end
end