1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Approvable do
let(:merge_request) { create(:merge_request) }
let(:user) { create(:user) }
describe '#approved_by?' do
subject { merge_request.approved_by?(user) }
context 'when a user has not approved' do
it 'returns false' do
is_expected.to be_falsy
end
end
context 'when a user has approved' do
let!(:approval) { create(:approval, merge_request: merge_request, user: user) }
it 'returns false' do
is_expected.to be_truthy
end
end
context 'when a user is nil' do
let(:user) { nil }
it 'returns false' do
is_expected.to be_falsy
end
end
end
describe '#approved?' do
context 'when a merge request is approved' do
before do
create(:approval, merge_request: merge_request, user: user)
end
it 'returns true' do
expect(merge_request.approved?).to eq(true)
end
end
context 'when a merge request is not approved' do
it 'returns false' do
expect(merge_request.approved?).to eq(false)
end
end
end
describe '#eligible_for_approval_by?' do
subject { merge_request.eligible_for_approval_by?(user) }
before do
merge_request.project.add_developer(user) if user
end
it 'returns true' do
is_expected.to eq(true)
end
context 'when a user has approved' do
let!(:approval) { create(:approval, merge_request: merge_request, user: user) }
it 'returns false' do
is_expected.to eq(false)
end
end
context 'when a user is nil' do
let(:user) { nil }
it 'returns false' do
is_expected.to eq(false)
end
end
end
describe '#eligible_for_unapproval_by?' do
subject { merge_request.eligible_for_unapproval_by?(user) }
before do
merge_request.project.add_developer(user) if user
end
it 'returns false' do
is_expected.to be_falsy
end
context 'when a user has approved' do
let!(:approval) { create(:approval, merge_request: merge_request, user: user) }
it 'returns true' do
is_expected.to be_truthy
end
end
context 'when a user is nil' do
let(:user) { nil }
it 'returns false' do
is_expected.to be_falsy
end
end
end
describe '.not_approved_by_users_with_usernames' do
subject { MergeRequest.not_approved_by_users_with_usernames([user.username, user2.username]) }
let!(:merge_request2) { create(:merge_request) }
let!(:merge_request3) { create(:merge_request) }
let!(:merge_request4) { create(:merge_request) }
let(:user2) { create(:user) }
let(:user3) { create(:user) }
before do
create(:approval, merge_request: merge_request, user: user)
create(:approval, merge_request: merge_request2, user: user2)
create(:approval, merge_request: merge_request2, user: user3)
create(:approval, merge_request: merge_request4, user: user3)
end
it 'has the merge request that is not approved at all and not approved by either user' do
expect(subject).to contain_exactly(merge_request3, merge_request4)
end
end
end
|
