1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe ContainerRegistry::Event, feature_category: :container_registry do
using RSpec::Parameterized::TableSyntax
let_it_be(:group) { create(:group, name: 'group') }
let_it_be(:project) { create(:project, path: 'test', namespace: group) }
describe '#supported?' do
let(:raw_event) { { 'action' => action } }
subject { described_class.new(raw_event).supported? }
where(:action, :supported) do
'delete' | true
'push' | true
'mount' | false
'pull' | false
end
with_them do
it { is_expected.to eq supported }
end
end
describe '#handle!' do
let(:action) { 'push' }
let(:repository) { project.full_path }
let(:target) do
{
'mediaType' => ContainerRegistry::Client::DOCKER_DISTRIBUTION_MANIFEST_V2_TYPE,
'tag' => 'latest',
'repository' => repository
}
end
let(:raw_event) { { 'action' => action, 'target' => target } }
subject(:handle!) { described_class.new(raw_event).handle! }
shared_examples 'event with project statistics update' do
it 'enqueues a project statistics update' do
expect(ProjectCacheWorker).to receive(:perform_async).with(project.id, [], [:container_registry_size])
handle!
end
it 'clears the cache for the namespace container repositories size' do
expect(Rails.cache).to receive(:delete).with(group.container_repositories_size_cache_key)
handle!
end
end
shared_examples 'event without project statistics update' do
it 'does not queue a project statistics update' do
expect(ProjectCacheWorker).not_to receive(:perform_async)
handle!
end
end
it_behaves_like 'event with project statistics update'
context 'with no target tag' do
let(:target) { super().without('tag') }
it_behaves_like 'event without project statistics update'
context 'with a target digest' do
let(:target) { super().merge('digest' => 'abc123') }
it_behaves_like 'event without project statistics update'
end
context 'with a delete action' do
let(:action) { 'delete' }
context 'without a target digest' do
it_behaves_like 'event without project statistics update'
end
context 'with a target digest' do
let(:target) { super().merge('digest' => 'abc123') }
it_behaves_like 'event with project statistics update'
end
end
end
context 'with an unsupported action' do
let(:action) { 'pull' }
it_behaves_like 'event without project statistics update'
end
context 'with an invalid project repository path' do
let(:repository) { 'does/not/exist' }
it_behaves_like 'event without project statistics update'
end
context 'with no project repository path' do
let(:repository) { nil }
it_behaves_like 'event without project statistics update'
end
end
describe '#track!' do
let_it_be(:container_repository) { create(:container_repository, name: 'container', project: project) }
let_it_be(:rsa_key) { OpenSSL::PKey::RSA.generate(3072) }
let(:raw_event) { { 'action' => action, 'target' => target } }
let(:key_file) { Tempfile.new('keypath') }
before do
allow(Gitlab.config.registry).to receive_messages(enabled: true, issuer: 'rspec', key: key_file.path)
allow(OpenSSL::PKey::RSA).to receive(:new).and_return(rsa_key)
allow_next_instance_of(JSONWebToken::RSAToken) do |instance|
allow(instance).to receive(:key).and_return(rsa_key)
end
end
subject { described_class.new(raw_event).track! }
shared_examples 'tracking event is sent to HLLRedisCounter with event and originator ID' do |originator_type|
it 'sends a tracking event to HLLRedisCounter' do
expect(::Gitlab::UsageDataCounters::HLLRedisCounter)
.to receive(:track_event).with("i_container_registry_#{event}_#{originator_type}", values: originator.id)
.exactly(count).time
subject
end
end
shared_examples 'event originator is fetched based on ID' do |originator_class|
it 'fetches the event originator based on id' do
count.times do
expect(originator_class).to receive(:find).with(originator.id)
end
subject
end
end
context 'with a respository target' do
let(:target) do
{
'mediaType' => ContainerRegistry::Client::DOCKER_DISTRIBUTION_MANIFEST_V2_TYPE,
'repository' => repository_path
}
end
where(:repository_path, :action, :tracking_action) do
'group/test/container' | 'push' | 'push_repository'
'group/test/container' | 'delete' | 'delete_repository'
'foo/bar' | 'push' | 'create_repository'
'foo/bar' | 'delete' | 'delete_repository'
end
with_them do
it 'creates a tracking event' do
expect(::Gitlab::Tracking).to receive(:event).with('container_registry:notification', tracking_action)
subject
end
end
end
context 'with a tag target' do
let(:target) do
{
'mediaType' => ContainerRegistry::Client::DOCKER_DISTRIBUTION_MANIFEST_V2_TYPE,
'repository' => repository_path,
'tag' => 'latest'
}
end
where(:repository_path, :action, :tracking_action) do
'group/test/container' | 'push' | 'push_tag'
'group/test/container' | 'delete' | 'delete_tag'
'foo/bar' | 'push' | 'push_tag'
'foo/bar' | 'delete' | 'delete_tag'
end
with_them do
it 'creates a tracking event' do
expect(::Gitlab::Tracking).to receive(:event).with('container_registry:notification', tracking_action)
subject
end
end
end
context 'with a deploy token as the actor' do
let!(:originator) { create(:deploy_token, username: 'username', id: 3) }
shared_examples 'no tracking of a deploy token is sent to HLLRedisCounter' do
it 'does not send a tracking event to HLLRedisCounter' do
expect(DeployToken).not_to receive(:find)
expect(DeployToken).not_to receive(:find_by_username)
expect(::Gitlab::UsageDataCounters::HLLRedisCounter).not_to receive(:track_event)
expect { subject }.not_to raise_error
end
end
context 'when only username is provided and no deploy_token_id is given' do
let(:raw_event) do
{
'action' => 'push',
'target' => { 'tag' => 'latest' },
'actor' => { 'user_type' => 'deploy_token', 'name' => originator.username }
}
end
it_behaves_like 'no tracking of a deploy token is sent to HLLRedisCounter'
end
context 'when no username or deploy_token_id is given' do
let(:raw_event) { { 'action' => 'push', 'target' => {}, 'actor' => { 'user_type' => 'deploy_token' } } }
it_behaves_like 'no tracking of a deploy token is sent to HLLRedisCounter'
end
context 'when deploy_token_id is given' do
let(:deploy_token_info) do
{
token_type: 'deploy_token',
username: originator.username,
deploy_token_id: originator.id
}
end
let(:token) do
JSONWebToken::RSAToken.new(rsa_key).tap do |token|
token[:user_info] = deploy_token_info
end
end
let(:raw_event) do
{
'action' => action,
'target' => target,
'actor' => { 'user_type' => 'deploy_token', 'name' => originator.username, 'user' => token.encoded }
}
end
where(:target, :action, :event, :count) do
{ 'tag' => 'latest' } | 'push' | 'push_tag' | 1
{ 'tag' => 'latest' } | 'delete' | 'delete_tag' | 1
{ 'repository' => 'foo/bar' } | 'push' | 'create_repository' | 1
{ 'repository' => 'foo/bar' } | 'delete' | 'delete_repository' | 1
{ 'tag' => 'latest' } | 'copy' | '' | 0
end
with_them do
it_behaves_like 'event originator is fetched based on ID', DeployToken
it_behaves_like 'tracking event is sent to HLLRedisCounter with event and originator ID', :deploy_token
end
context "when there are errors" do
let(:action) { 'push' }
let(:target) { { 'tag' => 'latest' } }
context 'when the registry key file does not exist' do
before do
allow(File).to receive(:read).and_call_original
allow(File).to receive(:read).with(key_file.path).and_raise(Errno::ENOENT)
end
it_behaves_like 'no tracking of a deploy token is sent to HLLRedisCounter'
end
[JWT::VerificationError, JWT::DecodeError, JWT::ExpiredSignature, JWT::ImmatureSignature].each do |error|
context "when JWT decoding encounters #{error}" do
before do
allow(JWT).to receive(:decode)
.with(token.encoded, rsa_key, true, { algorithm: "RS256" })
.and_raise(error)
end
it_behaves_like 'no tracking of a deploy token is sent to HLLRedisCounter'
end
end
end
end
end
context 'with a user as the actor' do
let_it_be(:originator) { create(:user, username: 'username') }
context 'when user_id is available' do
let(:user_info) do
{
token_type: user_type,
username: originator.username,
user_id: originator.id
}
end
let(:token) do
JSONWebToken::RSAToken.new(rsa_key).tap do |token|
token[:user_info] = user_info
end
end
let(:raw_event) do
{
'action' => action,
'target' => target,
'actor' => { 'user_type' => user_type, 'name' => originator.username, 'user' => token.encoded }
}
end
where(:target, :action, :event, :user_type, :count) do
{ 'tag' => 'latest' } | 'push' | 'push_tag' | 'personal_access_token' | 1
{ 'tag' => 'latest' } | 'delete' | 'delete_tag' | 'personal_access_token' | 1
{ 'repository' => 'foo/bar' } | 'push' | 'create_repository' | 'build' | 1
{ 'repository' => 'foo/bar' } | 'delete' | 'delete_repository' | 'gitlab_or_ldap' | 1
{ 'repository' => 'foo/bar' } | 'delete' | 'delete_repository' | 'not_a_user' | 0
{ 'tag' => 'latest' } | 'copy' | '' | nil | 0
{ 'repository' => 'foo/bar' } | 'copy' | '' | '' | 0
end
with_them do
it_behaves_like 'event originator is fetched based on ID', User
it_behaves_like 'tracking event is sent to HLLRedisCounter with event and originator ID', :user
end
end
context 'when only username is available and user_id is not' do
let(:raw_event) do
{
'action' => 'push',
'target' => { 'tag' => 'latest' },
'actor' => { 'user_type' => 'personal_access_token', 'name' => originator.username }
}
end
it 'does not send a tracking event to HLLRedisCounter' do
expect(::Gitlab::UsageDataCounters::HLLRedisCounter).not_to receive(:track_event)
subject
end
end
context 'when no username or id is given' do
let(:raw_event) { { 'action' => 'push', 'target' => {}, 'actor' => { 'user_type' => 'build' } } }
it 'does not send a tracking event to HLLRedisCounter' do
expect(::Gitlab::UsageDataCounters::HLLRedisCounter).not_to receive(:track_event)
subject
end
end
end
context 'when it is a manifest delete event' do
let(:raw_event) { { 'action' => 'delete', 'target' => { 'digest' => 'x' }, 'actor' => {} } }
it 'calls the ContainerRegistryEventCounter' do
expect(::Gitlab::UsageDataCounters::ContainerRegistryEventCounter)
.to receive(:count).with('i_container_registry_delete_manifest')
subject
end
end
context 'when it is not a manifest delete event' do
let(:raw_event) { { 'action' => 'push', 'target' => { 'digest' => 'x' }, 'actor' => {} } }
it 'does not call the ContainerRegistryEventCounter' do
expect(::Gitlab::UsageDataCounters::ContainerRegistryEventCounter)
.not_to receive(:count).with('i_container_registry_delete_manifest')
subject
end
end
end
end
|