1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Integrations::DroneCi, :use_clean_rails_memory_store_caching, feature_category: :integrations do
include ReactiveCachingHelpers
subject(:integration) { described_class.new }
let_it_be(:project) { create(:project, :repository, name: 'project') }
it_behaves_like Integrations::BaseCi
it_behaves_like Integrations::ResetSecretFields do
let(:integration) { subject }
end
it_behaves_like Integrations::HasAvatar
describe 'validations' do
context 'active' do
before do
subject.active = true
end
it { is_expected.to validate_presence_of(:token) }
it { is_expected.to validate_presence_of(:drone_url) }
it_behaves_like 'issue tracker integration URL attribute', :drone_url
end
context 'inactive' do
before do
subject.active = false
end
it { is_expected.not_to validate_presence_of(:token) }
it { is_expected.not_to validate_presence_of(:drone_url) }
end
end
shared_context 'drone ci integration' do
subject(:drone) do
described_class.new(
project: project,
active: true,
drone_url: drone_url,
token: token
)
end
let(:path) { project.full_path }
let(:drone_url) { 'http://drone.example.com' }
let(:sha) { '2ab7834c' }
let(:branch) { 'dev' }
let(:token) { 'secret' }
let(:iid) { rand(1..9999) }
# URLs
let(:build_page) { "#{drone_url}/gitlab/#{path}/redirect/commits/#{sha}?branch=#{branch}" }
let(:commit_status_path) { "#{drone_url}/gitlab/#{path}/commits/#{sha}?branch=#{branch}&access_token=#{token}" }
def stub_request(status: 200, body: nil)
body ||= %q({"status":"success"})
WebMock.stub_request(:get, commit_status_path).to_return(
status: status,
headers: { 'Content-Type' => 'application/json' },
body: body
)
end
end
include_context Integrations::EnableSslVerification do
describe '#enable_ssl_verification' do
before do
allow(integration).to receive(:new_record?).and_return(false)
end
it 'returns true for a known hostname' do
integration.drone_url = 'https://cloud.drone.io'
expect(integration.enable_ssl_verification).to be(true)
end
it 'returns true for new records' do
allow(integration).to receive(:new_record?).and_return(true)
integration.drone_url = 'http://example.com'
expect(integration.enable_ssl_verification).to be(true)
end
it 'returns false for an unknown hostname' do
integration.drone_url = 'https://example.com'
expect(integration.enable_ssl_verification).to be(false)
end
it 'returns false for a HTTP URL' do
integration.drone_url = 'http://cloud.drone.io'
expect(integration.enable_ssl_verification).to be(false)
end
it 'returns false for an invalid URL' do
integration.drone_url = 'https://example.com:foo'
expect(integration.enable_ssl_verification).to be(false)
end
it 'returns the persisted value if present' do
integration.drone_url = 'https://cloud.drone.io'
integration.enable_ssl_verification = false
expect(integration.enable_ssl_verification).to be(false)
end
end
end
describe '#attribution_notice' do
it do
expect(subject.attribution_notice)
.to eq('Drone CI icon and logo by Harness Inc. are licensed under CC NC-ND 4.0.')
end
end
it_behaves_like Integrations::HasWebHook do
include_context 'drone ci integration'
let(:integration) { drone }
let(:hook_url) { "#{drone_url}/hook?owner=#{project.namespace.full_path}&name=#{project.path}&access_token={token}" }
it 'does not create a hook if project is not present' do
integration.project = nil
integration.instance = true
expect { integration.save! }.not_to change(ServiceHook, :count)
end
end
describe "integration page/path methods" do
include_context 'drone ci integration'
it { expect(drone.build_page(sha, branch)).to eq(build_page) }
it { expect(drone.commit_status_path(sha, branch)).to eq(commit_status_path) }
end
describe '#commit_status' do
include_context 'drone ci integration'
it 'returns the contents of the reactive cache' do
stub_reactive_cache(drone, { commit_status: 'foo' }, 'sha', 'ref')
expect(drone.commit_status('sha', 'ref')).to eq('foo')
end
end
describe '#calculate_reactive_cache' do
include_context 'drone ci integration'
describe '#commit_status' do
subject { drone.calculate_reactive_cache(sha, branch)[:commit_status] }
it 'sets commit status to :error when status is 500' do
stub_request(status: 500)
is_expected.to eq(:error)
end
it 'sets commit status to :error when status is 404' do
stub_request(status: 404)
is_expected.to eq(:error)
end
Gitlab::HTTP::HTTP_ERRORS.each do |http_error|
it "sets commit status to :error with a #{http_error.name} error" do
WebMock.stub_request(:get, commit_status_path)
.to_raise(http_error)
expect(Gitlab::ErrorTracking)
.to receive(:log_exception)
.with(instance_of(http_error), { project_id: project.id })
is_expected.to eq(:error)
end
end
{
"killed" => :canceled,
"failure" => :failed,
"error" => :failed,
"success" => "success"
}.each do |drone_status, our_status|
it "sets commit status to #{our_status.inspect} when returned status is #{drone_status.inspect}" do
stub_request(body: %({"status":"#{drone_status}"}))
is_expected.to eq(our_status)
end
end
end
end
describe "execute" do
include_context 'drone ci integration'
let(:user) { build(:user, username: 'username') }
let(:push_sample_data) do
Gitlab::DataBuilder::Push.build_sample(project, user)
end
it 'executes the webhook' do
expect(drone).to receive(:execute_web_hook!).with(push_sample_data)
drone.execute(push_sample_data)
end
it 'does not try to execute the webhook if the integration is not in a project' do
drone.project = nil
drone.instance = true
expect(drone).not_to receive(:execute_web_hook!)
drone.execute(push_sample_data)
end
end
end
|