1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584 2585 2586 2587 2588 2589 2590 2591 2592 2593 2594 2595 2596 2597 2598 2599 2600 2601 2602 2603 2604 2605 2606 2607 2608 2609 2610 2611 2612 2613 2614 2615 2616 2617 2618 2619 2620 2621 2622 2623 2624 2625 2626 2627 2628 2629 2630 2631 2632 2633 2634 2635 2636 2637 2638
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Issue, feature_category: :team_planning do
include ExternalAuthorizationServiceHelpers
using RSpec::Parameterized::TableSyntax
let_it_be(:user) { create(:user) }
let_it_be_with_reload(:reusable_project) { create(:project) }
describe "Associations" do
it { is_expected.to belong_to(:milestone) }
it { is_expected.to belong_to(:project) }
it { is_expected.to belong_to(:work_item_type).class_name('WorkItems::Type') }
it { is_expected.to belong_to(:moved_to).class_name('Issue') }
it { is_expected.to have_one(:moved_from).class_name('Issue') }
it { is_expected.to belong_to(:duplicated_to).class_name('Issue') }
it { is_expected.to belong_to(:closed_by).class_name('User') }
it { is_expected.to have_many(:assignees) }
it { is_expected.to have_many(:user_mentions).class_name("IssueUserMention") }
it { is_expected.to have_many(:designs) }
it { is_expected.to have_many(:design_versions) }
it { is_expected.to have_one(:sentry_issue) }
it { is_expected.to have_one(:alert_management_alert) }
it { is_expected.to have_many(:alert_management_alerts).validate(false) }
it { is_expected.to have_many(:resource_milestone_events) }
it { is_expected.to have_many(:resource_state_events) }
it { is_expected.to have_many(:issue_email_participants) }
it { is_expected.to have_one(:email) }
it { is_expected.to have_many(:timelogs).autosave(true) }
it { is_expected.to have_one(:incident_management_issuable_escalation_status) }
it { is_expected.to have_many(:issue_customer_relations_contacts) }
it { is_expected.to have_many(:customer_relations_contacts) }
it { is_expected.to have_many(:incident_management_timeline_events) }
it { is_expected.to have_many(:assignment_events).class_name('ResourceEvents::IssueAssignmentEvent').inverse_of(:issue) }
describe '#assignees_by_name_and_id' do
it 'returns users ordered by name ASC, id DESC' do
user1 = create(:user, name: 'BBB')
user2 = create(:user, name: 'AAA')
user3 = create(:user, name: 'BBB')
users = [user1, user2, user3]
issue = create(:issue, project: reusable_project, assignees: users)
expect(issue.assignees_by_name_and_id).to match([user2, user3, user1])
end
end
describe 'versions.most_recent' do
it 'returns the most recent version' do
issue = create(:issue, project: reusable_project)
create_list(:design_version, 2, issue: issue)
last_version = create(:design_version, issue: issue)
expect(issue.design_versions.most_recent).to eq(last_version)
end
end
end
describe 'modules' do
subject { described_class }
it { is_expected.to include_module(Issuable) }
it { is_expected.to include_module(Referable) }
it { is_expected.to include_module(Sortable) }
it { is_expected.to include_module(Taskable) }
it { is_expected.to include_module(MilestoneEventable) }
it { is_expected.to include_module(StateEventable) }
it_behaves_like 'AtomicInternalId' do
let(:internal_id_attribute) { :iid }
let(:instance) { build(:issue) }
let(:scope) { :namespace }
let(:scope_attrs) { { namespace: instance.project.project_namespace } }
let(:usage) { :issues }
end
end
describe 'custom validations' do
subject(:valid?) { issue.valid? }
describe 'due_date_after_start_date' do
let(:today) { Date.today }
context 'when both values are not present' do
let(:issue) { build(:issue) }
it { is_expected.to be_truthy }
end
context 'when start date is present and due date is not' do
let(:issue) { build(:work_item, start_date: today) }
it { is_expected.to be_truthy }
end
context 'when due date is present and start date is not' do
let(:issue) { build(:work_item, due_date: today) }
it { is_expected.to be_truthy }
end
context 'when both date values are present' do
context 'when due date is greater than start date' do
let(:issue) { build(:work_item, start_date: today, due_date: 1.week.from_now) }
it { is_expected.to be_truthy }
end
context 'when due date is equal to start date' do
let(:issue) { build(:work_item, start_date: today, due_date: today) }
it { is_expected.to be_truthy }
end
context 'when due date is before start date' do
let(:issue) { build(:work_item, due_date: today, start_date: 1.week.from_now) }
it { is_expected.to be_falsey }
it 'adds an error message' do
valid?
expect(issue.errors.full_messages).to contain_exactly(
'Due date must be greater than or equal to start date'
)
end
end
end
end
describe '#allowed_work_item_type_change' do
where(:old_type, :new_type, :is_valid) do
:issue | :incident | true
:incident | :issue | true
:test_case | :issue | true
:issue | :test_case | true
:issue | :task | false
:test_case | :task | false
:incident | :task | false
:task | :issue | false
:task | :incident | false
:task | :test_case | false
end
with_them do
it 'is possible to change type only between selected types' do
issue = create(:issue, old_type, project: reusable_project)
issue.assign_attributes(work_item_type: WorkItems::Type.default_by_type(new_type))
expect(issue.valid?).to eq(is_valid)
end
end
end
describe 'confidentiality' do
let_it_be(:project) { create(:project) }
context 'when parent and child are confidential' do
let_it_be(:parent) { create(:work_item, confidential: true, project: project) }
let_it_be(:child) { create(:work_item, :task, confidential: true, project: project) }
let_it_be(:link) { create(:parent_link, work_item: child, work_item_parent: parent) }
it 'does not allow to make child not-confidential' do
issue = described_class.find(child.id)
issue.confidential = false
expect(issue).not_to be_valid
expect(issue.errors[:base])
.to include(_('A non-confidential issue cannot have a confidential parent.'))
end
it 'allows to make parent not-confidential' do
issue = described_class.find(parent.id)
issue.confidential = false
expect(issue).to be_valid
end
end
context 'when parent and child are not-confidential' do
let_it_be(:parent) { create(:work_item, project: project) }
let_it_be(:child) { create(:work_item, :task, project: project) }
let_it_be(:link) { create(:parent_link, work_item: child, work_item_parent: parent) }
it 'does not allow to make parent confidential' do
issue = described_class.find(parent.id)
issue.confidential = true
expect(issue).not_to be_valid
expect(issue.errors[:base])
.to include(_('A confidential issue must have only confidential children. Make any child items confidential and try again.'))
end
it 'allows to make child confidential' do
issue = described_class.find(child.id)
issue.confidential = true
expect(issue).to be_valid
end
end
end
end
subject { create(:issue, project: reusable_project) }
describe 'callbacks' do
describe '#ensure_metrics!' do
it 'creates metrics after saving' do
expect(subject.metrics).to be_persisted
expect(Issue::Metrics.count).to eq(1)
end
it 'does not create duplicate metrics for an issue' do
subject.close!
expect(subject.metrics).to be_persisted
expect(Issue::Metrics.count).to eq(1)
end
it 'records current metrics' do
expect(Issue::Metrics).to receive(:record!)
create(:issue, project: reusable_project)
end
context 'when metrics record is missing' do
before do
subject.metrics.delete
subject.reload
end
it 'creates the metrics record' do
subject.update!(title: 'title')
expect(subject.metrics).to be_present
end
end
end
describe '#ensure_work_item_type' do
let_it_be(:issue_type) { create(:work_item_type, :issue) }
let_it_be(:incident_type) { create(:work_item_type, :incident) }
let_it_be(:project) { create(:project) }
context 'when a type was already set' do
let_it_be(:issue, refind: true) { create(:issue, project: project) }
it 'does not fetch a work item type from the DB' do
expect(issue.work_item_type_id).to eq(issue_type.id)
expect(WorkItems::Type).not_to receive(:default_by_type)
expect(issue).to be_valid
end
it 'does not fetch a work item type from the DB when updating the type' do
expect(issue.work_item_type_id).to eq(issue_type.id)
expect(WorkItems::Type).not_to receive(:default_by_type)
issue.update!(work_item_type: incident_type)
expect(issue.work_item_type_id).to eq(incident_type.id)
end
it 'ensures a work item type if updated to nil' do
expect(issue.work_item_type_id).to eq(issue_type.id)
expect do
issue.update!(work_item_type: nil)
end.to not_change(issue, :work_item_type).from(issue_type)
end
end
context 'when no type was set' do
let(:issue) { build(:issue, project: project, work_item_type: nil) }
it 'sets a work item type before validation' do
expect(issue.work_item_type_id).to be_nil
issue.save!
expect(issue.work_item_type_id).to eq(issue_type.id)
end
it 'does not fetch type from DB if provided during update' do
expect(issue.work_item_type_id).to be_nil
expect(WorkItems::Type).not_to receive(:default_by_type)
issue.update!(work_item_type: incident_type)
expect(issue.work_item_type_id).to eq(incident_type.id)
end
end
end
describe '#record_create_action' do
it 'records the creation action after saving' do
expect(Gitlab::UsageDataCounters::IssueActivityUniqueCounter).to receive(:track_issue_created_action)
create(:issue)
end
it_behaves_like 'internal event tracking' do
let(:project) { reusable_project }
let(:event) { Gitlab::UsageDataCounters::IssueActivityUniqueCounter::ISSUE_CREATED }
subject { create(:issue, project: reusable_project, author: user) }
end
end
context 'issue namespace' do
let(:issue) { build(:issue, project: reusable_project) }
it 'sets the namespace_id' do
expect(issue).to be_valid
expect(issue.namespace).to eq(reusable_project.project_namespace)
end
context 'when issue is created' do
it 'sets the namespace_id' do
issue.save!
expect(issue.reload.namespace).to eq(reusable_project.project_namespace)
end
end
context 'when existing issue is saved' do
let(:issue) { create(:issue) }
before do
issue.update!(namespace_id: nil)
end
it 'sets the namespace id' do
issue.update!(title: "#{issue.title} and something extra")
expect(issue.namespace).to eq(issue.project.project_namespace)
end
end
end
end
describe 'scopes for preloading' do
before_all do
create(:issue, project: reusable_project)
end
describe '.preload_namespace' do
subject(:preload_namespace) { described_class.in_projects(reusable_project).preload_namespace }
it { expect(preload_namespace.first.association(:namespace)).to be_loaded }
end
describe '.preload_routables' do
subject(:preload_routables) { described_class.in_projects(reusable_project).preload_routables }
it { expect(preload_routables.first.association(:project)).to be_loaded }
it { expect(preload_routables.first.project.association(:route)).to be_loaded }
it { expect(preload_routables.first.project.association(:namespace)).to be_loaded }
it { expect(preload_routables.first.project.namespace.association(:route)).to be_loaded }
end
end
describe '.in_namespaces_with_cte' do
let_it_be(:issue) { create(:issue, project: reusable_project) }
let_it_be(:other_project) { create(:project) }
let_it_be(:other_issue) { create(:issue, project: other_project) }
subject(:in_namespaces_with_cte) { described_class.in_namespaces_with_cte(Namespace.where(id: issue.namespace_id)) }
it 'returns issues from a given namespace' do
expect(in_namespaces_with_cte).to match_array(issue)
end
it 'can be used with other scopes' do
expect(in_namespaces_with_cte.with_work_item_type).to match_array(issue)
end
end
context 'order by upvotes' do
let!(:issue) { create(:issue) }
let!(:issue2) { create(:issue) }
let!(:award_emoji) { create(:award_emoji, :upvote, awardable: issue2) }
describe '.order_upvotes_desc' do
it 'orders on upvotes' do
expect(described_class.order_upvotes_desc.to_a).to eq [issue2, issue]
end
end
describe '.order_upvotes_asc' do
it 'orders on upvotes' do
expect(described_class.order_upvotes_asc.to_a).to eq [issue, issue2]
end
end
end
describe '.with_alert_management_alerts' do
subject { described_class.with_alert_management_alerts }
it 'gets only issues with alerts' do
alert = create(:alert_management_alert, project: reusable_project, issue: create(:issue, project: reusable_project))
issue = create(:issue, project: reusable_project)
expect(subject).to contain_exactly(alert.issue)
expect(subject).not_to include(issue)
end
end
describe '.due_before' do
subject { described_class.due_before(Date.today) }
let!(:issue) { create(:issue, due_date: 1.day.ago) }
let!(:issue2) { create(:issue, due_date: 1.day.from_now) }
it 'returns issues which are over due' do
expect(subject).to contain_exactly(issue)
expect(subject).not_to include(issue2)
end
end
describe '.due_after' do
subject { described_class.due_after(Date.today) }
let!(:issue) { create(:issue, due_date: 1.day.ago) }
let!(:issue2) { create(:issue, due_date: 1.day.from_now) }
it 'returns issues which are due in the future' do
expect(subject).to contain_exactly(issue2)
expect(subject).not_to include(issue)
end
end
describe '.simple_sorts' do
it 'includes all keys' do
expect(described_class.simple_sorts.keys).to include(
*%w[created_asc created_at_asc created_date created_desc created_at_desc
closest_future_date closest_future_date_asc due_date due_date_asc due_date_desc
id_asc id_desc relative_position relative_position_asc updated_desc updated_asc
updated_at_asc updated_at_desc title_asc title_desc])
end
end
describe '.in_namespaces' do
let(:group) { create(:group) }
let!(:group_work_item) { create(:issue, :group_level, namespace: group) }
let!(:project_work_item) { create(:issue, project: reusable_project) }
subject { described_class.in_namespaces(group) }
it { is_expected.to contain_exactly(group_work_item) }
end
describe '.with_issue_type' do
let_it_be(:issue) { create(:issue, project: reusable_project) }
let_it_be(:incident) { create(:incident, project: reusable_project) }
it 'returns issues with the given issue type' do
expect(described_class.with_issue_type('issue'))
.to contain_exactly(issue)
end
context 'when multiple issue_types are provided' do
it 'returns issues with the given issue types' do
expect(described_class.with_issue_type(%w[issue incident]))
.to contain_exactly(issue, incident)
end
it 'joins the work_item_types table for filtering with issues.correct_work_item_type_id column' do
expect do
described_class.with_issue_type([:issue, :incident]).to_a
end.to make_queries_matching(
%r{
INNER\sJOIN\s"work_item_types"\sON\s"work_item_types"\."correct_id"\s=\s"issues"\."correct_work_item_type_id"
\sWHERE\s"work_item_types"\."base_type"\sIN\s\(0,\s1\)
}x
)
end
context 'when issues_use_correct_work_item_type_id FF is disabled' do
before do
stub_feature_flags(issues_use_correct_work_item_type_id: false)
end
it 'joins the work_item_types table for filtering with issues.work_item_type_id column' do
expect do
described_class.with_issue_type([:issue, :incident]).to_a
end.to make_queries_matching(
%r{
INNER\sJOIN\s"work_item_types"\sON\s"work_item_types"\."id"\s=\s"issues"\."work_item_type_id"
\sWHERE\s"work_item_types"\."base_type"\sIN\s\(0,\s1\)
}x
)
end
end
end
context 'when a single issue_type is provided' do
it 'uses an optimized query for a single work item type using issues.correct_work_item_type_id column' do
expect do
described_class.with_issue_type([:incident]).to_a
end.to make_queries_matching(
%r{
WHERE\s\("issues"\."correct_work_item_type_id"\s=
\s\(SELECT\s"work_item_types"\."correct_id"\sFROM\s"work_item_types"
\sWHERE\s"work_item_types"\."base_type"\s=\s1
\sLIMIT\s1\)\)
}x
)
end
context 'when issues_use_correct_work_item_type_id FF is disabled' do
before do
stub_feature_flags(issues_use_correct_work_item_type_id: false)
end
it 'uses an optimized query for a single work item type using issues.work_item_type_id column' do
expect do
described_class.with_issue_type([:incident]).to_a
end.to make_queries_matching(
%r{
WHERE\s\("issues"\."work_item_type_id"\s=
\s\(SELECT\s"work_item_types"\."id"\sFROM\s"work_item_types"\sWHERE\s"work_item_types"\."base_type"\s=\s1
\sLIMIT\s1\)\)
}x
)
end
end
end
context 'when no types are provided' do
it 'activerecord handles the false condition' do
expect(described_class.with_issue_type([]).to_sql).to include('WHERE 1=0')
end
end
end
describe '.without_issue_type' do
let_it_be(:issue) { create(:issue, project: reusable_project) }
let_it_be(:incident) { create(:incident, project: reusable_project) }
let_it_be(:task) { create(:issue, :task, project: reusable_project) }
it 'returns issues without the given issue type' do
expect(described_class.without_issue_type('issue'))
.to contain_exactly(incident, task)
end
it 'returns issues without the given issue types' do
expect(described_class.without_issue_type(%w[issue incident]))
.to contain_exactly(task)
end
it 'uses the work_item_types table and issues.correct_work_item_type_id for filtering' do
expect do
described_class.without_issue_type(:issue).to_a
end.to make_queries_matching(
%r{
INNER\sJOIN\s"work_item_types"\sON\s"work_item_types"\."correct_id"\s=\s"issues"\."correct_work_item_type_id"
\sWHERE\s"work_item_types"\."base_type"\s!=\s0
}x
)
end
context 'when issues_use_correct_work_item_type_id FF is disabled' do
before do
stub_feature_flags(issues_use_correct_work_item_type_id: false)
end
it 'uses the work_item_types table and issues.work_item_type_id for filtering' do
expect do
described_class.without_issue_type(:issue).to_a
end.to make_queries_matching(
%r{
INNER\sJOIN\s"work_item_types"\sON\s"work_item_types"\."id"\s=\s"issues"\."work_item_type_id"
\sWHERE\s"work_item_types"\."base_type"\s!=\s0
}x
)
end
end
end
describe '.order_severity' do
let_it_be(:issue_high_severity) { create(:issuable_severity, severity: :high).issue }
let_it_be(:issue_low_severity) { create(:issuable_severity, severity: :low).issue }
let_it_be(:issue_no_severity) { create(:incident) }
context 'sorting ascending' do
subject { described_class.order_severity_asc }
it { is_expected.to eq([issue_no_severity, issue_low_severity, issue_high_severity]) }
end
context 'sorting descending' do
subject { described_class.order_severity_desc }
it { is_expected.to eq([issue_high_severity, issue_low_severity, issue_no_severity]) }
end
end
describe '.order_title' do
let_it_be(:issue1) { create(:issue, title: 'foo') }
let_it_be(:issue2) { create(:issue, title: 'bar') }
let_it_be(:issue3) { create(:issue, title: 'baz') }
let_it_be(:issue4) { create(:issue, title: 'Baz 2') }
context 'sorting ascending' do
subject { described_class.order_title_asc }
it { is_expected.to eq([issue2, issue3, issue4, issue1]) }
end
context 'sorting descending' do
subject { described_class.order_title_desc }
it { is_expected.to eq([issue1, issue4, issue3, issue2]) }
end
end
describe '#order_by_relative_position' do
let(:project) { reusable_project }
let!(:issue1) { create(:issue, project: project) }
let!(:issue2) { create(:issue, project: project) }
let!(:issue3) { create(:issue, project: project, relative_position: -200) }
let!(:issue4) { create(:issue, project: project, relative_position: -100) }
it 'returns ordered list' do
expect(project.issues.order_by_relative_position)
.to match [issue3, issue4, issue1, issue2]
end
end
context 'order by escalation status' do
let_it_be(:triggered_incident) { create(:incident_management_issuable_escalation_status, :triggered).issue }
let_it_be(:resolved_incident) { create(:incident_management_issuable_escalation_status, :resolved).issue }
let_it_be(:issue_no_status) { create(:issue) }
describe '.order_escalation_status_asc' do
subject { described_class.order_escalation_status_asc }
it { is_expected.to eq([triggered_incident, resolved_incident, issue_no_status]) }
end
describe '.order_escalation_status_desc' do
subject { described_class.order_escalation_status_desc }
it { is_expected.to eq([resolved_incident, triggered_incident, issue_no_status]) }
end
end
describe '#sort' do
let(:project) { reusable_project }
context "by relative_position" do
let!(:issue) { create(:issue, project: project, relative_position: nil) }
let!(:issue2) { create(:issue, project: project, relative_position: 2) }
let!(:issue3) { create(:issue, project: project, relative_position: 1) }
it "sorts asc with nulls at the end" do
issues = project.issues.sort_by_attribute('relative_position')
expect(issues).to eq([issue3, issue2, issue])
end
end
end
describe '#card_attributes' do
it 'includes the author name' do
allow(subject).to receive(:author).and_return(double(name: 'Robert'))
allow(subject).to receive(:assignees).and_return([])
expect(subject.card_attributes)
.to eq({ 'Author' => 'Robert', 'Assignee' => '' })
end
it 'includes the assignee name' do
allow(subject).to receive(:author).and_return(double(name: 'Robert'))
allow(subject).to receive(:assignees).and_return([double(name: 'Douwe')])
expect(subject.card_attributes)
.to eq({ 'Author' => 'Robert', 'Assignee' => 'Douwe' })
end
end
describe '#close' do
subject(:issue) { create(:issue, project: reusable_project, state: 'opened') }
it 'sets closed_at to Time.current when an issue is closed' do
expect { issue.close }.to change { issue.closed_at }.from(nil)
end
it 'changes the state to closed' do
open_state = described_class.available_states[:opened]
closed_state = described_class.available_states[:closed]
expect { issue.close }.to change { issue.state_id }.from(open_state).to(closed_state)
end
context 'when an argument is provided' do
context 'and the argument is a User' do
it 'changes closed_by to the given user' do
expect { issue.close(user) }.to change { issue.closed_by }.from(nil).to(user)
end
end
context 'and the argument is a not a User' do
it 'does not change closed_by' do
expect { issue.close("test") }.not_to change { issue.closed_by }
end
end
end
context 'when an argument is not provided' do
it 'does not change closed_by' do
expect { issue.close }.not_to change { issue.closed_by }
end
end
end
describe '#reopen' do
let_it_be_with_reload(:issue) { create(:issue, project: reusable_project, state: 'closed', closed_at: Time.current, closed_by: user) }
it 'sets closed_at to nil when an issue is reopened' do
expect { issue.reopen }.to change { issue.closed_at }.to(nil)
end
it 'sets closed_by to nil when an issue is reopened' do
expect { issue.reopen }.to change { issue.closed_by }.from(user).to(nil)
end
it 'clears moved_to_id for moved issues' do
moved_issue = create(:issue)
issue.update!(moved_to_id: moved_issue.id)
expect { issue.reopen }.to change { issue.moved_to_id }.from(moved_issue.id).to(nil)
end
it 'clears duplicated_to_id for duplicated issues' do
duplicate_issue = create(:issue)
issue.update!(duplicated_to_id: duplicate_issue.id)
expect { issue.reopen }.to change { issue.duplicated_to_id }.from(duplicate_issue.id).to(nil)
end
it 'changes the state to opened' do
expect { issue.reopen }.to change { issue.state_id }.from(described_class.available_states[:closed]).to(described_class.available_states[:opened])
end
end
describe '#to_reference' do
let_it_be(:namespace) { create(:namespace) }
let_it_be(:project) { create(:project, namespace: namespace) }
let_it_be(:issue) { create(:issue, project: project) }
context 'when nil argument' do
it 'returns issue id' do
expect(issue.to_reference).to eq "##{issue.iid}"
end
it 'returns complete path to the issue with full: true' do
expect(issue.to_reference(full: true)).to eq "#{project.full_path}##{issue.iid}"
end
end
context 'when argument is a project' do
context 'when same project' do
it 'returns issue id' do
expect(issue.to_reference(project)).to eq("##{issue.iid}")
end
it 'returns full reference with full: true' do
expect(issue.to_reference(project, full: true)).to eq "#{project.full_path}##{issue.iid}"
end
end
context 'when cross-project in same namespace' do
let(:another_project) do
create(:project, namespace: project.namespace)
end
it 'returns a cross-project reference' do
expect(issue.to_reference(another_project)).to eq "#{project.path}##{issue.iid}"
end
end
context 'when cross-project in different namespace' do
let(:another_namespace) { build(:namespace, id: non_existing_record_id, path: 'another-namespace') }
let(:another_namespace_project) { build(:project, namespace: another_namespace) }
it 'returns complete path to the issue' do
expect(issue.to_reference(another_namespace_project)).to eq "#{project.full_path}##{issue.iid}"
end
end
end
context 'when argument is a namespace' do
context 'when same as issue' do
it 'returns path to the issue with the project name' do
expect(issue.to_reference(namespace)).to eq "#{project.path}##{issue.iid}"
end
it 'returns full reference with full: true' do
expect(issue.to_reference(namespace, full: true)).to eq "#{project.full_path}##{issue.iid}"
end
end
context 'when different to issue namespace' do
let(:group) { build(:group, name: 'Group', path: 'sample-group') }
it 'returns full path to the issue with full: true' do
expect(issue.to_reference(group)).to eq "#{project.full_path}##{issue.iid}"
end
end
end
end
describe '#to_reference with table syntax' do
using RSpec::Parameterized::TableSyntax
let_it_be(:user) { create(:user) }
let_it_be(:user_namespace) { user.namespace }
let_it_be(:parent) { create(:group) }
let_it_be(:group) { create(:group, parent: parent) }
let_it_be(:another_group) { create(:group) }
let_it_be(:project) { create(:project, namespace: group) }
let_it_be(:project_namespace) { project.project_namespace }
let_it_be(:same_namespace_project) { create(:project, namespace: group) }
let_it_be(:same_namespace_project_namespace) { same_namespace_project.project_namespace }
let_it_be(:another_namespace_project) { create(:project) }
let_it_be(:another_namespace_project_namespace) { another_namespace_project.project_namespace }
let_it_be(:project_issue) { build(:issue, project: project, iid: 123) }
let_it_be(:project_issue_full_reference) { "#{project.full_path}##{project_issue.iid}" }
let_it_be(:group_issue) { build(:issue, namespace: group, iid: 123) }
let_it_be(:group_issue_full_reference) { "#{group.full_path}##{group_issue.iid}" }
# this one is just theoretically possible, not smth to be supported for real
let_it_be(:user_issue) { build(:issue, namespace: user_namespace, iid: 123) }
let_it_be(:user_issue_full_reference) { "#{user_namespace.full_path}##{user_issue.iid}" }
# namespace would be group, project namespace or user namespace
where(:issue, :full, :from, :result) do
ref(:project_issue) | false | nil | lazy { "##{issue.iid}" }
ref(:project_issue) | true | nil | ref(:project_issue_full_reference)
ref(:project_issue) | false | ref(:group) | lazy { "#{project.path}##{issue.iid}" }
ref(:project_issue) | true | ref(:group) | ref(:project_issue_full_reference)
ref(:project_issue) | false | ref(:parent) | ref(:project_issue_full_reference)
ref(:project_issue) | true | ref(:parent) | ref(:project_issue_full_reference)
ref(:project_issue) | false | ref(:project) | lazy { "##{issue.iid}" }
ref(:project_issue) | true | ref(:project) | ref(:project_issue_full_reference)
ref(:project_issue) | false | ref(:project_namespace) | lazy { "##{issue.iid}" }
ref(:project_issue) | true | ref(:project_namespace) | ref(:project_issue_full_reference)
ref(:project_issue) | false | ref(:same_namespace_project) | lazy { "#{project.path}##{issue.iid}" }
ref(:project_issue) | true | ref(:same_namespace_project) | ref(:project_issue_full_reference)
ref(:project_issue) | false | ref(:same_namespace_project_namespace) | lazy { "#{project.path}##{issue.iid}" }
ref(:project_issue) | true | ref(:same_namespace_project_namespace) | ref(:project_issue_full_reference)
ref(:project_issue) | false | ref(:another_group) | ref(:project_issue_full_reference)
ref(:project_issue) | true | ref(:another_group) | ref(:project_issue_full_reference)
ref(:project_issue) | false | ref(:another_namespace_project) | ref(:project_issue_full_reference)
ref(:project_issue) | true | ref(:another_namespace_project) | ref(:project_issue_full_reference)
ref(:project_issue) | false | ref(:another_namespace_project_namespace) | ref(:project_issue_full_reference)
ref(:project_issue) | true | ref(:another_namespace_project_namespace) | ref(:project_issue_full_reference)
ref(:project_issue) | false | ref(:user_namespace) | ref(:project_issue_full_reference)
ref(:project_issue) | true | ref(:user_namespace) | ref(:project_issue_full_reference)
ref(:group_issue) | false | nil | lazy { "##{issue.iid}" }
ref(:group_issue) | true | nil | ref(:group_issue_full_reference)
ref(:group_issue) | false | ref(:user_namespace) | ref(:group_issue_full_reference)
ref(:group_issue) | true | ref(:user_namespace) | ref(:group_issue_full_reference)
ref(:group_issue) | false | ref(:group) | lazy { "##{issue.iid}" }
ref(:group_issue) | true | ref(:group) | ref(:group_issue_full_reference)
ref(:group_issue) | false | ref(:parent) | ref(:group_issue_full_reference)
ref(:group_issue) | true | ref(:parent) | ref(:group_issue_full_reference)
ref(:group_issue) | false | ref(:project) | lazy { "#{group.path}##{issue.iid}" }
ref(:group_issue) | true | ref(:project) | ref(:group_issue_full_reference)
ref(:group_issue) | false | ref(:project_namespace) | lazy { "#{group.path}##{issue.iid}" }
ref(:group_issue) | true | ref(:project_namespace) | ref(:group_issue_full_reference)
ref(:group_issue) | false | ref(:another_group) | ref(:group_issue_full_reference)
ref(:group_issue) | true | ref(:another_group) | ref(:group_issue_full_reference)
ref(:group_issue) | false | ref(:another_namespace_project) | ref(:group_issue_full_reference)
ref(:group_issue) | true | ref(:another_namespace_project) | ref(:group_issue_full_reference)
ref(:group_issue) | false | ref(:another_namespace_project_namespace) | ref(:group_issue_full_reference)
ref(:group_issue) | true | ref(:another_namespace_project_namespace) | ref(:group_issue_full_reference)
ref(:user_issue) | false | nil | lazy { "##{issue.iid}" }
ref(:user_issue) | true | nil | ref(:user_issue_full_reference)
ref(:user_issue) | false | ref(:user_namespace) | lazy { "##{issue.iid}" }
ref(:user_issue) | true | ref(:user_namespace) | ref(:user_issue_full_reference)
ref(:user_issue) | false | ref(:group) | ref(:user_issue_full_reference)
ref(:user_issue) | true | ref(:group) | ref(:user_issue_full_reference)
ref(:user_issue) | false | ref(:parent) | ref(:user_issue_full_reference)
ref(:user_issue) | true | ref(:parent) | ref(:user_issue_full_reference)
ref(:user_issue) | false | ref(:project) | ref(:user_issue_full_reference)
ref(:user_issue) | true | ref(:project) | ref(:user_issue_full_reference)
ref(:user_issue) | false | ref(:project_namespace) | ref(:user_issue_full_reference)
ref(:user_issue) | true | ref(:project_namespace) | ref(:user_issue_full_reference)
ref(:user_issue) | false | ref(:another_group) | ref(:user_issue_full_reference)
ref(:user_issue) | true | ref(:another_group) | ref(:user_issue_full_reference)
ref(:user_issue) | false | ref(:another_namespace_project) | ref(:user_issue_full_reference)
ref(:user_issue) | true | ref(:another_namespace_project) | ref(:user_issue_full_reference)
ref(:user_issue) | false | ref(:another_namespace_project_namespace) | ref(:user_issue_full_reference)
ref(:user_issue) | true | ref(:another_namespace_project_namespace) | ref(:user_issue_full_reference)
end
with_them do
it 'returns correct reference' do
expect(issue.to_reference(from, full: full)).to eq(result)
end
end
end
describe '#assignee_or_author?' do
let(:issue) { create(:issue, project: reusable_project) }
it 'returns true for a user that is assigned to an issue' do
issue.assignees << user
expect(issue.assignee_or_author?(user)).to be_truthy
end
it 'returns true for a user that is the author of an issue' do
issue.update!(author: user)
expect(issue.assignee_or_author?(user)).to be_truthy
end
it 'returns false for a user that is not the assignee or author' do
expect(issue.assignee_or_author?(user)).to be_falsey
end
end
describe '#related_issues to relate incidents and issues' do
let_it_be(:authorized_project) { create(:project) }
let_it_be(:authorized_project2) { create(:project) }
let_it_be(:unauthorized_project) { create(:project) }
let_it_be(:authorized_issue_a) { create(:issue, project: authorized_project) }
let_it_be(:authorized_issue_b) { create(:issue, project: authorized_project) }
let_it_be(:authorized_issue_c) { create(:issue, project: authorized_project2) }
let_it_be(:authorized_incident_a) { create(:incident, project: authorized_project) }
let_it_be(:unauthorized_issue) { create(:issue, project: unauthorized_project) }
let_it_be(:issue_link_a) { create(:issue_link, source: authorized_issue_a, target: authorized_issue_b) }
let_it_be(:issue_link_b) { create(:issue_link, source: authorized_issue_a, target: unauthorized_issue) }
let_it_be(:issue_link_c) { create(:issue_link, source: authorized_issue_a, target: authorized_issue_c) }
let_it_be(:issue_incident_link_a) { create(:issue_link, source: authorized_issue_a, target: authorized_incident_a) }
before_all do
authorized_project.add_developer(user)
authorized_project2.add_developer(user)
end
it 'returns only authorized related issues for given user' do
expect(authorized_issue_a.related_issues(user))
.to contain_exactly(authorized_issue_b, authorized_issue_c, authorized_incident_a)
end
it 'returns issues with valid issue_link_type' do
link_types = authorized_issue_a.related_issues(user).map(&:issue_link_type)
expect(link_types).not_to be_empty
expect(link_types).not_to include(nil)
end
it 'returns issues including the link creation time' do
dates = authorized_issue_a.related_issues(user).map(&:issue_link_created_at)
expect(dates).not_to be_empty
expect(dates).not_to include(nil)
end
it 'returns issues including the link update time' do
dates = authorized_issue_a.related_issues(user).map(&:issue_link_updated_at)
expect(dates).not_to be_empty
expect(dates).not_to include(nil)
end
describe 'when a user cannot read cross project' do
it 'only returns issues within the same project' do
expect(Ability).to receive(:allowed?).with(user, :read_all_resources, :global).at_least(:once).and_call_original
expect(Ability).to receive(:allowed?).with(user, :read_cross_project).and_return(false)
expect(authorized_issue_a.related_issues(user))
.to contain_exactly(authorized_issue_b, authorized_incident_a)
end
end
context 'when authorize argument is false' do
it 'returns all related issues' do
expect(authorized_issue_a.related_issues(authorize: false))
.to contain_exactly(authorized_issue_b, authorized_issue_c, authorized_incident_a, unauthorized_issue)
end
end
context 'when current_user argument is nil' do
let_it_be(:public_issue) { create(:issue, project: create(:project, :public)) }
it 'returns public linked issues only' do
create(:issue_link, source: authorized_issue_a, target: public_issue)
expect(authorized_issue_a.related_issues).to contain_exactly(public_issue)
end
end
context 'when issue is a new record' do
let(:new_issue) { build(:issue, project: authorized_project) }
it { expect(new_issue.related_issues(user)).to be_empty }
end
end
describe '#can_move?' do
let(:issue) { create(:issue) }
subject { issue.can_move?(user) }
context 'user is not a member of project issue belongs to' do
it { is_expected.to eq false }
end
context 'user is reporter in project issue belongs to' do
let(:issue) { create(:issue, project: reusable_project) }
before_all do
reusable_project.add_reporter(user)
end
it { is_expected.to eq true }
context 'issue not persisted' do
let(:issue) { build(:issue, project: reusable_project) }
it { is_expected.to eq false }
end
context 'checking destination project also' do
subject { issue.can_move?(user, to_project) }
let_it_be(:to_project) { create(:project) }
context 'destination project allowed' do
before do
to_project.add_reporter(user)
end
it { is_expected.to eq true }
end
context 'destination project not allowed' do
before do
to_project.add_guest(user)
end
it { is_expected.to eq false }
end
end
end
end
describe '#moved?' do
context 'when issue has not been moved' do
subject { build_stubbed(:issue) }
it { is_expected.not_to be_moved }
end
context 'when issue has already been moved' do
subject { build_stubbed(:issue, moved_to: build_stubbed(:issue)) }
it { is_expected.to be_moved }
end
end
describe '#duplicated?' do
let(:issue) { create(:issue, project: reusable_project) }
subject { issue.duplicated? }
context 'issue not duplicated' do
it { is_expected.to eq false }
end
context 'issue already duplicated' do
let(:duplicated_to_issue) { create(:issue, project: reusable_project) }
let(:issue) { create(:issue, duplicated_to: duplicated_to_issue) }
it { is_expected.to eq true }
end
end
describe '#from_service_desk?' do
subject { issue.from_service_desk? }
context 'when issue author is support bot' do
let(:issue) { create(:issue, project: reusable_project, author: ::Users::Internal.support_bot) }
it { is_expected.to be_truthy }
end
context 'when issue author is not support bot' do
let(:issue) { create(:issue, project: reusable_project) }
it { is_expected.to be_falsey }
end
end
describe '#autoclose_by_merged_closing_merge_request?' do
subject { issue.autoclose_by_merged_closing_merge_request? }
context 'when issue belongs to a group' do
let(:issue) { build_stubbed(:issue, :group_level, namespace: build_stubbed(:group)) }
it { is_expected.to eq(false) }
end
context 'when issue belongs to a project' do
let(:issue) { build_stubbed(:issue, project: reusable_project) }
context 'when autoclose_referenced_issues is enabled for the project' do
it { is_expected.to eq(true) }
end
context 'when autoclose_referenced_issues is disabled for the project' do
before do
issue.project.update!(autoclose_referenced_issues: false)
end
it { is_expected.to eq(false) }
end
end
end
describe '#suggested_branch_name' do
let(:repository) { double }
subject { build(:issue) }
before do
allow(subject.project).to receive(:repository).and_return(repository)
end
describe '#to_branch_name does not exists' do
before do
allow(repository).to receive(:branch_exists?).and_return(false)
end
it 'returns #to_branch_name' do
expect(subject.suggested_branch_name).to eq(subject.to_branch_name)
end
end
describe '#to_branch_name exists not ending with -index' do
before do
allow(repository).to receive(:branch_exists?).and_return(true)
allow(repository).to receive(:branch_exists?).with(/#{subject.to_branch_name}-\d/).and_return(false)
end
it 'returns #to_branch_name ending with -2' do
expect(subject.suggested_branch_name).to eq("#{subject.to_branch_name}-2")
end
end
describe '#to_branch_name exists ending with -index' do
it 'returns #to_branch_name ending with max index + 1' do
allow(repository).to receive(:branch_exists?).and_return(true)
allow(repository).to receive(:branch_exists?).with("#{subject.to_branch_name}-3").and_return(false)
expect(subject.suggested_branch_name).to eq("#{subject.to_branch_name}-3")
end
context 'when branch name still exists after 5 attempts' do
it 'returns #to_branch_name ending with random characters' do
allow(repository).to receive(:branch_exists?).with(subject.to_branch_name).and_return(true)
allow(repository).to receive(:branch_exists?).with(/#{subject.to_branch_name}-\d/).and_return(true)
allow(repository).to receive(:branch_exists?).with(/#{subject.to_branch_name}-\h{8}/).and_return(false)
expect(subject.suggested_branch_name).to match(/#{subject.to_branch_name}-\h{8}/)
end
end
end
end
it_behaves_like 'a time trackable' do
let(:trackable) { create(:issue) }
let(:timelog) { create(:issue_timelog, issue: trackable) }
end
it_behaves_like 'an editable mentionable' do
subject { create(:issue, project: create(:project, :repository)) }
let(:backref_text) { "issue #{subject.to_reference}" }
let(:set_mentionable_text) { ->(txt) { subject.description = txt } }
end
it_behaves_like 'a Taskable' do
let(:subject) { create :issue }
end
describe '.to_branch_name' do
it 'parameterizes arguments and joins with dashes' do
expect(described_class.to_branch_name(123, 'foo bar!@#$%f!o@o#b$a%r^')).to eq('123-foo-bar-f-o-o-b-a-r')
end
it 'preserves the case in the first argument' do
expect(described_class.to_branch_name('ACME-!@#$-123', 'FoO BaR')).to eq('ACME-123-foo-bar')
end
it 'truncates branch name to at most 100 characters' do
expect(described_class.to_branch_name('a' * 101, 'a')).to eq('a' * 100)
end
it 'truncates dangling parts of the branch name' do
branch_name = described_class.to_branch_name(
999,
'Lorem ipsum dolor sit amet consectetur adipiscing elit Mauris sit amet ipsum id lacus custom fringilla convallis'
)
# 100 characters would've got us "999-lorem...lacus-custom-fri".
expect(branch_name).to eq('999-lorem-ipsum-dolor-sit-amet-consectetur-adipiscing-elit-mauris-sit-amet-ipsum-id-lacus-custom')
end
it 'takes issue branch template into account' do
project = create(:project)
project.project_setting.update!(issue_branch_template: 'feature-%{id}-%{title}')
expect(described_class.to_branch_name(123, 'issue title', project: project)).to eq('feature-123-issue-title')
end
end
describe '#to_branch_name' do
let_it_be(:issue, reload: true) { create(:issue, project: reusable_project, iid: 123, title: 'Testing Issue') }
it 'returns a branch name with the issue title if not confidential' do
expect(issue.to_branch_name).to eq('123-testing-issue')
end
it 'returns a generic branch name if confidential' do
issue.confidential = true
expect(issue.to_branch_name).to eq('123-confidential-issue')
end
end
describe '#can_be_worked_on?' do
let(:project) { build(:project) }
subject { build(:issue, :opened, project: project) }
context 'is closed' do
subject { build(:issue, :closed) }
it { is_expected.not_to be_can_be_worked_on }
end
context 'project is forked' do
before do
allow(project).to receive(:forked?).and_return(true)
end
it { is_expected.not_to be_can_be_worked_on }
end
it { is_expected.to be_can_be_worked_on }
end
describe '#participants' do
it_behaves_like 'issuable participants' do
let_it_be(:issuable_parent) { create(:project, :public) }
let_it_be_with_refind(:issuable) { create(:issue, project: issuable_parent) }
let(:params) { { noteable: issuable, project: issuable_parent } }
end
context 'using a private project' do
it 'does not include mentioned users that do not have access to the project' do
project = create(:project)
issue = create(:issue, project: project)
user = create(:user)
create(
:note_on_issue,
noteable: issue,
project: project,
note: user.to_reference
)
expect(issue.participants).not_to include(user)
end
end
end
describe 'cached counts' do
it 'updates when assignees change' do
user1 = create(:user)
user2 = create(:user)
issue = create(:issue, assignees: [user1], project: reusable_project)
reusable_project.add_developer(user1)
reusable_project.add_developer(user2)
expect(user1.assigned_open_issues_count).to eq(1)
expect(user2.assigned_open_issues_count).to eq(0)
issue.assignees = [user2]
issue.save!
expect(user1.assigned_open_issues_count).to eq(0)
expect(user2.assigned_open_issues_count).to eq(1)
end
end
describe '#visible_to_user?' do
let(:project) { reusable_project }
let(:issue) { build(:issue, project: project) }
subject { issue.visible_to_user?(user) }
context 'with a project' do
it 'returns false when feature is disabled' do
project.add_developer(user)
project.project_feature.update_attribute(:issues_access_level, ProjectFeature::DISABLED)
is_expected.to eq(false)
end
end
context 'with a group level issue' do
let_it_be(:group) { create(:group) }
let(:issue) { build(:work_item, :group_level, namespace: group) }
context 'when readable_by? is false' do
it 'returns false' do
allow(issue).to receive(:readable_by?).and_return false
is_expected.to eq(false)
end
end
context 'when readable_by? is true' do
before do
allow(issue).to receive(:readable_by?).and_return true
end
it { is_expected.to eq(true) }
context 'when user.can_read_all_resources? is true' do
before do
allow(user).to receive(:can_read_all_resources?).and_return true
end
it { is_expected.to eq(true) }
it 'does not check project external authorization' do
expect(::Gitlab::ExternalAuthorization).not_to receive(:access_allowed?)
is_expected.to eq(true)
end
end
context 'when user.can_read_all_resources? is false' do
before do
allow(user).to receive(:can_read_all_resources?).and_return false
end
it { is_expected.to eq(true) }
it 'does not check project external authorization' do
expect(::Gitlab::ExternalAuthorization).not_to receive(:access_allowed?)
is_expected.to eq(true)
end
end
end
end
context 'without a user' do
let(:user) { nil }
context 'with issue available as public' do
before do
project.project_feature.update_attribute(:issues_access_level, ProjectFeature::PUBLIC)
end
it 'returns true when the issue is publicly visible' do
expect(issue).to receive(:publicly_visible?).and_return(true)
is_expected.to eq(true)
end
it 'returns false when the issue is not publicly visible' do
expect(issue).to receive(:publicly_visible?).and_return(false)
is_expected.to eq(false)
end
end
context 'with issues available only to team members in a public project' do
let(:public_project) { create(:project, :public) }
let(:issue) { build(:issue, project: public_project) }
before do
public_project.project_feature.update_attribute(:issues_access_level, ProjectFeature::PRIVATE)
end
it 'returns false' do
is_expected.to eq(false)
end
end
end
context 'with a user' do
shared_examples 'issue readable by user' do
it { is_expected.to eq(true) }
end
shared_examples 'issue not readable by user' do
it { is_expected.to eq(false) }
end
shared_examples 'confidential issue readable by user' do
specify do
issue.confidential = true
is_expected.to eq(true)
end
end
shared_examples 'confidential issue not readable by user' do
specify do
issue.confidential = true
is_expected.to eq(false)
end
end
shared_examples 'hidden issue readable by user' do
before do
issue.author.ban!
end
specify do
is_expected.to eq(true)
end
after do
issue.author.activate!
end
end
shared_examples 'hidden issue not readable by user' do
before do
issue.author.ban!
end
specify do
is_expected.to eq(false)
end
after do
issue.author.activate!
end
end
context 'with an admin user' do
let(:user) { build(:admin) }
context 'when admin mode is enabled', :enable_admin_mode do
it_behaves_like 'issue readable by user'
it_behaves_like 'confidential issue readable by user'
it_behaves_like 'hidden issue readable by user'
end
context 'when admin mode is disabled' do
it_behaves_like 'issue not readable by user'
it_behaves_like 'confidential issue not readable by user'
it_behaves_like 'hidden issue not readable by user'
end
end
# TODO update when we have multiple owners of a project
# https://gitlab.com/gitlab-org/gitlab/-/issues/350605
context 'with an owner' do
before do
project.add_maintainer(user)
end
it_behaves_like 'issue readable by user'
it_behaves_like 'confidential issue readable by user'
it_behaves_like 'hidden issue not readable by user'
end
context 'with a reporter user' do
before do
project.add_reporter(user)
end
it_behaves_like 'issue readable by user'
it_behaves_like 'confidential issue readable by user'
it_behaves_like 'hidden issue not readable by user'
end
context 'with a guest user' do
before do
project.add_guest(user)
end
it_behaves_like 'issue readable by user'
it_behaves_like 'confidential issue not readable by user'
it_behaves_like 'hidden issue not readable by user'
context 'when user is an assignee' do
before do
issue.update!(assignees: [user])
end
it_behaves_like 'issue readable by user'
it_behaves_like 'confidential issue readable by user'
it_behaves_like 'hidden issue not readable by user'
end
context 'when user is the author' do
before do
issue.update!(author: user)
end
it_behaves_like 'issue readable by user'
it_behaves_like 'confidential issue readable by user'
it_behaves_like 'hidden issue not readable by user'
end
end
context 'with a user that is not a member' do
context 'using a public project' do
let(:project) { build(:project, :public) }
it_behaves_like 'issue readable by user'
it_behaves_like 'confidential issue not readable by user'
it_behaves_like 'hidden issue not readable by user'
end
context 'using an internal project' do
let(:project) { build(:project, :internal) }
context 'using an internal user' do
before do
allow(user).to receive(:external?).and_return(false)
end
it_behaves_like 'issue readable by user'
it_behaves_like 'confidential issue not readable by user'
it_behaves_like 'hidden issue not readable by user'
end
context 'using an external user' do
before do
allow(user).to receive(:external?).and_return(true)
end
it_behaves_like 'issue not readable by user'
it_behaves_like 'confidential issue not readable by user'
it_behaves_like 'hidden issue not readable by user'
end
end
context 'using an external user' do
before do
allow(user).to receive(:external?).and_return(true)
end
it_behaves_like 'issue not readable by user'
it_behaves_like 'confidential issue not readable by user'
it_behaves_like 'hidden issue not readable by user'
end
end
context 'with an external authentication service' do
before do
enable_external_authorization_service_check
end
it 'is `false` when an external authorization service is enabled' do
issue = build(:issue, project: build(:project, :public))
expect(issue).not_to be_visible_to_user
end
it 'checks the external service to determine if an issue is readable by a user' do
project = build(:project, :public, external_authorization_classification_label: 'a-label')
issue = build(:issue, project: project)
user = build(:user)
allow(::Gitlab::ExternalAuthorization).to receive(:access_allowed?).with(user, 'a-label', project.full_path).and_call_original
expect(::Gitlab::ExternalAuthorization).to receive(:access_allowed?).with(user, 'a-label') { false }
expect(issue.visible_to_user?(user)).to be_falsy
end
it 'does not check the external service if a user does not have access to the project' do
project = build(:project, :private, external_authorization_classification_label: 'a-label')
issue = build(:issue, project: project)
user = build(:user)
expect(::Gitlab::ExternalAuthorization).not_to receive(:access_allowed?)
expect(issue.visible_to_user?(user)).to be_falsy
end
context 'with an admin' do
context 'when admin mode is enabled', :enable_admin_mode do
it 'does not check the external webservice' do
issue = build(:issue)
user = build(:admin)
expect(::Gitlab::ExternalAuthorization).not_to receive(:access_allowed?)
issue.visible_to_user?(user)
end
end
context 'when admin mode is disabled' do
it 'checks the external service to determine if an issue is readable by the admin' do
project = build(:project, :public, external_authorization_classification_label: 'a-label')
issue = build(:issue, project: project)
user = build(:admin)
allow(::Gitlab::ExternalAuthorization).to receive(:access_allowed?).with(user, 'a-label', project.full_path).and_call_original
expect(::Gitlab::ExternalAuthorization).to receive(:access_allowed?).with(user, 'a-label') { false }
expect(issue.visible_to_user?(user)).to be_falsy
end
end
end
end
context 'when issue is moved to a private project' do
let(:private_project) { build(:project, :private) }
before do
issue.update!(project: private_project) # move issue to private project
end
shared_examples 'issue visible if user has guest access' do
context 'when user is not a member' do
it_behaves_like 'issue not readable by user'
it_behaves_like 'confidential issue not readable by user'
end
context 'when user is a guest' do
before do
private_project.add_guest(user)
end
it_behaves_like 'issue readable by user'
it_behaves_like 'confidential issue readable by user'
end
end
context 'when user is the author of the original issue' do
before do
issue.update!(author: user)
end
it_behaves_like 'issue visible if user has guest access'
end
context 'when user is an assignee in the original issue' do
before do
issue.update!(assignees: [user])
end
it_behaves_like 'issue visible if user has guest access'
end
context 'when user is not the author or an assignee in original issue' do
context 'when user is a guest' do
before do
private_project.add_guest(user)
end
it_behaves_like 'issue readable by user'
it_behaves_like 'confidential issue not readable by user'
end
context 'when user is a reporter' do
before do
private_project.add_reporter(user)
end
it_behaves_like 'issue readable by user'
it_behaves_like 'confidential issue readable by user'
end
end
end
end
end
describe '#publicly_visible?' do
let(:project) { build(:project, project_visibility) }
let(:issue) { build(:issue, confidential: confidential, project: project) }
subject { issue.send(:publicly_visible?) }
where(:project_visibility, :confidential, :expected_value) do
:public | false | true
:public | true | false
:internal | false | false
:internal | true | false
:private | false | false
:private | true | false
end
with_them do
it { is_expected.to eq(expected_value) }
end
context 'with group level issues' do
let(:group) { build(:group, group_visibility) }
let(:issue) { build(:issue, :group_level, confidential: confidential, namespace: group) }
before do
stub_licensed_features(epics: false)
end
where(:group_visibility, :confidential, :expected_value) do
:public | false | false
:public | true | false
:internal | false | false
:internal | true | false
:private | false | false
:private | true | false
end
with_them do
it { is_expected.to eq(expected_value) }
end
end
end
describe '#allow_possible_spam?' do
let_it_be(:issue) { build(:issue) }
subject { issue.allow_possible_spam?(issue.author) }
context 'when the `allow_possible_spam` application setting is turned off' do
context 'when the issue is private' do
it { is_expected.to eq(true) }
context 'when the user is the support bot' do
before do
allow(issue.author).to receive(:support_bot?).and_return(true)
end
it { is_expected.to eq(false) }
end
end
context 'when the issue is public' do
before do
allow(issue).to receive(:publicly_visible?).and_return(true)
end
it { is_expected.to eq(false) }
end
end
context 'when the `allow_possible_spam` application setting is turned on' do
before do
stub_application_setting(allow_possible_spam: true)
end
it { is_expected.to eq(true) }
end
end
describe '#check_for_spam?' do
let_it_be(:support_bot) { ::Users::Internal.support_bot }
where(:support_bot?, :visibility_level, :confidential, :new_attributes, :check_for_spam?) do
### non-support-bot cases
# spammable attributes changing
false | Gitlab::VisibilityLevel::PUBLIC | false | { description: 'new' } | true
false | Gitlab::VisibilityLevel::PUBLIC | false | { title: 'new' } | true
# confidential to non-confidential
false | Gitlab::VisibilityLevel::PUBLIC | true | { confidential: false } | false
# non-confidential to confidential
false | Gitlab::VisibilityLevel::PUBLIC | false | { confidential: true } | false
# spammable attributes changing on confidential
false | Gitlab::VisibilityLevel::PUBLIC | true | { description: 'new' } | true
# spammable attributes changing while changing to confidential
false | Gitlab::VisibilityLevel::PUBLIC | false | { title: 'new', confidential: true } | true
# spammable attribute not changing
false | Gitlab::VisibilityLevel::PUBLIC | false | { description: 'original description' } | false
# non-spammable attribute changing
false | Gitlab::VisibilityLevel::PUBLIC | false | { weight: 3 } | false
# spammable attributes changing on non-public
false | Gitlab::VisibilityLevel::INTERNAL | false | { description: 'new' } | true
false | Gitlab::VisibilityLevel::PRIVATE | false | { description: 'new' } | true
### support-bot cases
# confidential to non-confidential
true | Gitlab::VisibilityLevel::PUBLIC | true | { confidential: false } | false
# non-confidential to confidential
true | Gitlab::VisibilityLevel::PUBLIC | false | { confidential: true } | false
# spammable attributes changing on confidential
true | Gitlab::VisibilityLevel::PUBLIC | true | { description: 'new' } | true
# spammable attributes changing while changing to confidential
true | Gitlab::VisibilityLevel::PUBLIC | false | { title: 'new', confidential: true } | true
# spammable attributes changing on non-public
true | Gitlab::VisibilityLevel::INTERNAL | false | { description: 'new' } | true
true | Gitlab::VisibilityLevel::PRIVATE | false | { title: 'new' } | true
# spammable attribute not changing
true | Gitlab::VisibilityLevel::PUBLIC | false | { description: 'original description' } | false
# non-spammable attribute changing
true | Gitlab::VisibilityLevel::PRIVATE | true | { weight: 3 } | false
end
with_them do
it 'checks for spam when necessary' do
active_user = support_bot? ? support_bot : user
project = reusable_project
project.update!(visibility_level: visibility_level)
issue = create(:issue, project: project, confidential: confidential, description: 'original description', author: support_bot)
issue.assign_attributes(new_attributes)
expect(issue.check_for_spam?(user: active_user)).to eq(check_for_spam?)
end
end
end
describe 'removing an issue' do
it 'refreshes the number of open issues of the project' do
project = subject.project
expect do
subject.destroy!
BatchLoader::Executor.clear_current
end.to change { project.open_issues_count }.from(1).to(0)
end
end
describe '.public_only' do
it 'only returns public issues' do
public_issue = create(:issue, project: reusable_project)
create(:issue, project: reusable_project, confidential: true)
expect(described_class.public_only).to eq([public_issue])
end
end
describe '.confidential_only' do
it 'only returns confidential_only issues' do
create(:issue, project: reusable_project)
confidential_issue = create(:issue, project: reusable_project, confidential: true)
expect(described_class.confidential_only).to eq([confidential_issue])
end
end
describe '.without_hidden' do
let_it_be(:banned_user) { create(:user, :banned) }
let_it_be(:public_issue) { create(:issue, project: reusable_project) }
let_it_be(:hidden_issue) { create(:issue, project: reusable_project, author: banned_user) }
it 'only returns without_hidden issues' do
expect(described_class.without_hidden).to eq([public_issue])
end
end
describe '.by_project_id_and_iid' do
let_it_be(:issue_a) { create(:issue, project: reusable_project) }
let_it_be(:issue_b) { create(:issue, iid: issue_a.iid) }
let_it_be(:issue_c) { create(:issue, project: issue_a.project) }
let_it_be(:issue_d) { create(:issue, project: issue_a.project) }
it_behaves_like 'a where_composite scope', :by_project_id_and_iid do
let(:all_results) { [issue_a, issue_b, issue_c, issue_d] }
let(:first_result) { issue_a }
let(:composite_ids) do
all_results.map { |issue| { project_id: issue.project_id, iid: issue.iid } }
end
end
end
describe '.service_desk' do
it 'returns the service desk issue' do
service_desk_issue = create(:issue, project: reusable_project, author: ::Users::Internal.support_bot)
regular_issue = create(:issue, project: reusable_project)
expect(described_class.service_desk).to include(service_desk_issue)
expect(described_class.service_desk).not_to include(regular_issue)
end
end
it_behaves_like 'throttled touch' do
subject { create(:issue, updated_at: 1.hour.ago) }
end
context "relative positioning" do
let_it_be(:group) { create(:group) }
let_it_be(:project) { create(:project, group: group) }
let_it_be(:issue1) { create(:issue, project: project, relative_position: nil) }
let_it_be(:issue2) { create(:issue, project: project, relative_position: nil) }
it_behaves_like "a class that supports relative positioning" do
let_it_be(:project) { reusable_project }
let(:factory) { :issue }
let(:default_params) { { project: project } }
end
it 'is not blocked for repositioning by default' do
expect(issue1.blocked_for_repositioning?).to eq(false)
end
context 'when block_issue_repositioning flag is enabled for group' do
before do
stub_feature_flags(block_issue_repositioning: group)
end
it 'is blocked for repositioning' do
expect(issue1.blocked_for_repositioning?).to eq(true)
end
it 'does not move issues with null position' do
payload = [issue1, issue2]
expect { described_class.move_nulls_to_end(payload) }.to raise_error(Gitlab::RelativePositioning::IssuePositioningDisabled)
expect { described_class.move_nulls_to_start(payload) }.to raise_error(Gitlab::RelativePositioning::IssuePositioningDisabled)
end
end
end
it_behaves_like 'versioned description'
describe "#previous_updated_at" do
let_it_be(:updated_at) { Time.zone.local(2012, 01, 06) }
let_it_be(:issue) { create(:issue, project: reusable_project, updated_at: updated_at) }
it 'returns updated_at value if updated_at did not change at all' do
allow(issue).to receive(:previous_changes).and_return({})
expect(issue.previous_updated_at).to eq(updated_at)
end
it 'returns updated_at value if `previous_changes` has nil value for `updated_at`' do
allow(issue).to receive(:previous_changes).and_return({ 'updated_at' => nil })
expect(issue.previous_updated_at).to eq(updated_at)
end
it 'returns updated_at value if previous updated_at value is not present' do
allow(issue).to receive(:previous_changes).and_return({ 'updated_at' => [nil, Time.zone.local(2013, 02, 06)] })
expect(issue.previous_updated_at).to eq(updated_at)
end
it 'returns previous updated_at when present' do
allow(issue).to receive(:previous_changes).and_return({ 'updated_at' => [Time.zone.local(2013, 02, 06), Time.zone.local(2013, 03, 06)] })
expect(issue.previous_updated_at).to eq(Time.zone.local(2013, 02, 06))
end
end
describe '#design_collection' do
it 'returns a design collection' do
issue = build(:issue)
collection = issue.design_collection
expect(collection).to be_a(DesignManagement::DesignCollection)
expect(collection.issue).to eq(issue)
end
end
describe 'current designs' do
let(:issue) { create(:issue, project: reusable_project) }
subject { issue.designs.current }
context 'an issue has no designs' do
it { is_expected.to be_empty }
end
context 'an issue only has current designs' do
let!(:design_a) { create(:design, :with_file, issue: issue) }
let!(:design_b) { create(:design, :with_file, issue: issue) }
let!(:design_c) { create(:design, :with_file, issue: issue) }
it { is_expected.to include(design_a, design_b, design_c) }
end
context 'an issue only has deleted designs' do
let!(:design_a) { create(:design, :with_file, issue: issue, deleted: true) }
let!(:design_b) { create(:design, :with_file, issue: issue, deleted: true) }
let!(:design_c) { create(:design, :with_file, issue: issue, deleted: true) }
it { is_expected.to be_empty }
end
context 'an issue has a mixture of current and deleted designs' do
let!(:design_a) { create(:design, :with_file, issue: issue) }
let!(:design_b) { create(:design, :with_file, issue: issue, deleted: true) }
let!(:design_c) { create(:design, :with_file, issue: issue) }
it { is_expected.to contain_exactly(design_a, design_c) }
end
end
describe 'banzai_render_context' do
let(:project) { build(:project_empty_repo) }
let(:issue) { build :issue, project: project }
subject(:context) { issue.banzai_render_context(:title) }
it 'sets the label_url_method in the context' do
expect(context[:label_url_method]).to eq(:project_issues_url)
end
end
describe 'scheduling rebalancing' do
before do
allow_next_instance_of(RelativePositioning::Mover) do |mover|
allow(mover).to receive(:move) { raise RelativePositioning::NoSpaceLeft }
end
end
shared_examples 'schedules issues rebalancing' do
let(:issue) { build_stubbed(:issue, relative_position: 100, project: project) }
it 'schedules rebalancing if there is no space left' do
lhs = build_stubbed(:issue, relative_position: 99, project: project)
to_move = build(:issue, project: project)
expect(Issues::RebalancingWorker).to receive(:perform_async).with(nil, project_id, namespace_id)
expect { to_move.move_between(lhs, issue) }.to raise_error(RelativePositioning::NoSpaceLeft)
end
end
context 'when project in user namespace' do
let(:project_namespace) { build_stubbed(:project_namespace) }
let(:project) { build_stubbed(:project_empty_repo, project_namespace: project_namespace) }
let(:project_id) { project.id }
let(:namespace_id) { nil }
it_behaves_like 'schedules issues rebalancing'
end
context 'when project in a group namespace' do
let(:group) { create(:group) }
let(:project_namespace) { build_stubbed(:project_namespace) }
let(:project) { build_stubbed(:project_empty_repo, group: group, project_namespace: project_namespace) }
let(:project_id) { nil }
let(:namespace_id) { group.id }
it_behaves_like 'schedules issues rebalancing'
end
end
describe '#allows_reviewers?' do
it 'returns false as we do not support reviewers on issues yet' do
issue = build_stubbed(:issue)
expect(issue.allows_reviewers?).to be(false)
end
end
describe '#issue_type' do
let_it_be(:issue) { create(:issue) }
it 'gets the type field from the work_item_types table' do
expect(issue).to receive_message_chain(:work_item_type, :base_type)
issue.issue_type
end
context 'when the issue is not persisted' do
it 'uses the default work item type' do
non_persisted_issue = build(:issue, work_item_type: nil)
expect(non_persisted_issue.issue_type).to eq(described_class::DEFAULT_ISSUE_TYPE.to_s)
end
end
end
describe '#issue_type_supports?' do
let_it_be(:issue) { create(:issue) }
it 'raises error when feature is invalid' do
expect { issue.issue_type_supports?(:unkown_feature) }.to raise_error(ArgumentError)
end
end
describe '#supports_assignee?' do
Gitlab::DatabaseImporters::WorkItems::BaseTypeImporter::WIDGETS_FOR_TYPE.each_pair do |base_type, widgets|
specify do
issue = build(:issue, base_type)
supports_assignee = widgets.include?(:assignees)
expect(issue.supports_assignee?).to eq(supports_assignee)
end
end
end
describe '#supports_time_tracking?' do
let_it_be(:project) { create(:project) }
let_it_be_with_refind(:issue) { create(:incident, project: project) }
where(:issue_type, :supports_time_tracking) do
:issue | true
:incident | true
end
with_them do
before do
issue.update!(work_item_type: WorkItems::Type.default_by_type(issue_type))
end
specify do
expect(issue.supports_time_tracking?).to eq(supports_time_tracking)
end
end
end
describe '#time_estimate' do
let_it_be(:project) { create(:project) }
let_it_be(:issue) { create(:issue, project: project) }
context 'when time estimate on the issue record is NULL' do
before do
issue.update_column(:time_estimate, nil)
end
it 'sets time estimate to zeor on save' do
expect(issue.read_attribute(:time_estimate)).to be_nil
issue.save!
expect(issue.reload.read_attribute(:time_estimate)).to eq(0)
end
end
end
describe '#supports_move_and_clone?' do
let_it_be(:project) { create(:project) }
let_it_be_with_refind(:issue) { create(:incident, project: project) }
where(:issue_type, :supports_move_and_clone) do
:issue | true
:incident | true
end
with_them do
before do
issue.update!(work_item_type: WorkItems::Type.default_by_type(issue_type))
end
specify do
expect(issue.supports_move_and_clone?).to eq(supports_move_and_clone)
end
end
end
describe '#email_participants_emails' do
let_it_be(:issue) { create(:issue) }
it 'returns a list of emails' do
participant1 = issue.issue_email_participants.create!(email: 'a@gitlab.com')
participant2 = issue.issue_email_participants.create!(email: 'b@gitlab.com')
expect(issue.email_participants_emails).to contain_exactly(participant1.email, participant2.email)
end
end
describe '#email_participants_downcase' do
it 'returns a list of emails with all uppercase letters replaced with their lowercase counterparts' do
participant = create(:issue_email_participant, email: 'SomEoNe@ExamPLe.com')
expect(participant.issue.email_participants_emails_downcase).to match([participant.email.downcase])
end
end
describe '#escalation_status' do
it 'returns the incident_management_issuable_escalation_status association' do
escalation_status = create(:incident_management_issuable_escalation_status)
issue = escalation_status.issue
expect(issue.escalation_status).to eq(escalation_status)
end
end
describe '#expire_etag_cache' do
let_it_be(:issue) { create(:issue) }
subject(:expire_cache) { issue.expire_etag_cache }
it 'touches the etag cache store' do
key = Gitlab::Routing.url_helpers.realtime_changes_project_issue_path(issue.project, issue)
expect_next_instance_of(Gitlab::EtagCaching::Store) do |cache_store|
expect(cache_store).to receive(:touch).with(key)
end
expire_cache
end
end
describe '#link_reference_pattern' do
let(:match_data) { described_class.link_reference_pattern.match(link_reference_url) }
context 'with issue url' do
let(:link_reference_url) { 'http://localhost/namespace/project/-/issues/1' }
it 'matches with expected attributes' do
expect(match_data['namespace']).to eq('namespace')
expect(match_data['project']).to eq('project')
expect(match_data['issue']).to eq('1')
end
end
context 'with incident url' do
let(:link_reference_url) { 'http://localhost/namespace1/project1/-/issues/incident/2' }
it 'matches with expected attributes' do
expect(match_data['namespace']).to eq('namespace1')
expect(match_data['project']).to eq('project1')
expect(match_data['issue']).to eq('2')
end
end
end
context 'order by closed_at' do
let!(:issue_a) { create(:issue, closed_at: 1.day.ago) }
let!(:issue_b) { create(:issue, closed_at: 5.days.ago) }
let!(:issue_c_nil) { create(:issue, closed_at: nil) }
let!(:issue_d) { create(:issue, closed_at: 3.days.ago) }
let!(:issue_e_nil) { create(:issue, closed_at: nil) }
describe '.order_closed_at_asc' do
it 'orders on closed at' do
expect(described_class.order_closed_at_asc.to_a).to eq([issue_b, issue_d, issue_a, issue_c_nil, issue_e_nil])
end
end
describe '.order_closed_at_desc' do
it 'orders on closed at' do
expect(described_class.order_closed_at_desc.to_a).to eq([issue_a, issue_d, issue_b, issue_c_nil, issue_e_nil])
end
end
end
describe '#full_search' do
context 'when searching non-english terms' do
[
'abc 中文語',
'中文語cn',
'中文語',
'Привет'
].each do |term|
it 'adds extra where clause to match partial index' do
expect(described_class.full_search(term).to_sql).to include(
"AND (issues.title NOT SIMILAR TO '[\\u0000-\\u02FF\\u1E00-\\u1EFF\\u2070-\\u218F]*' " \
"OR issues.description NOT SIMILAR TO '[\\u0000-\\u02FF\\u1E00-\\u1EFF\\u2070-\\u218F]*')"
)
end
end
end
end
describe '#work_item_type_with_default' do
subject { described_class.new.work_item_type_with_default }
it { is_expected.to eq(WorkItems::Type.default_by_type(::Issue::DEFAULT_ISSUE_TYPE)) }
end
describe '#update_search_data!' do
it 'copies namespace_id to search data' do
issue = create(:issue)
expect(issue.search_data.namespace_id).to eq(issue.namespace_id)
end
end
describe '#linked_items_count' do
let_it_be(:issue1) { create(:issue, project: reusable_project) }
let_it_be(:issue2) { create(:issue, project: reusable_project) }
let_it_be(:issue3) { create(:issue, project: reusable_project) }
let_it_be(:issue4) { build(:issue, project: reusable_project) }
it 'returns number of issues linked to the issue' do
create(:issue_link, source: issue1, target: issue2)
create(:issue_link, source: issue1, target: issue3)
expect(issue1.linked_items_count).to eq(2)
expect(issue2.linked_items_count).to eq(1)
expect(issue3.linked_items_count).to eq(1)
expect(issue4.linked_items_count).to eq(0)
end
end
describe '#readable_by?' do
let_it_be(:admin_user) { create(:user, :admin) }
subject { issue_subject.readable_by?(user) }
context 'when issue belongs directly to a project' do
let_it_be_with_reload(:project_issue) { create(:issue, project: reusable_project) }
let_it_be(:project_reporter) { create(:user, reporter_of: reusable_project) }
let_it_be(:project_guest) { create(:user, guest_of: reusable_project) }
let(:issue_subject) { project_issue }
context 'when user is in admin mode', :enable_admin_mode do
let(:user) { admin_user }
it { is_expected.to be_truthy }
end
context 'when user is a reporter' do
let(:user) { project_reporter }
it { is_expected.to be_truthy }
context 'when issues project feature is not enabled' do
before do
reusable_project.project_feature.update!(issues_access_level: ProjectFeature::DISABLED)
end
it { is_expected.to be_falsey }
end
context 'when issue is hidden (banned author)' do
before do
issue_subject.author.ban!
end
it { is_expected.to be_falsey }
end
end
context 'when user is a guest' do
let(:user) { project_guest }
context 'when issue is confidential' do
before do
issue_subject.update!(confidential: true)
end
it { is_expected.to be_falsey }
context 'when user is assignee of the issue' do
before do
issue_subject.update!(assignees: [user])
end
it { is_expected.to be_truthy }
end
end
end
end
context 'when issue belongs directly to the group' do
let_it_be(:group) { create(:group) }
let_it_be_with_reload(:group_issue) { create(:issue, :group_level, namespace: group) }
let_it_be(:group_reporter) { create(:user, reporter_of: group) }
let_it_be(:group_guest) { create(:user, guest_of: group) }
let(:issue_subject) { group_issue }
context 'when user is in admin mode', :enable_admin_mode do
let(:user) { admin_user }
it { is_expected.to be_truthy }
end
context 'when user is a reporter' do
let(:user) { group_reporter }
it { is_expected.to be_truthy }
context 'when issue is hidden (banned author)' do
before do
issue_subject.author.ban!
end
it { is_expected.to be_falsey }
end
end
context 'when user is a guest' do
let(:user) { group_guest }
it { is_expected.to be_truthy }
context 'when issue is confidential' do
before do
issue_subject.update!(confidential: true)
end
it { is_expected.to be_falsey }
context 'when user is assignee of the issue' do
before do
issue_subject.update!(assignees: [user])
end
it { is_expected.to be_truthy }
end
end
end
end
end
describe '#gfm_reference' do
where(:issue_type, :expected_name) do
:issue | 'issue'
:incident | 'incident'
:test_case | 'test case'
:task | 'task'
end
with_them do
it 'uses the issue type as the reference name' do
issue = create(:issue, issue_type, project: reusable_project)
expect(issue.gfm_reference).to eq("#{expected_name} #{issue.to_reference}")
end
end
end
describe '#has_widget?' do
let_it_be(:work_item_type) { create(:work_item_type, :non_default) }
let_it_be_with_reload(:issue) { create(:issue, project: reusable_project, work_item_type: work_item_type) }
# Setting a fixed widget here so we don't get a licensed widget from the list as that could break the specs.
# Using const_get in the implementation will make sure the widget exists in CE (no licenses)
let(:widget_type) { :assignees }
subject { issue.has_widget?(widget_type) }
context 'when the work item does not have the widget' do
it { is_expected.to be_falsey }
end
context 'when the work item has the widget' do
before do
create(
:widget_definition,
widget_type: widget_type,
work_item_type: work_item_type
)
end
it { is_expected.to be_truthy }
end
end
shared_examples 'a markdown field that parses work item references' do
shared_examples 'a html field with work item information' do
it 'parses the work item reference' do
html_link = Nokogiri::HTML.fragment(issue[:"#{field}_html"]).css('a').first
expect(html_link.text).to eq(expected_link_text)
expect(html_link[:href]).to eq(work_item_path)
end
end
let_it_be(:group) { create(:group) }
context 'when it is a group level issue', :aggregate_failures do
let(:issue) { create(:issue, :group_level, namespace: group, field => work_item_reference) }
let(:work_item_path) { Gitlab::UrlBuilder.build(group_work_item, only_path: true) }
let(:expected_link_text) { group_work_item.to_reference }
context 'when field contains a work item reference (URL)' do
let(:work_item_path) { Gitlab::UrlBuilder.build(group_work_item) }
let(:work_item_reference) { work_item_path }
it_behaves_like 'a html field with work item information'
end
context 'when field contains a work item reference (short)' do
let(:work_item_reference) { group_work_item.to_reference }
it_behaves_like 'a html field with work item information'
end
context 'when field contains a work item reference (full)' do
let(:work_item_reference) { group_work_item.to_reference(full: true) }
it_behaves_like 'a html field with work item information'
end
context 'when field contains a project level work item reference (URL)' do
let(:work_item_path) { Gitlab::UrlBuilder.build(project_work_item) }
let(:work_item_reference) { work_item_path }
let(:expected_link_text) { "#{reusable_project.full_path}##{project_work_item.iid}" }
it_behaves_like 'a html field with work item information'
end
end
context 'when it is a project level issue', :aggregate_failures do
let(:issue) { create(:issue, :task, project: reusable_project, field => work_item_reference) }
let(:work_item_path) { Gitlab::UrlBuilder.build(project_work_item, only_path: true) }
let(:expected_link_text) { group_work_item.to_reference }
context 'when field contains a work item reference (URL)' do
let(:work_item_path) { Gitlab::UrlBuilder.build(project_work_item) }
let(:work_item_reference) { work_item_path }
let(:expected_link_text) { project_work_item.to_reference }
it_behaves_like 'a html field with work item information'
end
context 'when field contains a work item reference (short)' do
let(:work_item_reference) { project_work_item.to_reference }
it_behaves_like 'a html field with work item information'
end
context 'when field contains a work item reference (full)' do
let(:work_item_reference) { project_work_item.to_reference(full: true) }
it_behaves_like 'a html field with work item information'
end
context 'when field contains a group level work item reference (URL)' do
let(:work_item_path) { Gitlab::UrlBuilder.build(group_work_item) }
let(:work_item_reference) { work_item_path }
let(:expected_link_text) { "#{group.full_path}##{group_work_item.iid}" }
it_behaves_like 'a html field with work item information'
end
end
end
describe '#title_html' do
it_behaves_like 'a markdown field that parses work item references' do
let_it_be(:group_work_item) { create(:work_item, :group_level, namespace: group) }
let_it_be(:project_work_item) { create(:work_item, :task, project: reusable_project) }
let(:field) { :title }
end
end
describe '#description_html' do
it_behaves_like 'a markdown field that parses work item references' do
let_it_be(:group_work_item) { create(:work_item, :group_level, namespace: group) }
let_it_be(:project_work_item) { create(:work_item, :task, project: reusable_project) }
let(:field) { :description }
end
end
describe '#work_item_type' do
let_it_be_with_reload(:issue) { create(:issue, project: reusable_project) }
it 'uses the correct_work_item_type_id column to fetch the associated type' do
expect do
issue.work_item_type
end.to make_queries_matching(/FROM "work_item_types" WHERE "work_item_types"\."correct_id" =/)
end
context 'when the issues_use_correct_work_item_type_id feature flag is disabled' do
before do
stub_feature_flags(issues_use_correct_work_item_type_id: false)
end
it 'uses the work_item_type_id column to fetch the associated type' do
expect do
issue.work_item_type
end.to make_queries_matching(/FROM "work_item_types" WHERE "work_item_types"\."id" =/)
end
end
end
describe '#work_item_type_id=', :aggregate_failures do
it 'also sets correct_work_item_type_id' do
issue = build(:issue, project: reusable_project, work_item_type: nil)
work_item_type = create(:work_item_type, :non_default)
expect(issue.work_item_type_id).to be_nil
expect(issue.correct_work_item_type_id).to be_nil
issue.work_item_type_id = work_item_type.id
expect(issue.work_item_type_id).to eq(work_item_type.id)
expect(issue.correct_work_item_type_id).to eq(work_item_type.correct_id)
end
context 'when work_item_type_id does not exist in the DB' do
it 'validates work item type presence correctly' do
issue = build(:issue, project: reusable_project, work_item_type: nil)
expect(issue.work_item_type_id).to be_nil
expect(issue.correct_work_item_type_id).to be_nil
issue.work_item_type_id = non_existing_record_id
expect(issue).to be_invalid
expect(issue.errors.full_messages).to contain_exactly("Work item type can't be blank")
end
end
context 'when work_item_type_id is nil' do
it 'validates work item type presence correctly' do
issue = build(:issue, project: reusable_project)
expect(issue.work_item_type_id).to be_present
expect(issue.correct_work_item_type_id).to be_present
issue.work_item_type = nil
issue.work_item_type_id = nil
# A before_validation callback will set the default type if it's nil. Just testing that setting a nil
# work_item_type_id doesn't break anything
expect(issue).to be_valid
end
end
end
describe '#work_item_type=' do
it 'also sets correct_work_item_type', :aggregate_failures do
issue = build(:issue, project: reusable_project, work_item_type: nil)
work_item_type = create(:work_item_type, :non_default)
expect(issue.work_item_type).to be_nil
expect(issue.correct_work_item_type).to be_nil
issue.work_item_type = work_item_type
expect(issue.work_item_type).to eq(work_item_type)
expect(issue.correct_work_item_type).to eq(work_item_type)
end
end
end
|