1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Namespace::PackageSetting, feature_category: :package_registry do
describe 'relationships' do
it { is_expected.to belong_to(:namespace) }
end
describe 'validations' do
it { is_expected.to validate_presence_of(:namespace) }
describe '#maven_duplicates_allowed' do
it { is_expected.to validate_length_of(:maven_duplicate_exception_regex).is_at_most(255) }
end
it { is_expected.not_to allow_value(nil).for(:nuget_symbol_server_enabled) }
it { is_expected.to validate_length_of(:generic_duplicate_exception_regex).is_at_most(255) }
it { is_expected.to validate_length_of(:nuget_duplicate_exception_regex).is_at_most(255) }
it { is_expected.to allow_value(true, false).for(:terraform_module_duplicates_allowed) }
it { is_expected.not_to allow_value(nil).for(:terraform_module_duplicates_allowed) }
it { is_expected.to validate_length_of(:terraform_module_duplicate_exception_regex).is_at_most(255) }
describe 'regex values' do
let_it_be(:package_settings) { create(:namespace_package_setting) }
subject { package_settings }
valid_regexps = %w[SNAPSHOT .* v.+ v10.1.* (?:v.+|SNAPSHOT|TEMP)]
invalid_regexps = ['[', '(?:v.+|SNAPSHOT|TEMP']
%i[maven_duplicate_exception_regex generic_duplicate_exception_regex nuget_duplicate_exception_regex].each do |attribute|
valid_regexps.each do |valid_regexp|
it { is_expected.to allow_value(valid_regexp).for(attribute) }
end
invalid_regexps.each do |invalid_regexp|
it { is_expected.not_to allow_value(invalid_regexp).for(attribute) }
end
end
end
end
describe 'scopes' do
describe '.namespace_id_in' do
let_it_be(:package_settings) { create(:namespace_package_setting) }
let_it_be(:other_package_settings) { create(:namespace_package_setting) }
subject { described_class.namespace_id_in([package_settings.namespace_id]) }
it { is_expected.to eq([package_settings]) }
end
describe '.with_terraform_module_duplicates_allowed_or_exception_regex' do
let_it_be(:package_settings) { create(:namespace_package_setting) }
subject { described_class.with_terraform_module_duplicates_allowed_or_exception_regex }
context 'when terraform_module_duplicates_allowed is true' do
before do
package_settings.update_column(:terraform_module_duplicates_allowed, true)
end
it { is_expected.to eq([package_settings]) }
end
context 'when terraform_module_duplicate_exception_regex is present' do
before do
package_settings.update_column(:terraform_module_duplicate_exception_regex, 'foo')
end
it { is_expected.to eq([package_settings]) }
end
context 'when terraform_module_duplicates_allowed is false and terraform_module_duplicate_exception_regex is empty' do
before do
package_settings.update_columns(
terraform_module_duplicates_allowed: false,
terraform_module_duplicate_exception_regex: ''
)
end
it { is_expected.to be_empty }
end
end
end
shared_examples 'package types without package_settings' do
package_types = Packages::Package.package_types.keys - Namespace::PackageSetting::PACKAGES_WITH_SETTINGS
package_types.each do |package_type|
context "with package_type:#{package_type}" do
let_it_be(:package) { create("#{package_type}_package", package_name_and_version(package_type)) }
let_it_be(:package_settings) { package.project.namespace.package_settings }
it 'raises an error' do
expect { subject }.to raise_error(Namespace::PackageSetting::PackageSettingNotImplemented)
end
end
end
end
describe '.duplicates_allowed?' do
using RSpec::Parameterized::TableSyntax
subject { described_class.duplicates_allowed?(package) }
context 'package types with package_settings' do
Namespace::PackageSetting::PACKAGES_WITH_SETTINGS.each do |package_type|
context "with package_type: #{package_type}" do
let_it_be(:package) { create("#{package_type}_package", package_name_and_version(package_type)) }
let_it_be(:package_type) { package.package_type }
let_it_be(:package_setting) { package.project.namespace.package_settings }
where(:duplicates_allowed, :duplicate_exception_regex, :result) do
true | '' | true
false | '' | false
false | '.*' | true
false | 'fo.*' | true
false | '.*be.*' | true
end
with_them do
before do
package_setting.update!(
"#{package_type}_duplicates_allowed" => duplicates_allowed,
"#{package_type}_duplicate_exception_regex" => duplicate_exception_regex
)
end
it { is_expected.to be(result) }
end
end
end
end
it_behaves_like 'package types without package_settings'
end
describe '.duplicates_allowed_for_package?' do
using RSpec::Parameterized::TableSyntax
subject { described_class.duplicates_allowed_for_package?(package) }
context 'with no package given' do
let(:package) { nil }
it { is_expected.to be true }
end
context 'package types with package_settings' do
Namespace::PackageSetting::PACKAGES_WITH_SETTINGS.each do |package_type|
context "with package_type: #{package_type}" do
let_it_be(:package) { create("#{package_type}_package", package_name_and_version(package_type)) }
let_it_be(:package_settings) { package.package_settings }
where(:duplicates_allowed, :result) do
true | true
false | false
end
with_them do
before do
package_settings.update!("#{package_type}_duplicates_allowed" => duplicates_allowed)
end
it { is_expected.to be result }
end
end
end
end
it_behaves_like 'package types without package_settings'
end
describe '.matches_duplicate_exception?' do
subject { described_class.matches_duplicate_exception?(package) }
context 'with no package given' do
let(:package) { nil }
it { is_expected.to be true }
end
context 'package types with package_settings' do
Namespace::PackageSetting::PACKAGES_WITH_SETTINGS.each do |package_type|
context "with package_type: #{package_type}" do
let_it_be(:package) { create("#{package_type}_package", package_name_and_version(package_type)) }
let_it_be(:package_setting) { package.package_settings }
context 'when regexp matches package name' do
before do
package_setting.update!(
"#{package_type}_duplicate_exception_regex" => package.name
)
end
it { is_expected.to be true }
end
context 'when regexp matches package version' do
before do
package_setting.update!(
"#{package_type}_duplicate_exception_regex" => package.version
)
end
it { is_expected.to be true }
end
context 'when regexp does not match either package name or version' do
before do
package_setting.update!(
"#{package_type}_duplicate_exception_regex" => 'zz42'
)
end
it { is_expected.to be false }
end
end
end
end
end
describe 'package forwarding attributes' do
%i[maven_package_requests_forwarding pypi_package_requests_forwarding npm_package_requests_forwarding]
.each do |attribute|
it_behaves_like 'a cascading namespace setting boolean attribute',
settings_attribute_name: attribute,
settings_association: :package_settings
end
end
def package_name_and_version(package_type)
package_name = 'foo'
version = '1.0.0-beta'
package_name = 'foo/bar' if package_type == 'terraform_module'
version = 'v1.0.1' if package_type == 'golang'
{ name: package_name, version: version }
end
end
|
