1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Namespaces::Traversal::Cached, feature_category: :database do
describe 'callbacks' do
let_it_be_with_refind(:old_parent) { create(:group) }
let_it_be_with_refind(:new_parent) { create(:group) }
let_it_be_with_refind(:group) { create(:group, parent: old_parent) }
let_it_be_with_refind(:subgroup) { create(:group, parent: group) }
context 'when the namespace_descendants_cache_expiration feature flag is off' do
let!(:cache) { create(:namespace_descendants, namespace: group) }
before do
stub_feature_flags(namespace_descendants_cache_expiration: false)
end
it 'does not invalidate the cache' do
expect { group.update!(parent: new_parent) }.not_to change { cache.reload.outdated_at }
end
context 'when the group is deleted' do
it 'invalidates the cache' do
subgroup.destroy!
expect { group.destroy! }.not_to change { cache.reload.outdated_at }
end
end
end
context 'when no cached records are present' do
it 'does nothing' do
group.parent = new_parent
expect { group.save! }.not_to change { Namespaces::Descendants.all.to_a }
end
end
context 'when the namespace record is UserNamespace' do
it 'does nothing' do
# we won't use the optimization for UserNamespace
namespace = create(:user_namespace)
cache = create(:namespace_descendants, namespace: namespace)
expect { namespace.destroy! }.not_to change { cache.reload.outdated_at }
end
end
context 'when cached record is present' do
let!(:cache) { create(:namespace_descendants, namespace: group) }
it 'invalidates the cache' do
expect { group.update!(parent: new_parent) }.to change { cache.reload.outdated_at }.from(nil)
end
it 'does not invalidate the cache of subgroups' do
subgroup_cache = create(:namespace_descendants, namespace: subgroup)
expect { group.update!(parent: new_parent) }.not_to change { subgroup_cache.reload.outdated_at }
end
context 'when a new subgroup is added' do
it 'invalidates the cache' do
expect { create(:group, parent: group) }.to change { cache.reload.outdated_at }
end
end
context 'when a new project is added' do
it 'invalidates the cache' do
expect { create(:project, group: group) }.to change { cache.reload.outdated_at }
end
end
end
context 'when parent group has cached record' do
it 'invalidates the parent cache' do
old_parent_cache = create(:namespace_descendants, namespace: old_parent)
new_parent_cache = create(:namespace_descendants, namespace: new_parent)
group.update!(parent: new_parent)
expect(old_parent_cache.reload.outdated_at).not_to be_nil
expect(new_parent_cache.reload.outdated_at).not_to be_nil
end
end
context 'when group is destroyed' do
it 'invalidates the cache' do
subgroup.destroy!
cache = create(:namespace_descendants, namespace: group)
expect { group.destroy! }.to change { cache.reload.outdated_at }.from(nil)
end
context 'when parent group has cached record' do
it 'invalidates the parent cache' do
old_parent_cache = create(:namespace_descendants, namespace: old_parent)
new_parent_cache = create(:namespace_descendants, namespace: new_parent)
subgroup.destroy!
group.destroy!
expect(old_parent_cache.reload.outdated_at).not_to be_nil
expect(new_parent_cache.reload.outdated_at).to be_nil # no change
end
end
end
end
describe 'query methods' do
let_it_be(:group) { create(:group) }
let_it_be(:subgroup) { create(:group, parent: group) }
let_it_be(:subsubgroup) { create(:group, parent: subgroup) }
let_it_be(:project1) { create(:project, group: group) }
let_it_be(:project2) { create(:project, group: subsubgroup) }
# deliberately making self_and_descendant_group_ids different from the actual
# self_and_descendant_ids so we can verify that the cached query is running.
let_it_be_with_refind(:namespace_descendants) do
create(:namespace_descendants,
:up_to_date,
namespace: group,
self_and_descendant_group_ids: [group.id, subgroup.id],
all_project_ids: [project1.id]
)
end
describe '#self_and_descendant_ids' do
subject(:ids) { group.self_and_descendant_ids.pluck(:id) }
it 'returns the cached values' do
expect(ids).to eq(namespace_descendants.self_and_descendant_group_ids)
end
context 'when the cache is outdated' do
it 'returns the values from the uncached self_and_descendant_ids query' do
namespace_descendants.update!(outdated_at: Time.current)
expect(ids.sort).to eq([group.id, subgroup.id, subsubgroup.id])
end
end
context 'when the group_hierarchy_optimization feature flag is disabled' do
before do
stub_feature_flags(group_hierarchy_optimization: false)
end
it 'returns the values from the uncached self_and_descendant_ids query' do
expect(ids.sort).to eq([group.id, subgroup.id, subsubgroup.id])
end
end
context 'when the scope is specified' do
it 'returns uncached values that match the scope' do
ids = group.self_and_descendant_ids(skope: Namespace).pluck(:id)
expect(ids).to contain_exactly(
group.id, subgroup.id, subsubgroup.id, project1.project_namespace.id, project2.project_namespace.id
)
end
end
end
describe '#all_project_ids' do
subject(:ids) { group.all_project_ids.pluck(:id) }
it 'returns the cached values' do
expect(ids).to eq(namespace_descendants.all_project_ids)
end
context 'when the cache is outdated' do
it 'returns the values from the uncached all_project_ids query' do
namespace_descendants.update!(outdated_at: Time.current)
expect(ids.sort).to eq([project1.id, project2.id])
end
end
context 'when the group_hierarchy_optimization feature flag is disabled' do
before do
stub_feature_flags(group_hierarchy_optimization: false)
end
it 'returns the values from the uncached all_project_ids query' do
expect(ids.sort).to eq([project1.id, project2.id])
end
end
end
end
end
|
