1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe NotificationRecipient, feature_category: :team_planning do
include ExternalAuthorizationServiceHelpers
let(:user) { create(:user) }
let(:project) { create(:project, namespace: user.namespace) }
let(:target) { create(:issue, project: project) }
subject(:recipient) { described_class.new(user, :watch, target: target, project: project) }
describe '#notifiable?' do
let(:recipient) { described_class.new(user, :mention, target: target, project: project) }
context 'when emails are disabled' do
it 'returns false if group disabled' do
expect(project.namespace).to receive(:emails_enabled?).and_return(false)
expect(recipient).to receive(:emails_disabled?).and_call_original
expect(recipient.notifiable?).to eq false
end
it 'returns false if project disabled' do
expect(project).to receive(:emails_disabled?).and_return(true)
expect(recipient).to receive(:emails_disabled?).and_call_original
expect(recipient.notifiable?).to eq false
end
end
context 'when emails are enabled' do
it 'returns true if group enabled' do
expect(project.namespace).to receive(:emails_enabled?).and_return(true)
expect(recipient).to receive(:emails_disabled?).and_call_original
expect(recipient.notifiable?).to eq true
end
it 'returns true if project enabled' do
expect(project).to receive(:emails_disabled?).and_return(false)
expect(recipient).to receive(:emails_disabled?).and_call_original
expect(recipient.notifiable?).to eq true
end
end
context 'when recipient email is blocked', :freeze_time, :clean_gitlab_redis_rate_limiting do
before do
allow(Gitlab::ApplicationRateLimiter).to receive(:rate_limits)
.and_return(
temporary_email_failure: { threshold: 1, interval: 1.minute },
permanent_email_failure: { threshold: 1, interval: 1.minute }
)
end
context 'with permanent failures' do
before do
2.times { Gitlab::ApplicationRateLimiter.throttled?(:permanent_email_failure, scope: user.email) }
end
it 'returns false' do
expect(recipient.notifiable?).to eq(false)
end
end
context 'with temporary failures' do
it 'returns false' do
2.times { Gitlab::ApplicationRateLimiter.throttled?(:temporary_email_failure, scope: user.email) }
expect(recipient.notifiable?).to eq(false)
end
end
end
end
describe '#has_access?' do
before do
allow(user).to receive(:can?).and_call_original
end
context 'when external authorization service denies access' do
let(:target) { project }
before do
enable_external_authorization_service_check
external_service_deny_access(user, project)
end
it 'returns false' do
expect(recipient.has_access?).to eq false
end
end
context 'user cannot read project' do
let(:target) { project }
it 'returns false' do
expect(user).to receive(:can?).with(:read_project, project).and_return(false)
expect(user).not_to receive(:can?).with(:read_cross_project)
expect(recipient.has_access?).to eq false
end
end
context 'user cannot read build' do
let(:target) { build(:ci_pipeline) }
it 'returns false' do
expect(user).to receive(:can?).with(:read_build, target).and_return(false)
expect(recipient.has_access?).to eq false
end
end
context 'user cannot read commit' do
let(:target) { build(:commit) }
it 'returns false' do
expect(user).to receive(:can?).with(:read_commit, target).and_return(false)
expect(recipient.has_access?).to eq false
end
end
context 'target has no policy' do
let(:target) { double.as_null_object }
it 'returns true' do
expect(recipient.has_access?).to eq true
end
end
end
describe '#notification_setting' do
context 'for child groups' do
let!(:moved_group) { create(:group) }
let(:group) { create(:group) }
let(:sub_group_1) { create(:group, parent: group) }
let(:sub_group_2) { create(:group, parent: sub_group_1) }
let(:project) { create(:project, namespace: moved_group) }
before do
sub_group_2.add_owner(user)
moved_group.add_owner(user)
Groups::TransferService.new(moved_group, user).execute(sub_group_2)
moved_group.reload
end
context 'when notification setting is global' do
before do
user.notification_settings_for(group).global!
user.notification_settings_for(sub_group_1).mention!
user.notification_settings_for(sub_group_2).global!
user.notification_settings_for(moved_group).global!
end
it 'considers notification setting from the first parent without global setting' do
expect(subject.notification_setting.source).to eq(sub_group_1)
end
end
context 'when notification setting is not global' do
before do
user.notification_settings_for(group).global!
user.notification_settings_for(sub_group_1).mention!
user.notification_settings_for(sub_group_2).watch!
user.notification_settings_for(moved_group).disabled!
end
it 'considers notification setting from lowest group member in hierarchy' do
expect(subject.notification_setting.source).to eq(moved_group)
end
end
end
end
describe '#suitable_notification_level?' do
context 'when notification level is mention' do
before do
user.notification_settings_for(project).mention!
end
context 'when type is mention' do
let(:recipient) { described_class.new(user, :mention, target: target, project: project) }
it 'returns true' do
expect(recipient.suitable_notification_level?).to eq true
end
end
context 'when type is not mention' do
it 'returns false' do
expect(recipient.suitable_notification_level?).to eq false
end
end
end
context 'when notification level is participating' do
let(:notification_setting) { user.notification_settings_for(project) }
context 'when type is participating' do
let(:recipient) { described_class.new(user, :participating, target: target, project: project) }
it 'returns true' do
expect(recipient.suitable_notification_level?).to eq true
end
end
context 'when type is mention' do
let(:recipient) { described_class.new(user, :mention, target: target, project: project) }
it 'returns true' do
expect(recipient.suitable_notification_level?).to eq true
end
end
context 'with custom action' do
context "when action is failed_pipeline" do
let(:recipient) do
described_class.new(
user,
:watch,
custom_action: :failed_pipeline,
target: target,
project: project
)
end
it 'returns true' do
expect(recipient.suitable_notification_level?).to eq true
end
end
context "when action is fixed_pipeline" do
let(:recipient) do
described_class.new(
user,
:watch,
custom_action: :fixed_pipeline,
target: target,
project: project
)
end
it 'returns true' do
expect(recipient.suitable_notification_level?).to eq true
end
end
context "when action is not fixed_pipeline or failed_pipeline" do
let(:recipient) do
described_class.new(
user,
:watch,
custom_action: :success_pipeline,
target: target,
project: project
)
end
it 'returns false' do
expect(recipient.suitable_notification_level?).to eq false
end
end
end
end
context 'when notification level is custom' do
before do
user.notification_settings_for(project).custom!
end
context 'when type is participating' do
let(:notification_setting) { user.notification_settings_for(project) }
let(:recipient) do
described_class.new(
user,
:participating,
custom_action: :new_note,
target: target,
project: project
)
end
context 'with custom event enabled' do
before do
notification_setting.update!(new_note: true)
end
it 'returns true' do
expect(recipient.suitable_notification_level?).to eq true
end
end
context 'without custom event enabled' do
before do
notification_setting.update!(new_note: false)
end
it 'returns true' do
expect(recipient.suitable_notification_level?).to eq true
end
end
end
context 'when type is mention' do
let(:notification_setting) { user.notification_settings_for(project) }
let(:recipient) do
described_class.new(
user,
:mention,
custom_action: :new_issue,
target: target,
project: project
)
end
context 'with custom event enabled' do
before do
notification_setting.update!(new_issue: true)
end
it 'returns true' do
expect(recipient.suitable_notification_level?).to eq true
end
end
context 'without custom event enabled' do
before do
notification_setting.update!(new_issue: false)
end
it 'returns true' do
expect(recipient.suitable_notification_level?).to eq true
end
end
end
context 'when type is watch' do
let(:notification_setting) { user.notification_settings_for(project) }
let(:recipient) do
described_class.new(
user,
:watch,
custom_action: :failed_pipeline,
target: target,
project: project
)
end
context 'with custom event enabled' do
before do
notification_setting.update!(failed_pipeline: true)
end
it 'returns true' do
expect(recipient.suitable_notification_level?).to eq true
end
end
context 'without custom event enabled' do
before do
notification_setting.update!(failed_pipeline: false)
end
it 'returns false' do
expect(recipient.suitable_notification_level?).to eq false
end
end
context 'when custom_action is fixed_pipeline and success_pipeline event is enabled' do
let(:recipient) do
described_class.new(
user,
:watch,
custom_action: :fixed_pipeline,
target: target,
project: project
)
end
before do
notification_setting.update!(success_pipeline: true)
end
it 'returns true' do
expect(recipient.suitable_notification_level?).to eq true
end
end
context 'with merge_when_pipeline_succeeds' do
let(:notification_setting) { user.notification_settings_for(project) }
let(:recipient) do
described_class.new(
user,
:watch,
custom_action: :merge_when_pipeline_succeeds,
target: target,
project: project
)
end
context 'custom event enabled' do
before do
notification_setting.update!(merge_when_pipeline_succeeds: true)
end
it 'returns true' do
expect(recipient.suitable_notification_level?).to eq true
end
end
context 'custom event disabled' do
before do
notification_setting.update!(merge_when_pipeline_succeeds: false)
end
it 'returns false' do
expect(recipient.suitable_notification_level?).to eq false
end
end
end
end
end
context 'when notification level is watch' do
before do
user.notification_settings_for(project).watch!
end
context 'when type is watch' do
context 'without excluded watcher events' do
it 'returns true' do
expect(recipient.suitable_notification_level?).to eq true
end
end
context 'with excluded watcher events' do
let(:recipient) do
described_class.new(user, :watch, custom_action: :issue_due, target: target, project: project)
end
it 'returns false' do
expect(recipient.suitable_notification_level?).to eq false
end
end
end
context 'when type is not watch' do
context 'without excluded watcher events' do
let(:recipient) { described_class.new(user, :participating, target: target, project: project) }
it 'returns true' do
expect(recipient.suitable_notification_level?).to eq true
end
end
context 'with excluded watcher events' do
let(:recipient) do
described_class.new(user, :participating, custom_action: :issue_due, target: target, project: project)
end
it 'returns false' do
expect(recipient.suitable_notification_level?).to eq false
end
end
end
end
end
end
|
