File: runner_manager_policy_preloader_spec.rb

package info (click to toggle)
gitlab 17.6.5-19
  • links: PTS, VCS
  • area: main
  • in suites: sid
  • size: 629,368 kB
  • sloc: ruby: 1,915,304; javascript: 557,307; sql: 60,639; xml: 6,509; sh: 4,567; makefile: 1,239; python: 406
file content (38 lines) | stat: -rw-r--r-- 1,664 bytes parent folder | download
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
# frozen_string_literal: true

require 'spec_helper'

RSpec.describe Preloaders::RunnerManagerPolicyPreloader, feature_category: :fleet_visibility do
  let_it_be(:user) { create(:user) }
  let_it_be(:runner1) { create(:ci_runner) }
  let_it_be(:runner2) { create(:ci_runner) }
  let_it_be(:runner_manager1) { create(:ci_runner_machine, runner: runner1) }
  let_it_be(:runner_manager2) { create(:ci_runner_machine, runner: runner2) }

  let(:base_runner_managers) do
    Project.where(id: [runner_manager1, runner_manager2])
  end

  it 'avoids N+1 queries when authorizing a list of runner managers', :request_store do
    preload_runner_managers_for_policy(user)
    control = ActiveRecord::QueryRecorder.new { authorize_all_runner_managers(user) }

    new_runner1 = create(:ci_runner)
    new_runner2 = create(:ci_runner)
    new_runner_manager1 = create(:ci_runner_machine, runner: new_runner1)
    new_runner_manager2 = create(:ci_runner_machine, runner: new_runner2)

    pristine_runner_managers = Project.where(id: base_runner_managers + [new_runner_manager1, new_runner_manager2])

    preload_runner_managers_for_policy(user, pristine_runner_managers)
    expect { authorize_all_runner_managers(user, pristine_runner_managers) }.not_to exceed_query_limit(control)
  end

  def authorize_all_runner_managers(current_user, runner_manager_list = base_runner_managers)
    runner_manager_list.each { |runner_manager| current_user.can?(:read_runner_manager, runner_manager) }
  end

  def preload_runner_managers_for_policy(current_user, runner_manager_list = base_runner_managers)
    described_class.new(runner_manager_list, current_user).execute
  end
end