1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Preloaders::UserMaxAccessLevelInProjectsPreloader, feature_category: :system_access do
let_it_be(:user) { create(:user) }
let_it_be(:project_1) { create(:project) }
let_it_be(:project_2) { create(:project) }
let_it_be(:project_3) { create(:project) }
let_it_be(:project_4) { create(:project) }
let_it_be(:project_5) { create(:project) }
let(:projects) { [project_1, project_2, project_3, project_4, project_5] }
let(:query) { projects.each { |project| user.can?(:read_project, project) } }
before do
project_1.add_developer(user)
project_2.add_developer(user)
end
context 'without preloader' do
it 'runs some queries', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/444712' do
# we have an existing N+1, one for each project for which user is not a member
# in this spec, project_3, project_4, project_5
# https://gitlab.com/gitlab-org/gitlab/-/issues/362890
expect { query }.to make_queries(projects.size + 3)
end
end
describe '#execute', :request_store do
let(:projects_arg) { projects }
context 'when user is present' do
before do
described_class.new(projects_arg, user).execute
end
it 'avoids N+1 queries', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/446114' do
expect { query }.not_to make_queries
end
context 'when projects is an array of IDs' do
let(:projects_arg) { projects.map(&:id) }
it 'avoids N+1 queries', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/446114' do
expect { query }.not_to make_queries
end
end
# Test for handling of SQL table name clashes.
context 'when projects is a relation including project_authorizations' do
let(:projects_arg) do
Project.where(id: ProjectAuthorization.where(project_id: projects).select(:project_id))
end
it 'avoids N+1 queries', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/446114' do
expect { query }.not_to make_queries
end
end
end
context 'when user is not present' do
before do
described_class.new(projects_arg, nil).execute
end
it 'does not avoid N+1 queries' do
expect { query }.to make_queries
end
end
end
end
|
