1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe ResourceLabelEvent, feature_category: :team_planning, type: :model do
let_it_be(:group) { create(:group) }
let_it_be(:project) { create(:project, :repository, group: group) }
let_it_be(:issue) { create(:issue, project: project) }
let_it_be(:merge_request) { create(:merge_request, source_project: project) }
let_it_be(:label) { create(:label, project: project) }
subject(:resource_label_event) { build(:resource_label_event, issue: issue, label: label) }
it_behaves_like 'having unique enum values'
it_behaves_like 'a resource event'
it_behaves_like 'a resource event that responds to imported'
it_behaves_like 'a resource event for issues'
it_behaves_like 'a resource event for merge requests'
it_behaves_like 'a note for work item resource event'
describe 'associations' do
it { is_expected.to belong_to(:label) }
end
describe 'validations' do
it { is_expected.to be_valid }
describe 'Issuable validation' do
it 'is invalid if issue_id and merge_request_id are missing' do
subject.attributes = { issue: nil, merge_request: nil }
expect(subject).to be_invalid
end
it 'is invalid if issue_id and merge_request_id are set' do
subject.attributes = { issue: issue, merge_request: merge_request }
expect(subject).to be_invalid
end
it 'is valid if only issue_id is set' do
subject.attributes = { issue: issue, merge_request: nil }
expect(subject).to be_valid
end
it 'is valid if only merge_request_id is set' do
subject.attributes = { merge_request: merge_request, issue: nil }
expect(subject).to be_valid
end
end
end
context 'callbacks' do
describe '#broadcast_notes_changed' do
it 'broadcasts note change on event save' do
expect(subject.issuable).to receive(:broadcast_notes_changed)
subject.save!
end
it 'broadcasts note change on event destroy' do
subject.save!
expect(subject.issuable).to receive(:broadcast_notes_changed)
subject.destroy!
end
end
end
describe '#outdated_markdown?' do
it 'returns true if label is missing and reference is not empty' do
subject.attributes = { reference: 'ref', label_id: nil }
expect(subject.outdated_markdown?).to be true
end
it 'returns true if reference is not set yet' do
subject.attributes = { reference: nil }
expect(subject.outdated_markdown?).to be true
end
it 'returns true if markdown is outdated' do
subject.attributes = { cached_markdown_version: Gitlab::MarkdownCache::CACHE_COMMONMARK_VERSION_SHIFTED + 1 }
expect(subject.outdated_markdown?).to be true
end
it 'returns false if label and reference are set' do
subject.attributes = { reference: 'whatever', cached_markdown_version: Gitlab::MarkdownCache::CACHE_COMMONMARK_VERSION_SHIFTED }
expect(subject.outdated_markdown?).to be false
end
end
describe '#reference_html' do
subject { Nokogiri::HTML.fragment(label_event.reference_html).css('a').first.attr('href') }
before do
label_event.refresh_invalid_reference
end
context 'when resource event belongs to a group level issue' do
let(:group_label) { create(:group_label, group: group) }
let(:label_event) do
group_issue = create(:issue, :group_level, namespace: group)
create(:resource_label_event, issue: group_issue, label: group_label)
end
it { is_expected.to eq(Gitlab::Routing.url_helpers.group_work_items_path(group, label_name: group_label.title)) }
end
context 'when resource event belongs to a project level issue' do
let(:label_event) { resource_label_event }
it { is_expected.to eq(Gitlab::Routing.url_helpers.project_issues_path(project, label_name: label.title)) }
end
context 'when resource event belongs to a merge request' do
let(:label_event) { create(:resource_label_event, merge_request: merge_request, label: label) }
it do
is_expected.to eq(Gitlab::Routing.url_helpers.project_merge_requests_path(project, label_name: label.title))
end
end
end
describe '#group' do
subject { build_stubbed(:resource_label_event, **issuable_attributes).group }
context 'when issuable is a merge request' do
let(:issuable_attributes) { { merge_request: merge_request } }
it { is_expected.to be_nil }
end
context 'when issuable is an issue' do
context 'when issue exists at the project level' do
let(:issuable_attributes) { { issue: issue } }
it { is_expected.to be_nil }
end
context 'when issue exists at the group level' do
let(:issuable_attributes) { { issue: build_stubbed(:issue, :group_level, namespace: group) } }
it { is_expected.to eq(group) }
end
end
end
describe '.visible_to_user?' do
let_it_be(:user) { create(:user) }
let_it_be(:issue_project) { create(:project) }
let_it_be(:issue) { create(:issue, project: issue_project) }
subject { described_class.visible_to_user?(user, issue.resource_label_events.inc_relations) }
it 'returns events with labels accessible by user' do
label = create(:label, project: issue_project)
event = create_event(label)
issue_project.add_guest(user)
expect(subject).to eq [event]
end
it 'filters events with public project labels if issues and MRs are private' do
project = create(:project, :public, :issues_private, :merge_requests_private)
label = create(:label, project: project)
create_event(label)
expect(subject).to be_empty
end
it 'filters events with project labels not accessible by user' do
project = create(:project, :private)
label = create(:label, project: project)
create_event(label)
expect(subject).to be_empty
end
it 'filters events with group labels not accessible by user' do
group = create(:group, :private)
label = create(:group_label, group: group)
create_event(label)
expect(subject).to be_empty
end
def create_event(label)
create(:resource_label_event, issue: issue, label: label)
end
end
describe '#discussion_id' do
it 'generates different discussion ID for events created milliseconds apart' do
now = Time.current
event_1 = create(:resource_label_event, issue: issue, label: label, user: issue.author, created_at: now)
event_2 = create(:resource_label_event, issue: issue, label: label, user: issue.author, created_at: now.advance(seconds: 0.001))
expect(event_1.discussion_id).not_to eq(event_2.discussion_id)
end
end
context 'with multiple label events' do
let_it_be(:user) { create(:user) }
let_it_be(:project) { create(:project) }
let_it_be(:work_item) { create(:work_item, :task, project: project, author: user) }
let_it_be(:events) { create_pair(:resource_label_event, issue: work_item) }
it 'builds synthetic note' do
first_event = events.first
synthetic_note = first_event.work_item_synthetic_system_note(events: events)
expect(synthetic_note.class.name).to eq(first_event.synthetic_note_class.name)
expect(synthetic_note.events).to match_array(events)
end
end
end
|