1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe ServiceDeskSetting, feature_category: :service_desk do
subject(:setting) { build(:service_desk_setting) }
describe 'validations' do
it { is_expected.to validate_presence_of(:project_id) }
it { is_expected.to validate_length_of(:outgoing_name).is_at_most(255) }
it { is_expected.to validate_length_of(:project_key).is_at_most(255) }
it { is_expected.to allow_value('abc123_').for(:project_key) }
it { is_expected.not_to allow_value('abc 12').for(:project_key).with_message("can contain only lowercase letters, digits, and '_'.") }
it { is_expected.not_to allow_value('Big val').for(:project_key) }
it { is_expected.to validate_length_of(:custom_email).is_at_most(255) }
describe '#custom_email_enabled' do
it { expect(setting.custom_email_enabled).to be_falsey }
it { expect(described_class.new(custom_email_enabled: true).custom_email_enabled).to be_truthy }
context 'when set to true' do
let(:expected_error_part) { 'cannot be enabled until verification process has finished.' }
before do
setting.custom_email = 'user@example.com'
setting.custom_email_enabled = true
end
it 'is not valid' do
is_expected.not_to be_valid
expect(setting.errors[:custom_email_enabled].join).to include(expected_error_part)
end
context 'when custom email records exist' do
let_it_be(:project) { create(:project) }
let_it_be(:credential) { build(:service_desk_custom_email_credential, project: project).save!(validate: false) }
let!(:verification) { create(:service_desk_custom_email_verification, project: project) }
subject(:setting) { build_stubbed(:service_desk_setting, project: project) }
before do
project.reset
end
context 'when custom email verification started' do
it 'is not valid' do
is_expected.not_to be_valid
expect(setting.errors[:custom_email_enabled].join).to include(expected_error_part)
end
end
context 'when custom email verification has been finished' do
before do
verification.mark_as_finished!
end
it { is_expected.to be_valid }
end
end
end
end
context 'when custom_email_enabled is true' do
before do
# Test without ServiceDesk::CustomEmailVerification for simplicity
setting.custom_email_enabled = true
end
it { is_expected.to validate_presence_of(:custom_email) }
it { is_expected.to validate_uniqueness_of(:custom_email).allow_nil }
it { is_expected.to allow_value('support@example.com').for(:custom_email) }
it { is_expected.to allow_value('support@xn--brggen-4ya.de').for(:custom_email) } # converted domain name with umlaut
it { is_expected.to allow_value('support1@shop.example.com').for(:custom_email) }
it { is_expected.to allow_value('support-shop_with.crazy-address@shop.example.com').for(:custom_email) }
it { is_expected.not_to allow_value('support@example@example.com').for(:custom_email) }
it { is_expected.not_to allow_value('support.example.com').for(:custom_email) }
it { is_expected.not_to allow_value('example.com').for(:custom_email) }
it { is_expected.not_to allow_value('example').for(:custom_email) }
it { is_expected.not_to allow_value('" "@example.org').for(:custom_email) }
it { is_expected.not_to allow_value('support+12@example.com').for(:custom_email) }
it { is_expected.not_to allow_value('user@[IPv6:2001:db8::1]').for(:custom_email) }
it { is_expected.not_to allow_value('"><script>alert(1);</script>"@example.org').for(:custom_email) }
it { is_expected.not_to allow_value('file://example').for(:custom_email) }
it { is_expected.not_to allow_value('no email at all').for(:custom_email) }
end
describe '#valid_issue_template' do
let_it_be(:project) { create(:project, :custom_repo, files: { '.gitlab/issue_templates/service_desk.md' => 'template' }) }
it 'is not valid if template does not exist' do
settings = build(:service_desk_setting, project: project, issue_template_key: 'invalid key')
expect(settings).not_to be_valid
expect(settings.errors[:issue_template_key].first).to eq('is empty or does not exist')
end
it 'is valid if template exists' do
settings = build(:service_desk_setting, project: project, issue_template_key: 'service_desk')
expect(settings).to be_valid
end
end
end
describe '#custom_email_address_for_verification' do
it 'returns nil' do
expect(setting.custom_email_address_for_verification).to be_nil
end
context 'when custom_email exists' do
it 'returns correct verification address' do
setting.custom_email = 'support@example.com'
expect(setting.custom_email_address_for_verification).to eq('support+verify@example.com')
end
end
end
describe '#valid_project_key' do
# Creates two projects with same full path slug
# group1/test/one and group1/test-one will both have 'group-test-one' slug
let_it_be(:group) { create(:group) }
let_it_be(:subgroup) { create(:group, parent: group, name: 'test') }
let_it_be(:project1) { create(:project, path: 'test-one', group: group) }
let_it_be(:project2) { create(:project, path: 'one', group: subgroup) }
let_it_be(:project_key) { 'key' }
let!(:setting) do
create(:service_desk_setting, project: project1, project_key: project_key)
end
context 'when project_key exists' do
it 'is valid' do
expect(setting).to be_valid
end
end
context 'when project_key is unique for every project slug' do
it 'does not add error' do
settings = build(:service_desk_setting, project: project2, project_key: 'otherkey')
expect(settings).to be_valid
end
end
context 'when project with same slug and settings project_key exists' do
it 'adds error' do
settings = build(:service_desk_setting, project: project2, project_key: project_key)
expect(settings).to be_invalid
expect(settings.errors[:project_key].first).to eq('already in use for another service desk address.')
end
end
end
describe '#tickets_confidential_by_default?' do
using RSpec::Parameterized::TableSyntax
where(:visibility_level, :setting_value, :expected_value) do
Gitlab::VisibilityLevel::PUBLIC | true | true
Gitlab::VisibilityLevel::PUBLIC | false | true
Gitlab::VisibilityLevel::PRIVATE | true | true
Gitlab::VisibilityLevel::PRIVATE | false | false
end
with_them do
let(:project) { build(:project, visibility_level: visibility_level) }
subject(:setting) do
build(:service_desk_setting, project: project, tickets_confidential_by_default: setting_value)
.tickets_confidential_by_default?
end
it { is_expected.to be expected_value }
end
end
describe 'associations' do
let(:project) { build(:project) }
let(:verification) { build(:service_desk_custom_email_verification) }
let(:custom_email_settings) do
build_stubbed(
:service_desk_setting,
custom_email: 'support@example.com'
)
end
it { is_expected.to belong_to(:project) }
it 'can access custom email verification from project' do
project.service_desk_custom_email_verification = verification
custom_email_settings.project = project
expect(custom_email_settings.custom_email_verification).to eq(verification)
end
end
end
|
