1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Timelog, feature_category: :team_planning do
subject { create(:timelog) }
let_it_be(:issue) { create(:issue) }
let_it_be(:merge_request) { create(:merge_request) }
it { is_expected.to belong_to(:project) }
it { is_expected.to belong_to(:issue).touch(true) }
it { is_expected.to belong_to(:merge_request).touch(true) }
it { is_expected.to belong_to(:timelog_category).optional(true) }
it { is_expected.to be_valid }
it { is_expected.to validate_presence_of(:time_spent) }
it { is_expected.to validate_presence_of(:user) }
it { is_expected.to validate_length_of(:summary).is_at_most(255) }
it { expect(subject.project_id).not_to be_nil }
describe 'validation' do
it 'is invalid if issue_id and merge_request_id are missing' do
subject.attributes = { issue: nil, merge_request: nil }
expect(subject).to be_invalid
end
it 'is invalid if issue_id and merge_request_id are set' do
subject.attributes = { issue: issue, merge_request: merge_request }
expect(subject).to be_invalid
end
it 'is valid if only issue_id is set' do
subject.attributes = { issue: issue, merge_request: nil }
expect(subject).to be_valid
end
it 'is valid if only merge_request_id is set' do
subject.attributes = { merge_request: merge_request, issue: nil }
expect(subject).to be_valid
end
describe 'check if total time spent would be within the set range' do
let_it_be(:time_already_spent) { 1.minute.to_i }
before_all do
create(:issue_timelog, issue: issue, time_spent: time_already_spent)
end
it 'is valid when a negative time spent offsets the time already spent' do
timelog = build(:issue_timelog, issue: issue, time_spent: -time_already_spent)
expect(timelog).to be_valid
end
context 'when total time spent is within the allowed range' do
before_all do
# Offset the time already spent
create(:issue_timelog, issue: issue, time_spent: -time_already_spent)
end
it 'is valid' do
timelog = build(:issue_timelog, issue: issue, time_spent: 1.minute.to_i)
expect(timelog).to be_valid
end
end
context 'when total time spent is outside the allowed range' do
it 'adds an error if total time spent would exceed a year' do
time_to_spend = described_class::MAX_TOTAL_TIME_SPENT - time_already_spent + 1.second.to_i
timelog = build(:issue_timelog, issue: issue, time_spent: time_to_spend)
expect { timelog.save! }
.to raise_error(ActiveRecord::RecordInvalid,
_('Validation failed: Total time spent cannot exceed a year.'))
end
it 'adds an error if total time spent would be negative' do
time_to_spend = -time_already_spent - 1.second.to_i
timelog = build(:issue_timelog, issue: issue, time_spent: time_to_spend)
expect { timelog.save! }
.to raise_error(ActiveRecord::RecordInvalid,
_('Validation failed: Total time spent cannot be negative.'))
end
end
end
describe 'when importing' do
it 'is valid if issue_id and merge_request_id are missing' do
subject.attributes = { issue: nil, merge_request: nil, importing: true }
expect(subject).to be_valid
end
end
end
describe 'scopes' do
let_it_be(:group) { create(:group) }
let_it_be(:group_project) { create(:project, :empty_repo, group: group) }
let_it_be(:group_issue) { create(:issue, project: group_project) }
let_it_be(:group_merge_request) { create(:merge_request, source_project: group_project) }
let_it_be(:subgroup) { create(:group, parent: group) }
let_it_be(:subgroup_project) { create(:project, :empty_repo, group: subgroup) }
let_it_be(:subgroup_issue) { create(:issue, project: subgroup_project) }
let_it_be(:subgroup_merge_request) { create(:merge_request, source_project: subgroup_project) }
let_it_be(:short_time_ago) { 5.days.ago }
let_it_be(:medium_time_ago) { 15.days.ago }
let_it_be(:long_time_ago) { 65.days.ago }
let_it_be(:user) { create(:user) }
let_it_be(:timelog) { create(:issue_timelog, spent_at: long_time_ago, user: user) }
let_it_be(:timelog1) { create(:issue_timelog, spent_at: medium_time_ago, issue: group_issue, user: user) }
let_it_be(:timelog2) { create(:issue_timelog, spent_at: short_time_ago, issue: subgroup_issue) }
let_it_be(:timelog3) { create(:merge_request_timelog, spent_at: long_time_ago) }
let_it_be(:timelog4) { create(:merge_request_timelog, spent_at: medium_time_ago, merge_request: group_merge_request) }
let_it_be(:timelog5) { create(:merge_request_timelog, spent_at: short_time_ago, merge_request: subgroup_merge_request) }
describe '.in_group' do
it 'return timelogs created for group issues and merge requests' do
expect(described_class.in_group(group)).to contain_exactly(timelog1, timelog2, timelog4, timelog5)
end
end
describe '.for_user' do
it 'return timelogs created by user' do
expect(described_class.for_user(user)).to contain_exactly(timelog, timelog1)
end
end
describe '.in_project' do
it 'returns timelogs created for project issues and merge requests' do
project = create(:project, :empty_repo)
create(:issue_timelog)
create(:merge_request_timelog)
timelog1 = create(:issue_timelog, issue: create(:issue, project: project))
timelog2 = create(:merge_request_timelog, merge_request: create(:merge_request, source_project: project))
expect(described_class.in_project(project.id)).to contain_exactly(timelog1, timelog2)
end
end
describe '.at_or_after' do
it 'returns timelogs at the time limit' do
timelogs = described_class.at_or_after(short_time_ago)
expect(timelogs).to contain_exactly(timelog2, timelog5)
end
it 'returns timelogs after given time' do
timelogs = described_class.at_or_after(just_before(short_time_ago))
expect(timelogs).to contain_exactly(timelog2, timelog5)
end
end
describe '.at_or_before' do
it 'returns timelogs at the time limit' do
timelogs = described_class.at_or_before(long_time_ago)
expect(timelogs).to contain_exactly(timelog, timelog3)
end
it 'returns timelogs before given time' do
timelogs = described_class.at_or_before(just_after(long_time_ago))
expect(timelogs).to contain_exactly(timelog, timelog3)
end
end
def just_before(time)
time - 1.day
end
def just_after(time)
time + 1.day
end
end
describe 'hooks' do
describe '.set_project' do
it 'populates project with issuable project' do
timelog = create(:issue_timelog, issue: issue)
expect(timelog.project_id).to be(timelog.issue.project_id)
end
end
end
describe 'sorting' do
let_it_be(:user) { create(:user) }
let_it_be(:timelog_a) do
create(
:issue_timelog, time_spent: 7200, spent_at: 1.hour.ago,
created_at: 1.hour.ago, updated_at: 1.hour.ago, user: user
)
end
let_it_be(:timelog_b) do
create(
:issue_timelog, time_spent: 5400, spent_at: 2.hours.ago,
created_at: 2.hours.ago, updated_at: 2.hours.ago, user: user
)
end
let_it_be(:timelog_c) do
create(
:issue_timelog, time_spent: 1800, spent_at: 30.minutes.ago,
created_at: 30.minutes.ago, updated_at: 30.minutes.ago, user: user
)
end
let_it_be(:timelog_d) do
create(
:issue_timelog, time_spent: 3600, spent_at: 1.day.ago,
created_at: 1.day.ago, updated_at: 1.day.ago, user: user
)
end
describe '.sort_by_field' do
it 'sorts timelogs by time spent in ascending order' do
expect(user.timelogs.sort_by_field(:time_spent_asc)).to eq([timelog_c, timelog_d, timelog_b, timelog_a])
end
it 'sorts timelogs by time spent in descending order' do
expect(user.timelogs.sort_by_field(:time_spent_desc)).to eq([timelog_a, timelog_b, timelog_d, timelog_c])
end
it 'sorts timelogs by spent at in ascending order' do
expect(user.timelogs.sort_by_field(:spent_at_asc)).to eq([timelog_d, timelog_b, timelog_a, timelog_c])
end
it 'sorts timelogs by spent at in descending order' do
expect(user.timelogs.sort_by_field(:spent_at_desc)).to eq([timelog_c, timelog_a, timelog_b, timelog_d])
end
it 'sorts timelogs by created at in ascending order' do
expect(user.timelogs.sort_by_field(:created_at_asc)).to eq([timelog_d, timelog_b, timelog_a, timelog_c])
end
it 'sorts timelogs by created at in descending order' do
expect(user.timelogs.sort_by_field(:created_at_desc)).to eq([timelog_c, timelog_a, timelog_b, timelog_d])
end
it 'sorts timelogs by updated at in ascending order' do
expect(user.timelogs.sort_by_field(:updated_at_asc)).to eq([timelog_d, timelog_b, timelog_a, timelog_c])
end
it 'sorts timelogs by updated at in descending order' do
expect(user.timelogs.sort_by_field(:updated_at_desc)).to eq([timelog_c, timelog_a, timelog_b, timelog_d])
end
end
end
end
|