1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe WorkItem, feature_category: :portfolio_management do
using RSpec::Parameterized::TableSyntax
let_it_be(:reusable_project) { create(:project) }
let_it_be(:reusable_group) { create(:group) }
describe 'associations' do
it { is_expected.to belong_to(:namespace) }
it { is_expected.to have_one(:work_item_parent).class_name('WorkItem') }
it 'has one `parent_link`' do
is_expected.to have_one(:parent_link)
.class_name('::WorkItems::ParentLink')
.with_foreign_key('work_item_id')
end
it 'has one `dates_source`' do
is_expected.to have_one(:dates_source)
.class_name('WorkItems::DatesSource')
.with_foreign_key('issue_id')
.inverse_of(:work_item)
end
it 'has many `work_item_children`' do
is_expected.to have_many(:work_item_children)
.class_name('WorkItem')
.with_foreign_key('work_item_id')
end
it 'has many `work_item_children_by_relative_position`' do
is_expected.to have_many(:work_item_children_by_relative_position)
.class_name('WorkItem')
.with_foreign_key('work_item_id')
end
it 'has many `child_links`' do
is_expected.to have_many(:child_links)
.class_name('::WorkItems::ParentLink')
.with_foreign_key('work_item_parent_id')
end
end
describe '.work_item_children_by_relative_position' do
subject { parent_item.reload.work_item_children_by_relative_position }
let_it_be(:parent_item) { create(:work_item, :objective, project: reusable_project) }
let_it_be(:oldest_item) { create(:work_item, :objective, project: reusable_project) }
let_it_be(:middle_item) { create(:work_item, :objective, project: reusable_project) }
let_it_be(:newest_item) { create(:work_item, :objective, project: reusable_project) }
let_it_be_with_reload(:link_to_oldest_item) do
create(:parent_link, work_item_parent: parent_item, work_item: oldest_item)
end
let_it_be_with_reload(:link_to_middle_item) do
create(:parent_link, work_item_parent: parent_item, work_item: middle_item)
end
let_it_be_with_reload(:link_to_newest_item) do
create(:parent_link, work_item_parent: parent_item, work_item: newest_item)
end
context 'when ordered by relative position' do
using RSpec::Parameterized::TableSyntax
where(:oldest_item_position, :middle_item_position, :newest_item_position, :expected_order) do
nil | nil | nil | lazy { [oldest_item, middle_item, newest_item] }
nil | nil | 1 | lazy { [newest_item, oldest_item, middle_item] }
nil | 1 | 2 | lazy { [middle_item, newest_item, oldest_item] }
2 | 3 | 1 | lazy { [newest_item, oldest_item, middle_item] }
1 | 2 | 3 | lazy { [oldest_item, middle_item, newest_item] }
1 | 3 | 2 | lazy { [oldest_item, newest_item, middle_item] }
2 | 1 | 3 | lazy { [middle_item, oldest_item, newest_item] }
3 | 1 | 2 | lazy { [middle_item, newest_item, oldest_item] }
3 | 2 | 1 | lazy { [newest_item, middle_item, oldest_item] }
1 | 2 | 1 | lazy { [oldest_item, newest_item, middle_item] }
end
with_them do
before do
link_to_oldest_item.update!(relative_position: oldest_item_position)
link_to_middle_item.update!(relative_position: middle_item_position)
link_to_newest_item.update!(relative_position: newest_item_position)
end
it { is_expected.to eq(expected_order) }
end
end
end
describe '#create_dates_source_from_current_dates' do
let_it_be(:start_date) { nil }
let_it_be(:due_date) { nil }
let(:dates_source) { work_item.dates_source }
let_it_be_with_reload(:work_item) do
create(:work_item, project: reusable_project, start_date: start_date, due_date: due_date)
end
before do
work_item.update!(start_date: start_date, due_date: due_date)
end
subject(:create_dates_source_from_current_dates) { work_item.create_dates_source_from_current_dates }
context 'when both due_date and start_date are present' do
let_it_be(:due_date) { Time.zone.tomorrow }
let_it_be(:start_date) { Time.zone.today }
it 'creates dates_source with correct attributes' do
expect { create_dates_source_from_current_dates }.to change { WorkItems::DatesSource.count }.by(1)
expect(dates_source.reload).to have_attributes(
due_date: due_date,
start_date: start_date,
start_date_is_fixed: true,
due_date_is_fixed: true,
start_date_fixed: start_date,
due_date_fixed: due_date
)
end
end
context 'when only due_date is present' do
let_it_be(:due_date) { Time.zone.tomorrow }
let_it_be(:start_date) { nil }
it 'creates dates_source with correct attributes' do
create_dates_source_from_current_dates
expect(dates_source).to have_attributes(
due_date: work_item.due_date,
start_date: nil,
start_date_is_fixed: true,
due_date_is_fixed: true,
start_date_fixed: nil,
due_date_fixed: work_item.due_date
)
end
end
context 'when only start_date is present' do
let_it_be(:due_date) { nil }
let_it_be(:start_date) { Time.zone.today }
it 'creates dates_source with correct attributes' do
create_dates_source_from_current_dates
expect(dates_source).to have_attributes(
due_date: nil,
start_date: work_item.start_date,
start_date_is_fixed: true,
due_date_is_fixed: true,
start_date_fixed: work_item.start_date,
due_date_fixed: nil
)
end
end
context 'when neither due_date nor start_date is present' do
it 'creates dates_source with correct attributes' do
dates_source = work_item.create_dates_source_from_current_dates
expect(dates_source).to have_attributes(
due_date: nil,
start_date: nil,
start_date_is_fixed: false,
due_date_is_fixed: false,
start_date_fixed: nil,
due_date_fixed: nil
)
end
end
end
describe '#noteable_target_type_name' do
it 'returns `issue` as the target name' do
work_item = build(:work_item)
expect(work_item.noteable_target_type_name).to eq('issue')
end
end
describe '#todoable_target_type_name' do
it 'returns correct target name' do
work_item = build(:work_item)
expect(work_item.todoable_target_type_name).to contain_exactly('Issue', 'WorkItem')
end
end
describe '#widgets' do
subject { build(:work_item).widgets }
it 'returns instances of supported widgets' do
is_expected.to include(
instance_of(WorkItems::Widgets::Description),
instance_of(WorkItems::Widgets::Hierarchy),
instance_of(WorkItems::Widgets::Labels),
instance_of(WorkItems::Widgets::Assignees),
instance_of(WorkItems::Widgets::StartAndDueDate)
)
end
end
describe '#get_widget' do
let(:work_item) { build(:work_item, description: 'foo') }
it 'returns widget object' do
expect(work_item.get_widget(:description)).to be_an_instance_of(WorkItems::Widgets::Description)
end
context 'when widget does not exist' do
it 'returns nil' do
expect(work_item.get_widget(:nop)).to be_nil
end
end
end
describe '#supports_assignee?' do
Gitlab::DatabaseImporters::WorkItems::BaseTypeImporter::WIDGETS_FOR_TYPE.each_pair do |base_type, widgets|
specify do
work_item = build(:work_item, base_type)
supports_assignee = widgets.include?(:assignees)
expect(work_item.supports_assignee?).to eq(supports_assignee)
end
end
end
describe '#supports_time_tracking?' do
Gitlab::DatabaseImporters::WorkItems::BaseTypeImporter::WIDGETS_FOR_TYPE.each_pair do |base_type, widgets|
specify do
work_item = build(:work_item, base_type)
supports_time_tracking = widgets.include?(:time_tracking)
expect(work_item.supports_time_tracking?).to eq(supports_time_tracking)
end
end
end
describe '#supported_quick_action_commands' do
let(:work_item) { build(:work_item, :task) }
subject { work_item.supported_quick_action_commands }
it 'returns quick action commands supported for all work items' do
is_expected.to include(:title, :reopen, :close, :cc, :tableflip, :shrug, :type, :promote_to, :checkin_reminder,
:subscribe, :unsubscribe, :confidential, :award)
end
context 'when work item supports the assignee widget' do
it 'returns assignee related quick action commands' do
is_expected.to include(:assign, :unassign, :reassign)
end
end
context 'when work item does not the assignee widget' do
let(:work_item) { build(:work_item, :test_case) }
it 'omits assignee related quick action commands' do
is_expected.not_to include(:assign, :unassign, :reassign)
end
end
context 'when work item supports the labels widget' do
it 'returns labels related quick action commands' do
is_expected.to include(:label, :labels, :relabel, :remove_label, :unlabel)
end
end
context 'when work item does not support the labels widget' do
let(:work_item) { build(:work_item, :incident) }
it 'omits labels related quick action commands' do
is_expected.not_to include(:label, :labels, :relabel, :remove_label, :unlabel)
end
end
context 'when work item supports the start and due date widget' do
it 'returns due date related quick action commands' do
is_expected.to include(:due, :remove_due_date)
end
end
context 'when work item does not support the start and due date widget' do
let(:work_item) { build(:work_item, :incident) }
it 'omits due date related quick action commands' do
is_expected.not_to include(:due, :remove_due_date)
end
end
context 'when work item supports the current user todos widget' do
it 'returns todos related quick action commands' do
is_expected.to include(:todo, :done)
end
end
context 'when work item does not support current user todos widget' do
let(:work_item) { build(:work_item, :task) }
before do
WorkItems::Type.default_by_type(:task).widget_definitions
.find_by_widget_type(:current_user_todos).update!(disabled: true)
end
it 'omits todos related quick action commands' do
is_expected.not_to include(:todo, :done)
end
end
end
describe 'transform_quick_action_params' do
let(:command_params) { { title: 'bar', assignee_ids: ['foo'] } }
let(:work_item) { build(:work_item, :task) }
subject(:transformed_params) { work_item.transform_quick_action_params(command_params) }
it 'correctly separates widget params from regular params' do
expect(transformed_params).to eq({
common: {
title: 'bar'
},
widgets: {
assignees_widget: {
assignee_ids: ['foo']
}
}
})
end
context 'with current user todos widget' do
let(:command_params) { { title: 'bar', todo_event: param } }
where(:param, :expected) do
'done' | 'mark_as_done'
'add' | 'add'
end
with_them do
it 'correctly transform todo_event param' do
expect(transformed_params).to eq({
common: {
title: 'bar'
},
widgets: {
current_user_todos_widget: {
action: expected
}
}
})
end
end
end
end
describe 'callbacks' do
describe 'record_create_action' do
it 'records the creation action after saving' do
expect(Gitlab::UsageDataCounters::WorkItemActivityUniqueCounter).to receive(:track_work_item_created_action)
# During the work item transition we also want to track work items as issues
expect(Gitlab::UsageDataCounters::IssueActivityUniqueCounter).to receive(:track_issue_created_action)
create(:work_item)
end
it_behaves_like 'internal event tracking' do
let(:event) { Gitlab::UsageDataCounters::IssueActivityUniqueCounter::ISSUE_CREATED }
let(:project) { reusable_project }
let(:user) { create(:user) }
subject(:service_action) { create(:work_item, project: reusable_project, author: user) }
end
end
context 'work item namespace' do
let(:work_item) { build(:work_item, project: reusable_project) }
it 'sets the namespace_id' do
expect(work_item).to be_valid
expect(work_item.namespace).to eq(reusable_project.project_namespace)
end
context 'when work item is saved' do
it 'sets the namespace_id' do
work_item.save!
expect(work_item.reload.namespace).to eq(reusable_project.project_namespace)
end
end
context 'when existing work item is saved' do
let(:work_item) { create(:work_item) }
before do
work_item.update!(namespace_id: nil)
end
it 'sets the namespace id' do
work_item.update!(title: "#{work_item.title} and something extra")
expect(work_item.namespace).to eq(work_item.project.project_namespace)
end
end
end
context 'with title containing preceding or trailing spaces' do
let_it_be(:work_item) { build(:work_item, project: reusable_project, title: " some title ") }
it 'removes spaces from title' do
work_item.save!
expect(work_item.title).to eq("some title")
end
end
end
describe 'validations' do
subject { work_item.valid? }
describe 'confidentiality' do
let_it_be(:project) { create(:project) }
context 'when parent and child are confidential' do
let_it_be(:parent) { create(:work_item, confidential: true, project: project) }
let_it_be(:child) { create(:work_item, :task, confidential: true, project: project) }
let_it_be(:link) { create(:parent_link, work_item: child, work_item_parent: parent) }
it 'does not allow to make child non-confidential' do
child.confidential = false
expect(child).not_to be_valid
expect(child.errors[:base])
.to include(_('A non-confidential work item cannot have a confidential parent.'))
end
it 'allows to make parent non-confidential' do
parent.confidential = false
expect(parent).to be_valid
end
end
context 'when parent and child are non-confidential' do
let_it_be(:parent) { create(:work_item, project: project) }
let_it_be(:child) { create(:work_item, :task, project: project) }
let_it_be(:link) { create(:parent_link, work_item: child, work_item_parent: parent) }
it 'does not allow to make parent confidential' do
parent.confidential = true
expect(parent).not_to be_valid
expect(parent.errors[:base]).to include(
_('All child items must be confidential in order to turn on confidentiality.')
)
end
it 'allows to make child confidential' do
child.confidential = true
expect(child).to be_valid
end
end
context 'when creating new child' do
let_it_be(:child) { build(:work_item, project: project) }
it 'does not allow to set confidential parent' do
child.work_item_parent = create(:work_item, confidential: true, project: project)
expect(child).not_to be_valid
expect(child.errors[:base])
.to include('A non-confidential work item cannot have a confidential parent.')
end
end
end
end
describe '#link_reference_pattern' do
let(:match_data) { described_class.link_reference_pattern.match(link_reference_url) }
before_all do
# Required on the unlikely event that factory lint specs load the WorkItem class for the first time as
# those will define the instance's URL to be gitlab.com and link_reference_pattern is memoized in the class
described_class.instance_variable_set(:@link_reference_pattern, nil)
end
context 'with work item url' do
let(:link_reference_url) { 'http://localhost/namespace/project/-/work_items/1' }
it 'matches with expected attributes' do
expect(match_data['group_or_project_namespace']).to eq('namespace/project')
expect(match_data['work_item']).to eq('1')
end
context 'when work item exists in a group' do
let(:link_reference_url) { 'http://localhost/groups/group/sub_group/-/work_items/1' }
it 'matches with expected attributes' do
expect(match_data['group_or_project_namespace']).to eq('group/sub_group')
expect(match_data['work_item']).to eq('1')
end
end
end
end
describe '#linked_items_keyset_order' do
subject { described_class.linked_items_keyset_order }
it { is_expected.to eq('"issue_links"."id" DESC') }
end
context 'with hierarchy' do
let_it_be(:type1) { create(:work_item_type, :non_default) }
let_it_be(:type2) { create(:work_item_type, :non_default) }
let_it_be(:type3) { create(:work_item_type, :non_default) }
let_it_be(:type4) { create(:work_item_type, :non_default) }
let_it_be(:hierarchy_restriction1) { create(:hierarchy_restriction, parent_type: type1, child_type: type2) }
let_it_be(:hierarchy_restriction2) { create(:hierarchy_restriction, parent_type: type2, child_type: type2) }
let_it_be(:hierarchy_restriction3) { create(:hierarchy_restriction, parent_type: type2, child_type: type3) }
let_it_be(:hierarchy_restriction4) { create(:hierarchy_restriction, parent_type: type3, child_type: type3) }
let_it_be(:hierarchy_restriction5) { create(:hierarchy_restriction, parent_type: type3, child_type: type4) }
let_it_be(:item1) { create(:work_item, work_item_type: type1, project: reusable_project) }
let_it_be(:item2_1) { create(:work_item, work_item_type: type2, project: reusable_project) }
let_it_be(:item2_2) { create(:work_item, work_item_type: type2, project: reusable_project) }
let_it_be(:item3_1) { create(:work_item, work_item_type: type3, project: reusable_project) }
let_it_be(:item3_2) { create(:work_item, work_item_type: type3, project: reusable_project) }
let_it_be(:item4) { create(:work_item, work_item_type: type4, project: reusable_project) }
let_it_be(:ignored_ancestor) { create(:work_item, work_item_type: type1, project: reusable_project) }
let_it_be(:ignored_descendant) { create(:work_item, work_item_type: type4, project: reusable_project) }
let_it_be(:link1) { create(:parent_link, work_item_parent: item1, work_item: item2_1) }
let_it_be(:link2) { create(:parent_link, work_item_parent: item2_1, work_item: item2_2) }
let_it_be(:link3) { create(:parent_link, work_item_parent: item2_2, work_item: item3_1) }
let_it_be(:link4) { create(:parent_link, work_item_parent: item3_1, work_item: item3_2) }
let_it_be(:link5) { create(:parent_link, work_item_parent: item3_2, work_item: item4) }
describe '#ancestors' do
it 'returns all ancestors in ascending order' do
expect(item3_1.ancestors).to eq([item2_2, item2_1, item1])
end
it 'returns an empty array if there are no ancestors' do
expect(item1.ancestors).to be_empty
end
end
describe '#descendants' do
it 'returns all descendants' do
expect(item1.descendants).to match_array([item2_1, item2_2, item3_1, item3_2, item4])
end
end
describe '#same_type_base_and_ancestors' do
it 'returns self and all ancestors of the same type in ascending order' do
expect(item3_2.same_type_base_and_ancestors).to eq([item3_2, item3_1])
end
it 'returns self if there are no ancestors of the same type' do
expect(item3_1.same_type_base_and_ancestors).to match_array([item3_1])
end
end
describe '#same_type_descendants_depth' do
it 'returns max descendants depth including self' do
expect(item3_1.same_type_descendants_depth).to eq(2)
end
it 'returns 1 if there are no descendants' do
expect(item1.same_type_descendants_depth).to eq(1)
end
end
end
describe '#allowed_work_item_type_change' do
let_it_be(:all_types) { WorkItems::Type::BASE_TYPES.keys }
it 'is possible to change between all types', :aggregate_failures do
all_types.each do |type|
work_item = build(:work_item, type, project: reusable_project)
(all_types - [type]).each do |new_type|
work_item.work_item_type_id = WorkItems::Type.default_by_type(new_type).id
expect(work_item).to be_valid, "#{type} to #{new_type}"
end
end
end
context 'with ParentLink relation' do
let_it_be(:old_type) { create(:work_item_type, :non_default) }
let_it_be(:new_type) { create(:work_item_type, :non_default) }
context 'with hierarchy restrictions' do
let_it_be(:child_type) { create(:work_item_type, :non_default) }
let_it_be_with_reload(:parent) { create(:work_item, work_item_type: old_type, project: reusable_project) }
let_it_be_with_reload(:child) { create(:work_item, work_item_type: child_type, project: reusable_project) }
let_it_be(:hierarchy_restriction) do
create(:hierarchy_restriction, parent_type: old_type, child_type: child_type)
end
let_it_be(:link) { create(:parent_link, work_item_parent: parent, work_item: child) }
context 'when child items restrict the type change' do
before do
parent.work_item_type = new_type
end
context 'when child items are compatible with the new type' do
let_it_be(:hierarchy_restriction_new_type) do
create(:hierarchy_restriction, parent_type: new_type, child_type: child_type)
end
it 'allows to change types' do
expect(parent).to be_valid
expect(parent.errors).to be_empty
end
end
context 'when child items are not compatible with the new type' do
it 'does not allow to change types' do
expect(parent).not_to be_valid
expect(parent.errors[:work_item_type_id])
.to include("cannot be changed to #{new_type.name} with these child item types.")
end
end
end
context 'when the parent restricts the type change' do
before do
child.work_item_type = new_type
end
it 'does not allow to change types' do
expect(child.valid?).to eq(false)
expect(child.errors[:work_item_type_id]).to include(
format(
"cannot be changed to %{type_name} when linked to a parent %{parent_name}.",
type_name: new_type.name.downcase,
parent_name: parent.work_item_type.name.downcase
)
)
end
end
end
context 'with hierarchy depth restriction' do
let_it_be_with_reload(:item1) { create(:work_item, work_item_type: new_type, project: reusable_project) }
let_it_be_with_reload(:item2) { create(:work_item, work_item_type: new_type, project: reusable_project) }
let_it_be_with_reload(:item3) { create(:work_item, work_item_type: new_type, project: reusable_project) }
let_it_be_with_reload(:item4) { create(:work_item, work_item_type: new_type, project: reusable_project) }
let_it_be(:hierarchy_restriction1) do
create(:hierarchy_restriction, parent_type: old_type, child_type: new_type)
end
let_it_be(:hierarchy_restriction2) do
create(:hierarchy_restriction, parent_type: new_type, child_type: old_type)
end
let_it_be_with_reload(:hierarchy_restriction3) do
create(:hierarchy_restriction, parent_type: new_type, child_type: new_type, maximum_depth: 4)
end
let_it_be(:link1) { create(:parent_link, work_item_parent: item1, work_item: item2) }
let_it_be(:link2) { create(:parent_link, work_item_parent: item2, work_item: item3) }
let_it_be(:link3) { create(:parent_link, work_item_parent: item3, work_item: item4) }
before do
hierarchy_restriction3.update!(maximum_depth: maximum_depth)
end
shared_examples 'validates the depth correctly' do
before do
work_item.update!(work_item_type: old_type)
end
context 'when it is valid' do
let(:maximum_depth) { 4 }
it 'allows to change types' do
work_item.work_item_type = new_type
expect(work_item).to be_valid
end
end
context 'when it is not valid' do
let(:maximum_depth) { 3 }
it 'does not allow to change types' do
work_item.work_item_type = new_type
expect(work_item).not_to be_valid
expect(work_item.errors[:work_item_type_id]).to include("reached maximum depth")
end
end
end
context 'with the highest ancestor' do
let_it_be_with_reload(:work_item) { item1 }
it_behaves_like 'validates the depth correctly'
end
context 'with a child item' do
let_it_be_with_reload(:work_item) { item2 }
it_behaves_like 'validates the depth correctly'
end
context 'with the last child item' do
let_it_be_with_reload(:work_item) { item4 }
it_behaves_like 'validates the depth correctly'
end
context 'when ancestor is still the old type' do
let_it_be(:hierarchy_restriction4) do
create(:hierarchy_restriction, parent_type: old_type, child_type: old_type)
end
before do
item1.update!(work_item_type: old_type)
item2.update!(work_item_type: old_type)
end
context 'when it exceeds maximum depth' do
let(:maximum_depth) { 2 }
it 'does not allow to change types' do
item2.work_item_type = new_type
expect(item2).not_to be_valid
expect(item2.errors[:work_item_type_id]).to include("reached maximum depth")
end
end
context 'when it does not exceed maximum depth' do
let(:maximum_depth) { 3 }
it 'does allow to change types' do
item2.work_item_type = new_type
expect(item2).to be_valid
end
end
end
end
end
end
describe '#linked_work_items' do
let_it_be(:user) { create(:user) }
let_it_be(:authorized_project) { create(:project) }
let_it_be(:authorized_project2) { create(:project) }
let_it_be(:unauthorized_project) { create(:project, :private) }
let_it_be(:authorized_item_a) { create(:work_item, project: authorized_project) }
let_it_be(:authorized_item_b) { create(:work_item, project: authorized_project) }
let_it_be(:authorized_item_c) { create(:work_item, project: authorized_project2) }
let_it_be(:unauthorized_item) { create(:work_item, project: unauthorized_project) }
let_it_be(:work_item_link_a) { create(:work_item_link, source: authorized_item_a, target: authorized_item_b) }
let_it_be(:work_item_link_b) { create(:work_item_link, source: authorized_item_a, target: unauthorized_item) }
let_it_be(:work_item_link_c) { create(:work_item_link, source: authorized_item_a, target: authorized_item_c) }
before_all do
authorized_project.add_guest(user)
authorized_project2.add_guest(user)
end
it 'returns only authorized linked work items for given user' do
expect(authorized_item_a.linked_work_items(user)).to contain_exactly(authorized_item_b, authorized_item_c)
end
it 'returns work items with valid work_item_link_type' do
link_types = authorized_item_a.linked_work_items(user).map(&:issue_link_type)
expect(link_types).not_to be_empty
expect(link_types).not_to include(nil)
end
it 'returns work items including the link creation time' do
dates = authorized_item_a.linked_work_items(user).map(&:issue_link_created_at)
expect(dates).not_to be_empty
expect(dates).not_to include(nil)
end
it 'returns work items including the link update time' do
dates = authorized_item_a.linked_work_items(user).map(&:issue_link_updated_at)
expect(dates).not_to be_empty
expect(dates).not_to include(nil)
end
context 'when a user cannot read cross project' do
it 'only returns work items within the same project' do
allow(Ability).to receive(:allowed?).with(user, :read_all_resources, :global).and_call_original
expect(Ability).to receive(:allowed?).with(user, :read_cross_project).and_return(false)
expect(authorized_item_a.linked_work_items(user)).to contain_exactly(authorized_item_b)
end
end
context 'when filtering by link type' do
before do
work_item_link_c.update!(link_type: 'blocks')
end
it 'returns authorized work items with given link type' do
expect(authorized_item_a.linked_work_items(user, link_type: 'relates_to')).to contain_exactly(authorized_item_b)
end
end
context 'when authorize option is true and current_user is nil' do
it 'returns empty result' do
expect(authorized_item_a.linked_work_items).to be_empty
end
end
context 'when authorize option is false' do
it 'returns all work items linked to the work item' do
expect(authorized_item_a.linked_work_items(authorize: false))
.to contain_exactly(authorized_item_b, authorized_item_c, unauthorized_item)
end
end
context 'when work item is a new record' do
let(:new_work_item) { build(:work_item, project: authorized_project) }
it { expect(new_work_item.linked_work_items(user)).to be_empty }
end
end
describe '#linked_items_count' do
let_it_be(:item1) { create(:work_item, :issue, project: reusable_project) }
let_it_be(:item2) { create(:work_item, :issue, project: reusable_project) }
let_it_be(:item3) { create(:work_item, :issue, project: reusable_project) }
let_it_be(:item4) { build(:work_item, :issue, project: reusable_project) }
it 'returns number of items linked to the work item' do
create(:work_item_link, source: item1, target: item2)
create(:work_item_link, source: item1, target: item3)
expect(item1.linked_items_count).to eq(2)
expect(item2.linked_items_count).to eq(1)
expect(item3.linked_items_count).to eq(1)
expect(item4.linked_items_count).to eq(0)
end
end
context 'work item participants' do
context 'project level work item' do
let_it_be(:work_item) { create(:work_item, project: reusable_project) }
it 'has participants' do
expect(work_item.participants).to match_array([work_item.author])
end
end
context 'group level work item' do
let_it_be(:work_item) { create(:work_item, namespace: reusable_group) }
it 'has participants' do
expect(work_item.participants).to match_array([work_item.author])
end
end
end
describe '#due_date' do
let_it_be(:work_item) { create(:work_item, :issue) }
context 'when work_item have no dates_source fallbacks to work_item due_date' do
before do
work_item.update!(due_date: 1.day.from_now)
end
specify { expect(work_item.due_date).to eq(work_item.due_date) }
end
context 'when work_item have dates_source use it instead of work_item due_date value' do
before do
work_item.create_dates_source!(due_date: 1.day.ago)
work_item.reload.update!(due_date: nil)
end
specify { expect(work_item.due_date).to eq(work_item.dates_source.due_date) }
end
end
describe '#start_date' do
let_it_be(:work_item) { create(:work_item, :issue) }
context 'when work_item have no dates_source fallbacks to work_item start_date' do
before do
work_item.update!(start_date: 1.day.ago)
end
specify { expect(work_item.start_date).to eq(work_item.start_date) }
end
context 'when work_item have dates_source use it instead of work_item start_date value' do
before do
work_item.create_dates_source!(start_date: 1.day.from_now)
work_item.reload.update!(start_date: nil)
end
specify { expect(work_item.start_date).to eq(work_item.dates_source.start_date) }
end
end
describe '#max_depth_reached?' do
let_it_be(:work_item) { create(:work_item) }
let_it_be(:child_type) { create(:work_item_type) }
context 'when there is no hierarchy restriction' do
it 'returns false' do
expect(work_item.max_depth_reached?(child_type)).to be false
end
end
context 'when there is a hierarchy restriction without maximum depth' do
before do
create(:hierarchy_restriction,
parent_type_id: work_item.work_item_type_id,
child_type_id: child_type.id,
maximum_depth: nil)
end
it 'returns false' do
expect(work_item.max_depth_reached?(child_type)).to be false
end
end
context 'when there is a hierarchy restriction with maximum depth' do
let(:max_depth) { 3 }
before do
create(:hierarchy_restriction,
parent_type_id: work_item.work_item_type_id,
child_type_id: child_type.id,
maximum_depth: max_depth)
end
context 'when work item type is the same as child type' do
let(:child_type) { work_item.work_item_type }
it 'returns true when depth is reached' do
allow(work_item).to receive_message_chain(:same_type_base_and_ancestors, :count).and_return(max_depth)
expect(work_item.max_depth_reached?(child_type)).to be true
end
it 'returns false when depth is not reached' do
allow(work_item).to receive_message_chain(:same_type_base_and_ancestors, :count).and_return(max_depth - 1)
expect(work_item.max_depth_reached?(child_type)).to be false
end
end
context 'when work item type is different from child type' do
it 'returns true when depth is reached' do
allow(work_item).to receive_message_chain(:hierarchy, :base_and_ancestors, :count).and_return(max_depth)
expect(work_item.max_depth_reached?(child_type)).to be true
end
it 'returns false when depth is not reached' do
allow(work_item).to receive_message_chain(:hierarchy, :base_and_ancestors, :count).and_return(max_depth - 1)
expect(work_item.max_depth_reached?(child_type)).to be false
end
end
end
end
end
|