1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Admin::AbuseReportsController, type: :request, feature_category: :insider_threat do
include AdminModeHelper
let_it_be(:admin) { create(:admin) }
before do
enable_admin_mode!(admin)
sign_in(admin)
end
describe 'GET #index' do
let!(:open_report) { create(:abuse_report) }
let!(:closed_report) { create(:abuse_report, :closed) }
it 'returns open reports by default' do
get admin_abuse_reports_path
expect(assigns(:abuse_reports).count).to eq 1
expect(assigns(:abuse_reports).first.open?).to eq true
end
it 'returns reports by specified status' do
get admin_abuse_reports_path, params: { status: 'closed' }
expect(assigns(:abuse_reports).count).to eq 1
expect(assigns(:abuse_reports).first.closed?).to eq true
end
it 'labels does not introduce N+1 queries' do
get admin_abuse_reports_path # warm up
control = ActiveRecord::QueryRecorder.new { get admin_abuse_reports_path }
create_list(:abuse_report, 2)
expect { get admin_abuse_reports_path }.to issue_same_number_of_queries_as(control).ignoring_cached_queries
end
end
describe 'GET #show' do
let!(:report) { create(:abuse_report) }
it 'returns the requested report' do
get admin_abuse_report_path(report)
expect(assigns(:abuse_report)).to eq report
end
end
describe 'PUT #update' do
let_it_be(:report) { create(:abuse_report) }
let_it_be(:label1) { create(:abuse_report_label, title: 'Uno') }
let(:params) { { label_ids: [Gitlab::GlobalId.build(label1, id: label1.id).to_s] } }
let(:expected_params) { ActionController::Parameters.new(params).permit! }
subject(:request) { put admin_abuse_report_path(report, params) }
it 'invokes the Admin::AbuseReports::UpdateService' do
expect_next_instance_of(Admin::AbuseReports::UpdateService, report, admin, expected_params) do |service|
expect(service).to receive(:execute).and_call_original
end
request
end
context 'when the service response is a success' do
before do
allow_next_instance_of(Admin::AbuseReports::UpdateService, report, admin, expected_params) do |service|
allow(service).to receive(:execute).and_return(ServiceResponse.success)
end
request
end
it 'returns with a success status' do
expect(response).to have_gitlab_http_status(:ok)
end
end
context 'when the service response is an error' do
let(:error_message) { 'Error updating abuse report' }
before do
allow_next_instance_of(Admin::AbuseReports::UpdateService, report, admin, expected_params) do |service|
allow(service).to receive(:execute).and_return(ServiceResponse.error(message: error_message))
end
request
end
it 'returns the service response message with a failed status' do
expect(response).to have_gitlab_http_status(:unprocessable_entity)
expect(json_response['message']).to eq(error_message)
end
end
end
describe 'PUT #moderate_user' do
let(:report) { create(:abuse_report) }
let(:params) { { user_action: 'block_user', close: 'true', reason: 'spam', comment: 'obvious spam' } }
let(:expected_params) { ActionController::Parameters.new(params).permit! }
let(:message) { 'Service response' }
subject(:request) { put moderate_user_admin_abuse_report_path(report, params) }
it 'invokes the Admin::AbuseReports::ModerateUserService' do
expect_next_instance_of(Admin::AbuseReports::ModerateUserService, report, admin, expected_params) do |service|
expect(service).to receive(:execute).and_call_original
end
request
end
context 'when the service response is a success' do
before do
allow_next_instance_of(Admin::AbuseReports::ModerateUserService, report, admin, expected_params) do |service|
allow(service).to receive(:execute).and_return(ServiceResponse.success(message: message))
end
request
end
it 'returns the service response message with a success status' do
expect(response).to have_gitlab_http_status(:ok)
expect(json_response['message']).to eq(message)
end
end
context 'when the service response is an error' do
before do
allow_next_instance_of(Admin::AbuseReports::ModerateUserService, report, admin, expected_params) do |service|
allow(service).to receive(:execute).and_return(ServiceResponse.error(message: message))
end
request
end
it 'returns the service response message with a failed status' do
expect(response).to have_gitlab_http_status(:unprocessable_entity)
expect(json_response['message']).to eq(message)
end
end
end
describe 'DELETE #destroy' do
let!(:report) { create(:abuse_report) }
let(:params) { {} }
subject { delete admin_abuse_report_path(report, params) }
it 'destroys the report' do
expect { subject }.to change { AbuseReport.count }.by(-1)
end
context 'when passing the `remove_user` parameter' do
let(:params) { { remove_user: true } }
it 'calls the `remove_user` method' do
expect_next_found_instance_of(AbuseReport) do |report|
expect(report).to receive(:remove_user).with(deleted_by: admin)
end
subject
end
end
end
end
|
