1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe API::API, feature_category: :system_access do
include GroupAPIHelpers
describe 'Record user last activity in after hook' do
# It does not matter which endpoint is used because last_activity_on should
# be updated on every request. `/groups` is used as an example
# to represent any API endpoint
let(:user) { create(:user, last_activity_on: Date.yesterday) }
it 'updates the users last_activity_on to the current date' do
expect(Users::ActivityService).to receive(:new).with(author: user, project: nil, namespace: nil).and_call_original
expect { get api('/groups', user) }.to change { user.reload.last_activity_on }.to(Date.today)
end
context "with a project-specific path" do
let_it_be(:project) { create(:project, :public) }
let_it_be(:user) { project.first_owner }
it "passes correct arguments to ActivityService" do
activity_args = { author: user, project: project, namespace: project.group }
expect(Users::ActivityService).to receive(:new).with(activity_args).and_call_original
get(api("/projects/#{project.id}/issues", user))
end
end
end
describe 'User with only read_api scope personal access token' do
# It does not matter which endpoint is used because this should behave
# in the same way for every request. `/groups` is used as an example
# to represent any API endpoint
context 'when personal access token has only read_api scope' do
let_it_be(:user) { create(:user) }
let_it_be(:group) { create(:group) }
let_it_be(:token) { create(:personal_access_token, user: user, scopes: [:read_api]) }
before_all do
group.add_owner(user)
end
it 'does authorize user for get request' do
get api('/groups', personal_access_token: token)
expect(response).to have_gitlab_http_status(:ok)
end
it 'does authorize user for head request' do
head api('/groups', personal_access_token: token)
expect(response).to have_gitlab_http_status(:ok)
end
it 'does not authorize user for revoked token' do
revoked = create(:personal_access_token, :revoked, user: user, scopes: [:read_api])
get api('/groups', personal_access_token: revoked)
expect(response).to have_gitlab_http_status(:unauthorized)
end
it 'does not authorize user for post request' do
params = attributes_for_group_api
post api("/groups", personal_access_token: token), params: params
expect(response).to have_gitlab_http_status(:forbidden)
end
it 'does not authorize user for put request' do
group_param = { name: 'Test' }
put api("/groups/#{group.id}", personal_access_token: token), params: group_param
expect(response).to have_gitlab_http_status(:forbidden)
end
it 'does not authorize user for delete request' do
delete api("/groups/#{group.id}", personal_access_token: token)
expect(response).to have_gitlab_http_status(:forbidden)
end
end
end
describe 'authentication with deploy token' do
context 'admin mode' do
let_it_be(:project) { create(:project, :public) }
let_it_be(:package) { create(:maven_package, project: project, name: project.full_path) }
let_it_be(:maven_metadatum) { package.maven_metadatum }
let_it_be(:package_file) { package.package_files.first }
let_it_be(:deploy_token) { create(:deploy_token) }
let(:headers_with_deploy_token) do
{
Gitlab::Auth::AuthFinders::DEPLOY_TOKEN_HEADER => deploy_token.token
}
end
it 'does not bypass the session' do
expect(Gitlab::Auth::CurrentUserMode).not_to receive(:bypass_session!)
get(api("/packages/maven/#{maven_metadatum.path}/#{package_file.file_name}"),
headers: headers_with_deploy_token)
expect(response).to have_gitlab_http_status(:ok)
expect(response.media_type).to eq('application/octet-stream')
end
end
end
describe 'counter metrics', :aggregate_failures do
let_it_be(:project) { create(:project, :public) }
let_it_be(:user) { project.first_owner }
let_it_be(:http_router_rule_counter) { Gitlab::Metrics.counter(:gitlab_http_router_rule_total, 'description') }
let(:perform_request) { get(api("/projects/#{project.id}", user), headers: headers) }
context 'when the headers are present' do
context 'for classify action' do
let(:headers) do
{
'X-Gitlab-Http-Router-Rule-Action' => 'classify',
'X-Gitlab-Http-Router-Rule-Type' => 'FIRST_CELL'
}
end
it 'increments the counter' do
expect { perform_request }
.to change { http_router_rule_counter.get(rule_action: 'classify', rule_type: 'FIRST_CELL') }.by(1)
end
end
context 'for proxy action' do
let(:headers) do
{
'X-Gitlab-Http-Router-Rule-Action' => 'proxy'
}
end
it 'increments the counter' do
expect { perform_request }
.to change { http_router_rule_counter.get(rule_action: 'proxy', rule_type: nil) }.by(1)
end
end
end
context 'for invalid action and type' do
let(:headers) do
{
'X-Gitlab-Http-Router-Rule-Action' => 'invalid',
'X-Gitlab-Http-Router-Rule-Type' => 'invalid'
}
end
it 'does not increment the counter' do
expect { perform_request }
.to change { http_router_rule_counter.get(rule_action: 'invalid', rule_type: 'invalid') }.by(0)
end
end
context 'when action is not present and type is present' do
let(:headers) do
{
'X-Gitlab-Http-Router-Rule-Type' => 'FIRST_CELL'
}
end
it 'does not increment the counter' do
expect { perform_request }.to change {
http_router_rule_counter.get(rule_action: nil, rule_type: 'FIRST_CELL')
}.by(0)
end
end
context 'when the headers are absent' do
let(:headers) { {} }
it 'does not increment the counter' do
expect { perform_request }
.to change { http_router_rule_counter.get(rule_action: nil, rule_type: nil) }.by(0)
end
end
end
describe 'logging', :aggregate_failures do
let_it_be(:project) { create(:project, :public) }
let_it_be(:user) { project.first_owner }
context 'when the endpoint is handled by the application' do
context 'when the endpoint supports all possible fields' do
it 'logs all application context fields and the route' do
expect(described_class::LOG_FORMATTER).to receive(:call) do |_severity, _datetime, _, data|
expect(data.stringify_keys).to include(
'correlation_id' => an_instance_of(String),
'meta.caller_id' => 'GET /api/:version/projects/:id/issues',
'meta.remote_ip' => an_instance_of(String),
'meta.project' => project.full_path,
'meta.root_namespace' => project.namespace.full_path,
'meta.user' => user.username,
'meta.client_id' => a_string_matching(%r{\Auser/.+}),
'meta.feature_category' => 'team_planning',
'meta.http_router_rule_action' => 'classify',
'meta.http_router_rule_type' => 'FIRST_CELL',
'route' => '/api/:version/projects/:id/issues'
)
end
get(api("/projects/#{project.id}/issues", user), headers: {
'X-Gitlab-Http-Router-Rule-Action' => 'classify',
'X-Gitlab-Http-Router-Rule-Type' => 'FIRST_CELL'
})
expect(response).to have_gitlab_http_status(:ok)
end
end
context 'with an expired token' do
let_it_be(:private_project) { create(:project) }
let_it_be(:token) { create(:personal_access_token, :expired, user: user) }
it 'logs all application context fields and the route' do
expect(described_class::LOG_FORMATTER).to receive(:call) do |_severity, _datetime, _, data|
expect(data.stringify_keys).to include(
'correlation_id' => an_instance_of(String),
'meta.caller_id' => 'GET /api/:version/projects/:id/issues',
'meta.remote_ip' => an_instance_of(String),
'meta.client_id' => a_string_matching(%r{\Aip/.+}),
'meta.auth_fail_reason' => "token_expired",
'meta.auth_fail_token_id' => "PersonalAccessToken/#{token.id}",
'meta.feature_category' => 'team_planning',
'route' => '/api/:version/projects/:id/issues'
)
end
get(api("/projects/#{private_project.id}/issues", personal_access_token: token))
expect(response).to have_gitlab_http_status(:unauthorized)
end
end
it 'skips context fields that do not apply' do
expect(described_class::LOG_FORMATTER).to receive(:call) do |_severity, _datetime, _, data|
expect(data.stringify_keys).to include(
'correlation_id' => an_instance_of(String),
'meta.caller_id' => 'GET /api/:version/broadcast_messages',
'meta.remote_ip' => an_instance_of(String),
'meta.client_id' => a_string_matching(%r{\Aip/.+}),
'meta.feature_category' => 'notifications',
'route' => '/api/:version/broadcast_messages'
)
expect(data.stringify_keys).not_to include('meta.project', 'meta.root_namespace', 'meta.user')
end
get(api('/broadcast_messages'))
expect(response).to have_gitlab_http_status(:ok)
end
end
context 'when there is an unsupported media type' do
it 'logs the route and context metadata for the client' do
expect(described_class::LOG_FORMATTER).to receive(:call) do |_severity, _datetime, _, data|
expect(data.stringify_keys).to include(
'correlation_id' => an_instance_of(String),
'meta.remote_ip' => an_instance_of(String),
'meta.client_id' => a_string_matching(%r{\Aip/.+}),
'route' => '/api/:version/users/:id'
)
expect(data.stringify_keys).not_to include('meta.caller_id', 'meta.feature_category', 'meta.user')
end
put(api("/users/#{user.id}", user), params: { 'name' => 'Test' }, headers: { 'Content-Type' => 'image/png' })
expect(response).to have_gitlab_http_status(:unsupported_media_type)
end
end
context 'when there is an OPTIONS request' do
it 'logs the route and context metadata for the client' do
expect(described_class::LOG_FORMATTER).to receive(:call) do |_severity, _datetime, _, data|
expect(data.stringify_keys).to include(
'correlation_id' => an_instance_of(String),
'meta.remote_ip' => an_instance_of(String),
'meta.client_id' => a_string_matching(%r{\Auser/.+}),
'meta.user' => user.username,
'meta.feature_category' => 'user_profile',
'route' => '/api/:version/users'
)
expect(data.stringify_keys).not_to include('meta.caller_id')
end
options(api('/users', user))
expect(response).to have_gitlab_http_status(:no_content)
end
end
context 'when the API version is not matched' do
it 'logs the route and context metadata for the client' do
expect(described_class::LOG_FORMATTER).to receive(:call) do |_severity, _datetime, _, data|
expect(data.stringify_keys).to include(
'correlation_id' => an_instance_of(String),
'meta.remote_ip' => an_instance_of(String),
'meta.client_id' => a_string_matching(%r{\Aip/.+}),
'route' => '/api/:version/*path'
)
expect(data.stringify_keys).not_to include('meta.caller_id', 'meta.user')
end
get('/api/v4_or_is_it')
expect(response).to have_gitlab_http_status(:not_found)
end
end
context 'when there is an unhandled exception for an anonymous request' do
it 'logs all application context fields and the route' do
expect(described_class::LOG_FORMATTER).to receive(:call) do |_severity, _datetime, _, data|
expect(data.stringify_keys).to include(
'correlation_id' => an_instance_of(String),
'meta.caller_id' => 'GET /api/:version/broadcast_messages',
'meta.remote_ip' => an_instance_of(String),
'meta.client_id' => a_string_matching(%r{\Aip/.+}),
'meta.feature_category' => 'notifications',
'route' => '/api/:version/broadcast_messages'
)
expect(data.stringify_keys).not_to include('meta.project', 'meta.root_namespace', 'meta.user')
end
expect(System::BroadcastMessage).to receive(:all).and_raise('An error!')
get(api('/broadcast_messages'))
expect(response).to have_gitlab_http_status(:internal_server_error)
end
end
end
describe 'Marginalia comments' do
context 'GET /user/:id' do
let_it_be(:user) { create(:user) }
let(:component_map) do
{
"application" => "test",
"endpoint_id" => "GET /api/:version/users/:id"
}
end
subject { ActiveRecord::QueryRecorder.new { get api("/users/#{user.id}", user) } }
it 'generates a query that includes the expected annotations' do
expect(subject.log.last).to match(/correlation_id:.*/)
component_map.each do |component, value|
expect(subject.log.last).to include("#{component}:#{value}")
end
end
end
end
describe 'supported content-types' do
context 'GET /user/:id.txt' do
let_it_be(:user) { create(:user) }
subject { get api("/users/#{user.id}.txt", user) }
it 'returns application/json' do
subject
expect(response).to have_gitlab_http_status(:ok)
expect(response.media_type).to eq('application/json')
expect(response.body).to include('{"id":')
end
end
end
describe 'content security policy header' do
let_it_be(:user) { create(:user) }
let(:csp) { nil }
let(:report_only) { false }
subject { get api("/users/#{user.id}", user) }
before do
allow(Rails.application.config).to receive(:content_security_policy).and_return(csp)
allow(Rails.application.config).to receive(:content_security_policy_report_only).and_return(report_only)
end
context 'when CSP is not configured globally' do
it 'does not set the CSP header' do
subject
expect(response).to have_gitlab_http_status(:ok)
expect(response.headers['Content-Security-Policy']).to be_nil
end
end
context 'when CSP is configured globally' do
let(:csp) do
ActionDispatch::ContentSecurityPolicy.new do |p|
p.default_src :self
end
end
it 'sets a stricter CSP header' do
subject
expect(response).to have_gitlab_http_status(:ok)
expect(response.headers['Content-Security-Policy']).to eq("default-src 'none'")
end
context 'when report_only is true' do
let(:report_only) { true }
it 'does not set any CSP header' do
subject
expect(response).to have_gitlab_http_status(:ok)
expect(response.headers['Content-Security-Policy']).to be_nil
expect(response.headers['Content-Security-Policy-Report-Only']).to be_nil
end
end
end
end
describe 'admin mode support' do
let(:admin) { create(:admin) }
subject do
get api("/admin/clusters", personal_access_token: token)
response
end
context 'with `admin_mode` scope' do
let(:token) { create(:personal_access_token, user: admin, scopes: [:api, :admin_mode]) }
context 'when admin mode setting is disabled', :do_not_mock_admin_mode_setting do
it { is_expected.to have_gitlab_http_status(:ok) }
end
context 'when admin mode setting is enabled' do
it { is_expected.to have_gitlab_http_status(:ok) }
end
end
context 'without `admin_mode` scope' do
let(:token) { create(:personal_access_token, user: admin, scopes: [:api]) }
context 'when admin mode setting is disabled', :do_not_mock_admin_mode_setting do
it { is_expected.to have_gitlab_http_status(:ok) }
end
context 'when admin mode setting is enabled' do
it { is_expected.to have_gitlab_http_status(:forbidden) }
end
end
end
describe 'Handle Gitlab::Git::ResourceExhaustedError exception' do
let_it_be(:user) { create(:user) }
let_it_be(:project) { create(:project, :repository, creator: user) }
before do
project.add_maintainer(user)
allow(Gitlab::GitalyClient).to receive(:call).with(any_args).and_raise(
Gitlab::Git::ResourceExhaustedError.new("Upstream Gitaly has been exhausted. Try again later", 50)
)
end
it 'returns 503 status and Retry-After header' do
get api("/projects/#{project.id}/repository/commits", user)
expect(response).to have_gitlab_http_status(:service_unavailable)
expect(response.headers['Retry-After']).to be(50)
expect(json_response).to eql(
'message' => 'Upstream Gitaly has been exhausted. Try again later'
)
end
end
describe 'Grape::Exceptions::Base handler' do
it 'returns 400 on JSON parse errors' do
post api('/projects'),
params: '{"test":"random_\$escaped/symbols\;here"}',
headers: { 'content-type' => 'application/json' }
expect(response).to have_gitlab_http_status(:bad_request)
end
end
end
|