1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe API::Ci::Runner, :clean_gitlab_redis_shared_state, feature_category: :fleet_visibility do
include StubGitlabCalls
include RedisHelpers
include WorkhorseHelpers
before do
stub_feature_flags(ci_enable_live_trace: true)
stub_gitlab_calls
allow_next_instance_of(::Ci::Runner) { |runner| allow(runner).to receive(:cache_attributes) }
end
describe '/api/v4/runners' do
let(:registration_token) { 'abcdefg123456' }
before do
stub_application_setting(runners_registration_token: registration_token)
end
describe 'DELETE /api/v4/runners' do
it_behaves_like 'runner migrations backoff' do
let(:request) { delete api('/runners') }
end
context 'when no token is provided' do
it 'returns 400 error' do
delete api('/runners')
expect(response).to have_gitlab_http_status(:bad_request)
end
end
context 'when invalid token is provided' do
it 'returns 403 error' do
delete api('/runners'), params: { token: 'invalid' }
expect(response).to have_gitlab_http_status(:forbidden)
end
end
context 'when valid token is provided' do
let!(:runner) { create(:ci_runner, *args) }
let(:args) { [] }
subject(:perform_request) { delete api('/runners'), params: { token: runner.token } }
it 'deletes runner' do
expect { perform_request }
.to change { ::Ci::Runner.count }.by(-1)
expect(response).to have_gitlab_http_status(:no_content)
end
it 'does not create missing runner manager' do
query = ActiveRecord::QueryRecorder.new { perform_request }
expect(query.log.select { |cmd| cmd.include?(::Ci::RunnerManager.table_name) }).to be_empty
end
it 'does not modify any record' do
query = ActiveRecord::QueryRecorder.new { perform_request }
expect(query.log.select { |cmd| cmd.include?('UPDATE') }).to be_empty
end
context 'with associated runner manager' do
let(:args) { :with_runner_manager }
it 'deletes runner and associated manager' do
expect { perform_request }
.to change { ::Ci::Runner.count }.by(-1)
.and change { ::Ci::RunnerManager.count }.by(-1)
expect(response).to have_gitlab_http_status(:no_content)
end
it 'does not modify any record' do
query = ActiveRecord::QueryRecorder.new { perform_request }
expect(query.log.select { |cmd| cmd.include?('UPDATE') }).to be_empty
end
end
it_behaves_like '412 response' do
let(:request) { api('/runners') }
let(:params) { { token: runner.token } }
end
it_behaves_like 'storing arguments in the application context for the API' do
let(:expected_params) { { client_id: "runner/#{runner.id}" } }
end
end
end
end
describe '/api/v4/runners/managers' do
describe 'DELETE /api/v4/runners/managers' do
subject(:delete_request) { delete api('/runners/managers'), params: delete_params }
context 'with created runner' do
let!(:runner) { create(:ci_runner, :with_runner_manager, registration_type: :authenticated_user) }
context 'with matching system_id' do
context 'when no token is provided' do
let(:delete_params) { { system_id: runner.runner_managers.first.system_xid } }
it 'returns 400 error' do
delete_request
expect(response).to have_gitlab_http_status(:bad_request)
end
end
context 'when invalid token is provided' do
let(:delete_params) { { token: 'invalid', system_id: runner.runner_managers.first.system_xid } }
it 'returns 403 error' do
delete_request
expect(response).to have_gitlab_http_status(:forbidden)
end
end
end
end
context 'when valid token is provided' do
context 'with created runner' do
let!(:runner) { create(:ci_runner, :with_runner_manager, registration_type: :authenticated_user) }
context 'with matching system_id' do
let(:delete_params) { { token: runner.token, system_id: runner.runner_managers.first.system_xid } }
it 'deletes runner manager' do
expect do
delete_request
expect(response).to have_gitlab_http_status(:no_content)
end.to change { runner.runner_managers.count }.from(1).to(0)
expect(::Ci::Runner.count).to eq(1)
end
it_behaves_like '412 response' do
let(:request) { api('/runners/managers') }
let(:params) { delete_params }
end
it_behaves_like 'storing arguments in the application context for the API' do
let(:expected_params) { { client_id: "runner/#{runner.id}" } }
end
end
context 'with unknown system_id' do
let(:delete_params) { { token: runner.token, system_id: 'unknown_system_id' } }
it 'returns 404 error' do
delete_request
expect(response).to have_gitlab_http_status(:not_found)
end
end
context 'without system_id' do
let(:delete_params) { { token: runner.token } }
it 'does not delete runner manager nor runner' do
delete_request
expect(response).to have_gitlab_http_status(:bad_request)
end
end
end
end
end
end
end
|
