1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe 'Bulk update issues', feature_category: :team_planning do
include GraphqlHelpers
let_it_be(:developer) { create(:user) }
let_it_be(:group) { create(:group, developers: developer) }
let_it_be(:project) { create(:project, group: group) }
let_it_be(:label1) { create(:group_label, group: group) }
let_it_be(:label2) { create(:group_label, group: group) }
let_it_be(:updatable_issues, reload: true) { create_list(:issue, 2, project: project, label_ids: [label1.id]) }
let_it_be(:milestone) { create(:milestone, group: group) }
let(:parent) { project }
let(:max_issues) { Mutations::Issues::BulkUpdate::MAX_ISSUES }
let(:mutation) { graphql_mutation(:issues_bulk_update, base_arguments.merge(additional_arguments)) }
let(:mutation_response) { graphql_mutation_response(:issues_bulk_update) }
let(:current_user) { developer }
let(:base_arguments) { { parent_id: parent.to_gid.to_s, ids: updatable_issues.map { |i| i.to_gid.to_s } } }
let(:additional_arguments) do
{
assignee_ids: [current_user.to_gid.to_s],
milestone_id: milestone.to_gid.to_s,
state_event: :CLOSE,
add_label_ids: [label2.to_gid.to_s],
remove_label_ids: [label1.to_gid.to_s],
subscription_event: :UNSUBSCRIBE
}
end
before_all do
updatable_issues.each { |i| i.subscribe(developer, project) }
end
context 'when Gitlab is FOSS only' do
unless Gitlab.ee?
context 'when parent is a group' do
let(:parent) { group }
it 'does not allow bulk updating issues at the group level' do
post_graphql_mutation(mutation, current_user: current_user)
expect(graphql_errors).to contain_exactly(
hash_including(
'message' => match(/does not represent an instance of IssueParent/)
)
)
end
end
end
end
context 'when the `bulk_update_issues_mutation` feature flag is disabled' do
before do
stub_feature_flags(bulk_update_issues_mutation: false)
end
it 'returns a resource not available error' do
post_graphql_mutation(mutation, current_user: current_user)
expect(graphql_errors).to contain_exactly(
hash_including(
'message' => '`bulk_update_issues_mutation` feature flag is disabled.'
)
)
end
end
context 'when user can not update all issues' do
let_it_be(:forbidden_issue) { create(:issue) }
it 'updates only issues that the user can update' do
expect do
post_graphql_mutation(mutation, current_user: current_user)
updatable_issues.each(&:reset)
forbidden_issue.reset
end.to change { updatable_issues.flat_map(&:assignee_ids) }.from([]).to([current_user.id] * 2).and(
not_change(forbidden_issue, :assignee_ids).from([])
)
expect(mutation_response).to include(
'updatedIssueCount' => updatable_issues.count
)
end
end
context 'when user can update all issues' do
it 'updates all issues' do
expect do
post_graphql_mutation(mutation, current_user: current_user)
updatable_issues.each(&:reload)
end.to change { updatable_issues.flat_map(&:assignee_ids) }.from([]).to([current_user.id] * 2)
.and(change { updatable_issues.map(&:milestone_id) }.from([nil] * 2).to([milestone.id] * 2))
.and(change { updatable_issues.map(&:state) }.from(['opened'] * 2).to(['closed'] * 2))
.and(change { updatable_issues.flat_map(&:label_ids) }.from([label1.id] * 2).to([label2.id] * 2))
.and(
change { updatable_issues.map { |i| i.subscribed?(developer, project) } }.from([true] * 2).to([false] * 2)
)
expect(mutation_response).to include(
'updatedIssueCount' => updatable_issues.count
)
end
context 'when current user cannot read the specified project' do
let_it_be(:parent) { create(:project, :private) }
it 'returns a resource not found error' do
post_graphql_mutation(mutation, current_user: current_user)
expect(graphql_errors).to contain_exactly(
hash_including(
'message' => "The resource that you are attempting to access does not exist or you don't have " \
'permission to perform this action'
)
)
end
end
context 'when setting arguments to null or none' do
let(:additional_arguments) { { assignee_ids: [], milestone_id: nil } }
before do
updatable_issues.each do |issue|
issue.update!(assignees: [current_user], milestone: milestone)
end
end
it 'updates all issues' do
expect do
post_graphql_mutation(mutation, current_user: current_user)
updatable_issues.each(&:reload)
end.to change { updatable_issues.flat_map(&:assignee_ids) }.from([current_user.id] * 2).to([])
.and(change { updatable_issues.map(&:milestone_id) }.from([milestone.id] * 2).to([nil] * 2))
expect(mutation_response).to include(
'updatedIssueCount' => updatable_issues.count
)
end
end
end
context 'when update service returns an error' do
before do
allow_next_instance_of(Issuable::BulkUpdateService) do |update_service|
allow(update_service).to receive(:execute).and_return(
ServiceResponse.error(message: 'update error', http_status: 422) # rubocop:disable Gitlab/ServiceResponse
)
end
end
it 'returns an error message' do
post_graphql_mutation(mutation, current_user: current_user)
expect(graphql_data.dig('issuesBulkUpdate', 'errors')).to contain_exactly('update error')
end
end
context 'when trying to update more than the max allowed' do
before do
stub_const('Mutations::Issues::BulkUpdate::MAX_ISSUES', updatable_issues.count - 1)
end
it "restricts updating more than #{Mutations::Issues::BulkUpdate::MAX_ISSUES} issues at the same time" do
post_graphql_mutation(mutation, current_user: current_user)
expect(graphql_errors).to contain_exactly(
hash_including(
'message' =>
format(_('No more than %{max_issues} issues can be updated at the same time'), max_issues: max_issues)
)
)
end
end
end
|
