File: delete_spec.rb

package info (click to toggle)
gitlab 17.6.5-19
  • links: PTS, VCS
  • area: main
  • in suites: sid
  • size: 629,368 kB
  • sloc: ruby: 1,915,304; javascript: 557,307; sql: 60,639; xml: 6,509; sh: 4,567; makefile: 1,239; python: 406
file content (103 lines) | stat: -rw-r--r-- 3,150 bytes parent folder | download
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
# frozen_string_literal: true

require 'spec_helper'

RSpec.describe 'Destroying a model version', feature_category: :mlops do
  using RSpec::Parameterized::TableSyntax

  include GraphqlHelpers

  let_it_be_with_reload(:model_version) { create(:ml_model_versions) }
  let_it_be(:user) { create(:user) }

  let(:project) { model_version.project }
  let(:id) { model_version.to_global_id.to_s }

  let(:query) do
    <<~GQL
      modelVersion {
        id
      }
      errors
    GQL
  end

  let(:params) { { id: id } }
  let(:mutation) { graphql_mutation(:ml_model_version_delete, params, query) }
  let(:mutation_response) { graphql_mutation_response(:ml_model_version_delete) }

  shared_examples 'destroying the model' do
    it 'destroys model' do
      expect(::Ml::DestroyModelVersionService).to receive(:new).with(model_version, user).and_call_original

      expect { mutation_request }.to change { ::Ml::ModelVersion.count }.by(-1)
      expect(mutation_response['modelVersion']).to eq({ "id" => GitlabSchema.id_from_object(model_version).to_s })
    end

    it_behaves_like 'returning response status', :success
  end

  shared_examples 'model version was not found' do
    it 'does not delete the model' do
      expect(::Ml::DestroyModelVersionService).not_to receive(:new)

      expect { mutation_request }.to not_change { ::Ml::ModelVersion.count }

      expect(mutation_response["errors"]).to match_array(['Model version not found'])
    end

    it_behaves_like 'returning response status', :success
  end

  describe 'post graphql mutation' do
    subject(:mutation_request) { post_graphql_mutation(mutation, current_user: user) }

    context 'with valid id' do
      where(:user_role, :mutation_behavior) do
        :maintainer | 'destroying the model'
        :developer  | 'destroying the model'
        :reporter   | 'a mutation that returns a top-level access error'
        :guest      | 'a mutation that returns a top-level access error'
        :anonymous  | 'a mutation that returns a top-level access error'
      end

      with_them do
        let(:current_user) { user }

        before do
          project.public_send("add_#{user_role}", user) unless user_role == :anonymous
        end

        it_behaves_like params[:mutation_behavior]
      end
    end

    context 'with authorized user' do
      before do
        project.add_maintainer(user)
      end

      context 'with invalid id' do
        let(:params) do
          { id: "gid://gitlab/Ml::ModelVersion/#{non_existing_record_id}" }
        end

        it_behaves_like 'model version was not found'
      end

      context 'when an error occurs' do
        it 'returns the errors in the response' do
          allow_next_found_instance_of(::Ml::ModelVersion) do |model|
            allow(model).to receive(:destroy).and_return(nil)
            errors = ActiveModel::Errors.new(model).tap { |e| e.add(:id, 'some error') }
            allow(model).to receive(:errors).and_return(errors)
          end

          mutation_request

          expect(mutation_response['errors']).to match_array(['Id some error'])
        end
      end
    end
  end
end