1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe 'Deleting a model', feature_category: :mlops do
using RSpec::Parameterized::TableSyntax
include GraphqlHelpers
let_it_be_with_reload(:model) { create(:ml_models) }
let_it_be(:user) { create(:user) }
let(:project) { model.project }
let(:id) { model.to_global_id.to_s }
let(:query) do
<<~GQL
model {
id
}
errors
GQL
end
let(:params) { { project_path: project.full_path, id: id } }
let(:mutation) { graphql_mutation(:ml_model_delete, params, query) }
let(:mutation_response) { graphql_mutation_response(:ml_model_delete) }
shared_examples 'destroying the model' do
it 'destroys model' do
expect(::Ml::DestroyModelService).to receive(:new).with(model, user).and_call_original
expect { mutation_request }.to change { ::Ml::Model.count }.by(-1)
expect(mutation_response['model']).to eq({ "id" => id })
end
it_behaves_like 'returning response status', :success
end
shared_examples 'denying the mutation request' do
it 'does not delete the model' do
expect(::Ml::DestroyModelService).not_to receive(:new)
expect { mutation_request }.to not_change { ::Ml::Model.count }
expect(mutation_response).to be_nil
expect_graphql_errors_to_include("The resource that you are attempting to access does not exist or you don't " \
"have permission to perform this action")
end
it_behaves_like 'returning response status', :success
end
shared_examples 'model was not found' do
it 'does not delete the model' do
expect(::Ml::DestroyModelService).not_to receive(:new)
expect { mutation_request }.to not_change { ::Ml::Model.count }
expect(mutation_response["errors"]).to match_array(['Model not found'])
end
it_behaves_like 'returning response status', :success
end
describe 'post graphql mutation' do
subject(:mutation_request) { post_graphql_mutation(mutation, current_user: user) }
context 'with valid id' do
where(:user_role, :mutation_behavior) do
:developer | 'destroying the model'
:reporter | 'denying the mutation request'
:guest | 'denying the mutation request'
end
with_them do
before do
project.public_send("add_#{user_role}", user)
end
it_behaves_like params[:mutation_behavior]
end
end
context 'with authorized user' do
before do
project.add_maintainer(user)
end
context 'with invalid id' do
let(:params) { { project_path: project.full_path, id: "gid://gitlab/Ml::Model/#{non_existing_record_id}" } }
it_behaves_like 'model was not found'
end
context 'when an error occurs' do
it 'returns the errors in the response' do
allow_next_found_instance_of(::Ml::Model) do |model|
allow(model).to receive(:destroy).and_return(nil)
errors = ActiveModel::Errors.new(model).tap { |e| e.add(:id, 'some error') }
allow(model).to receive(:errors).and_return(errors)
end
mutation_request
expect(mutation_response['errors']).to match_array(['Id some error'])
end
end
end
end
end
|
