1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe 'getting project members information', feature_category: :groups_and_projects do
include GraphqlHelpers
let_it_be(:parent_group) { create(:group, :public) }
let_it_be(:parent_project) { create(:project, :public, group: parent_group) }
let_it_be(:user) { create(:user) }
let_it_be(:user_1) { create(:user, username: 'user', name: 'Same Name') }
let_it_be(:user_2) { create(:user, username: 'test', name: 'Same Name') }
before_all do
[user_1, user_2].each { |user| parent_group.add_guest(user) }
end
context 'when the request is correct' do
it_behaves_like 'a working graphql query' do
before do
fetch_members(project: parent_project)
end
end
it 'returns project members successfully' do
fetch_members(project: parent_project)
expect(graphql_errors).to be_nil
expect_array_response(user_1, user_2)
end
describe 'search argument' do
it 'returns members that match the search query' do
fetch_members(project: parent_project, args: { search: 'test' })
expect(graphql_errors).to be_nil
expect_array_response(user_2)
end
context 'when paginating' do
it 'returns correct results' do
fetch_members(project: parent_project, args: { search: 'Same Name', first: 1 })
expect_array_response(user_1)
next_cursor = graphql_data_at(:project, :projectMembers, :pageInfo, :endCursor)
fetch_members(project: parent_project, args: { search: 'Same Name', first: 1, after: next_cursor })
expect_array_response(user_2)
end
end
end
end
context 'member relations' do
let_it_be(:child_group) { create(:group, :public, parent: parent_group) }
let_it_be(:child_project) { create(:project, :public, group: child_group) }
let_it_be(:invited_group) { create(:group, :public) }
let_it_be(:child_user) { create(:user) }
let_it_be(:invited_user) { create(:user) }
let_it_be(:group_link) { create(:project_group_link, project: child_project, group: invited_group) }
before_all do
child_project.add_guest(child_user)
invited_group.add_guest(invited_user)
end
context 'when a member is invited only via email and current_user is a maintainer' do
before do
parent_project.add_maintainer(user)
create(:project_member, :invited, source: parent_project)
end
it 'returns null in the user field' do
fetch_members(project: parent_project, args: { relations: [:DIRECT] })
expect(graphql_errors).to be_nil
expect(graphql_data_at(:project, :project_members, :edges, :node)).to contain_exactly(
a_graphql_entity_for(user: a_graphql_entity_for(user)),
{ 'user' => nil }
)
end
end
it 'returns direct members' do
fetch_members(project: child_project, args: { relations: [:DIRECT] })
expect(graphql_errors).to be_nil
expect_array_response(child_user)
end
it 'returns invited members plus inherited members' do
fetch_members(project: child_project, args: { relations: [:INVITED_GROUPS] })
expect(graphql_errors).to be_nil
expect_array_response(invited_user, user_1, user_2)
end
it 'returns direct, inherited, descendant, and invited members' do
fetch_members(project: child_project, args: { relations: [:DIRECT, :INHERITED, :DESCENDANTS, :INVITED_GROUPS] })
expect(graphql_errors).to be_nil
expect_array_response(child_user, user_1, user_2, invited_user)
end
it 'returns an error for an invalid member relation' do
fetch_members(project: child_project, args: { relations: [:OBLIQUE] })
expect(graphql_errors.first).to include(
'path' => %w[query project projectMembers relations],
'message' => a_string_including('invalid value ([OBLIQUE])')
)
end
context 'when project is owned by a member' do
let_it_be(:project) { create(:project, namespace: user.namespace) }
before_all do
project.add_guest(child_user)
project.add_guest(invited_user)
end
it 'returns the owner in the response' do
fetch_members(project: project)
expect(graphql_errors).to be_nil
expect_array_response(user, child_user, invited_user)
end
end
end
context 'merge request interactions' do
let(:project_path) { var('ID!').with(parent_project.full_path) }
let(:mr_a) do
var('MergeRequestID!')
.with(global_id_of(create(:merge_request, source_project: parent_project, source_branch: 'branch-1')))
end
let(:mr_b) do
var('MergeRequestID!')
.with(global_id_of(create(:merge_request, source_project: parent_project, source_branch: 'branch-2')))
end
let(:interaction_query) do
<<~HEREDOC
edges {
node {
user {
id
}
mrA: #{query_graphql_field(:merge_request_interaction, { id: mr_a }, 'canMerge')}
}
}
HEREDOC
end
let(:interaction_b_query) do
<<~HEREDOC
edges {
node {
user {
id
}
mrA: #{query_graphql_field(:merge_request_interaction, { id: mr_a }, 'canMerge')}
mrB: #{query_graphql_field(:merge_request_interaction, { id: mr_b }, 'canMerge')}
}
}
HEREDOC
end
it 'avoids N+1 queries, when requesting multiple MRs' do
control_query = with_signature(
[project_path, mr_a],
graphql_query_for(
:project,
{ full_path: project_path },
query_graphql_field(:project_members, nil, interaction_query)
)
)
query_two = with_signature(
[project_path, mr_a, mr_b],
graphql_query_for(
:project,
{ full_path: project_path },
query_graphql_field(:project_members, nil, interaction_b_query)
)
)
control_count = ActiveRecord::QueryRecorder.new do
post_graphql(control_query, current_user: user, variables: [project_path, mr_a])
end
# two project members, neither of whom can merge
expect(can_merge(:mrA)).to eq [false, false]
expect do
post_graphql(query_two, current_user: user, variables: [project_path, mr_a, mr_b])
expect(can_merge(:mrA)).to eq [false, false]
expect(can_merge(:mrB)).to eq [false, false]
end.not_to exceed_query_limit(control_count)
end
it 'avoids N+1 queries, when more users are involved' do
new_user = create(:user)
query = with_signature(
[project_path, mr_a],
graphql_query_for(
:project,
{ full_path: project_path },
query_graphql_field(:project_members, nil, interaction_query)
)
)
control_count = ActiveRecord::QueryRecorder.new do
post_graphql(query, current_user: user, variables: [project_path, mr_a])
end
# two project members, neither of whom can merge
expect(can_merge(:mrA)).to eq [false, false]
parent_project.add_guest(new_user)
expect do
post_graphql(query, current_user: user, variables: [project_path, mr_a])
expect(can_merge(:mrA)).to eq [false, false, false]
end.not_to exceed_query_limit(control_count)
end
def can_merge(name)
graphql_data_at(:project, :project_members, :edges, :node, name, :can_merge)
end
end
context 'when unauthenticated' do
it 'returns members' do
fetch_members(current_user: nil, project: parent_project)
expect(graphql_errors).to be_nil
expect_array_response(user_1, user_2)
end
end
def fetch_members(project:, current_user: user, args: {})
post_graphql(members_query(project.full_path, args), current_user: current_user)
end
def members_query(group_path, args = {})
members_node = <<~NODE
edges {
node {
user {
id
}
}
}
pageInfo {
endCursor
}
NODE
graphql_query_for('project',
{ full_path: group_path },
[query_graphql_field('projectMembers', args, members_node)]
)
end
def expect_array_response(*items)
expect(response).to have_gitlab_http_status(:success)
members = graphql_data_at(:project, :project_members, :edges, :node, :user)
expect(members).to match_array(items.map { |u| a_graphql_entity_for(u) })
end
end
|