1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe 'Project.user_access_authorized_agents', feature_category: :deployment_management do
include GraphqlHelpers
let_it_be(:organization) { create(:group) }
let_it_be(:agent_management_project) { create(:project, :private, group: organization) }
let_it_be(:agent) { create(:cluster_agent, project: agent_management_project) }
let_it_be(:deployment_project) { create(:project, :private, group: organization) }
let_it_be(:deployment_developer) { create(:user, developer_of: deployment_project) }
let_it_be(:deployment_reporter) { create(:user, reporter_of: deployment_project) }
let(:user) { deployment_developer }
let(:query) do
%(
query {
project(fullPath: "#{deployment_project.full_path}") {
userAccessAuthorizedAgents {
nodes {
agent {
id
name
project {
name
}
}
config
}
}
}
}
)
end
subject { GitlabSchema.execute(query, context: { current_user: user }).as_json }
context 'with project authorization' do
let!(:user_access) { create(:agent_user_access_project_authorization, agent: agent, project: deployment_project) }
it 'returns the authorized agent' do
authorized_agents = subject.dig('data', 'project', 'userAccessAuthorizedAgents', 'nodes')
expect(authorized_agents.count).to eq(1)
authorized_agent = authorized_agents.first
expect(authorized_agent['agent']['id']).to eq(agent.to_global_id.to_s)
expect(authorized_agent['agent']['name']).to eq(agent.name)
expect(authorized_agent['config']).to eq({})
expect(authorized_agent['agent']['project']).to be_nil # User is not authorized to read other resources.
end
context 'when user is developer in the agent management project' do
before do
agent_management_project.add_developer(deployment_developer)
end
it 'returns the project information as well' do
authorized_agent = subject.dig('data', 'project', 'userAccessAuthorizedAgents', 'nodes').first
expect(authorized_agent['agent']['project']['name']).to eq(agent_management_project.name)
end
end
context 'when user is reporter' do
let(:user) { deployment_reporter }
it 'returns nothing' do
expect(subject['data']['project']['userAccessAuthorizedAgents']).to be_nil
end
end
end
context 'with group authorization' do
context "when the agent is authorized to the group the agent's project belongs to" do
# Authorize the agent to the organization, that the agent's project belongs to
let!(:user_access) { create(:agent_user_access_group_authorization, agent: agent, group: organization) }
before_all do
organization.add_developer(deployment_developer)
organization.add_reporter(deployment_reporter)
end
it 'returns the authorized agent' do
authorized_agents = subject.dig('data', 'project', 'userAccessAuthorizedAgents', 'nodes')
expect(authorized_agents.count).to eq(1)
authorized_agent = authorized_agents.first
expect(authorized_agent['agent']['id']).to eq(agent.to_global_id.to_s)
expect(authorized_agent['agent']['name']).to eq(agent.name)
expect(authorized_agent['config']).to eq({})
expect(authorized_agent['agent']['project']['name']).to eq(agent_management_project.name)
end
context 'when user is reporter' do
let(:user) { deployment_reporter }
it 'returns nothing' do
expect(subject['data']['project']['userAccessAuthorizedAgents']).to be_nil
end
end
end
context "when the agent is authorized to the sub-group" do
let_it_be(:sub_group) { create(:group, :private, parent: organization) }
# Authorize the agent to the sub-group of the organization, that the agent's project belongs to
let!(:user_access) { create(:agent_user_access_group_authorization, agent: agent, group: sub_group) }
before_all do
sub_group.add_developer(deployment_developer)
sub_group.add_reporter(deployment_reporter)
end
it 'returns empty authorized agents' do
authorized_agents = subject.dig('data', 'project', 'userAccessAuthorizedAgents', 'nodes')
expect(authorized_agents).to be_empty
end
context 'when user is reporter' do
let(:user) { deployment_reporter }
it 'returns nothing' do
expect(subject['data']['project']['userAccessAuthorizedAgents']).to be_nil
end
end
end
context "when two agents are authorized, one to the parent group and one to the sub-group" do
# Authorize the agent to the group that the agent's project belongs to
let!(:user_access) { create(:agent_user_access_group_authorization, agent: agent, group: organization) }
let_it_be(:sub_group) { create(:group, :private, parent: organization) }
let_it_be(:sub_group_project) { create(:project, :private, group: sub_group) }
let_it_be(:sub_group_agent) { create(:cluster_agent, project: sub_group_project) }
# Authorize the sub-group agent to the parent group
let!(:user_access_sub_group_agent) do
create(:agent_user_access_group_authorization, agent: sub_group_agent, group: organization)
end
before_all do
organization.add_developer(deployment_developer)
organization.add_reporter(deployment_reporter)
end
it 'returns both authorized agents' do
authorized_agents = subject.dig('data', 'project', 'userAccessAuthorizedAgents', 'nodes')
expect(authorized_agents.count).to eq(2)
authorized_agents.each do |authorized_agent|
expect(authorized_agent['agent']['id']).to be_in([agent.to_global_id.to_s, sub_group_agent.to_global_id.to_s])
end
end
context 'when user is reporter' do
let(:user) { deployment_reporter }
it 'returns nothing' do
expect(subject['data']['project']['userAccessAuthorizedAgents']).to be_nil
end
end
end
end
context 'when deployment project is not authorized to user_access to the agent' do
it 'returns empty' do
authorized_agents = subject.dig('data', 'project', 'userAccessAuthorizedAgents', 'nodes')
expect(authorized_agents).to be_empty
end
end
end
|
