1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe API::MergeRequestApprovals, feature_category: :source_code_management do
let_it_be(:user) { create(:user) }
let_it_be(:user2) { create(:user) }
let_it_be(:bot) { create(:user, :project_bot) }
let_it_be(:project) { create(:project, :public, :repository, creator: user, namespace: user.namespace) }
let_it_be(:approver) { create :user }
let(:merge_request) { create(:merge_request, :simple, author: user, source_project: project) }
describe 'GET :id/merge_requests/:merge_request_iid/approvals' do
it 'retrieves the approval status' do
project.add_developer(approver)
project.add_developer(create(:user))
create(:approval, user: approver, merge_request: merge_request)
get api("/projects/#{project.id}/merge_requests/#{merge_request.iid}/approvals", user)
expect(response).to have_gitlab_http_status(:ok)
end
context 'when merge request author has only guest access' do
it_behaves_like 'rejects user from accessing merge request info' do
let(:url) { "/projects/#{project.id}/merge_requests/#{merge_request.iid}/approvals" }
end
end
end
describe 'POST :id/merge_requests/:merge_request_iid/approve' do
context 'as a valid approver' do
let_it_be(:approver) { create(:user) }
before do
project.add_developer(approver)
project.add_developer(create(:user))
end
def approve(extra_params = {})
post api("/projects/#{project.id}/merge_requests/#{merge_request.iid}/approve", approver), params: extra_params
end
context 'when the sha param is not set' do
it 'approves the merge request' do
approve
expect(response).to have_gitlab_http_status(:created)
end
end
context 'when the sha param is correct' do
it 'approves the merge request' do
approve(sha: merge_request.diff_head_sha)
expect(response).to have_gitlab_http_status(:created)
end
end
context 'when the sha param is incorrect' do
it 'does not approve the merge request' do
approve(sha: merge_request.diff_head_sha.reverse)
expect(response).to have_gitlab_http_status(:conflict)
expect(merge_request.approvals).to be_empty
end
end
end
end
describe 'POST :id/merge_requests/:merge_request_iid/unapprove' do
context 'as a user who has approved the merge request' do
it 'unapproves the merge request' do
unapprover = create(:user)
project.add_developer(approver)
project.add_developer(unapprover)
project.add_developer(create(:user))
create(:approval, user: approver, merge_request: merge_request)
create(:approval, user: unapprover, merge_request: merge_request)
post api("/projects/#{project.id}/merge_requests/#{merge_request.iid}/unapprove", unapprover)
expect(response).to have_gitlab_http_status(:created)
end
it 'calls MergeRequests::UpdateReviewerStateService' do
unapprover = create(:user)
project.add_developer(approver)
project.add_developer(unapprover)
project.add_developer(create(:user))
create(:approval, user: approver, merge_request: merge_request)
create(:approval, user: unapprover, merge_request: merge_request)
expect_next_instance_of(
MergeRequests::UpdateReviewerStateService,
project: project, current_user: unapprover
) do |service|
expect(service).to receive(:execute).with(merge_request, 'unapproved')
end
post api("/projects/#{project.id}/merge_requests/#{merge_request.iid}/unapprove", unapprover)
expect(response).to have_gitlab_http_status(:created)
end
end
end
describe 'PUT :id/merge_requests/:merge_request_iid/reset_approvals' do
before do
merge_request.approvals.create!(user: user2)
create(:project_member, :maintainer, user: bot, source: project)
end
context 'for a bot user' do
context 'when the MR is merged' do
let(:merge_request) { create(:merge_request, :merged, :simple, author: user, source_project: project) }
it 'returns 401' do
put api("/projects/#{project.id}/merge_requests/#{merge_request.iid}/reset_approvals", bot)
merge_request.reload
expect(response).to have_gitlab_http_status(:unauthorized)
expect(merge_request.approvals.pluck(:user_id)).to contain_exactly(user2.id)
end
end
it 'clears approvals of the merge_request' do
put api("/projects/#{project.id}/merge_requests/#{merge_request.iid}/reset_approvals", bot)
merge_request.reload
expect(response).to have_gitlab_http_status(:accepted)
expect(merge_request.approvals).to be_empty
end
context 'when bot user approved the merge request' do
before do
merge_request.approvals.create!(user: bot)
end
it 'clears approvals of the merge_request' do
put api("/projects/#{project.id}/merge_requests/#{merge_request.iid}/reset_approvals", bot)
merge_request.reload
expect(response).to have_gitlab_http_status(:accepted)
expect(merge_request.approvals).to be_empty
end
end
end
context 'for users with non-bot roles' do
let(:human_user) { create(:user) }
[:add_owner, :add_maintainer, :add_developer, :add_guest].each do |role_method|
it 'returns 401' do
project.send(role_method, human_user)
put api("/projects/#{project.id}/merge_requests/#{merge_request.iid}/reset_approvals", human_user)
merge_request.reload
expect(response).to have_gitlab_http_status(:unauthorized)
expect(merge_request.approvals.pluck(:user_id)).to contain_exactly(user2.id)
end
end
end
context 'for bot-users from external namespaces' do
let_it_be(:external_bot) { create(:user, :project_bot) }
context 'for external group bot-user' do
before do
create(:group_member, :maintainer, user: external_bot, source: create(:group))
end
it 'returns 401' do
put api("/projects/#{project.id}/merge_requests/#{merge_request.iid}/reset_approvals", external_bot)
merge_request.reload
expect(response).to have_gitlab_http_status(:unauthorized)
expect(merge_request.approvals.pluck(:user_id)).to contain_exactly(user2.id)
end
end
context 'for external project bot-user' do
before do
create(:project_member, :maintainer, user: external_bot, source: create(:project))
end
it 'returns 401' do
put api("/projects/#{project.id}/merge_requests/#{merge_request.iid}/reset_approvals", external_bot)
merge_request.reload
expect(response).to have_gitlab_http_status(:unauthorized)
expect(merge_request.approvals.pluck(:user_id)).to contain_exactly(user2.id)
end
end
end
end
end
|
