1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe API::PackageFiles, feature_category: :package_registry do
let(:user) { create(:user) }
let(:project) { create(:project, :public) }
let(:package) { create(:maven_package, project: project) }
describe 'GET /projects/:id/packages/:package_id/package_files' do
let(:url) { "/projects/#{project.id}/packages/#{package.id}/package_files" }
shared_examples 'handling job token and returning' do |status:|
it "returns status #{status}" do
get api(url, job_token: job.token)
expect(response).to have_gitlab_http_status(status)
expect(response).to match_response_schema('public_api/v4/packages/package_files') if status == :ok
end
end
before do
project.add_developer(user)
end
context 'without the need for a license' do
context 'project is public' do
it 'returns 200' do
get api(url)
expect(response).to have_gitlab_http_status(:ok)
end
it 'returns 404 if package does not exist' do
get api("/projects/#{project.id}/packages/0/package_files")
expect(response).to have_gitlab_http_status(:not_found)
end
context 'with JOB-TOKEN auth' do
let(:job) { create(:ci_build, :running, user: user, project: project) }
it_behaves_like 'handling job token and returning', status: :ok
end
end
context 'project is private' do
let(:project) { create(:project, :private) }
it 'returns 404 for non authenticated user' do
get api(url)
expect(response).to have_gitlab_http_status(:not_found)
end
it 'returns 404 for a user without access to the project', :sidekiq_inline do
project.team.truncate
get api(url, user)
expect(response).to have_gitlab_http_status(:not_found)
end
it 'returns 200 and valid response schema' do
get api(url, user)
expect(response).to have_gitlab_http_status(:ok)
expect(response).to match_response_schema('public_api/v4/packages/package_files')
end
context 'with JOB-TOKEN auth' do
let(:job) { create(:ci_build, :running, user: user, project: project) }
context 'a non authenticated user' do
let(:user) { nil }
it_behaves_like 'handling job token and returning', status: :not_found
end
context 'a user without access to the project', :sidekiq_inline do
before do
project.team.truncate
end
it_behaves_like 'handling job token and returning', status: :forbidden
end
context 'a user with access to the project' do
it_behaves_like 'handling job token and returning', status: :ok
end
end
end
context 'with pagination params' do
let(:per_page) { 2 }
let(:package_files) { package.package_files.order(:id) }
let(:package_file_1) { package_files[0] }
let(:package_file_2) { package_files[1] }
let(:package_file_3) { package_files[2] }
context 'when viewing the first page' do
it 'returns first 2 packages' do
get api(url, user), params: { page: 1, per_page: per_page }
expect_paginated_array_response([package_file_1.id, package_file_2.id])
end
end
context 'viewing the second page' do
it 'returns the last package' do
get api(url, user), params: { page: 2, per_page: per_page }
expect_paginated_array_response([package_file_3.id])
end
end
end
context 'with package files pending destruction' do
let!(:package_file_pending_destruction) { create(:package_file, :pending_destruction, package: package) }
let(:package_file_ids) { json_response.map { |e| e['id'] } }
it 'does not return them' do
get api(url, user)
expect(package_file_ids).not_to include(package_file_pending_destruction.id)
end
end
end
end
describe 'DELETE /projects/:id/packages/:package_id/package_files/:package_file_id' do
let(:package_file_id) { package.package_files.first.id }
let(:url) { "/projects/#{project.id}/packages/#{package.id}/package_files/#{package_file_id}" }
subject(:api_request) { delete api(url, user) }
shared_examples 'handling job token and returning' do |status:|
it "returns status #{status}", :aggregate_failures do
if status == :no_content
expect { api_request }.to change { package.package_files.pending_destruction.count }.by(1)
else
expect { api_request }.not_to change { package.package_files.pending_destruction.count }
end
expect(response).to have_gitlab_http_status(status)
end
end
context 'project is public' do
context 'without user' do
let(:user) { nil }
it 'returns 403 for non authenticated user', :aggregate_failures do
expect { api_request }.not_to change { package.package_files.pending_destruction.count }
expect(response).to have_gitlab_http_status(:forbidden)
end
end
context 'with JOB-TOKEN auth' do
subject(:api_request) { delete api(url, job_token: job.token) }
let(:job) { create(:ci_build, :running, user: user, project: project) }
it_behaves_like 'handling job token and returning', status: :forbidden
end
it 'returns 403 for a user without access to the project', :aggregate_failures do
expect { api_request }.not_to change { package.package_files.pending_destruction.count }
expect(response).to have_gitlab_http_status(:forbidden)
end
end
context 'project is private' do
let_it_be_with_refind(:project) { create(:project, :private) }
it 'returns 404 for a user without access to the project', :aggregate_failures do
expect { api_request }.not_to change { package.package_files.pending_destruction.count }
expect(response).to have_gitlab_http_status(:not_found)
end
it 'returns 403 for a user without enough permissions', :aggregate_failures do
project.add_developer(user)
expect { api_request }.not_to change { package.package_files.pending_destruction.count }
expect(response).to have_gitlab_http_status(:forbidden)
end
it 'returns 204', :aggregate_failures do
project.add_maintainer(user)
expect { api_request }.to change { package.package_files.pending_destruction.count }.by(1)
expect(response).to have_gitlab_http_status(:no_content)
end
context 'without user' do
let(:user) { nil }
it 'returns 404 for non authenticated user', :aggregate_failures do
expect { api_request }.not_to change { package.package_files.pending_destruction.count }
expect(response).to have_gitlab_http_status(:not_found)
end
end
context 'invalid file' do
let(:url) { "/projects/#{project.id}/packages/#{package.id}/package_files/999999" }
it 'returns 404 when the package file does not exist', :aggregate_failures do
project.add_maintainer(user)
expect { api_request }.not_to change { package.package_files.pending_destruction.count }
expect(response).to have_gitlab_http_status(:not_found)
end
end
context 'with package file pending destruction' do
let!(:package_file_id) { create(:package_file, :pending_destruction, package: package).id }
before do
project.add_maintainer(user)
end
it 'can not be accessed', :aggregate_failures do
expect { api_request }.not_to change { package.package_files.pending_destruction.count }
expect(response).to have_gitlab_http_status(:not_found)
end
end
context 'with JOB-TOKEN auth' do
subject(:api_request) { delete api(url, job_token: job.token) }
let(:job) { create(:ci_build, :running, user: user, project: project) }
let_it_be_with_refind(:project) { create(:project, :private) }
context 'a user without access to the project' do
it_behaves_like 'handling job token and returning', status: :forbidden
end
context 'a user without enough permissions' do
before do
project.add_developer(user)
end
it_behaves_like 'handling job token and returning', status: :forbidden
end
context 'a user with the right permissions' do
before do
project.add_maintainer(user)
end
it_behaves_like 'handling job token and returning', status: :no_content
end
end
end
end
end
|
