1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe API::ProjectMilestones, feature_category: :team_planning do
let_it_be(:user) { create(:user) }
let_it_be_with_reload(:project) { create(:project, namespace: user.namespace, reporters: user) }
let_it_be(:closed_milestone) { create(:closed_milestone, project: project, title: 'version1', description: 'closed milestone') }
let_it_be(:route) { "/projects/#{project.id}/milestones" }
let_it_be(:milestone) do
create(:milestone, project: project, title: 'version2', description: 'open milestone', updated_at: 5.days.ago)
end
let(:params) { {} }
it_behaves_like 'group and project milestones', "/projects/:id/milestones"
shared_examples 'listing all milestones' do
it 'returns correct list of milestones' do
get api(route, user), params: params
expect(response).to have_gitlab_http_status(:ok)
expect(json_response.size).to eq(milestones.size)
expect(json_response.map { |entry| entry["id"] }).to match_array(milestones.map(&:id))
end
end
describe 'GET /projects/:id/milestones' do
let_it_be(:ancestor_group) { create(:group, :private) }
let_it_be(:group) { create(:group, :private, parent: ancestor_group) }
let_it_be(:ancestor_group_milestone) { create(:milestone, group: ancestor_group, updated_at: 1.day.ago) }
let_it_be(:group_milestone) { create(:milestone, group: group, updated_at: 3.days.ago) }
context 'when project parent is a namespace' do
let(:milestones) { [milestone, closed_milestone] }
it_behaves_like 'listing all milestones'
context 'when include_ancestors is true' do
let(:params) { { include_ancestors: true } }
it_behaves_like 'listing all milestones'
end
context 'when deprecated include_parent_milestones is true' do
let(:params) { { include_parent_milestones: true } }
it_behaves_like 'listing all milestones'
end
context 'when both include_parent_milestones and include_ancestors are specified' do
let(:params) { { include_ancestors: true, include_parent_milestones: true } }
it 'returns 400' do
get api(route, user), params: params
expect(response).to have_gitlab_http_status(:bad_request)
end
end
end
context 'when project parent is a group' do
before_all do
project.update!(namespace: group)
end
context 'when include_ancestors is true' do
let(:params) { { include_ancestors: true } }
let(:milestones) { [group_milestone, ancestor_group_milestone, milestone, closed_milestone] }
it_behaves_like 'listing all milestones'
context 'when iids param is present' do
let(:params) { { include_ancestors: true, iids: [group_milestone.iid] } }
it_behaves_like 'listing all milestones'
end
context 'when user is not a member of the private project' do
let(:external_user) { create(:user) }
it 'returns a 404 error' do
get api(route, external_user), params: params
expect(response).to have_gitlab_http_status(:not_found)
end
end
context 'when updated_before param is present' do
let(:params) { { updated_before: 12.hours.ago.iso8601, include_ancestors: true } }
it_behaves_like 'listing all milestones' do
let(:milestones) { [group_milestone, ancestor_group_milestone, milestone] }
end
end
context 'when updated_after param is present' do
let(:params) { { updated_after: 2.days.ago.iso8601, include_ancestors: true } }
it_behaves_like 'listing all milestones' do
let(:milestones) { [ancestor_group_milestone, closed_milestone] }
end
end
end
context 'when updated_before param is present' do
let(:params) { { updated_before: 12.hours.ago.iso8601 } }
it_behaves_like 'listing all milestones' do
let(:milestones) { [milestone] }
end
end
context 'when updated_after param is present' do
let(:params) { { updated_after: 2.days.ago.iso8601 } }
it_behaves_like 'listing all milestones' do
let(:milestones) { [closed_milestone] }
end
end
end
end
describe 'DELETE /projects/:id/milestones/:milestone_id' do
let(:guest) { create(:user) }
let(:reporter) { create(:user) }
before do
project.add_reporter(reporter)
end
it 'returns 404 response when the project does not exist' do
delete api("/projects/0/milestones/#{milestone.id}", user)
expect(response).to have_gitlab_http_status(:not_found)
end
it 'returns 404 response when the milestone does not exist' do
delete api("/projects/#{project.id}/milestones/0", user)
expect(response).to have_gitlab_http_status(:not_found)
end
it "returns 404 from guest user deleting a milestone" do
delete api("/projects/#{project.id}/milestones/#{milestone.id}", guest)
expect(response).to have_gitlab_http_status(:not_found)
end
end
describe 'PUT /projects/:id/milestones/:milestone_id to test observer on close' do
it 'creates an activity event when a milestone is closed' do
path = "/projects/#{project.id}/milestones/#{milestone.id}"
expect do
put api(path, user), params: { state_event: 'close' }
end.to change(Event, :count).by(1)
end
end
describe 'POST /projects/:id/milestones/:milestone_id/promote' do
let(:group) { create(:group) }
before do
project.update!(namespace: group)
end
context 'when user does not have permission to promote milestone' do
before do
group.add_guest(user)
end
it 'returns 403' do
post api("/projects/#{project.id}/milestones/#{milestone.id}/promote", user)
expect(response).to have_gitlab_http_status(:forbidden)
end
end
context 'when user has permission' do
before do
group.add_developer(user)
end
it 'returns 200' do
post api("/projects/#{project.id}/milestones/#{milestone.id}/promote", user)
expect(response).to have_gitlab_http_status(:ok)
expect(group.milestones.first.title).to eq(milestone.title)
end
it 'returns 200 for closed milestone' do
post api("/projects/#{project.id}/milestones/#{closed_milestone.id}/promote", user)
expect(response).to have_gitlab_http_status(:ok)
expect(group.milestones.first.title).to eq(closed_milestone.title)
end
end
context 'when no such resource' do
before do
group.add_developer(user)
end
it 'returns 404 response when the project does not exist' do
post api("/projects/0/milestones/#{milestone.id}/promote", user)
expect(response).to have_gitlab_http_status(:not_found)
end
it 'returns 404 response when the milestone does not exist' do
post api("/projects/#{project.id}/milestones/0/promote", user)
expect(response).to have_gitlab_http_status(:not_found)
end
end
context 'when project does not belong to group' do
before do
project.update!(namespace: user.namespace)
end
it 'returns 403' do
post api("/projects/#{project.id}/milestones/#{milestone.id}/promote", user)
expect(response).to have_gitlab_http_status(:forbidden)
end
end
end
end
|
