1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe API::ProjectPackagesProtectionRules, :aggregate_failures, feature_category: :package_registry do
let_it_be(:project) { create(:project, :private) }
let_it_be(:other_project) { create(:project, :private) }
let_it_be(:protection_rule) { create(:package_protection_rule, project: project) }
let_it_be(:protection_rule_id) { protection_rule.id }
let_it_be(:maintainer) { create(:user, maintainer_of: [project, other_project]) }
let_it_be(:api_user) { create(:user) }
let_it_be(:invalid_token) { 'invalid-token123' }
let_it_be(:headers_with_invalid_token) { { Gitlab::Auth::AuthFinders::PRIVATE_TOKEN_HEADER => invalid_token } }
let(:path) { 'packages/protection/rules' }
let(:url) { "/projects/#{project.id}/#{path}" }
let(:params) do
{ package_name_pattern: '@my-new-scope/my-package-*',
package_type: protection_rule.package_type,
minimum_access_level_for_push: protection_rule.minimum_access_level_for_push }
end
shared_examples 'rejecting project packages protection rules request when enough permissions' do
it_behaves_like 'rejecting protection rules request when invalid project'
end
describe 'GET /projects/:id/packages/protection/rules' do
let(:url) { "/projects/#{project.id}/packages/protection/rules" }
subject(:get_package_rules) { get(api(url, api_user)) }
it_behaves_like 'rejecting project protection rules request when not enough permissions'
context 'for maintainer' do
let(:api_user) { maintainer }
let_it_be(:other_package_protection_rule) do
create(:package_protection_rule, project: project, package_name_pattern: "@my-scope/my-package-*")
end
it 'gets the package protection rules' do
get_package_rules
expect(response).to have_gitlab_http_status(:ok)
expect(json_response.count).to eq(2)
end
it_behaves_like 'rejecting project packages protection rules request when enough permissions'
end
context 'with invalid token' do
subject(:get_package_rules) { get(api(url), headers: headers_with_invalid_token) }
it_behaves_like 'returning response status', :unauthorized
end
end
describe 'POST /projects/:id/packages/protection/rules' do
let(:url) { "/projects/#{project.id}/packages/protection/rules" }
subject(:post_package_rule) { post(api(url, api_user), params: params) }
it_behaves_like 'rejecting project protection rules request when not enough permissions'
context 'for maintainer' do
let(:api_user) { maintainer }
it 'creates a package protection rule' do
expect { post_package_rule }.to change { Packages::Protection::Rule.count }.by(1)
expect(response).to have_gitlab_http_status(:created)
end
context 'with invalid package_type' do
before do
params[:package_type] = "not in enum"
end
it 'does not create a package protection rule' do
expect { post_package_rule }.to not_change(Packages::Protection::Rule, :count)
expect(response).to have_gitlab_http_status(:bad_request)
end
end
context 'with invalid minimum_access_level_for_push' do
before do
params[:minimum_access_level_for_push] = "not in enum"
end
it 'does not create a package protection rule' do
expect { post_package_rule }.to not_change(Packages::Protection::Rule, :count)
expect(response).to have_gitlab_http_status(:bad_request)
end
end
context 'with already existing package_name_pattern' do
before do
params[:package_name_pattern] = protection_rule.package_name_pattern
end
it 'does not create a package protection rule' do
expect { post_package_rule }.to not_change(Packages::Protection::Rule, :count)
expect(response).to have_gitlab_http_status(:unprocessable_entity)
end
end
it_behaves_like 'rejecting project packages protection rules request when enough permissions'
end
context 'with invalid token' do
subject(:post_package_rules) { post(api(url), headers: headers_with_invalid_token, params: params) }
it_behaves_like 'returning response status', :unauthorized
end
end
describe 'PATCH /projects/:id/packages/protection/rules/:package_protection_rule_id' do
let(:path) { "packages/protection/rules/#{protection_rule_id}" }
subject(:patch_package_rule) { patch(api(url, api_user), params: params) }
it_behaves_like 'rejecting project protection rules request when not enough permissions'
context 'for maintainer' do
let(:api_user) { maintainer }
let_it_be(:changed_scope) { '@my-changed-scope/my-package-*' }
context 'with full changeset' do
before do
params[:package_name_pattern] = changed_scope
end
it 'updates a package protection rule' do
patch_package_rule
expect(response).to have_gitlab_http_status(:ok)
expect(json_response["package_name_pattern"]).to eq(changed_scope)
expect(json_response["package_type"]).to eq(protection_rule.package_type)
end
end
context 'with a single change' do
let(:params) { { package_name_pattern: changed_scope } }
it 'updates a package protection rule' do
patch_package_rule
expect(response).to have_gitlab_http_status(:ok)
expect(json_response["package_name_pattern"]).to eq(changed_scope)
end
end
context 'with invalid package_type' do
before do
params[:package_type] = "not in enum"
end
it_behaves_like 'returning response status', :bad_request
end
context 'with invalid minimum_access_level_for_push' do
before do
params[:minimum_access_level_for_push] = "not in enum"
end
it_behaves_like 'returning response status', :bad_request
end
context 'with already existing package_name_pattern' do
before do
other_package_protection_rule = create(:package_protection_rule, project: project,
package_name_pattern: "@my-scope/my-package-*")
params[:package_name_pattern] = other_package_protection_rule.package_name_pattern
end
it_behaves_like 'returning response status', :unprocessable_entity
end
it_behaves_like 'rejecting protection rules request when handling rule ids'
it_behaves_like 'rejecting project packages protection rules request when enough permissions'
end
context 'with invalid token' do
subject(:patch_package_rules) { patch(api(url), headers: headers_with_invalid_token, params: params) }
it_behaves_like 'returning response status', :unauthorized
end
end
describe 'DELETE /projects/:id/packages/protection/rules/:package_protection_rule_id' do
let(:path) { "packages/protection/rules/#{protection_rule_id}" }
subject(:destroy_package_rule) { delete(api(url, api_user)) }
it_behaves_like 'rejecting project protection rules request when not enough permissions'
context 'for maintainer' do
let(:api_user) { maintainer }
it 'deletes the package protection rule' do
destroy_package_rule
expect do
Packages::Protection::Rule.find(protection_rule.id)
end.to raise_error(ActiveRecord::RecordNotFound)
expect(response).to have_gitlab_http_status(:no_content)
end
it_behaves_like 'rejecting protection rules request when handling rule ids'
it_behaves_like 'rejecting project packages protection rules request when enough permissions'
end
context 'with invalid token' do
subject(:delete_package_rules) { delete(api(url), headers: headers_with_invalid_token) }
it_behaves_like 'returning response status', :unauthorized
end
end
end
|
