1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Organizations::GroupsController, feature_category: :cell do
let_it_be(:organization) { create(:organization) }
describe 'GET #new' do
subject(:gitlab_request) { get new_groups_organization_path(organization) }
context 'when the user is not signed in' do
it_behaves_like 'organization - redirects to sign in page'
context 'when `ui_for_organizations` feature flag is disabled' do
before do
stub_feature_flags(ui_for_organizations: false)
end
it_behaves_like 'organization - redirects to sign in page'
end
end
context 'when the user is signed in' do
let_it_be(:user) { create(:user) }
before do
sign_in(user)
end
context 'with no association to an organization' do
it_behaves_like 'organization - not found response'
it_behaves_like 'organization - action disabled by `ui_for_organizations` feature flag'
end
context 'as as admin', :enable_admin_mode do
let_it_be(:user) { create(:admin) }
it_behaves_like 'organization - successful response'
it_behaves_like 'organization - action disabled by `ui_for_organizations` feature flag'
end
context 'as an organization user' do
let_it_be(:organization_user) { create(:organization_user, organization: organization, user: user) }
it_behaves_like 'organization - successful response'
it_behaves_like 'organization - action disabled by `ui_for_organizations` feature flag'
end
end
end
describe 'POST #create' do
let_it_be(:params) { { group: { name: 'test-group', path: 'test-group' } } }
let_it_be(:user) { create(:user) }
let_it_be(:organization) { create(:organization) }
subject(:gitlab_request) { post groups_organization_path(organization), params: params, as: :json }
context 'when the user is signed in' do
before do
sign_in(user)
end
it_behaves_like 'organization - action disabled by `ui_for_organizations` feature flag'
context 'when current user can create group inside the organization' do
let_it_be(:organization_user) { create(:organization_user, organization: organization, user: user) }
it 'returns the created group' do
gitlab_request
expect(response).to have_gitlab_http_status(:success)
expect(json_response['path']).to eq('test-group')
end
end
context 'when current user cannot create group inside the organization' do
it 'returns the error' do
gitlab_request
permission_error_message = "You don't have permission to create a group in the provided organization."
error = { "organization_id" => [permission_error_message] }
expect(json_response['message']).to eq(error)
expect(response).to have_gitlab_http_status(:unprocessable_entity)
end
end
end
context 'when the user is not signed in' do
it 'returns unauthorized' do
gitlab_request
expect(response).to have_gitlab_http_status(:unauthorized)
end
end
end
describe 'GET #edit' do
let_it_be(:group) { create(:group, organization: organization) }
context 'when group exists' do
subject(:gitlab_request) do
get edit_groups_organization_path(organization, id: group.to_param)
end
context 'when the user is not signed in' do
it_behaves_like 'organization - redirects to sign in page'
context 'when `ui_for_organizations` feature flag is disabled' do
before do
stub_feature_flags(ui_for_organizations: false)
end
it_behaves_like 'organization - redirects to sign in page'
end
end
context 'when the user is signed in' do
let_it_be(:user) { create(:user) }
before do
sign_in(user)
end
context 'as as admin', :enable_admin_mode do
let_it_be(:user) { create(:admin) }
it_behaves_like 'organization - successful response'
it_behaves_like 'organization - action disabled by `ui_for_organizations` feature flag'
end
context 'as a group owner' do
before_all do
group.add_owner(user)
end
it_behaves_like 'organization - successful response'
it_behaves_like 'organization - action disabled by `ui_for_organizations` feature flag'
end
context 'as a user that is not an owner' do
it_behaves_like 'organization - not found response'
it_behaves_like 'organization - action disabled by `ui_for_organizations` feature flag'
end
context 'as an organization owner' do
let_it_be(:user) do
organization_user = create(:organization_owner, organization: organization)
organization_user.user
end
it_behaves_like 'organization - successful response'
it_behaves_like 'organization - action disabled by `ui_for_organizations` feature flag'
end
end
end
context 'when group is not in organization' do
let_it_be(:user) { create(:user) }
let_it_be(:organization_2) { create(:organization) }
subject(:gitlab_request) do
get edit_groups_organization_path(organization_2, id: group.to_param)
end
before_all do
group.add_owner(user)
end
before do
sign_in(user)
end
it_behaves_like 'organization - not found response'
it_behaves_like 'organization - action disabled by `ui_for_organizations` feature flag'
end
context 'when group does not exist' do
subject(:gitlab_request) do
get edit_groups_organization_path(organization, id: 'group-that-does-not-exist')
end
context 'when the user is not signed in' do
it_behaves_like 'organization - redirects to sign in page'
end
context 'when the user is signed in' do
let_it_be(:user) { create(:user) }
before do
sign_in(user)
end
it_behaves_like 'organization - not found response'
end
end
end
describe 'DELETE #destroy' do
let_it_be(:group) { create(:group, organization: organization) }
shared_examples 'deletes the group' do
specify do
expect_next_instance_of(Groups::DestroyService) do |instance|
expect(instance).to receive(:async_execute)
end
gitlab_request
end
end
shared_examples 'unable to delete the group' do
specify do
expect_any_instance_of(Groups::DestroyService) do |instance|
expect(instance).not_to receive(:async_execute)
end
gitlab_request
end
end
context 'when group exists' do
subject(:gitlab_request) do
delete groups_organization_path(organization, id: group.to_param)
end
context 'when the user is not signed in' do
it_behaves_like 'organization - redirects to sign in page'
context 'when `ui_for_organizations` feature flag is disabled' do
before do
stub_feature_flags(ui_for_organizations: false)
end
it_behaves_like 'organization - redirects to sign in page'
it_behaves_like 'unable to delete the group'
end
end
context 'when the user is signed in' do
let_it_be(:user) { create(:user) }
before do
sign_in(user)
end
context 'as as admin', :enable_admin_mode do
let_it_be(:user) { create(:admin) }
it_behaves_like 'organization - successful response'
it_behaves_like 'organization - action disabled by `ui_for_organizations` feature flag'
it_behaves_like 'deletes the group'
end
context 'as a group owner' do
before_all do
group.add_owner(user)
end
it_behaves_like 'organization - successful response'
it_behaves_like 'organization - action disabled by `ui_for_organizations` feature flag'
it_behaves_like 'deletes the group'
context 'when destroy service raises DestroyError' do
let(:error_message) { "Error deleting group" }
before do
allow_next_instance_of(Groups::DestroyService) do |instance|
allow(instance).to receive(:async_execute)
.and_raise(Groups::DestroyService::DestroyError, error_message)
end
end
it 'returns the error message' do
gitlab_request
expect(response).to have_gitlab_http_status(:unprocessable_entity)
expect(json_response['message']).to eq(error_message)
end
end
end
context 'as a user that is not an owner' do
it_behaves_like 'organization - not found response'
it_behaves_like 'organization - action disabled by `ui_for_organizations` feature flag'
it_behaves_like 'unable to delete the group'
end
context 'as an organization owner' do
let_it_be(:user) do
organization_user = create(:organization_owner, organization: organization)
organization_user.user
end
it_behaves_like 'organization - successful response'
it_behaves_like 'organization - action disabled by `ui_for_organizations` feature flag'
it_behaves_like 'deletes the group'
end
end
end
context 'when group is not in organization' do
let_it_be(:user) { create(:user) }
let_it_be(:organization_2) { create(:organization) }
subject(:gitlab_request) do
delete groups_organization_path(organization_2, id: group.to_param)
end
before_all do
group.add_owner(user)
end
before do
sign_in(user)
end
it_behaves_like 'organization - not found response'
it_behaves_like 'organization - action disabled by `ui_for_organizations` feature flag'
it_behaves_like 'unable to delete the group'
end
context 'when group does not exist' do
subject(:gitlab_request) do
delete groups_organization_path(organization, id: 'group-that-does-not-exist')
end
context 'when the user is not signed in' do
it_behaves_like 'organization - redirects to sign in page'
end
context 'when the user is signed in' do
let_it_be(:user) { create(:user) }
before do
sign_in(user)
end
it_behaves_like 'organization - not found response'
it_behaves_like 'unable to delete the group'
end
end
end
end
|
