1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Projects::CommitController, feature_category: :source_code_management do
let_it_be(:project) { create(:project, :repository) }
let_it_be(:user) { project.owner }
describe '#rapid_diffs' do
let_it_be(:sha) { "913c66a37b4a45b9769037c55c2d238bd0942d2e" }
let_it_be(:commit) { project.commit_by(oid: sha) }
let_it_be(:diff_view) { :inline }
let(:params) do
{
rapid_diffs: 'true',
view: diff_view
}
end
subject(:send_request) { get project_commit_path(project, commit, params: params) }
before do
sign_in(user)
end
context 'when the feature flag rapid_diffs is disabled' do
before do
stub_feature_flags(rapid_diffs: false)
end
it 'returns 404' do
send_request
expect(response).to have_gitlab_http_status(:not_found)
end
it 'uses show action when rapid_diffs query parameter doesnt exist' do
get project_commit_path(project, commit)
expect(response).to have_gitlab_http_status(:ok)
expect(response.body).to include('data-page="projects:commit:show"')
end
end
it 'returns 200' do
send_request
expect(response).to have_gitlab_http_status(:ok)
expect(response.body).to include('data-page="projects:commit:rapid_diffs"')
end
it 'uses show action when rapid_diffs query parameter doesnt exist' do
get project_commit_path(project, commit)
expect(response).to have_gitlab_http_status(:ok)
expect(response.body).to include('data-page="projects:commit:show"')
end
it 'shows only first 5 files' do
send_request
expect(response.body.scan('<diff-file ').size).to eq(5)
end
it 'renders rapid_diffs template' do
send_request
expect(assigns(:diffs)).to be_a(Gitlab::Diff::FileCollection::Commit)
expect(assigns(:environment)).to be_nil
expect(response).to render_template(:rapid_diffs)
end
context 'for stream_url' do
it 'returns stream_url with offset' do
send_request
url = "/#{project.full_path}/-/commit/#{commit.id}/diffs_stream?offset=5&view=inline"
expect(assigns(:stream_url)).to eq(url)
end
context 'when view is set to parallel' do
let_it_be(:diff_view) { :parallel }
it 'returns stream_url with parallel view' do
send_request
url = "/#{project.full_path}/-/commit/#{commit.id}/diffs_stream?offset=5&view=parallel"
expect(assigns(:stream_url)).to eq(url)
end
end
end
end
describe 'GET #diff_files' do
let(:master_pickable_sha) { '7d3b0f7cff5f37573aea97cebfd5692ea1689924' }
let(:format) { :html }
let(:params) do
{
namespace_id: project.namespace,
project_id: project,
id: master_pickable_sha,
format: format
}
end
before_all do
project.add_maintainer(user)
end
context 'without expanded parameter' do
before do
sign_in(user)
end
it 'does not rate limit the endpoint' do
get diff_files_namespace_project_commit_url(params)
expect(::Gitlab::ApplicationRateLimiter)
.not_to receive(:throttled?).with(:expanded_diff_files, scope: user)
end
end
context 'with expanded parameter' do
before do
params[:expanded] = 1
end
context 'with signed in user' do
it_behaves_like 'rate limited endpoint', rate_limit_key: :expanded_diff_files do
let_it_be(:current_user) { user }
before do
sign_in current_user
end
def request
get diff_files_namespace_project_commit_url(params), params: { scope: user }
end
end
end
context 'without a signed in user' do
it_behaves_like 'rate limited endpoint', rate_limit_key: :expanded_diff_files do
let_it_be(:project) { create(:project, :public, :repository) }
let(:request_ip) { '1.2.3.4' }
def request
get diff_files_namespace_project_commit_url(params),
params: { scope: request_ip }, env: { REMOTE_ADDR: request_ip }
end
end
end
end
end
end
|
