1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Projects::Ml::ModelVersionsController, feature_category: :mlops do
let_it_be(:project) { create(:project) }
let_it_be(:another_project) { create(:project) }
let_it_be(:user) { project.first_owner }
let_it_be(:model) { create(:ml_models, :with_versions, project: project) }
let_it_be(:version) { model.versions.first }
let(:read_model_registry) { true }
let(:write_model_registry) { true }
before do
allow(Ability).to receive(:allowed?).and_call_original
allow(Ability).to receive(:allowed?)
.with(user, :read_model_registry, project)
.and_return(read_model_registry)
allow(Ability).to receive(:allowed?)
.with(user, :write_model_registry, project)
.and_return(write_model_registry)
sign_in(user)
end
describe 'show' do
let(:model_id) { model.id }
let(:version_id) { version.id }
let(:request_project) { model.project }
subject(:show_request) do
show_model_version
response
end
before do
show_request
end
it 'renders the template' do
is_expected.to render_template('projects/ml/model_versions/show')
end
it 'fetches the correct model_version' do
show_request
expect(assigns(:model)).to eq(model)
expect(assigns(:model_version)).to eq(version)
end
context 'when version id does not exist' do
let(:version_id) { non_existing_record_id }
it { is_expected.to have_gitlab_http_status(:not_found) }
end
context 'when version and model id are correct but project is not' do
let(:request_project) { another_project }
it { is_expected.to have_gitlab_http_status(:not_found) }
end
context 'when user does not have access' do
let(:read_model_registry) { false }
it { is_expected.to have_gitlab_http_status(:not_found) }
end
end
describe 'edit' do
let(:model_id) { model.id }
let(:version_id) { version.id }
let(:request_project) { model.project }
subject(:edit_request) do
edit_model_version
response
end
before do
edit_request
end
it 'renders the template' do
is_expected.to render_template('projects/ml/model_versions/edit')
end
it 'fetches the correct model_version' do
edit_request
expect(assigns(:model)).to eq(model)
expect(assigns(:model_version)).to eq(version)
end
context 'when version id does not exist' do
let(:version_id) { non_existing_record_id }
it { is_expected.to have_gitlab_http_status(:not_found) }
end
context 'when version and model id are correct but project is not' do
let(:request_project) { another_project }
it { is_expected.to have_gitlab_http_status(:not_found) }
end
context 'when user does not have access' do
let(:read_model_registry) { false }
it { is_expected.to have_gitlab_http_status(:not_found) }
end
context 'when user does not have write access' do
let(:write_model_registry) { false }
it { is_expected.to have_gitlab_http_status(:not_found) }
end
end
describe 'new' do
let(:model_id) { model.id }
let(:request_project) { model.project }
subject(:show_request) do
response
end
before do
new_model_version
show_request
end
it 'renders the template' do
is_expected.to render_template('projects/ml/model_versions/new')
end
it 'fetches the correct model' do
show_request
expect(assigns(:model)).to eq(model)
end
context 'when model id does not exist' do
let(:model_id) { non_existing_record_id }
it { is_expected.to have_gitlab_http_status(:not_found) }
end
context 'when model id are correct but project is not' do
let(:request_project) { another_project }
it { is_expected.to have_gitlab_http_status(:not_found) }
end
context 'when user does not have access' do
let(:read_model_registry) { false }
it { is_expected.to have_gitlab_http_status(:not_found) }
end
context 'when user does not have write access' do
let(:write_model_registry) { false }
it { is_expected.to have_gitlab_http_status(:not_found) }
end
end
private
def show_model_version
get project_ml_model_version_path(request_project, model_id, version_id)
end
def edit_model_version
get edit_project_ml_model_version_path(request_project, model_id, version_id)
end
def new_model_version
get new_project_ml_model_version_path(request_project, model_id)
end
end
|
