1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Projects::ServiceDeskController, feature_category: :service_desk do
let_it_be_with_reload(:project) do
create(:project, :private, :custom_repo,
service_desk_enabled: true,
files: { '.gitlab/issue_templates/service_desk.md' => 'template' })
end
let_it_be(:user) { create(:user, maintainer_of: project) }
before do
allow(Gitlab::Email::IncomingEmail).to receive(:enabled?).and_return(true)
allow(Gitlab::Email::IncomingEmail).to receive(:supports_wildcard?).and_return(true)
sign_in(user)
end
describe 'GET #show' do
it 'returns service_desk JSON data' do
get project_service_desk_path(project, format: :json)
expect(json_response["service_desk_address"]).to match(/\A[^@]+@[^@]+\z/)
expect(json_response["service_desk_enabled"]).to be_truthy
expect(response).to have_gitlab_http_status(:ok)
end
context 'when user is not project maintainer' do
let(:guest) { create(:user) }
it 'renders 404' do
project.add_guest(guest)
sign_in(guest)
get project_service_desk_path(project, format: :json)
expect(response).to have_gitlab_http_status(:not_found)
end
end
context 'when issue template is present' do
it 'returns template_file_missing as false' do
create(:service_desk_setting, project: project, issue_template_key: 'service_desk')
get project_service_desk_path(project, format: :json)
response_hash = Gitlab::Json.parse(response.body)
expect(response_hash['template_file_missing']).to eq(false)
end
end
context 'when issue template file becomes outdated' do
it 'returns template_file_missing as true' do
service = ServiceDeskSetting.new(project_id: project.id, issue_template_key: 'deleted')
service.save!(validate: false)
get project_service_desk_path(project, format: :json)
expect(json_response['template_file_missing']).to eq(true)
end
end
end
describe 'PUT #update' do
it 'toggles services desk incoming email' do
project.update!(service_desk_enabled: false)
put project_service_desk_path(project, format: :json), params: { service_desk_enabled: true }
expect(json_response["service_desk_address"]).to be_present
expect(json_response["service_desk_enabled"]).to be_truthy
expect(response).to have_gitlab_http_status(:ok)
end
it 'sets attributes', :aggregate_failures do
put project_service_desk_path(project, format: :json), params: {
issue_template_key: 'service_desk',
reopen_issue_on_external_participant_note: true,
add_external_participants_from_cc: true,
tickets_confidential_by_default: false
}
settings = project.service_desk_setting
expect(settings).to be_present
expect(settings).to have_attributes(
issue_template_key: 'service_desk',
reopen_issue_on_external_participant_note: true,
add_external_participants_from_cc: true,
tickets_confidential_by_default: false
)
expect(json_response).to include(
'issue_template_key' => 'service_desk',
'reopen_issue_on_external_participant_note' => true,
'add_external_participants_from_cc' => true,
'tickets_confidential_by_default' => false
)
end
it 'returns an error when update of service desk settings fails' do
put project_service_desk_path(project, format: :json), params: { issue_template_key: 'invalid key' }
expect(response).to have_gitlab_http_status(:unprocessable_entity)
expect(json_response['message']).to eq('Issue template key is empty or does not exist')
end
context 'when user cannot admin the project' do
let(:other_user) { create(:user) }
it 'renders 404' do
sign_in(other_user)
put project_service_desk_path(project, format: :json), params: { service_desk_enabled: true }
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
end
|
