1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe UsersController, feature_category: :user_management do
# This user should have the same e-mail address associated with the GPG key prepared for tests
let(:user) { create(:user, email: GpgHelpers::User1.emails[0]) }
let(:private_user) { create(:user, private_profile: true) }
let(:public_user) { create(:user) }
describe 'GET #show' do
shared_examples_for 'renders the show template' do
it 'renders the show template' do
get user_url user.username
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template('show')
end
end
context 'when the user exists and has public visibility' do
context 'when logged in' do
before do
sign_in(user)
end
it_behaves_like 'renders the show template'
end
context 'when logged out' do
it_behaves_like 'renders the show template'
end
end
context 'when public visibility level is restricted' do
before do
stub_application_setting(restricted_visibility_levels: [Gitlab::VisibilityLevel::PUBLIC])
end
context 'when logged out' do
it 'redirects to login page' do
get user_url user.username
expect(response).to redirect_to new_user_session_path
end
end
context 'when logged in' do
before do
sign_in(user)
end
it_behaves_like 'renders the show template'
end
end
context 'when a user by that username does not exist' do
context 'when logged out' do
it 'redirects to login page' do
get user_url 'nonexistent'
expect(response).to redirect_to new_user_session_path
end
end
context 'when logged in' do
before do
sign_in(user)
end
it 'renders 404' do
get user_url 'nonexistent'
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
context 'requested in json format' do
let(:project) { create(:project) }
before do
project.add_developer(user)
Gitlab::DataBuilder::Push.build_sample(project, user)
sign_in(user)
end
it 'returns 404 with deprecation message' do
# Requesting "/username?format=json" instead of "/username.json"
get user_url user.username, params: { format: :json }
expect(response).to have_gitlab_http_status(:not_found)
expect(response.media_type).to eq('application/json')
expect(Gitlab::Json.parse(response.body)['message']).to include('This endpoint is deprecated.')
end
end
end
describe 'GET /users/:username (deprecated user top)' do
it 'redirects to /user1' do
get '/users/user1'
expect(response).to redirect_to user_path('user1')
end
end
describe 'GET #activity' do
shared_examples_for 'renders the show template' do
it 'renders the show template' do
get user_activity_url user.username
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template('show')
end
end
context 'when the user exists and has public visibility' do
context 'when logged in' do
before do
sign_in(user)
end
it_behaves_like 'renders the show template'
end
context 'when logged out' do
it_behaves_like 'renders the show template'
end
end
context 'when public visibility level is restricted' do
before do
stub_application_setting(restricted_visibility_levels: [Gitlab::VisibilityLevel::PUBLIC])
end
context 'when logged out' do
it 'redirects to login page' do
get user_activity_url user.username
expect(response).to redirect_to new_user_session_path
end
end
context 'when logged in' do
before do
sign_in(user)
end
it_behaves_like 'renders the show template'
end
end
context 'when a user by that username does not exist' do
context 'when logged out' do
it 'redirects to login page' do
get user_activity_url 'nonexistent'
expect(response).to redirect_to new_user_session_path
end
end
context 'when logged in' do
before do
sign_in(user)
end
it 'renders 404' do
get user_activity_url 'nonexistent'
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
context 'requested in json format' do
context 'when profile_tabs_vue feature flag is turned OFF' do
let(:project) { create(:project) }
before do
project.add_developer(user)
Gitlab::DataBuilder::Push.build_sample(project, user)
stub_feature_flags(profile_tabs_vue: false)
sign_in(user)
end
it 'loads events' do
get user_activity_url user.username, format: :json
expect(response.media_type).to eq('application/json')
expect(Gitlab::Json.parse(response.body)['count']).to eq(1)
end
it 'hides events if the user cannot read cross project' do
allow(Ability).to receive(:allowed?).and_call_original
expect(Ability).to receive(:allowed?).with(user, :read_cross_project) { false }
get user_activity_url user.username, format: :json
expect(response.media_type).to eq('application/json')
expect(Gitlab::Json.parse(response.body)['count']).to eq(0)
end
it 'hides events if the user has a private profile' do
Gitlab::DataBuilder::Push.build_sample(project, private_user)
get user_activity_url private_user.username, format: :json
expect(response.media_type).to eq('application/json')
expect(Gitlab::Json.parse(response.body)['count']).to eq(0)
end
end
context 'when profile_tabs_vue feature flag is turned ON' do
let(:project) { create(:project) }
before do
project.add_developer(user)
Gitlab::DataBuilder::Push.build_sample(project, user)
stub_feature_flags(profile_tabs_vue: true)
sign_in(user)
end
it 'loads events' do
get user_activity_url user.username, format: :json
expect(response.media_type).to eq('application/json')
expect(Gitlab::Json.parse(response.body).count).to eq(1)
end
it 'hides events if the user cannot read cross project' do
allow(Ability).to receive(:allowed?).and_call_original
expect(Ability).to receive(:allowed?).with(user, :read_cross_project) { false }
get user_activity_url user.username, format: :json
expect(response.media_type).to eq('application/json')
expect(Gitlab::Json.parse(response.body).count).to eq(0)
end
it 'hides events if the user has a private profile' do
Gitlab::DataBuilder::Push.build_sample(project, private_user)
get user_activity_url private_user.username, format: :json
expect(response.media_type).to eq('application/json')
expect(Gitlab::Json.parse(response.body).count).to eq(0)
end
it 'hides events if the user has a private profile' do
project = create(:project, :private)
private_event_user = create(:user, include_private_contributions: true)
push_data = Gitlab::DataBuilder::Push.build_sample(project, private_event_user)
EventCreateService.new.push(project, private_event_user, push_data)
get user_activity_url private_event_user.username, format: :json
response_body = Gitlab::Json.parse(response.body)
event = response_body.first
expect(response.media_type).to eq('application/json')
expect(response_body.count).to eq(1)
expect(event).to include('created_at', 'author', 'action')
expect(event['action']).to eq('private')
expect(event).not_to include('ref', 'commit', 'target', 'resource_parent')
end
end
end
end
describe 'GET #ssh_keys' do
context 'non existent user' do
it 'does not generally work' do
get '/not-existent.keys'
expect(response).not_to be_successful
end
end
context 'user with no keys' do
it 'responds the empty body with text/plain content type' do
get "/#{user.username}.keys"
expect(response).to be_successful
expect(response.media_type).to eq("text/plain")
expect(response.body).to eq("")
end
end
context 'user with keys' do
let!(:key) { create(:key, user: user) }
let!(:another_key) { create(:another_key, user: user) }
let!(:deploy_key) { create(:deploy_key, user: user) }
shared_examples_for 'renders all public keys' do
it 'renders all non-deploy keys terminated with a new line with text/plain content type without the comment key' do
get "/#{user.username}.keys"
expect(response).to be_successful
expect(response.media_type).to eq("text/plain")
expect(response.body).not_to eq('')
expect(response.body).to eq(user.all_ssh_keys.map { |key| key + "\n" }.join)
expect(response.body).to include(key.key.sub(' dummy@gitlab.com', ''))
expect(response.body).to include(another_key.key.sub(' dummy@gitlab.com', ''))
expect(response.body).not_to match(/dummy@gitlab.com/)
expect(response.body).not_to include(deploy_key.key)
end
end
context 'while signed in' do
before do
sign_in(user)
end
it_behaves_like 'renders all public keys'
end
context 'when logged out' do
before do
sign_out(user)
end
it_behaves_like 'renders all public keys'
context 'when public visibility is restricted' do
before do
stub_application_setting(restricted_visibility_levels: [Gitlab::VisibilityLevel::PUBLIC])
end
it 'redirects to sign in' do
get "/#{user.username}.keys"
expect(response).to redirect_to(new_user_session_path)
end
end
end
end
end
describe 'GET #gpg_keys' do
context 'non existent user' do
it 'does not generally work' do
get '/not-existent.keys'
expect(response).not_to be_successful
end
end
context 'user with no keys' do
it 'responds the empty body with text/plain content type' do
get "/#{user.username}.gpg"
expect(response).to be_successful
expect(response.media_type).to eq("text/plain")
expect(response.body).to eq("")
end
end
context 'user with keys' do
let!(:gpg_key) { create(:gpg_key, user: user) }
let!(:another_gpg_key) { create(:another_gpg_key, user: user.reload) }
shared_examples_for 'renders all verified GPG keys' do
it 'renders all verified keys terminated with a new line with text/plain content type' do
get "/#{user.username}.gpg"
expect(response).to be_successful
expect(response.media_type).to eq("text/plain")
expect(response.body).not_to eq('')
expect(response.body).to eq(user.gpg_keys.filter_map { |gpg_key| gpg_key.key + "\n" if gpg_key.verified? }.join)
expect(response.body).to include(gpg_key.key)
expect(response.body).to include(another_gpg_key.key)
end
end
context 'while signed in' do
before do
sign_in(user)
end
it_behaves_like 'renders all verified GPG keys'
end
context 'when logged out' do
before do
sign_out(user)
end
it_behaves_like 'renders all verified GPG keys'
end
context 'when revoked' do
shared_examples_for 'doesn\'t render revoked keys' do
it 'doesn\'t render revoked keys' do
get "/#{user.username}.gpg"
expect(response.body).not_to eq('')
expect(response.body).to include(gpg_key.key)
expect(response.body).not_to include(another_gpg_key.key)
end
end
before do
sign_in(user)
another_gpg_key.revoke
end
context 'while signed in' do
it_behaves_like 'doesn\'t render revoked keys'
end
context 'when logged out' do
before do
sign_out(user)
end
it_behaves_like 'doesn\'t render revoked keys'
end
end
end
end
describe 'GET #calendar' do
context 'for user' do
let(:project) { create(:project) }
before do
sign_in(user)
project.add_developer(user)
end
context 'with public profile' do
it 'renders calendar' do
push_data = Gitlab::DataBuilder::Push.build_sample(project, public_user)
EventCreateService.new.push(project, public_user, push_data)
get user_calendar_url public_user.username, format: :json
expect(response).to have_gitlab_http_status(:ok)
end
end
context 'with private profile' do
it 'does not render calendar' do
push_data = Gitlab::DataBuilder::Push.build_sample(project, private_user)
EventCreateService.new.push(project, private_user, push_data)
get user_calendar_url private_user.username, format: :json
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
context 'forked project' do
let(:project) { create(:project) }
let(:forked_project) { Projects::ForkService.new(project, user).execute[:project] }
before do
sign_in(user)
project.add_developer(user)
push_data = Gitlab::DataBuilder::Push.build_sample(project, user)
fork_push_data = Gitlab::DataBuilder::Push
.build_sample(forked_project, user)
EventCreateService.new.push(project, user, push_data)
EventCreateService.new.push(forked_project, user, fork_push_data)
end
it 'includes forked projects' do
get user_calendar_url user.username
expect(assigns(:contributions_calendar).projects.count).to eq(2)
end
end
end
describe 'GET #calendar_activities' do
let!(:project) { create(:project) }
let(:user) { create(:user) }
before do
allow_next_instance_of(User) do |instance|
allow(instance).to receive(:contributed_projects_ids).and_return([project.id])
end
sign_in(user)
project.add_developer(user)
end
it 'renders activities on the specified day' do
get user_calendar_activities_url user.username, date: '2014-07-31'
expect(response.media_type).to eq('text/html')
expect(response.body).to include('Jul 31, 2014')
end
context 'for user' do
context 'with public profile' do
let(:issue) { create(:issue, project: project, author: user) }
let(:note) { create(:note, noteable: issue, author: user, project: project) }
before do
create_push_event
create_note_event
end
it 'renders calendar_activities' do
get user_calendar_activities_url public_user.username
expect(response.body).not_to be_empty
end
it 'renders the correct url for issues and work items' do
work_item = create(:work_item, :task, project: project)
issue = create(:issue, project: project)
EventCreateService.new.open_issue(work_item, public_user)
EventCreateService.new.open_issue(issue, public_user)
get user_calendar_activities_url public_user.username
expect(response.body).to include(project_work_item_path(project, work_item.iid))
expect(response.body).to include(project_issue_path(project, issue))
end
it 'avoids N+1 queries', :request_store do
get user_calendar_activities_url public_user.username
control = ActiveRecord::QueryRecorder.new { get user_calendar_activities_url public_user.username }
create_push_event
create_note_event
expect { get user_calendar_activities_url public_user.username }.not_to exceed_query_limit(control)
end
end
context 'with private profile' do
it 'does not render calendar_activities' do
push_data = Gitlab::DataBuilder::Push.build_sample(project, private_user)
EventCreateService.new.push(project, private_user, push_data)
get user_calendar_activities_url private_user.username
expect(response).to have_gitlab_http_status(:not_found)
end
end
context 'external authorization' do
subject { get user_calendar_activities_url user.username }
it_behaves_like 'disabled when using an external authorization service'
end
def create_push_event
push_data = Gitlab::DataBuilder::Push.build_sample(project, public_user)
EventCreateService.new.push(project, public_user, push_data)
end
def create_note_event
EventCreateService.new.leave_note(note, public_user)
end
end
end
describe 'GET #contributed' do
let(:project) { create(:project, :public) }
let(:aimed_for_deletion_project) { create(:project, :public, :archived, marked_for_deletion_at: 3.days.ago) }
subject do
get user_contributed_projects_url author.username, format: format
end
before do
sign_in(user)
project.add_developer(public_user)
project.add_developer(private_user)
aimed_for_deletion_project.add_developer(public_user)
aimed_for_deletion_project.add_developer(private_user)
create(:push_event, project: project, author: author)
create(:push_event, project: aimed_for_deletion_project, author: author)
end
shared_examples_for 'renders contributed projects' do
it 'renders contributed projects' do
expect(response).to have_gitlab_http_status(:ok)
expect(response.body).not_to be_empty
end
end
%i[html json].each do |format|
context "with format: #{format}" do
let(:format) { format }
before do
subject
end
context 'with public profile' do
let(:author) { public_user }
it_behaves_like 'renders contributed projects'
end
context 'with private profile' do
let(:author) { private_user }
it 'returns 404' do
expect(response).to have_gitlab_http_status(:not_found)
end
context 'with a user that has the ability to read private profiles', :enable_admin_mode do
let(:user) { create(:admin) }
it_behaves_like 'renders contributed projects'
if format == :json
it 'does not list projects aimed for deletion' do
expect(response).to have_gitlab_http_status(:ok)
expect(response.body).not_to include aimed_for_deletion_project.name
end
end
end
end
end
end
describe 'pagination' do
let(:author) { public_user }
let(:format) { :json }
let(:per_page_limit) { 2 }
before do
allow(Kaminari.config).to receive(:default_per_page).and_return(per_page_limit)
create_list(:project, per_page_limit + 1, :public, :small_repo).each do |small_project|
small_project.add_developer(author)
create(:push_event, project: small_project, author: author)
end
subject
end
it_behaves_like 'renders contributed projects'
it 'paginates without count' do
expect(assigns(:contributed_projects).size).to eq(per_page_limit)
expect(assigns(:contributed_projects)).to be_a(Kaminari::PaginatableWithoutCount)
end
end
end
describe 'GET #starred' do
let(:project) { create(:project, :public) }
let(:aimed_for_deletion_project) { create(:project, :public, :archived, marked_for_deletion_at: 3.days.ago) }
subject do
get user_starred_projects_url author.username, format: format
end
before do
author.toggle_star(project)
sign_in(user)
subject
end
shared_examples_for 'renders starred projects' do
it 'renders starred projects' do
expect(response).to have_gitlab_http_status(:ok)
expect(response.body).not_to be_empty
end
end
%i[html json].each do |format|
context "with format: #{format}" do
let(:format) { format }
context 'with public profile' do
let(:author) { public_user }
it_behaves_like 'renders starred projects'
end
context 'with private profile' do
let(:author) { private_user }
it 'returns 404' do
expect(response).to have_gitlab_http_status(:not_found)
end
context 'with a user that has the ability to read private profiles', :enable_admin_mode do
let(:user) { create(:admin) }
it_behaves_like 'renders starred projects'
if format == :json
it 'does not list projects aimed for deletion' do
expect(response).to have_gitlab_http_status(:ok)
expect(response.body).not_to include aimed_for_deletion_project.name
end
end
end
end
end
end
end
describe 'GET #snippets' do
before do
sign_in(user)
end
context 'format html' do
it 'renders snippets page' do
get user_snippets_url user.username
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template('show')
end
end
context 'format json' do
it 'response with snippets json data' do
get user_snippets_url user.username, format: :json
expect(response).to have_gitlab_http_status(:ok)
expect(json_response).to have_key('html')
end
end
context 'external authorization' do
subject { get user_snippets_url user.username }
it_behaves_like 'disabled when using an external authorization service'
end
end
describe 'GET #exists' do
context 'when user exists' do
before do
sign_in(user)
allow(::Gitlab::ApplicationRateLimiter).to receive(:throttled?).and_return(false)
end
let(:exists_true_response_body) { { exists: true }.to_json }
it 'returns JSON indicating the user exists' do
get user_exists_url user.username
expect(response.body).to eq(exists_true_response_body)
end
context 'when the casing is different' do
let(:user) { create(:user, username: 'CamelCaseUser') }
it 'returns JSON indicating the user exists' do
get user_exists_url user.username.downcase
expect(response.body).to eq(exists_true_response_body)
end
end
context 'when a group with the username exists' do
let_it_be(:group) { create(:group, name: 'get-user-exists') }
let_it_be(:subgroup) { create(:group, name: 'get-user-exists-child', parent: group) }
it 'treats the top-level group as a reserved name' do
get user_exists_url 'get-user-exists'
expect(response.body).to eq(exists_true_response_body)
end
it 'treats the sub-group as not a reserved name' do
get user_exists_url 'get-user-exists-child'
expect(response.body).to eq({ exists: false }.to_json)
end
end
end
context 'when the user does not exist' do
it 'will not show a signup page if registration is disabled' do
stub_application_setting(signup_enabled: false)
get user_exists_url 'foo'
expected_json = { error: "You must be authenticated to access this path." }.to_json
expect(response).to have_gitlab_http_status(:unauthorized)
expect(response.body).to eq(expected_json)
end
it 'returns JSON indicating the user does not exist' do
get user_exists_url 'foo'
expected_json = { exists: false }.to_json
expect(response.body).to eq(expected_json)
end
context 'when a user changed their username' do
let(:redirect_route) { user.namespace.redirect_routes.create!(path: 'old-username') }
it 'returns JSON indicating a user by that username does not exist' do
get user_exists_url 'old-username'
expected_json = { exists: false }.to_json
expect(response.body).to eq(expected_json)
end
end
context 'when a project has the same name as a desired username' do
let_it_be(:project) { create(:project, name: 'project-name') }
it 'returns JSON indicating a user by that username does not exist' do
get user_exists_url 'project-name'
expected_json = { exists: false }.to_json
expect(response.body).to eq(expected_json)
end
end
end
context 'when the rate limit has been reached' do
it 'returns status 429 Too Many Requests', :aggregate_failures do
ip = '1.2.3.4'
expect(::Gitlab::ApplicationRateLimiter).to receive(:throttled?).with(:username_exists, scope: ip).and_return(true)
get user_exists_url(user.username), env: { REMOTE_ADDR: ip }
expect(response).to have_gitlab_http_status(:too_many_requests)
end
end
end
describe 'GET #groups' do
before do
sign_in(user)
end
context 'format html' do
it 'renders groups page' do
get user_groups_url user.username
expect(response).to have_gitlab_http_status(:ok)
expect(response).to render_template('show')
end
end
context 'format json' do
before do
setup_data
end
it 'response with groups data' do
send_request
expect(response).to have_gitlab_http_status(:ok)
expect(json_response).to have_key('html')
end
it 'avoids N+1 DB queries', :request_store do
# warm up cache so these initial queries would not leak in our QueryRecorder
send_request
control = ActiveRecord::QueryRecorder.new(skip_cached: false) do
send_request
end
setup_data
expect do
send_request
end.to issue_same_number_of_queries_as(control)
end
context 'pagination' do
let!(:per_page_limit) { 3 }
before do
allow(Kaminari.config).to receive(:default_per_page).and_return(per_page_limit)
create_list(:group, per_page_limit + 2).each { |group| group.add_owner(user) }
end
it 'paginates without count' do
get user_groups_url user.username, format: :json
expect(assigns(:groups).size).to eq(per_page_limit)
expect(assigns(:groups)).to be_a(Kaminari::PaginatableWithoutCount)
end
end
def setup_data
create_list(:group, 2).each do |group|
group.add_owner(user)
create(:project, group: group)
create(:group_member, group: group)
end
end
def send_request
get user_groups_url user.username, format: :json
end
end
end
describe '#ensure_canonical_path' do
before do
sign_in(user)
end
context 'for a GET request' do
context 'when requesting users at the root path' do
context 'when requesting the canonical path' do
let(:user) { create(:user, username: 'CamelCaseUser') }
context 'with exactly matching casing' do
it 'responds with success' do
get user_url user.username
expect(response).to be_successful
end
end
context 'with different casing' do
it 'redirects to the correct casing' do
get user_url user.username.downcase
expect(response).to redirect_to(user)
expect(flash[:notice]).to be_nil
end
end
end
shared_examples_for 'redirects to the canonical path' do
it 'redirects to the canonical path' do
get user_url redirect_route.path
expect(response).to redirect_to(user)
expect(flash[:notice]).to eq(user_moved_message(redirect_route, user))
end
end
context 'when requesting a redirected path' do
let(:redirect_route) { user.namespace.redirect_routes.create!(path: 'old-path') }
it_behaves_like 'redirects to the canonical path'
context 'when the old path is a substring of the scheme or host' do
let(:redirect_route) { user.namespace.redirect_routes.create!(path: 'http') }
# it does not modify the requested host and ...
it_behaves_like 'redirects to the canonical path'
end
context 'when the old path is substring of users' do
let(:redirect_route) { user.namespace.redirect_routes.create!(path: 'ser') }
it_behaves_like 'redirects to the canonical path'
end
end
end
context 'when requesting users under the /users path' do
context 'when requesting the canonical path' do
let(:user) { create(:user, username: 'CamelCaseUser') }
context 'with exactly matching casing' do
it 'responds with success' do
get user_projects_url user.username
expect(response).to be_successful
end
end
context 'with different casing' do
it 'redirects to the correct casing' do
get user_projects_url user.username.downcase
expect(response).to redirect_to(user_projects_path(user))
expect(flash[:notice]).to be_nil
end
end
end
shared_examples_for 'redirects to the canonical path' do
it 'redirects to the canonical path' do
get user_projects_url redirect_route.path
expect(response).to redirect_to(user_projects_path(user))
expect(flash[:notice]).to eq(user_moved_message(redirect_route, user))
end
end
context 'when requesting a redirected path' do
let(:redirect_route) { user.namespace.redirect_routes.create!(path: 'old-path') }
it_behaves_like 'redirects to the canonical path'
context 'when the old path is a substring of the scheme or host' do
let(:redirect_route) { user.namespace.redirect_routes.create!(path: 'http') }
# it does not modify the requested host and ...
it_behaves_like 'redirects to the canonical path'
end
context 'when the old path is substring of users' do
let(:redirect_route) { user.namespace.redirect_routes.create!(path: 'ser') }
# it does not modify the /users part of the path
# (i.e. /users/ser should not become /ufoos/ser) and ...
it_behaves_like 'redirects to the canonical path'
end
end
end
end
end
describe 'POST #follow' do
context 'when over followee limit' do
before do
stub_const('Users::UserFollowUser::MAX_FOLLOWEE_LIMIT', 2)
sign_in(user)
end
it 'alerts and not follow' do
Users::UserFollowUser::MAX_FOLLOWEE_LIMIT.times { user.follow(create(:user)) }
post user_follow_url(username: public_user.username)
expect(response).to be_redirect
expected_message = format(_("You can't follow more than %{limit} users. To follow more users, unfollow some others."), limit: Users::UserFollowUser::MAX_FOLLOWEE_LIMIT)
expect(flash[:alert]).to eq(expected_message)
expect(user).not_to be_following(public_user)
end
end
context 'when user or followee disabled following' do
before do
sign_in(user)
end
it 'alerts and not follow if user disabled following' do
user.enabled_following = false
post user_follow_url(username: public_user.username)
expect(response).to be_redirect
expected_message = format(_('Action not allowed.'))
expect(flash[:alert]).to eq(expected_message)
expect(user).not_to be_following(public_user)
end
it 'alerts and not follow if followee disabled following' do
public_user.enabled_following = false
public_user.save!
post user_follow_url(username: public_user.username)
expect(response).to be_redirect
expected_message = format(_('Action not allowed.'))
expect(flash[:alert]).to eq(expected_message)
expect(user).not_to be_following(public_user)
end
end
end
describe 'POST #unfollow' do
before do
sign_in(user)
end
context 'when unfollow is successful' do
before do
user.follow(public_user)
end
it 'removes the follow relationship and sets a success message' do
post user_unfollow_url(username: public_user.username)
expect(response).to be_redirect
expect(user).not_to be_following(public_user)
end
end
context 'when there is an error during unfollow' do
it 'sets an error message and redirects' do
post user_unfollow_url(username: public_user.username)
expect(response).to be_redirect
expect(flash[:alert]).to eq(_('Failed to unfollow user'))
end
end
end
context 'token authentication' do
it_behaves_like 'authenticates sessionless user for the request spec', 'show atom', public_resource: true do
let(:url) { user_url(user, format: :atom) }
end
end
def user_moved_message(redirect_route, user)
"User '#{redirect_route.path}' was moved to '#{user.full_path}'. Please update any links and bookmarks that may still have the old path."
end
end
|