1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
|
# frozen_string_literal: true
require 'rubocop_spec_helper'
require_relative '../../../rubocop/cop/experiments_test_coverage'
require_relative '../../support/helpers/file_read_helpers'
RSpec.describe RuboCop::Cop::ExperimentsTestCoverage, feature_category: :acquisition do
include FileReadHelpers
let(:class_offense) { described_class::CLASS_OFFENSE }
let(:block_offense) { described_class::BLOCK_OFFENSE }
before do
allow_next_instance_of(Parser::Source::Buffer) do |node_buffer|
allow(node_buffer).to receive(:name).and_return(file_path)
end
stub_file_read(test_file_path, content: tests_code)
end
describe '#on_class' do
let(:file_path) { 'app/experiments/experiment_name_experiment.rb' }
let(:test_file_path) { 'spec/experiments/experiment_name_experiment_spec.rb' }
context 'when there are no tests' do
let(:tests_code) { '' }
it 'registers an offense' do
expect_offense(<<~RUBY)
class ExperimentName < ApplicationExperiment
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ #{class_offense}
end
RUBY
end
end
context 'when there is no stub_experiments' do
let(:tests_code) { "candidate third" }
it 'registers an offense' do
expect_offense(<<~RUBY)
class ExperimentName < ApplicationExperiment
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ #{class_offense}
candidate
variant(:third) { 'third option' }
end
RUBY
end
end
context 'when variant test is missing' do
let(:tests_code) { "\nstub_experiments(experiment_name: :candidate)" }
it 'registers an offense' do
expect_offense(<<~RUBY)
class ExperimentName < ApplicationExperiment
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ #{class_offense}
candidate
variant(:third) { 'third option' }
end
RUBY
end
end
context 'when stub_experiments is commented out' do
let(:tests_code) do
"\n# stub_experiments(experiment_name: :candidate, experiment_name: :third)"
end
it 'registers an offense' do
expect_offense(<<~RUBY)
class ExperimentName < ApplicationExperiment
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ #{class_offense}
candidate
variant(:third) { 'third option' }
end
RUBY
end
end
context 'when all tests are present' do
let(:tests_code) do
"#\nstub_experiments(experiment_name: :candidate, experiment_name: :third)"
end
it 'does not register an offense' do
expect_no_offenses(<<~RUBY)
class ExperimentName < ApplicationExperiment
candidate
variant(:third) { 'third option' }
end
RUBY
end
end
end
describe '#on_block' do
let(:file_path) { 'app/controllers/test_controller.rb' }
let(:test_file_path) { 'spec/requests/test_controller_spec.rb' }
context 'when there are no tests' do
let(:tests_code) { '' }
it 'registers an offense' do
expect_offense(<<~RUBY)
experiment(:experiment_name) do |e|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ #{block_offense}
end
RUBY
end
end
context 'when there is no stub_experiments' do
let(:tests_code) { "candidate third" }
it 'registers an offense' do
expect_offense(<<~RUBY)
experiment(:experiment_name) do |e|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ #{block_offense}
e.candidate { 'candidate' }
e.variant(:third) { 'third option' }
e.run
end
RUBY
end
end
context 'when variant test is missing' do
let(:tests_code) { "\nstub_experiments(experiment_name: :candidate)" }
it 'registers an offense' do
expect_offense(<<~RUBY)
experiment(:experiment_name) do |e|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ #{block_offense}
e.candidate { 'candidate' }
e.variant(:third) { 'third option' }
e.run
end
RUBY
end
end
context 'when stub_experiments is commented out' do
let(:tests_code) do
"\n# stub_experiments(experiment_name: :candidate, experiment_name: :third)"
end
it 'registers an offense' do
expect_offense(<<~RUBY)
experiment(:experiment_name) do |e|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ #{block_offense}
e.candidate { 'candidate' }
e.variant(:third) { 'third option' }
e.run
end
RUBY
end
end
context 'when all tests are present' do
shared_examples 'covered experiment block' do
it 'does not register an offense' do
expect_no_offenses(<<~RUBY)
experiment(:experiment_name) do |e|
e.candidate { 'candidate' }
e.variant(:third) { 'third option' }
e.run
end
RUBY
end
end
let(:tests_code) do
"#\nstub_experiments(experiment_name: :candidate, experiment_name: :third)"
end
it_behaves_like 'covered experiment block'
context 'when /lib/api folder' do
let(:file_path) { '/lib/api/tests.rb' }
let(:test_file_path) { '/spec/requests/api/tests_spec.rb' }
it_behaves_like 'covered experiment block'
end
context 'when *.haml file' do
let(:file_path) { 'app/view/show_test.html.haml' }
let(:test_file_path) { 'spec/view/show_test.html.haml_spec.rb' }
it_behaves_like 'covered experiment block'
end
end
end
end
|
