1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
|
# frozen_string_literal: true
require 'rubocop_spec_helper'
require_relative '../../../../rubocop/cop/migration/drop_table'
RSpec.describe RuboCop::Cop::Migration::DropTable do
context 'when in deployment migration' do
let(:msg) do
'`drop_table` in deployment migrations requires downtime. Drop tables in post-deployment migrations instead.'
end
before do
allow(cop).to receive(:in_deployment_migration?).and_return(true)
end
context 'with drop_table DSL method' do
context 'when in down method' do
it 'does not register an offense' do
expect_no_offenses(<<~PATTERN)
def down
drop_table :table
end
PATTERN
end
end
context 'when in up method' do
it 'registers an offense' do
expect_offense(<<~PATTERN)
def up
drop_table :table
^^^^^^^^^^ #{msg}
end
PATTERN
end
end
context 'when in change method' do
it 'registers an offense' do
expect_offense(<<~PATTERN)
def change
drop_table :table
^^^^^^^^^^ #{msg}
end
PATTERN
end
end
end
context 'with DROP TABLE SQL literal' do
it 'does not register an offense' do
expect_no_offenses(<<~PATTERN)
def down
execute "DROP TABLE table"
end
PATTERN
end
end
context 'when in up method' do
it 'registers an offense' do
expect_offense(<<~PATTERN)
def up
execute "DROP TABLE table"
^^^^^^^ #{msg}
end
PATTERN
end
end
context 'when in change method' do
it 'registers an offense' do
expect_offense(<<~PATTERN)
def change
execute "DROP TABLE table"
^^^^^^^ #{msg}
end
PATTERN
end
end
end
context 'when in post-deployment migration' do
before do
allow(cop).to receive(:in_post_deployment_migration?).and_return(true)
end
it 'registers no offense' do
expect_no_offenses(<<~PATTERN)
def change
drop_table :table
execute "DROP TABLE table"
end
PATTERN
end
end
context 'when outside of migration' do
it 'registers no offense' do
expect_no_offenses(<<~PATTERN)
def change
drop_table :table
execute "DROP TABLE table"
end
PATTERN
end
end
end
|
