File: tests-metadata_spec.rb

package info (click to toggle)
gitlab 17.6.5-19
  • links: PTS, VCS
  • area: main
  • in suites: sid
  • size: 629,368 kB
  • sloc: ruby: 1,915,304; javascript: 557,307; sql: 60,639; xml: 6,509; sh: 4,567; makefile: 1,239; python: 406
file content (415 lines) | stat: -rw-r--r-- 12,744 bytes parent folder | download
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
# frozen_string_literal: true

require 'fast_spec_helper'
require 'tempfile'
require_relative '../../../scripts/setup/tests-metadata'

# rubocop:disable Gitlab/Json, Lint/MissingCopEnableDirective -- It's not intended to have extra dependency

RSpec.describe TestsMetadata, feature_category: :tooling do # rubocop:disable Rails/FilePath,RSpec/SpecFilePathFormat -- We use dashes in scripts
  subject(:metadata) do
    described_class.new(
      mode: mode,
      knapsack_report_path: knapsack_report_path,
      flaky_report_path: flaky_report_path,
      fast_quarantine_path: fast_quarantine_path,
      average_knapsack: average_knapsack)
  end

  let(:average_knapsack) { true }
  let(:knapsack_report_path) { 'knapsack_report/path' }
  let(:flaky_report_path) { 'flaky_report/path' }
  let(:fast_quarantine_path) { 'fast_quarantine/path' }
  let(:aborted) { StandardError.new }

  describe '#main' do
    context 'when mode is retrieve' do
      let(:mode) { 'retrieve' }

      it 'calls prepare_directories and retrieve' do
        expect(metadata).to receive(:prepare_directories)
        expect(metadata).to receive(:retrieve)
        expect(metadata).not_to receive(:update)
        expect(metadata).not_to receive(:verify)

        metadata.main
      end
    end

    context 'when mode is update' do
      let(:mode) { 'update' }

      it 'calls prepare_directories and retrieve and update' do
        expect(metadata).to receive(:prepare_directories)
        expect(metadata).to receive(:retrieve)
        expect(metadata).to receive(:update)
        expect(metadata).not_to receive(:verify)

        metadata.main
      end
    end

    context 'when mode is verify' do
      let(:mode) { 'verify' }

      it 'calls prepare_directories and retrieve and update' do
        expect(metadata).not_to receive(:prepare_directories)
        expect(metadata).not_to receive(:retrieve)
        expect(metadata).not_to receive(:update)
        expect(metadata).to receive(:verify)

        metadata.main
      end
    end
  end

  describe '#prepare_directories' do
    let(:mode) { 'retrieve' }

    it 'prepares the directories' do
      expect(FileUtils).to receive(:mkdir_p).with([
        File.dirname(knapsack_report_path),
        File.dirname(flaky_report_path),
        File.dirname(fast_quarantine_path)
      ])

      metadata.__send__(:prepare_directories)
    end
  end

  shared_context 'with fake reports' do
    let(:knapsack_report_path) { knapsack_report_file.path }
    let(:flaky_report_path) { flaky_report_file.path }
    let(:fast_quarantine_path) { fast_quarantine_file.path }

    let(:knapsack_report_file) { tempfile_write('knapsack', knapsack_report) }
    let(:flaky_report_file) { tempfile_write('flaky', flaky_report) }
    let(:fast_quarantine_file) { tempfile_write('fast_quarantine', fast_quarantine_report) }

    let(:knapsack_report) { json_report }
    let(:flaky_report) { json_report }
    let(:fast_quarantine_report) { text_report }

    let(:json_report) { '{"valid":"json"}' }
    let(:text_report) { 'This is an apple' }

    after do
      [knapsack_report_file, flaky_report_file, fast_quarantine_file]
        .each(&:unlink)
    end

    def tempfile_write(path, content)
      file = Tempfile.new(path)
      file.write(content)
      file.close
      file
    end
  end

  describe '#retrieve' do
    include_context 'with fake reports'

    let(:mode) { 'retrieve' }
    let(:expect_curl) { true }
    let(:curl_knapsack_return) { true }
    let(:curl_flaky_report_return) { true }
    let(:curl_fast_quarantine_return) { true }

    before do
      expect_system_curl
    end

    def expect_system_curl
      expect_system_curl_with(%W[
        curl --fail --location -o #{knapsack_report_path} https://gitlab-org.gitlab.io/gitlab/#{knapsack_report_path}
      ], curl_knapsack_return)

      expect_system_curl_with(%W[
        curl --fail --location -o #{flaky_report_path} https://gitlab-org.gitlab.io/gitlab/#{flaky_report_path}
      ], curl_flaky_report_return)

      expect_system_curl_with(%W[
        curl --fail --location -o #{fast_quarantine_path} https://gitlab-org.gitlab.io/quality/engineering-productivity/fast-quarantine/#{fast_quarantine_path}
      ], curl_fast_quarantine_return)
    end

    def expect_system_curl_with(arguments, curl_return)
      to =
        if expect_curl
          :to
        else
          :not_to
        end

      expectation =
        expect(metadata).public_send(to, receive(:system)).with(*arguments) # rubocop:disable RSpec/MissingExpectationTargetMethod -- it's dynamic

      expectation.and_return(curl_return) if expect_curl
    end

    it 'downloads the metadata and parse it respectively' do
      metadata.__send__(:retrieve)

      expect(File.read(knapsack_report_path)).to eq(json_report)
      expect(File.read(flaky_report_path)).to eq(json_report)
      expect(File.read(fast_quarantine_path)).to eq(text_report)
    end

    context 'when JSON report we download is invalid' do
      let(:json_report) { 'This is a bad JSON' }

      it 'writes a fallback JSON file instead of using invalid JSON' do
        metadata.__send__(:retrieve)

        expect(File.read(knapsack_report_path)).to eq(described_class::FALLBACK_JSON)
        expect(File.read(flaky_report_path)).to eq(described_class::FALLBACK_JSON)
        expect(File.read(fast_quarantine_path)).to eq(text_report)
      end
    end

    context 'when fast quarantine report failed to download' do
      let(:curl_fast_quarantine_return) { false }

      it 'writes a fallback file with fallback content' do
        metadata.__send__(:retrieve)

        expect(File.read(fast_quarantine_path)).to eq('')
      end
    end

    context 'when it is update mode' do
      let(:mode) { 'update' }
      let(:expect_curl) { false }

      it 'does not download tests metadata via curl' do # rubocop:disable RSpec/NoExpectationExample -- set in before already, see expect_system_curl_with
        metadata.__send__(:retrieve)
      end
    end
  end

  describe '#update' do
    let(:mode) { 'update' }

    it 'updates all reports' do
      expect(metadata).to receive(:update_knapsack_report)
      expect(metadata).to receive(:update_flaky_report)
      expect(metadata).to receive(:prune_flaky_report)

      metadata.__send__(:update)
    end
  end

  describe '#update_knapsack_report' do
    include_context 'with fake reports'

    let(:mode) { 'update' }
    let(:knapsack_report_dir) { File.dirname(knapsack_report_path) }

    let(:individual_knapsack_reports) do
      %W[
        #{knapsack_report_dir}/rspec-0.json
        #{knapsack_report_dir}/rspec-1.json
      ]
    end

    before do
      allow(Dir).to receive(:[]).with("#{knapsack_report_dir}/rspec*.json")
        .and_return(individual_knapsack_reports)
    end

    it 'updates knapsack report' do
      expect(metadata).to receive(:system).with(
        'scripts/pipeline/average_reports.rb',
        '-i', knapsack_report_path,
        '-n', individual_knapsack_reports.join(',')
      ).and_return(true)

      metadata.__send__(:update_knapsack_report)
    end

    context 'when scripts/pipeline/average_reports.rb failed' do
      it 'aborts the process' do
        expect(metadata).to receive(:system).with(
          'scripts/pipeline/average_reports.rb',
          '-i', knapsack_report_path,
          '-n', individual_knapsack_reports.join(',')
        ).and_return(false)

        expect(metadata).to receive(:abort)

        metadata.__send__(:update_knapsack_report)
      end
    end

    context 'when average_knapsack is false' do
      let(:average_knapsack) { false }

      it 'uses scripts/merge-reports to merge reports instead' do
        expect(metadata).to receive(:system).with(
          'scripts/merge-reports',
          knapsack_report_path,
          individual_knapsack_reports.join(' ')
        ).and_return(true)

        metadata.__send__(:update_knapsack_report)
      end

      context 'when scripts/merge-reports failed' do
        it 'aborts the process' do
          expect(metadata).to receive(:system).with(
            'scripts/merge-reports',
            knapsack_report_path,
            individual_knapsack_reports.join(' ')
          ).and_return(false)

          expect(metadata).to receive(:abort)

          metadata.__send__(:update_knapsack_report)
        end
      end
    end
  end

  describe '#update_flaky_report' do
    include_context 'with fake reports'

    let(:mode) { 'update' }
    let(:flaky_report_dir) { File.dirname(flaky_report_path) }

    let(:individual_flaky_reports) do
      %W[
        #{flaky_report_dir}/all_0.json
        #{flaky_report_dir}/all_1.json
      ]
    end

    before do
      allow(Dir).to receive(:[]).with("#{flaky_report_dir}/all_*.json")
        .and_return(individual_flaky_reports)
    end

    it 'updates flaky report' do
      expect(metadata).to receive(:system).with(
        'scripts/merge-reports',
        flaky_report_path,
        individual_flaky_reports.join(' ')
      ).and_return(true)

      metadata.__send__(:update_flaky_report)
    end

    context 'when scripts/merge-reports failed' do
      it 'aborts the process' do
        expect(metadata).to receive(:system).with(
          'scripts/merge-reports',
          flaky_report_path,
          individual_flaky_reports.join(' ')
        ).and_return(false)

        expect(metadata).to receive(:abort).and_raise(aborted)

        expect do
          metadata.__send__(:update_flaky_report)
        end.to raise_error(aborted)
      end
    end
  end

  describe '#prune_flaky_report' do
    include_context 'with fake reports'

    let(:mode) { 'update' }
    let(:flaky_report_dir) { File.dirname(flaky_report_path) }

    it 'prunes flaky report' do
      expect(metadata).to receive(:system).with(
        'scripts/flaky_examples/prune-old-flaky-examples',
        flaky_report_path
      ).and_return(true)

      metadata.__send__(:prune_flaky_report)
    end

    context 'when scripts/flaky_examples/prune-old-flaky-examples failed' do
      it 'aborts the process' do
        expect(metadata).to receive(:system).with(
          'scripts/flaky_examples/prune-old-flaky-examples',
          flaky_report_path
        ).and_return(false)

        expect(metadata).to receive(:abort)

        metadata.__send__(:prune_flaky_report)
      end
    end
  end

  describe '#verify' do
    include_context 'with fake reports'

    shared_examples 'fail verification and abort' do
      it 'calls abort to fail the verification' do
        expect(metadata).to receive(:abort).and_raise(aborted)

        expect do
          metadata.__send__(:verify)
        end.to raise_error(aborted)
      end
    end

    let(:mode) { 'verify' }

    let(:knapsack_report) { JSON.dump({ __FILE__ => 123.456 }) }

    let(:flaky_report) do
      <<~JSON
        {
          "fa1659e83e918bab8cb80518ea5f80f4": {
            "first_flaky_at": "2023-12-07 14:21:34 +0000",
            "last_flaky_at": "2024-09-02 22:18:36 +0000",
            "last_flaky_job": "https://gitlab.com/gitlab-org/gitlab/-/jobs/7724274859",
            "last_attempts_count": 2,
            "flaky_reports": 954,
            "feature_category": "integrations",
            "example_id": "./spec/features/projects/integrations/user_activates_issue_tracker_spec.rb[1:4:1:2:1]",
            "file": "./spec/features/projects/integrations/user_activates_issue_tracker_spec.rb",
            "line": 49,
            "description": "User activates issue tracker behaves like external issue tracker activation user sets and activates the integration when the connection test fails activates the integration"
          }
        }
      JSON
    end

    let(:fast_quarantine_report) do
      <<~TEXT
        qa/specs/features/ee/browser_ui/3_create/remote_development/workspace_actions_spec.rb
        spec/features/work_items/work_item_spec.rb:67
      TEXT
    end

    it 'validates reports are valid' do
      expect { metadata.__send__(:verify) }.to output("OK\n").to_stdout
    end

    context 'when knapsack report has type error' do
      let(:knapsack_report) { JSON.dump({ __FILE__ => '123.456' }) }

      it_behaves_like 'fail verification and abort'
    end

    context 'when knapsack report is not valid JSON' do
      let(:knapsack_report) { { __FILE__ => 123.456 }.to_s }

      it_behaves_like 'fail verification and abort'
    end

    context 'when flaky report is not valid JSON' do
      let(:flaky_report) { 'This is an apple' }

      it_behaves_like 'fail verification and abort'
    end

    context 'when fast quarantine report is not valid',
      skip: 'This is not possible because it is always considered valid'
  end
end