1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Ci::ProcessSyncEventsService, feature_category: :continuous_integration do
let!(:group) { create(:group) }
let!(:project1) { create(:project, group: group) }
let!(:project2) { create(:project, group: group) }
let!(:parent_group_1) { create(:group) }
let!(:parent_group_2) { create(:group) }
subject(:service) { described_class.new(sync_event_class, hierarchy_class) }
describe '#perform' do
subject(:execute) { service.execute }
context 'for Projects::SyncEvent' do
let(:sync_event_class) { Projects::SyncEvent }
let(:hierarchy_class) { ::Ci::ProjectMirror }
before do
Projects::SyncEvent.delete_all
project1.update!(group: parent_group_1)
project2.update!(group: parent_group_2)
end
it { is_expected.to eq(service_results(2, 2, 2)) }
it 'consumes events' do
expect { execute }.to change(Projects::SyncEvent, :count).from(2).to(0)
expect(project1.reload.ci_project_mirror).to have_attributes(
namespace_id: parent_group_1.id
)
expect(project2.reload.ci_project_mirror).to have_attributes(
namespace_id: parent_group_2.id
)
end
context 'when any event left after processing' do
before do
stub_const("#{described_class}::BATCH_SIZE", 1)
end
it { is_expected.to eq(service_results(2, 1, 1)) }
it 'enqueues Projects::ProcessSyncEventsWorker' do
expect(Projects::ProcessSyncEventsWorker).to receive(:perform_async)
execute
end
end
context 'when no event left after processing' do
before do
stub_const("#{described_class}::BATCH_SIZE", 2)
end
it { is_expected.to eq(service_results(2, 2, 2)) }
it 'does not enqueue Projects::ProcessSyncEventsWorker' do
expect(Projects::ProcessSyncEventsWorker).not_to receive(:perform_async)
execute
end
end
context 'when there is no event' do
before do
Projects::SyncEvent.delete_all
end
it { is_expected.to eq(service_results(0, 0, nil)) }
it 'does nothing' do
expect { execute }.not_to change(Projects::SyncEvent, :count)
end
end
context 'when there is non-executed events' do
before do
new_project = create(:project)
sync_event_class.delete_all
project1.update!(group: parent_group_2)
new_project.update!(group: parent_group_1)
project2.update!(group: parent_group_1)
@new_project_sync_event = new_project.sync_events.last
allow(sync_event_class).to receive(:preload_synced_relation).and_return(
sync_event_class.where.not(id: @new_project_sync_event)
)
end
it { is_expected.to eq(service_results(3, 2, 2)) }
it 'does not delete non-executed events' do
expect { execute }.to change(Projects::SyncEvent, :count).from(3).to(1)
expect(@new_project_sync_event.reload).to be_persisted
end
end
private
def service_results(total, consumable, processed)
{
estimated_total_events: total,
consumable_events: consumable,
processed_events: processed
}.compact
end
end
context 'for Namespaces::SyncEvent' do
let(:sync_event_class) { Namespaces::SyncEvent }
let(:hierarchy_class) { ::Ci::NamespaceMirror }
before do
Namespaces::SyncEvent.delete_all
# Creates a sync event for group, and the ProjectNamespace of project1 & project2: 3 in total
group.update!(parent: parent_group_2)
# Creates a sync event for parent_group2 and all the children: 4 in total
parent_group_2.update!(parent: parent_group_1)
end
shared_examples 'event consuming' do
it 'consumes events' do
expect { execute }.to change(Namespaces::SyncEvent, :count).from(7).to(0)
expect(group.reload.ci_namespace_mirror).to have_attributes(
traversal_ids: [parent_group_1.id, parent_group_2.id, group.id]
)
expect(parent_group_2.reload.ci_namespace_mirror).to have_attributes(
traversal_ids: [parent_group_1.id, parent_group_2.id]
)
expect(project1.reload.project_namespace).to have_attributes(
traversal_ids: [parent_group_1.id, parent_group_2.id, group.id, project1.project_namespace.id]
)
expect(project2.reload.project_namespace).to have_attributes(
traversal_ids: [parent_group_1.id, parent_group_2.id, group.id, project2.project_namespace.id]
)
end
end
it_behaves_like 'event consuming'
it 'enqueues Namespaces::ProcessSyncEventsWorker if any left' do
stub_const("#{described_class}::BATCH_SIZE", 1)
expect(Namespaces::ProcessSyncEventsWorker).to receive(:perform_async)
execute
end
it 'does not enqueue Namespaces::ProcessSyncEventsWorker if no left' do
stub_const("#{described_class}::BATCH_SIZE", 7)
expect(Namespaces::ProcessSyncEventsWorker).not_to receive(:perform_async)
execute
end
end
context 'for Ci::Catalog::Resources::SyncEvent' do
let(:sync_event_class) { Ci::Catalog::Resources::SyncEvent }
let(:hierarchy_class) { Ci::Catalog::Resource }
let_it_be(:project1) { create(:project) }
let_it_be(:project2) { create(:project) }
let_it_be_with_refind(:resource1) { create(:ci_catalog_resource, project: project1) }
let_it_be(:resource2) { create(:ci_catalog_resource, project: project2) }
before_all do
create(:ci_catalog_resource_sync_event, catalog_resource: resource1, status: :processed)
# PG trigger adds an event for each update
project1.update!(name: 'Name 1', description: 'Test 1')
project1.update!(visibility_level: Gitlab::VisibilityLevel::INTERNAL)
project2.update!(name: 'Name 2', description: 'Test 2')
project2.update!(visibility_level: Gitlab::VisibilityLevel::PUBLIC)
end
it 'processes the events', :aggregate_failures do
# 2 pending events from resource1 + 2 pending events from resource2
expect { execute }.to change(Ci::Catalog::Resources::SyncEvent.status_pending, :count).from(4).to(0)
expect(resource1.reload.name).to eq(project1.name)
expect(resource2.reload.name).to eq(project2.name)
expect(resource1.reload.description).to eq(project1.description)
expect(resource2.reload.description).to eq(project2.description)
expect(resource1.reload.visibility_level).to eq(project1.visibility_level)
expect(resource2.reload.visibility_level).to eq(project2.visibility_level)
end
context 'when there are no remaining unprocessed events' do
it 'does not enqueue Ci::Catalog::Resources::ProcessSyncEventsWorker' do
stub_const("#{described_class}::BATCH_SIZE", 4)
expect(Ci::Catalog::Resources::ProcessSyncEventsWorker).not_to receive(:perform_async)
execute
end
end
context 'when there are remaining unprocessed events' do
it 'enqueues Ci::Catalog::Resources::ProcessSyncEventsWorker' do
stub_const("#{described_class}::BATCH_SIZE", 1)
expect(Ci::Catalog::Resources::ProcessSyncEventsWorker).to receive(:perform_async)
execute
end
end
# The `p_catalog_resource_sync_events` table does not enforce an FK on catalog_resource_id
context 'when there are orphaned sync events' do
it 'processes the events', :aggregate_failures do
resource1.destroy!
# 2 pending events from resource1 + 2 pending events from resource2
expect { execute }.to change(Ci::Catalog::Resources::SyncEvent.status_pending, :count).from(4).to(0)
expect(resource2.reload.name).to eq(project2.name)
expect(resource2.reload.description).to eq(project2.description)
expect(resource2.reload.visibility_level).to eq(project2.visibility_level)
end
end
end
end
end
|
