1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Issuable::Callbacks::Description, feature_category: :portfolio_management do
let_it_be(:random_user) { create(:user) }
let_it_be(:author) { create(:user) }
let_it_be(:guest) { create(:user) }
let_it_be(:reporter) { create(:user) }
let_it_be(:project) { create(:project, :public) }
let(:params) { { description: 'updated description' } }
let(:current_user) { author }
let(:work_item) do
create(
:work_item,
author: author,
project: project,
description: 'old description',
last_edited_at: Date.yesterday,
last_edited_by: random_user
)
end
let(:service) { described_class.new(issuable: work_item, current_user: current_user, params: params) }
describe '#after_initialize' do
subject(:after_initialize_callback) { service.after_initialize }
shared_examples 'sets work item description' do
it 'correctly sets work item description value' do
subject
expect(work_item.description).to eq(params[:description])
end
end
shared_examples 'does not set work item description' do
it 'does not change work item description value' do
subject
expect(work_item.description).to eq('old description')
expect(work_item.last_edited_by).to eq(random_user)
expect(work_item.last_edited_at).to eq(Date.yesterday)
end
end
context 'when user has permission to update description' do
context 'when user is work item author' do
let(:current_user) { author }
it_behaves_like 'sets work item description'
end
context 'when user is a project reporter' do
let(:current_user) { reporter }
before_all do
project.add_reporter(reporter)
end
it_behaves_like 'sets work item description'
end
context 'when description is nil' do
let(:current_user) { author }
let(:params) { { description: nil } }
it_behaves_like 'sets work item description'
end
context 'when description is empty' do
let(:current_user) { author }
let(:params) { { description: '' } }
it_behaves_like 'sets work item description'
end
context 'when description param is not present' do
let(:params) { {} }
it_behaves_like 'does not set work item description'
end
context 'when widget does not exist in new type' do
let(:current_user) { author }
let(:params) { {} }
before do
allow(service).to receive(:excluded_in_new_type?).and_return(true)
work_item.update!(description: 'test')
end
it "resets the work item's description" do
expect { after_initialize_callback }
.to change { work_item.description }
.from('test')
.to(nil)
end
end
end
context 'when user does not have permission to update description' do
context 'when user is a project guest' do
let(:current_user) { guest }
before_all do
project.add_guest(guest)
end
it_behaves_like 'does not set work item description'
end
context 'with private project' do
let_it_be(:project) { create(:project) }
context 'when user is work item author' do
let(:current_user) { author }
it_behaves_like 'does not set work item description'
end
end
end
end
describe '#before_update', :freeze_time do
subject(:before_update_callback) { service.before_update }
context 'when description was changed' do
it 'sets last_edited_by and last_edited_at' do
work_item.description = 'new description'
before_update_callback
expect(work_item.last_edited_by).to eq(current_user)
expect(work_item.last_edited_at).to be_like_time(Time.current)
end
end
context 'when description was not changed' do
it 'does not change last_edited_by and last_edited_at' do
before_update_callback
expect(work_item.last_edited_by).to eq(random_user)
expect(work_item.last_edited_at).to eq(Date.yesterday)
end
end
end
end
|
