1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe PreviewMarkdownService, feature_category: :markdown do
let_it_be_with_reload(:project) { create(:project, :repository) }
let_it_be(:developer) { create(:user, developer_of: project) }
let(:user) { developer }
let(:service) { described_class.new(container: project, current_user: user, params: params) }
describe 'user references' do
let(:params) { { text: "Take a look #{user.to_reference}" } }
it 'returns users referenced in text' do
result = service.execute
expect(result[:users]).to eq [user.username]
end
end
describe 'suggestions' do
let(:merge_request) do
create(:merge_request, target_project: project, source_project: project)
end
let(:text) { "```suggestion\nfoo\n```" }
let(:params) do
suggestion_params.merge(
text: text,
target_type: 'MergeRequest',
target_id: merge_request.iid
)
end
context 'when preview markdown param is present' do
let(:path) { "files/ruby/popen.rb" }
let(:line) { 10 }
let(:diff_refs) { merge_request.diff_refs }
let(:suggestion_params) do
{
preview_suggestions: true,
file_path: path,
line: line,
base_sha: diff_refs.base_sha,
start_sha: diff_refs.start_sha,
head_sha: diff_refs.head_sha
}
end
it 'returns suggestions referenced in text' do
position = Gitlab::Diff::Position.new(new_path: path, new_line: line, diff_refs: diff_refs)
expect(Gitlab::Diff::SuggestionsParser)
.to receive(:parse)
.with(
text,
position: position,
project: merge_request.project,
supports_suggestion: true
)
.and_call_original
result = service.execute
expect(result[:suggestions]).to all(be_a(Gitlab::Diff::Suggestion))
end
context 'when user is not authorized' do
let(:user) { create(:user, guest_of: project) }
it 'returns no suggestions' do
result = service.execute
expect(result[:suggestions]).to be_empty
end
end
end
context 'when preview markdown param is not present' do
let(:suggestion_params) do
{
preview_suggestions: false
}
end
it 'returns suggestions referenced in text' do
result = service.execute
expect(result[:suggestions]).to eq([])
end
end
end
context 'new note with quick actions' do
let(:issue) { create(:issue, project: project) }
let(:params) do
{
text: "Please do it\n/assign #{user.to_reference}",
target_type: 'Issue',
target_id: issue.id
}
end
it 'removes quick actions from text' do
result = service.execute
expect(result[:text]).to eq 'Please do it'
end
context 'when render_quick_actions' do
it 'keeps quick actions' do
params[:render_quick_actions] = true
result = service.execute
expect(result[:text]).to eq "Please do it\n<p>/assign #{user.to_reference}</p>"
end
end
it 'explains quick actions effect' do
result = service.execute
expect(result[:commands]).to eq "Assigns #{user.to_reference}."
end
end
context 'merge request description' do
let(:params) do
{
text: "My work\n/estimate 2y",
target_type: 'MergeRequest'
}
end
it 'removes quick actions from text' do
result = service.execute
expect(result[:text]).to eq 'My work'
end
it 'explains quick actions effect' do
result = service.execute
expect(result[:commands]).to eq 'Sets time estimate to 2y.'
end
end
context 'commit description' do
let(:commit) { project.commit }
let(:params) do
{
text: "My work\n/tag v1.2.3 Stable release",
target_type: 'Commit',
target_id: commit.id
}
end
it 'removes quick actions from text' do
result = service.execute
expect(result[:text]).to eq 'My work'
end
it 'explains quick actions effect' do
result = service.execute
expect(result[:commands]).to eq 'Tags this commit to v1.2.3 with "Stable release".'
end
end
context 'note with multiple quick actions' do
let(:issue) { create(:issue, project: project) }
let(:params) do
{
text: "/confidential\n/due 2001-12-31\n/estimate 2y\n/assign #{user.to_reference}",
target_type: 'Issue',
target_id: issue.id
}
end
it 'renders quick actions on multiple lines' do
result = service.execute
expect(result[:commands]).to eq "Makes this issue confidential.<br>Sets the due date to Dec 31, 2001.<br>" \
"Sets time estimate to 2y.<br>Assigns #{user.to_reference}."
end
end
context 'work item quick action types' do
let(:work_item) { create(:work_item, :task, project: project) }
let(:params) do
{
text: "/title new title",
target_type: 'WorkItem',
target_id: work_item.iid
}
end
let(:result) { service.execute }
it 'renders the quick action preview' do
expect(result[:commands]).to eq "Changes the title to \"new title\"."
end
end
end
|
