1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628
|
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Projects::ForkService, feature_category: :source_code_management do
subject(:service) { described_class.new(project, user, params) }
let_it_be_with_reload(:project) { create(:project, :repository, star_count: 100, description: 'project') }
let_it_be_with_reload(:user) { create(:user) }
let(:params) { { namespace: namespace } }
let(:namespace) { user.namespace }
shared_examples 'forks count cache refresh' do
it 'flushes the forks count cache of the source project', :clean_gitlab_redis_cache do
expect(from_project.forks_count).to be_zero
described_class.new(from_project, to_user, params).execute
BatchLoader::Executor.clear_current
expect(from_project.reload.forks_count).to eq(1)
end
end
describe '#execute' do
subject(:response) { service.execute }
let(:fork_of_project) { response[:project] }
before do
# NOTE: Avatar file is dropped after project reload. Explicitly re-add it for each test.
project.avatar = fixture_file_upload("spec/fixtures/dk.png", "image/png")
end
context 'when forker is a guest' do
before do
project.add_member(user, :guest)
end
it 'does not create a fork' do
is_expected.to be_error
expect(response.errors).to eq(['Forked from project is forbidden'])
end
it 'does not create a fork network' do
expect { subject }.not_to change { project.reload.fork_network }
end
end
context 'when forker is a developer' do
before do
project.add_member(user, :developer)
end
it 'creates a fork of the project' do
is_expected.to be_success
expect(fork_of_project.errors).to be_empty
expect(fork_of_project.first_owner).to eq(user)
expect(fork_of_project.namespace).to eq(user.namespace)
expect(fork_of_project.star_count).to be_zero
expect(fork_of_project.description).to eq(project.description)
expect(fork_of_project.avatar.file).to be_exists
expect(fork_of_project.ci_config_path).to eq(project.ci_config_path)
expect(fork_of_project.external_authorization_classification_label).to eq(project.external_authorization_classification_label)
expect(fork_of_project.suggestion_commit_message).to eq(project.suggestion_commit_message)
expect(fork_of_project.merge_commit_template).to eq(project.merge_commit_template)
expect(fork_of_project.squash_commit_template).to eq(project.squash_commit_template)
end
# This test is here because we had a bug where the from-project lost its
# avatar after being forked.
# https://gitlab.com/gitlab-org/gitlab-foss/issues/26158
it 'after forking the original project still has its avatar' do
# If we do not fork the project first we cannot detect the bug.
is_expected.to be_success
expect(project.avatar.file).to be_exists
end
it_behaves_like 'forks count cache refresh' do
let(:from_project) { project }
let(:to_user) { user }
end
it 'creates a fork network with the new project and the root project set' do
subject
fork_network = project.reload.fork_network
expect(fork_network).not_to be_nil
expect(fork_network.root_project).to eq(project)
expect(fork_network.projects).to contain_exactly(project, fork_of_project)
end
it 'imports the repository of the forked project', :sidekiq_might_not_need_inline do
expect(fork_of_project).to be_persisted
# The call to project.repository.after_import in RepositoryForkWorker does
# not reset the @exists variable of this fork_of_project.repository
# so we have to explicitly call this method to clear the @exists variable.
# of the instance we're returning here.
fork_of_project.repository.expire_content_cache
expect(fork_of_project.empty_repo?).to be_falsey
end
context 'when creating fork of the fork' do
let_it_be(:other_namespace) { create(:group, owners: user) }
it 'creates a new project' do
fork_response = described_class.new(project, user, params).execute
expect(fork_response).to be_success
fork_of_project = fork_response[:project]
expect(fork_of_project).to be_persisted
fork_of_fork_response = described_class.new(fork_of_project, user, { namespace: other_namespace }).execute
expect(fork_of_fork_response).to be_success
fork_of_fork = fork_of_fork_response[:project]
expect(fork_of_fork).to be_persisted
expect(fork_of_fork).to be_valid
expect(fork_of_fork.fork_network.root_project).to eq(project)
expect(fork_of_fork.fork_network_member.forked_from_project).to eq(fork_of_project)
end
context 'when the forked project has higher visibility than the root project' do
let_it_be(:root_project) { create(:project, :public) }
it 'successfully creates a fork of the fork with correct visibility' do
fork_response = described_class.new(root_project, user, params).execute
expect(fork_response).to be_success
fork_of_project = fork_response[:project]
expect(fork_of_project).to be_persisted
root_project.update!(visibility_level: Gitlab::VisibilityLevel::INTERNAL)
# Forked project visibility is not affected by root project visibility change
expect(fork_of_project).to have_attributes(visibility_level: Gitlab::VisibilityLevel::PUBLIC)
fork_of_fork_response = described_class.new(fork_of_project, user, { namespace: other_namespace }).execute
expect(fork_of_fork_response).to be_success
fork_of_fork = fork_of_fork_response[:project]
expect(fork_of_fork).to be_persisted
expect(fork_of_fork).to be_valid
expect(fork_of_fork).to have_attributes(visibility_level: Gitlab::VisibilityLevel::PUBLIC)
end
end
it_behaves_like 'forks count cache refresh' do
let(:from_project) { described_class.new(project, user, { namespace: other_namespace }).execute[:project] }
let(:to_user) { user }
end
end
context 'when project already exists' do
it 'fails due to validation, not transaction failure' do
existing_project = create(:project, namespace: namespace, path: project.path)
expect(existing_project).to be_persisted
is_expected.to be_error
expect(response.errors).to include('Path has already been taken')
end
end
context 'when repository in legacy storage already exists' do
let(:raw_fake_repo) { Gitlab::Git::Repository.new('default', File.join(user.namespace.full_path, "#{project.path}.git"), nil, nil) }
before do
stub_application_setting(hashed_storage_enabled: false)
raw_fake_repo.create_repository
end
after do
raw_fake_repo.remove
end
it 'does not allow creation' do
is_expected.to be_error
expect(response.errors).to include('There is already a repository with that name on disk')
end
context 'when repository disk validation is explicitly skipped' do
let(:params) { super().merge(skip_disk_validation: true) }
it 'allows fork project creation' do
is_expected.to be_success
expect(fork_of_project).to be_persisted
expect(fork_of_project.errors.messages).to be_empty
end
end
end
context 'CI/CD settings' do
context 'when origin has git depth specified' do
it 'inherits default_git_depth from the origin project' do
project.update!(ci_default_git_depth: 42)
is_expected.to be_success
expect(fork_of_project).to be_persisted
expect(fork_of_project.ci_default_git_depth).to eq(42)
end
end
context 'when origin does not define git depth' do
it 'the fork has git depth set to 0' do
project.update!(ci_default_git_depth: nil)
is_expected.to be_success
expect(fork_of_project).to be_persisted
expect(fork_of_project.ci_default_git_depth).to eq(0)
end
end
end
context 'when project has restricted visibility level' do
context 'and only one visibility level is restricted' do
before do
project.update!(visibility_level: Gitlab::VisibilityLevel::INTERNAL)
stub_application_setting(restricted_visibility_levels: [Gitlab::VisibilityLevel::INTERNAL])
end
it 'creates fork with lowest level' do
is_expected.to be_success
expect(fork_of_project).to be_persisted
expect(fork_of_project.visibility_level).to eq(Gitlab::VisibilityLevel::PRIVATE)
end
end
context "and all visibility levels are restricted" do
before do
stub_application_setting(restricted_visibility_levels: [Gitlab::VisibilityLevel::PUBLIC, Gitlab::VisibilityLevel::INTERNAL, Gitlab::VisibilityLevel::PRIVATE])
end
it "doesn't create a fork" do
is_expected.to be_error
expect(response.errors).to eq ['Visibility level private has been restricted by your GitLab administrator']
end
end
end
context 'when forking is disabled' do
before do
project.project_feature.update_attribute(:forking_access_level, ProjectFeature::DISABLED)
end
it 'does not create a fork' do
is_expected.to be_error
expect(response.errors).to eq(['Forked from project is forbidden'])
end
end
context 'when forking to the group namespace' do
context 'when user owns a target group' do
let_it_be_with_reload(:namespace) { create(:group, owners: user) }
it 'creates a fork in the group' do
is_expected.to be_success
expect(fork_of_project.first_owner).to eq(user)
expect(fork_of_project.namespace).to eq(namespace)
end
context 'when project already exists in group' do
it 'fails due to validation, not transaction failure' do
existing_project = create(:project, :repository, path: project.path, namespace: namespace)
expect(existing_project).to be_persisted
is_expected.to be_error
expect(response.errors).to include('Path has already been taken')
end
end
context 'when the namespace has a lower visibility level than the project' do
let_it_be(:namespace) { create(:group, :private, owners: user) }
let_it_be(:project) { create(:project, :public) }
it 'creates the project with the lower visibility level' do
is_expected.to be_success
expect(fork_of_project).to be_persisted
expect(fork_of_project.visibility_level).to eq(Gitlab::VisibilityLevel::PRIVATE)
end
end
end
context 'when user is not a group owner' do
let_it_be(:namespace) { create(:group, developers: user) }
it 'does not create a fork' do
is_expected.to be_error
expect(response.errors).to match_array(['Namespace is not valid', 'User is not allowed to import projects'])
end
end
end
context 'with optional attributes' do
let(:params) { super().merge(path: 'forked', name: 'My Fork', description: 'Description', visibility: 'private') }
it 'sets optional attributes to specified values' do
is_expected.to be_success
expect(fork_of_project).to be_persisted
expect(fork_of_project.path).to eq('forked')
expect(fork_of_project.name).to eq('My Fork')
expect(fork_of_project.description).to eq('Description')
expect(fork_of_project.visibility_level).to eq(Gitlab::VisibilityLevel::PRIVATE)
end
context 'when an unknown visibility is requested' do
let_it_be(:project) { create(:project, :public) }
let(:params) { super().merge(visibility: 'unknown') }
it 'sets visibility level to private' do
is_expected.to be_success
expect(fork_of_project).to be_persisted
expect(fork_of_project.visibility_level).to eq(Gitlab::VisibilityLevel::PRIVATE)
end
end
context 'when requested visibility level is greater than allowed' do
let_it_be(:project) { create(:project, :internal) }
let(:params) { super().merge(visibility: 'public') }
it 'sets visibility level to project visibility' do
is_expected.to be_success
expect(fork_of_project).to be_persisted
expect(fork_of_project.visibility_level).to eq(Gitlab::VisibilityLevel::INTERNAL)
end
end
context 'when target namespace has lower visibility than a project' do
let_it_be(:project) { create(:project, :public) }
let_it_be(:namespace) { create(:group, :private, owners: user) }
it 'sets visibility level to target namespace visibility level' do
is_expected.to be_success
expect(fork_of_project).to be_persisted
expect(fork_of_project.visibility_level).to eq(Gitlab::VisibilityLevel::PRIVATE)
end
end
context 'when project has custom visibility settings' do
let_it_be(:project) { create(:project, :public) }
let(:attrs) do
ProjectFeature::FEATURES.to_h do |f|
["#{f}_access_level", ProjectFeature::PRIVATE]
end
end
before do
project.project_feature.update!(attrs)
end
it 'copies project features visibility settings to the fork' do
is_expected.to be_success
expect(fork_of_project).to be_persisted
expect(fork_of_project.project_feature.slice(attrs.keys)).to eq(attrs)
end
end
end
context 'when a project is already forked' do
let_it_be(:project) { create(:project, :public, :repository) }
let_it_be(:group) { create(:group, owners: user) }
before do
# Stub everything required to move a project to a Gitaly shard that does not exist
allow(Gitlab::GitalyClient).to receive(:filesystem_id).with('default').and_call_original
allow(Gitlab::GitalyClient).to receive(:filesystem_id).with('test_second_storage').and_return(SecureRandom.uuid)
stub_storage_settings('test_second_storage' => {})
allow_any_instance_of(Gitlab::Git::Repository).to receive(:create_repository)
.and_return(true)
allow_any_instance_of(Gitlab::Git::Repository).to receive(:replicate)
allow_any_instance_of(Gitlab::Git::Repository).to receive(:checksum)
.and_return(::Gitlab::Git::SHA1_BLANK_SHA)
allow_next_instance_of(Gitlab::Git::ObjectPool) do |object_pool|
allow(object_pool).to receive(:link)
end
end
it 'creates a new pool repository after the project is moved to a new shard' do
fork_before_move = fork_of_project
storage_move = create(
:project_repository_storage_move,
:scheduled,
container: project,
destination_storage_name: 'test_second_storage'
)
Projects::UpdateRepositoryStorageService.new(storage_move).execute
fork_after_move_response = described_class.new(project.reload, user, namespace: group).execute
expect(fork_after_move_response).to be_success
fork_after_move = fork_after_move_response[:project]
pool_repository_before_move = PoolRepository.joins(:shard)
.find_by(source_project: project, shards: { name: 'default' })
pool_repository_after_move = PoolRepository.joins(:shard)
.find_by(source_project: project, shards: { name: 'test_second_storage' })
expect(fork_before_move.pool_repository).to eq(pool_repository_before_move)
expect(fork_after_move.pool_repository).to eq(pool_repository_after_move)
end
end
context 'when forking with object pools' do
let_it_be(:project) { create(:project, :public, :repository) }
context 'when no pool exists' do
it 'creates a new object pool' do
expect { response }.to change { PoolRepository.count }.by(1)
is_expected.to be_success
expect(fork_of_project.pool_repository).to eq(project.pool_repository)
end
context 'when project is private' do
let_it_be(:project) { create(:project, :private, :repository) }
it 'does not create an object pool' do
expect { response }.not_to change { PoolRepository.count }
is_expected.to be_success
expect(fork_of_project.pool_repository).to be_nil
end
end
end
context 'when a pool already exists' do
let!(:pool_repository) { create(:pool_repository, source_project: project) }
it 'joins the object pool' do
expect { response }.not_to change { PoolRepository.count }
is_expected.to be_success
expect(fork_of_project.pool_repository).to eq(pool_repository)
end
end
end
context 'when linking fork to an existing project' do
let_it_be_with_reload(:unlinked_fork) { create(:project, :public) }
before_all do
unlinked_fork.add_developer(user)
end
def forked_from_project(project)
project.fork_network_member&.forked_from_project
end
context 'if project is already forked' do
it 'does not create fork relation' do
allow(unlinked_fork).to receive(:forked?).and_return(true)
expect(forked_from_project(unlinked_fork)).to be_nil
expect(service.execute(unlinked_fork)).to be_error
expect(forked_from_project(unlinked_fork)).to be_nil
end
end
context 'if project is not forked' do
it 'creates fork relation' do
expect(unlinked_fork.forked?).to be_falsy
expect(forked_from_project(unlinked_fork)).to be_nil
service.execute(unlinked_fork)
unlinked_fork.reload
expect(unlinked_fork.forked?).to be true
expect(forked_from_project(unlinked_fork)).to eq project
expect(unlinked_fork.forked_from_project).to eq project
end
it 'flushes the forks count cache of the source project' do
expect(project.forks_count).to be_zero
service.execute(unlinked_fork)
BatchLoader::Executor.clear_current
expect(project.forks_count).to eq(1)
end
context 'when user cannot fork' do
let(:another_user) { create(:user) }
it 'returns an error' do
expect(unlinked_fork.forked?).to be_falsey
expect(forked_from_project(unlinked_fork)).to be_nil
response = described_class.new(project, another_user, params).execute(unlinked_fork)
expect(response).to be_error
expect(response.errors).to eq ['Forked from project is forbidden']
expect(forked_from_project(unlinked_fork)).to be_nil
end
end
context 'if the fork is not allowed' do
let_it_be(:project) { create(:project, :private) }
it 'does not delete the LFS objects' do
create(:lfs_objects_project, project: unlinked_fork)
expect { service.execute(unlinked_fork) }
.not_to change { unlinked_fork.lfs_objects_projects.size }
end
end
end
end
end
end
describe '#valid_fork_targets' do
subject { service.valid_fork_targets }
let(:finder_mock) { instance_double('ForkTargetsFinder', execute: ['finder_return_value']) }
before do
allow(ForkTargetsFinder).to receive(:new).with(project, user).and_return(finder_mock)
end
it 'returns whatever finder returns' do
is_expected.to eq ['finder_return_value']
end
end
describe '#valid_fork_branch?' do
subject { service.valid_fork_branch?(branch) }
context 'when branch exists' do
let(:branch) { project.default_branch_or_main }
it { is_expected.to be_truthy }
end
context 'when branch does not exist' do
let(:branch) { 'branch-that-does-not-exist' }
it { is_expected.to be_falsey }
end
end
describe '#valid_fork_target?' do
subject { service.valid_fork_target? }
let(:params) { {} }
context 'when target is not passed' do
context 'when current user is an admin' do
let(:user) { build(:user, :admin) }
it { is_expected.to be_truthy }
end
context 'when current_user is not an admin' do
let(:user) { create(:user) }
let(:finder_mock) { instance_double('ForkTargetsFinder', execute: [user.namespace]) }
before do
allow(ForkTargetsFinder).to receive(:new).with(project, user).and_return(finder_mock)
end
context 'when target namespace is in valid fork targets' do
let(:params) { { namespace: user.namespace } }
it { is_expected.to be_truthy }
end
context 'when target namespace is not in valid fork targets' do
let(:params) { { namespace: create(:group) } }
it { is_expected.to be_falsey }
end
end
end
context 'when target is passed' do
subject { service.valid_fork_target?(target) }
let(:target) { create(:group) }
context 'when current user is an admin' do
let(:user) { build(:user, :admin) }
it { is_expected.to be_truthy }
end
context 'when current user is not an admin' do
let(:user) { create(:user) }
before do
allow(ForkTargetsFinder).to receive(:new).with(project, user).and_return(finder_mock)
end
context 'when target namespace is in valid fork targets' do
let(:finder_mock) { instance_double('ForkTargetsFinder', execute: [target]) }
it { is_expected.to be_truthy }
end
context 'when target namespace is not in valid fork targets' do
let(:finder_mock) { instance_double('ForkTargetsFinder', execute: [create(:group)]) }
it { is_expected.to be_falsey }
end
end
end
end
end
|