1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177
|
# frozen_string_literal: true
RSpec.shared_examples 'wiki model' do
using RSpec::Parameterized::TableSyntax
let_it_be(:user) { create(:user, :commit_email) }
let(:wiki_container) { raise NotImplementedError }
let(:wiki_container_without_repo) { raise NotImplementedError }
let(:wiki_lfs_enabled) { false }
let(:wiki) { described_class.new(wiki_container, user) }
let(:commit) { subject.repository.head_commit }
subject { wiki }
it 'VALID_USER_MARKUPS contains all valid markups' do
expect(described_class::VALID_USER_MARKUPS.keys).to match_array(%i[markdown rdoc asciidoc org])
end
it 'container class includes HasWiki' do
# NOTE: This is not enforced at runtime, since we also need to support Geo::DeletedProject
expect(wiki_container).to be_kind_of(HasWiki)
expect(wiki_container_without_repo).to be_kind_of(HasWiki)
end
it_behaves_like 'model with repository' do
let(:container) { wiki }
let(:stubbed_container) { described_class.new(wiki_container_without_repo, user) }
let(:expected_full_path) { "#{container.container.full_path}.wiki" }
let(:expected_web_url_path) { "#{container.container.web_url(only_path: true).sub(%r{^/}, '')}/-/wikis/home" }
let(:expected_lfs_enabled) { wiki_lfs_enabled }
end
describe '.container_class' do
it 'is set to the container class' do
expect(described_class.container_class).to eq(wiki_container.class)
end
end
describe '.find_by_id' do
it 'returns a wiki instance if the container is found' do
wiki = described_class.find_by_id(wiki_container.id)
expect(wiki).to be_a(described_class)
expect(wiki.container).to eq(wiki_container)
end
it 'returns nil if the container is not found' do
expect(described_class.find_by_id(-1)).to be_nil
end
end
describe '#initialize' do
it 'accepts a valid user' do
expect do
described_class.new(wiki_container, user)
end.not_to raise_error
end
it 'accepts a blank user' do
expect do
described_class.new(wiki_container, nil)
end.not_to raise_error
end
it 'raises an error for invalid users' do
expect do
described_class.new(wiki_container, Object.new)
end.to raise_error(ArgumentError, 'user must be a User, got Object')
end
end
describe '#run_after_commit' do
it 'delegates to the container' do
expect(wiki_container).to receive(:run_after_commit)
wiki.run_after_commit
end
end
describe '#==' do
it 'returns true for wikis from the same container' do
expect(wiki).to eq(described_class.new(wiki_container))
end
it 'returns false for wikis from different containers' do
expect(wiki).not_to eq(described_class.new(wiki_container_without_repo))
end
end
describe '#id' do
it 'returns the ID of the container' do
expect(wiki.id).to eq(wiki_container.id)
end
end
describe '#has_home_page?' do
context 'when home page exists' do
before do
wiki.repository.create_file(
user,
'home.md',
'home file',
branch_name: wiki.default_branch,
message: "created home page",
author_email: user.email,
author_name: user.name
)
end
it 'returns true' do
expect(wiki.has_home_page?).to eq(true)
end
it 'returns false when #find_page raise an error' do
allow(wiki)
.to receive(:find_page)
.and_raise(StandardError)
expect(wiki.has_home_page?).to eq(false)
end
end
context 'when home page does not exist' do
it 'returns false' do
expect(wiki.has_home_page?).to eq(false)
end
end
end
describe '#to_global_id' do
it 'returns a global ID' do
expect(wiki.to_global_id.to_s).to eq("gid://gitlab/#{wiki.class.name}/#{wiki.id}")
end
end
describe '#repository' do
it 'returns a wiki repository' do
expect(subject.repository.repo_type).to be_wiki
expect(subject.repository.container).to be(subject)
end
end
describe '#full_path' do
it 'returns the container path with the .wiki extension' do
expect(subject.full_path).to eq(wiki_container.full_path + '.wiki')
end
end
describe '#wiki_base_path' do
it 'returns the wiki base path' do
expect(subject.wiki_base_path).to eq("#{wiki_container.web_url(only_path: true)}/-/wikis")
end
it 'includes the relative URL root' do
allow(Rails.application.routes).to receive(:default_url_options).and_return(script_name: '/root')
expect(subject.wiki_base_path).to start_with('/root/')
expect(subject.wiki_base_path).not_to start_with('/root/root')
end
end
describe '#empty?' do
context 'when the wiki repository is empty' do
it 'returns true' do
expect(subject.empty?).to be(true)
end
context 'when the repository does not exist' do
let(:wiki_container) { wiki_container_without_repo }
it 'returns true and does not create the repo' do
expect(subject.empty?).to be(true)
expect(wiki.repository_exists?).to be false
end
end
end
context 'when the wiki has pages' do
before do
subject.create_page('index', 'This is an awesome new Gollum Wiki')
subject.create_page('another-page', 'This is another page')
end
describe '#empty?' do
it 'returns false' do
expect(subject.empty?).to be(false)
end
end
end
context 'when the repository fails' do
let!(:page) { create(:wiki_page, wiki: subject, title: 'test page') }
it 'returns true if the repository raise an error' do
allow(Gitlab::GitalyClient).to receive(:call) do
raise GRPC::Unavailable, 'Gitaly broken in this spec'
end
expect(subject.empty?).to be(true)
expect(subject.error_message).to match(/Gitaly broken in this spec/)
end
end
end
describe '#list_pages' do
shared_examples 'wiki model #list_pages' do
let(:wiki_pages) { subject.list_pages }
before do
# The creation order below is intentional because we would like to test the sorting behavior as well.
# The sorting is performed based on the page's path.
subject.create_page('index2', 'This is an index2')
subject.create_page('index1', 'This is an index1')
subject.create_page('index 2', 'This is an index 2 with spaces only in the title')
subject.create_page('index 1', 'This is an index 1 with spaces only in the title')
subject.repository.create_file(
user, "index 2.md", "This is an index 2 with spaces in both the title and the path",
branch_name: subject.default_branch,
message: "created page index 2"
)
subject.repository.create_file(
user, "index 1.md", "This is an index 1 with spaces in both the title and the path",
branch_name: subject.default_branch,
message: "created page index 1"
)
end
it 'returns an array of WikiPage instances' do
expect(wiki_pages).to be_present
expect(wiki_pages).to all(be_a(WikiPage))
end
it 'does not load WikiPage content by default' do
wiki_pages.each do |page|
expect(page.content).to be_empty
end
end
it 'returns all pages by default' do
expect(wiki_pages.count).to eq(6)
end
context 'with limit option' do
it 'returns limited set of pages' do
expect(
subject.list_pages(limit: 1).map(&:path)
).to eql(["index 1.md"])
end
it 'returns all set of pages if limit is more than the total pages' do
expect(subject.list_pages(limit: 7).count).to eq(6)
end
it 'returns all set of pages if limit is 0' do
expect(subject.list_pages(limit: 0).count).to eq(6)
end
end
context 'with offset option' do
it 'returns offset-ed set of pages' do
expect(
subject.list_pages(offset: 1).map(&:path)
).to eq(["index 2.md", "index-1.md", "index-2.md", "index1.md", "index2.md"])
expect(
subject.list_pages(offset: 2).map(&:path)
).to eq(["index-1.md", "index-2.md", "index1.md", "index2.md"])
expect(
subject.list_pages(offset: 3).map(&:path)
).to eq(["index-2.md", "index1.md", "index2.md"])
expect(
subject.list_pages(offset: 4).map(&:path)
).to eq(["index1.md", "index2.md"])
expect(
subject.list_pages(offset: 5).map(&:path)
).to eq(["index2.md"])
expect(subject.list_pages(offset: 6).count).to eq(0)
expect(subject.list_pages(offset: 7).count).to eq(0)
end
it 'returns all set of pages if offset is 0' do
expect(subject.list_pages(offset: 0).count).to eq(6)
end
it 'can combines with limit' do
expect(
subject.list_pages(offset: 1, limit: 1).map(&:path)
).to eq(["index 2.md"])
end
end
context 'with sorting options' do
it 'returns pages sorted by title by default' do
pages = ["index 1.md", "index 2.md", "index-1.md", "index-2.md", "index1.md", "index2.md"]
expect(subject.list_pages.map(&:path)).to eq(pages)
expect(subject.list_pages(direction: 'desc').map(&:path)).to eq(pages.reverse)
end
end
context 'with load_content option' do
let(:pages) { subject.list_pages(load_content: true) }
it 'loads WikiPage content' do
contents = [
"This is an index 1 with spaces in both the title and the path",
"This is an index 2 with spaces in both the title and the path",
"This is an index 1 with spaces only in the title",
"This is an index 2 with spaces only in the title",
"This is an index1",
"This is an index2"
]
expect(pages.map(&:content)).to eq(contents)
end
end
context 'when the repository fails to list' do
let!(:page) { create(:wiki_page, wiki: subject, title: 'test page') }
it 'returns an empty list if the repository raise an error' do
allow(Gitlab::GitalyClient).to receive(:call) do
raise GRPC::Unavailable, 'Gitaly broken in this spec'
end
expect(wiki_pages.count).to eq(0)
expect(subject.error_message).to match(/Gitaly broken in this spec/)
end
end
end
it_behaves_like 'wiki model #list_pages'
end
describe '#find_page' do
shared_examples 'wiki model #find_page' do
before do
subject.create_page('index page', 'This is an awesome Gollum Wiki')
end
it 'returns the latest version of the page if it exists' do
page = subject.find_page('index page')
expect(page.title).to eq('index page')
end
it 'returns nil if the page or version does not exist' do
expect(subject.find_page('non-existent')).to be_nil
expect(subject.find_page('index page', 'non-existent')).to be_nil
end
it 'returns nil if the title is nil' do
expect(subject.find_page(nil)).to be_nil
end
it 'returns nil if the repository raise an error' do
expect(subject.repository)
.to receive(:search_files_by_regexp)
.and_raise(Gitlab::Git::CommandError)
.at_least(:once)
expect(subject.find_page('index page')).to be_nil
end
it 'can find a page by slug' do
page = subject.find_page('index-page')
expect(page.title).to eq('index page')
end
it 'returns a WikiPage instance' do
page = subject.find_page('index page')
expect(page).to be_a WikiPage
end
context 'when the repository fails to find' do
let!(:page) { create(:wiki_page, wiki: subject, title: 'test page') }
it 'returns nil if the repository raise an error' do
allow(Gitlab::GitalyClient).to receive(:call) do
raise GRPC::Unavailable, 'Gitaly broken in this spec'
end
expect(subject.find_page('index page')).to be_nil
expect(subject.error_message).to match(/Gitaly broken in this spec/)
end
end
# The repository can contain files that were not generated by Gollum Wiki
# and these files can contain spaces in the path.
context 'pages with spaces in the path' do
before do
subject.repository.create_file(
user, "page with spaces in the path.md", "This is an awesome Gollum Wiki",
branch_name: subject.default_branch,
message: "created page with spaces in the path"
)
end
it 'can find a page by title' do
page = subject.find_page('page with spaces in the path')
expect(page.title).to eq('page with spaces in the path')
end
it 'cannot find a page by slug' do
page = subject.find_page('page-with-spaces-in-the-path')
expect(page).to be_nil
end
end
context 'pages with multibyte-character title' do
before do
subject.create_page('autre pagé', "C'est un génial Gollum Wiki")
end
it 'can find a page by slug' do
page = subject.find_page('autre pagé')
expect(page.title).to eq('autre pagé')
end
end
context 'pages with invalidly-encoded content' do
before do
subject.create_page('encoding is fun', "f\xFCr".b)
end
it 'can find the page' do
page = subject.find_page('encoding is fun')
expect(page.content).to eq('fr')
end
end
context "wiki repository's default branch is updated" do
before do
old_default_branch = wiki.default_branch
subject.create_page('page in updated default branch', 'content')
subject.repository.add_branch(user, 'another_branch', old_default_branch)
subject.repository.rm_branch(user, old_default_branch)
subject.repository.expire_status_cache
end
it 'returns the page in the updated default branch' do
wiki = described_class.new(wiki_container, user)
page = wiki.find_page('page in updated default branch')
expect(wiki.default_branch).to eql('another_branch')
expect(page.title).to eq('page in updated default branch')
end
end
context "wiki repository's HEAD is updated" do
before do
subject.create_page('page in updated HEAD', 'content')
subject.repository.add_branch(user, 'another_branch', subject.default_branch)
subject.repository.change_head('another_branch')
subject.repository.expire_status_cache
end
it 'returns the page in the new HEAD' do
wiki = described_class.new(wiki_container, user)
page = subject.find_page('page in updated HEAD')
expect(wiki.default_branch).to eql('another_branch')
expect(page.title).to eq('page in updated HEAD')
end
end
context 'pages with relative paths' do
where(:path, :title) do
[
['~hello.md', '~Hello'],
['hello~world.md', 'Hello~World'],
['~~~hello.md', '~~~Hello'],
['~/hello.md', '~/Hello'],
['hello.md', '/Hello'],
['hello.md', '../Hello'],
['hello.md', './Hello'],
['dir/hello.md', '/dir/Hello']
]
end
with_them do
before do
wiki.repository.create_file(
user, path, "content of wiki file",
branch_name: wiki.default_branch,
message: "created page #{path}",
author_email: user.email,
author_name: user.name
)
end
it "can find page with `#{params[:title]}` title" do
page = subject.find_page(title)
expect(page.content).to eq("content of wiki file")
end
end
end
context 'pages with different file extensions' do
where(:extension, :path, :title) do
[
[:md, "wiki-markdown.md", "wiki markdown"],
[:markdown, "wiki-markdown-2.md", "wiki markdown 2"],
[:rdoc, "wiki-rdoc.rdoc", "wiki rdoc"],
[:asciidoc, "wiki-asciidoc.asciidoc", "wiki asciidoc"],
[:adoc, "wiki-asciidoc-2.adoc", "wiki asciidoc 2"],
[:org, "wiki-org.org", "wiki org"],
[:textile, "wiki-textile.textile", "wiki textile"],
[:creole, "wiki-creole.creole", "wiki creole"],
[:rest, "wiki-rest.rest", "wiki rest"],
[:rst, "wiki-rest-2.rst", "wiki rest 2"],
[:mediawiki, "wiki-mediawiki.mediawiki", "wiki mediawiki"],
[:wiki, "wiki-mediawiki-2.wiki", "wiki mediawiki 2"],
[:pod, "wiki-pod.pod", "wiki pod"],
[:text, "wiki-text.txt", "wiki text"]
]
end
with_them do
before do
wiki.repository.create_file(
user, path, "content of wiki file",
branch_name: wiki.default_branch,
message: "created page #{path}",
author_email: user.email,
author_name: user.name
)
end
it "can find page with #{params[:extension]} extension" do
page = subject.find_page(title)
expect(page.content).to eq("content of wiki file")
end
end
end
end
context 'find page with normal repository RPCs' do
it_behaves_like 'wiki model #find_page'
end
end
describe '#find_sidebar' do
shared_examples 'wiki model #find_sidebar' do
before do
subject.create_page(described_class::SIDEBAR, 'This is an awesome Sidebar')
end
it 'finds the page defined as _sidebar' do
page = subject.find_sidebar
expect(page.content).to eq('This is an awesome Sidebar')
end
end
context 'find sidebar with normal repository RPCs' do
it_behaves_like 'wiki model #find_sidebar'
end
end
describe '#find_file' do
let(:image) { File.open(Rails.root.join('spec', 'fixtures', 'big-image.png')) }
before do
subject.create_wiki_repository # Make sure the wiki repo exists
subject.repository.create_file(user, 'image.png', image, branch_name: subject.default_branch, message: 'add image')
end
it 'returns the latest version of the file if it exists' do
file = subject.find_file('image.png')
expect(file.mime_type).to eq('image/png')
end
it 'returns nil if the page does not exist' do
expect(subject.find_file('non-existent')).to eq(nil)
end
it 'returns a Gitlab::Git::WikiFile instance' do
file = subject.find_file('image.png')
expect(file).to be_a Gitlab::Git::WikiFile
end
it 'returns the whole file' do
file = subject.find_file('image.png')
image.rewind
expect(file.raw_data.b).to eq(image.read.b)
end
context 'when load_content is disabled' do
it 'includes the file data in the Gitlab::Git::WikiFile' do
file = subject.find_file('image.png', load_content: false)
expect(file.raw_data).to be_empty
end
end
context "wiki repository's default branch is updated" do
before do
old_default_branch = wiki.default_branch
subject.repository.add_branch(user, 'another_branch', old_default_branch)
subject.repository.rm_branch(user, old_default_branch)
subject.repository.expire_status_cache
end
it 'returns the page in the updated default branch' do
wiki = described_class.new(wiki_container, user)
file = wiki.find_file('image.png')
expect(file.mime_type).to eq('image/png')
end
end
context 'when the repository fails to find' do
let!(:page) { create(:wiki_page, wiki: subject, title: 'test page') }
it 'returns nil if the repository raise an error' do
allow(Gitlab::GitalyClient).to receive(:call) do
raise GRPC::Unavailable, 'Gitaly broken in this spec'
end
expect(subject.find_file('image.png')).to be_nil
expect(subject.error_message).to match(/Gitaly broken in this spec/)
end
end
end
describe '#create_page' do
shared_examples 'create_page tests' do
it 'creates a new wiki page' do
expect(subject.create_page('test page', 'this is content')).not_to eq(false)
expect(subject.list_pages.count).to eq(1)
end
it 'returns false when a duplicate page exists' do
subject.create_page('test page', 'content')
expect(subject.create_page('test page', 'content')).to eq(false)
end
it 'stores an error message when a duplicate page exists' do
2.times { subject.create_page('test page', 'content') }
expect(subject.error_message).to match(/Duplicate page:/)
end
it 'sets the correct commit message' do
subject.create_page('test page', 'some content', :markdown, 'commit message')
expect(subject.list_pages.first.version.message).to eq('commit message')
end
it 'sets the correct commit email' do
subject.create_page('test page', 'content')
expect(user.commit_email).not_to eq(user.email)
expect(commit.author_email).to eq(user.commit_email)
expect(commit.committer_email).to eq(user.commit_email)
end
it 'runs after_wiki_activity callbacks' do
expect(subject).to receive(:after_wiki_activity)
subject.create_page('Test Page', 'This is content')
end
it 'cannot create two pages with the same title but different format' do
subject.create_page('test page', 'content', :markdown)
subject.create_page('test page', 'content', :rdoc)
expect(subject.error_message).to match(/Duplicate page:/)
end
it 'cannot create two pages with the same title but different capitalization' do
subject.create_page('test page', 'content')
subject.create_page('Test page', 'content')
expect(subject.error_message).to match(/Duplicate page:/)
end
it 'cannot create two pages with the same title, different capitalization, and different format' do
subject.create_page('test page', 'content')
subject.create_page('Test page', 'content', :rdoc)
expect(subject.error_message).to match(/Duplicate page:/)
end
it 'cannot create two pages with the same title, even if the existing file has no sluggified path' do
subject.repository.create_file(
user, "page with spaces in the path.md", "page created outside of Gollum Wiki",
branch_name: subject.default_branch,
message: "created page with spaces in the path"
)
subject.create_page('page with spaces in the path', 'page created by Gollum Wiki')
expect(subject.error_message).to match(/Duplicate page:/)
end
it 'returns false if a page exists already in the repository', :aggregate_failures do
subject.create_page('test page', 'content')
allow(subject).to receive(:file_exists_by_regex?).and_return(false)
expect(subject.create_page('test page', 'content')).to eq false
expect(subject.error_message).to match(/Duplicate page:/)
end
it 'returns false if it has an invalid format', :aggregate_failures do
expect(subject.create_page('test page', 'content', :foobar)).to eq false
expect(subject.error_message).to match(/Invalid format selected/)
end
using RSpec::Parameterized::TableSyntax
where(:new_file, :format, :existing_repo_files, :success) do
'foo' | :markdown | [] | true
'foo' | :rdoc | [] | true
'foo' | :asciidoc | [] | true
'foo' | :org | [] | true
'foo' | :textile | [] | false
'foo' | :creole | [] | false
'foo' | :rest | [] | false
'foo' | :mediawiki | [] | false
'foo' | :pod | [] | false
'foo' | :plaintext | [] | false
'foo' | :markdown | ['foo.md'] | false
'foo' | :markdown | ['foO.md'] | false
'foO' | :markdown | ['foo.md'] | false
'foo' | :markdown | ['foo.mdfoo'] | true
'foo' | :markdown | ['foo.markdown'] | false
'foo' | :markdown | ['foo.mkd'] | false
'foo' | :markdown | ['foo.mkdn'] | false
'foo' | :markdown | ['foo.mdown'] | false
'foo' | :markdown | ['foo.adoc'] | false
'foo' | :markdown | ['foo.asciidoc'] | false
'foo' | :markdown | ['foo.org'] | false
'foo' | :markdown | ['foo.rdoc'] | false
'foo' | :markdown | ['foo.textile'] | false
'foo' | :markdown | ['foo.creole'] | false
'foo' | :markdown | ['foo.rest'] | false
'foo' | :markdown | ['foo.rest.txt'] | false
'foo' | :markdown | ['foo.rst'] | false
'foo' | :markdown | ['foo.rst.txt'] | false
'foo' | :markdown | ['foo.rst.txtfoo'] | true
'foo' | :markdown | ['foo.mediawiki'] | false
'foo' | :markdown | ['foo.wiki'] | false
'foo' | :markdown | ['foo.pod'] | false
'foo' | :markdown | ['foo.txt'] | false
'foo' | :markdown | ['foo.Md'] | false
'foo' | :markdown | ['foo.jpg'] | true
'foo' | :rdoc | ['foo.md'] | false
'foo' | :rdoc | ['foO.md'] | false
'foO' | :rdoc | ['foo.md'] | false
'foo' | :asciidoc | ['foo.md'] | false
'foo' | :org | ['foo.md'] | false
'foo' | :markdown | ['dir/foo.md'] | true
'/foo' | :markdown | ['foo.md'] | false
'~foo' | :markdown | [] | true
'~~~foo' | :markdown | [] | true
'./foo' | :markdown | ['foo.md'] | false
'../foo' | :markdown | ['foo.md'] | false
'../../foo' | :markdown | ['foo.md'] | false
'../../foo' | :markdown | ['dir/foo.md'] | true
'dir/foo' | :markdown | ['foo.md'] | true
'dir/foo' | :markdown | ['dir/foo.md'] | false
'dir/foo' | :markdown | ['dir/foo.rdoc'] | false
'/dir/foo' | :markdown | ['dir/foo.rdoc'] | false
'./dir/foo' | :markdown | ['dir/foo.rdoc'] | false
'../dir/foo' | :markdown | ['dir/foo.rdoc'] | false
'../dir/../foo' | :markdown | ['dir/foo.rdoc'] | true
'../dir/../foo' | :markdown | ['foo.rdoc'] | false
'../dir/../dir/foo' | :markdown | ['dir/foo.rdoc'] | false
'../dir/../another/foo' | :markdown | ['dir/foo.rdoc'] | true
'another/dir/foo' | :markdown | ['dir/foo.md'] | true
'foo bar' | :markdown | ['foo-bar.md'] | false
'foo bar' | :markdown | ['foo-bar.md'] | true
'föö'.encode('ISO-8859-1') | :markdown | ['f��.md'] | false
end
with_them do
before do
subject.create_wiki_repository # Make sure the wiki repo exists
existing_repo_files.each do |path|
subject.repository.create_file(
user, path, 'content',
branch_name: subject.default_branch,
message: "Add #{new_file}"
)
end
end
specify do
expect(subject.create_page(new_file, 'content', format)).to eq success
end
end
context 'when the repository fails to create' do
let!(:page) { create(:wiki_page, wiki: subject, title: 'test page') }
it 'returns false if the repository raise an error' do
allow(Gitlab::GitalyClient).to receive(:call) do
raise GRPC::Unavailable, 'Gitaly broken in this spec'
end
expect(subject.create_page('test page', 'content')).to eq(false)
expect(subject.error_message).to match(/Gitaly broken in this spec/)
end
end
end
it_behaves_like 'create_page tests'
end
describe '#update_page' do
shared_examples 'update_page tests' do
with_them do
let!(:page) { create(:wiki_page, wiki: subject, title: original_title, format: original_format, content: 'original content') }
let(:message) { 'updated page' }
let(:updated_content) { 'updated content' }
def update_page
subject.update_page(
page.page,
content: updated_content,
title: updated_title,
format: updated_format,
message: message
)
end
specify :aggregate_failures do
expect(subject).to receive(:after_wiki_activity)
expect(update_page).to eq true
page = subject.find_page(expected_title)
expect(page.raw_content).to eq(updated_content)
expect(page.path).to eq(expected_path)
expect(page.version.message).to eq(message)
expect(user.commit_email).not_to eq(user.email)
expect(commit.author_email).to eq(user.commit_email)
expect(commit.committer_email).to eq(user.commit_email)
end
end
end
shared_context 'common examples' do
using RSpec::Parameterized::TableSyntax
where(:original_title, :original_format, :updated_title, :updated_format, :expected_title, :expected_path) do
'test page' | :markdown | 'new test page' | :markdown | 'new test page' | 'new-test-page.md'
'test page' | :markdown | 'test page' | :markdown | 'test page' | 'test-page.md'
'test page' | :markdown | 'test page' | :asciidoc | 'test page' | 'test-page.asciidoc'
'test page' | :markdown | 'new dir/new test page' | :markdown | 'new dir/new test page' | 'new-dir/new-test-page.md'
'test page' | :markdown | 'new dir/test page' | :markdown | 'new dir/test page' | 'new-dir/test-page.md'
'test dir/test page' | :markdown | 'new dir/new test page' | :markdown | 'new dir/new test page' | 'new-dir/new-test-page.md'
'test dir/test page' | :markdown | 'test dir/test page' | :markdown | 'test dir/test page' | 'test-dir/test-page.md'
'test dir/test page' | :markdown | 'test dir/test page' | :asciidoc | 'test dir/test page' | 'test-dir/test-page.asciidoc'
'test dir/test page' | :markdown | 'new test page' | :markdown | 'new test page' | 'new-test-page.md'
'test dir/test page' | :markdown | 'test page' | :markdown | 'test page' | 'test-page.md'
'test page' | :markdown | nil | :markdown | 'test page' | 'test-page.md'
'test.page' | :markdown | nil | :markdown | 'test.page' | 'test.page.md'
'testpage' | :markdown | './testpage' | :markdown | 'testpage' | 'testpage.md'
end
end
# There are two bugs in Gollum. THe first one is when the title and the format are updated
# at the same time https://gitlab.com/gitlab-org/gitlab/-/issues/243519.
# The second one is when the wiki page is within a dir and the `title` argument
# we pass to the update method is `nil`. Gollum will remove the dir and move the page.
#
# We can include this context into the former once it is fixed
# or when Gollum is removed since the Gitaly approach already fixes it.
shared_context 'extended examples' do
using RSpec::Parameterized::TableSyntax
where(:original_title, :original_format, :updated_title, :updated_format, :expected_title, :expected_path) do
'test page' | :markdown | '~new test page' | :asciidoc | '~new test page' | '~new-test-page.asciidoc'
'test page' | :markdown | '~~~new test page' | :asciidoc | '~~~new test page' | '~~~new-test-page.asciidoc'
'test page' | :markdown | 'new test page' | :asciidoc | 'new test page' | 'new-test-page.asciidoc'
'test page' | :markdown | 'new dir/new test page' | :asciidoc | 'new dir/new test page' | 'new-dir/new-test-page.asciidoc'
'test dir/test page' | :markdown | 'new dir/new test page' | :asciidoc | 'new dir/new test page' | 'new-dir/new-test-page.asciidoc'
'test dir/test page' | :markdown | 'new test page' | :asciidoc | 'new test page' | 'new-test-page.asciidoc'
'test page' | :markdown | nil | :asciidoc | 'test page' | 'test-page.asciidoc'
'test dir/test page' | :markdown | nil | :asciidoc | 'test dir/test page' | 'test-dir/test-page.asciidoc'
'test dir/test page' | :markdown | nil | :markdown | 'test dir/test page' | 'test-dir/test-page.md'
'test page' | :markdown | '' | :markdown | 'test page' | 'test-page.md'
'test.page' | :markdown | '' | :markdown | 'test.page' | 'test.page.md'
'testpage' | :markdown | '../testpage' | :markdown | 'testpage' | 'testpage.md'
'dir/testpage' | :markdown | 'dir/../testpage' | :markdown | 'testpage' | 'testpage.md'
'dir/testpage' | :markdown | './dir/testpage' | :markdown | 'dir/testpage' | 'dir/testpage.md'
'dir/testpage' | :markdown | '../dir/testpage' | :markdown | 'dir/testpage' | 'dir/testpage.md'
'dir/testpage' | :markdown | '../dir/../testpage' | :markdown | 'testpage' | 'testpage.md'
'dir/testpage' | :markdown | '../dir/../dir/testpage' | :markdown | 'dir/testpage' | 'dir/testpage.md'
'dir/testpage' | :markdown | '../dir/../another/testpage' | :markdown | 'another/testpage' | 'another/testpage.md'
end
end
it_behaves_like 'update_page tests' do
include_context 'common examples'
include_context 'extended examples'
end
context 'when sluggified paths already exist in the repository' do
before do
subject.repository.create_file(
user, "folder with spaces.md", "folder created outside of Gollum Wiki",
branch_name: subject.default_branch,
message: "created folder with spaces in the path"
)
subject.repository.create_file(
user, "folder with spaces/page with spaces in the path.md", "page created outside of Gollum Wiki",
branch_name: subject.default_branch,
message: "created page with spaces in the path"
)
end
it 'the page path is sluggified' do
pages_before_update = subject.list_pages
expect(pages_before_update.map(&:title)).to match_array([
"folder with spaces", "page with spaces in the path"
])
expect(pages_before_update.map(&:path)).to match_array([
"folder with spaces.md", "folder with spaces/page with spaces in the path.md"
])
page = subject.find_page("folder with spaces/page with spaces in the path")
expect(subject.update_page(page.page, content: 'new content', format: :markdown)).to eq true
pages_after_update = subject.list_pages
expect(pages_after_update.map(&:title)).to match_array([
"folder with spaces", "page with spaces in the path"
])
expect(pages_after_update.map(&:path)).to match_array([
"folder with spaces.md", "folder-with-spaces/page-with-spaces-in-the-path.md"
])
end
end
context 'when format is invalid' do
let!(:page) { create(:wiki_page, wiki: subject, title: 'test page') }
it 'returns false and sets error message' do
expect(subject.update_page(page.page, content: 'new content', format: :foobar)).to eq false
expect(subject.error_message).to match(/Invalid format selected/)
end
end
context 'when format is not allowed' do
let!(:page) { create(:wiki_page, wiki: subject, title: 'test page') }
it 'returns false and sets error message' do
expect(subject.update_page(page.page, content: 'new content', format: :creole)).to eq false
expect(subject.error_message).to match(/Invalid format selected/)
end
end
context 'when the repository fails to update' do
let!(:page) { create(:wiki_page, wiki: subject, title: 'test page') }
it 'returns false if the repository raise an error' do
allow(Gitlab::GitalyClient).to receive(:call) do
raise GRPC::Unavailable, 'Gitaly broken in this spec'
end
expect(subject.update_page(page.page, content: 'new content', format: :markdown))
.to eq(false)
expect(subject.error_message).to match(/Gitaly broken in this spec/)
end
it 'returns false and sets error message if the repository raise an IndexError', :aggregate_failures do
expect(subject.repository)
.to receive(:commit_files)
.and_raise(Gitlab::Git::Index::IndexError.new)
expect(subject.update_page(page.page, content: 'new content', format: :markdown))
.to eq(false)
expect(subject.error_message)
.to match("Duplicate page: A page with that title already exists in the file test-page.md")
end
end
context 'when page path does not have a default extension' do
let!(:page) { create(:wiki_page, wiki: subject, title: 'test page') }
context 'when format is not different' do
it 'does not change the default extension' do
path = 'test-page.markdown'
page.page.instance_variable_set(:@path, path)
expect(subject.repository).to receive(:update_file_actions).with(path, anything, anything).and_return([])
subject.update_page(page.page, content: 'new content', format: :markdown)
end
end
end
end
describe '#delete_page' do
let(:page) { create(:wiki_page, wiki: wiki) }
it 'deletes the page' do
subject.delete_page(page)
expect(subject.list_pages.count).to eq(0)
end
it 'sets the correct commit email' do
subject.delete_page(page)
expect(user.commit_email).not_to eq(user.email)
expect(commit.author_email).to eq(user.commit_email)
expect(commit.committer_email).to eq(user.commit_email)
end
it 'runs after_wiki_activity callbacks' do
page
expect(subject).to receive(:after_wiki_activity)
subject.delete_page(page)
end
context 'when an error is raised' do
it 'logs the error and returns false' do
page = build(:wiki_page, wiki: wiki)
exception = Gitlab::Git::Index::IndexError.new('foo')
allow(subject.repository).to receive(:delete_file).and_raise(exception)
expect(Gitlab::ErrorTracking).to receive(:log_exception).with(exception, action: :deleted, wiki_id: wiki.id)
expect(subject.delete_page(page)).to be_falsey
end
end
end
describe '#hook_attrs' do
it 'returns a hash with values' do
expect(subject.hook_attrs).to be_a Hash
expect(subject.hook_attrs.keys).to contain_exactly(:web_url, :git_ssh_url, :git_http_url, :path_with_namespace, :default_branch)
end
end
describe '#default_branch' do
subject { wiki.default_branch }
before do
allow(Gitlab::DefaultBranch).to receive(:value).and_return('main')
end
context 'when repository is not created' do
let(:wiki_container) { wiki_container_without_repo }
it 'returns the instance default branch' do
expect(subject).to eq 'main'
end
end
context 'when repository is empty' do
let(:wiki_container) { wiki_container_without_repo }
before do
wiki.repository.create_if_not_exists
end
it 'returns the instance default branch' do
expect(subject).to eq 'main'
end
end
context 'when repository is not empty' do
it 'returns the repository default branch' do
wiki.create_page('index', 'test content')
expect(subject).to eq wiki.repository.root_ref
end
end
context 'when the repository fails' do
before do
wiki.repository.create_if_not_exists
wiki.create_page('index', 'test content')
end
it 'returns main branch if the repository raise an error' do
allow(Gitlab::GitalyClient).to receive(:call) do
raise GRPC::Unavailable, 'Gitaly broken in this spec'
end
expect(subject).to eq 'main'
expect(wiki.error_message).to match(/Gitaly broken in this spec/)
end
end
end
describe '#create_wiki_repository' do
let(:default_branch) { 'foo' }
before do
allow(Gitlab::CurrentSettings).to receive(:default_branch_name).and_return(default_branch)
end
subject { wiki.create_wiki_repository }
context 'when repository is not created' do
let(:wiki_container) { wiki_container_without_repo }
it 'changes the HEAD reference to the default branch' do
expect(wiki.empty?).to eq true
subject
expect(wiki.repository.raw.root_ref(head_only: true)).to eq default_branch
end
end
context 'when repository is empty' do
let(:wiki_container) { wiki_container_without_repo }
it 'creates the repository with the default branch' do
wiki.repository.create_if_not_exists(default_branch)
subject
expect(wiki.repository.raw.root_ref(head_only: true)).to eq default_branch
end
end
end
describe '#preview_slug' do
where(:title, :file_extension, :format, :expected_slug) do
'The Best Thing' | :md | :markdown | 'The-Best-Thing'
'The Best Thing' | :txt | :plaintext | 'The-Best-Thing'
'A Subject/Title Here' | :txt | :plaintext | 'A-Subject/Title-Here'
'A subject' | :txt | :plaintext | 'A-subject'
'A 1/B 2/C 3' | :txt | :plaintext | 'A-1/B-2/C-3'
'subject/title' | :txt | :plaintext | 'subject/title'
'subject/title.md' | :txt | :plaintext | 'subject/title.md'
'foo%2Fbar' | :txt | :plaintext | 'foo%2Fbar'
'' | :md | :markdown | '.md'
'' | :txt | :plaintext | '.txt'
end
with_them do
before do
subject.repository.create_file(
user, "#{title}.#{file_extension}", 'content',
branch_name: subject.default_branch,
message: "Add #{title}"
)
end
it do
expect(described_class.preview_slug(title, file_extension)).to eq(expected_slug)
end
end
end
end
|